On Thu, 25 Apr 2024 14:29:27 GMT, Nizar Benalla wrote:
> Please review this PR that aims to add all the remaining needed `@since` tags
> in `java.base`, and group them into a single fix.
> This is related to #18934 and my work around the `@since` checker feature.
> Explicit `@since` tags are nee
> When JLine reads a line, there may be a prompt provided. However, JLine will
> not interpret the prompt literally, it will handle `%` specially. As a
> consequence, doing:
>
> System.console().readLine("%%s");
>
>
> will not print `%s`, as first `String.format` is used, which will convert
>
On Mon, 29 Apr 2024 11:44:50 GMT, Jan Lahoda wrote:
> Consider code like:
>
> public class ConsoleTest {
> public static void main(String... args) {
> System.console().printf("Hello!");
> }
> }
>
>
> When run as:
>
> $ java ConsoleTest.java >/dev/null
>
>
> it prints `Hello!
On Thu, 4 Apr 2024 07:30:34 GMT, Jan Lahoda wrote:
> This is an implementation of JEP JDK-8315129: Module Import Declarations
> (Preview). Please see the JEP for details:
> https://bugs.openjdk.org/browse/JDK-8315129
>
> It is mostly straightforward - the module imports are parsed, and then
>
On Thu, 25 Apr 2024 14:29:27 GMT, Nizar Benalla wrote:
> Please review this PR that aims to add all the remaining needed `@since` tags
> in `java.base`, and group them into a single fix.
> This is related to #18934 and my work around the `@since` checker feature.
> Explicit `@since` tags are nee
On Fri, 26 Apr 2024 09:30:23 GMT, Nizar Benalla wrote:
> We will effectively enforce javadoc comment for some method overrides with
> the checker
Those overriding methods don't even appear on the javadoc output. If you go to
search for `CompletableFuture.resultNow` on
https://docs.oracle.com/
On Mon, 29 Apr 2024 17:26:53 GMT, Chen Liang wrote:
>> src/java.base/share/classes/java/io/FileInputStream.java line 345:
>>
>>> 343: * @throwsIllegalArgumentException {@inheritDoc}
>>> 344: * @throwsIOException {@inheritDoc}
>>> 345: * @throwsOutOfMemoryError {@inheri
On Mon, 29 Apr 2024 16:07:14 GMT, Pavel Rappo wrote:
>> Please review this PR that aims to add all the remaining needed `@since`
>> tags in `java.base`, and group them into a single fix.
>> This is related to #18934 and my work around the `@since` checker feature.
>> Explicit `@since` tags are n
On Mon, 29 Apr 2024 17:46:24 GMT, Nizar Benalla wrote:
> Pavel, can I simply change the PR/issue title to be more descriptive? As I
> want to include the the inherit doc because of the unchecked exceptions,
> rather than clean this up in a different PR
I suggest dropping all the changes that a
On Thu, 25 Apr 2024 14:29:27 GMT, Nizar Benalla wrote:
> Please review this PR that aims to add all the remaining needed `@since` tags
> in `java.base`, and group them into a single fix.
> This is related to #18934 and my work around the `@since` checker feature.
> Explicit `@since` tags are nee
On Mon, 29 Apr 2024 22:54:47 GMT, Chen Liang wrote:
> would be nice if you can share more about these (also about the behaviors of
> inheriting `@throws` etc.
I hope this document explains it well; if it doesn't, we should fix it:
https://docs.oracle.com/en/java/javase/22/docs/specs/javadoc/do
On Mon, 29 Apr 2024 20:02:32 GMT, Pavel Rappo wrote:
>>> > We will effectively enforce javadoc comment for some method overrides
>>> > with the checker
>>>
>>> Those overriding methods don't even appear on the javadoc output. If you go
>>> to search for `CompletableFuture.resultNow` on
>>> ht
On Fri, 26 Apr 2024 14:52:08 GMT, Chen Liang wrote:
> > We will effectively enforce javadoc comment for some method overrides with
> > the checker
>
> Those overriding methods don't even appear on the javadoc output. If you go
> to search for `CompletableFuture.resultNow` on
> https://docs.or
On Sat, 27 Apr 2024 10:33:42 GMT, Nizar Benalla wrote:
> Also have you looked at the output documentation? Without the `@inheritDoc`
> tags the content will only have a since tag, which is definitely wrong.
This is not how I remember it. Unless written around, `{@inheritDoc}` in a main
descrip
On Thu, 25 Apr 2024 14:29:27 GMT, Nizar Benalla wrote:
> Please review this PR that aims to add all the remaining needed `@since` tags
> in `java.base`, and group them into a single fix.
> This is related to #18934 and my work around the `@since` checker feature.
> Explicit `@since` tags are nee
Please review this PR that aims to add all the remaining needed `@since` tags
in `java.base`, and group them into a single fix.
This is related to #18934 and my work around the `@since` checker feature.
Explicit `@since` tags are needed for some overriding methods for the purpose
of the checker.
On Thu, 25 Apr 2024 14:29:27 GMT, Nizar Benalla wrote:
> Please review this PR that aims to add all the remaining needed `@since` tags
> in `java.base`, and group them into a single fix.
> This is related to #18934 and my work around the `@since` checker feature.
> Explicit `@since` tags are nee
On Thu, 25 Apr 2024 16:43:50 GMT, Chen Liang wrote:
> I think your changes mostly group in these categories:
>
> 1. New API methods provided in superclasses/superinterfaces, this class
> provides a more concrete implementation:
>Examples being `CompletableFuture`, `FileInputStream`, `DelayQ
On Fri, 3 May 2024 18:29:23 GMT, Justin Lu wrote:
>> Please review this PR which corrects an edge case bug for
>> java.text.DecimalFormat that causes incorrect parsing results for strings
>> with very large exponent values.
>>
>> When parsing values with large exponents, if the value of the ex
> This checker checks the values of the `@since` tag found in the documentation
> comment for an element against the release in which the element first
> appeared.
>
> Real since value of an API element is computed as the oldest release in which
> the given API element was introduced. That is:
On Thu, 2 May 2024 14:06:25 GMT, Hannes Wallnöfer wrote:
>> Nizar Benalla has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> - Added some legacy modules that existed long before preview features
>> (they were incubating)
>> - Not checkin
On Thu, 2 May 2024 13:49:43 GMT, Hannes Wallnöfer wrote:
>> Nizar Benalla has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> - Added some legacy modules that existed long before preview features
>> (they were incubating)
>> - Not checkin
> This checker checks the values of the `@since` tag found in the documentation
> comment for an element against the release in which the element first
> appeared.
>
> Real since value of an API element is computed as the oldest release in which
> the given API element was introduced. That is:
On Sun, 5 May 2024 12:05:48 GMT, Raffaello Giulietti
wrote:
>> src/java.base/share/classes/java/util/random/RandomGeneratorFactory.java
>> line 147:
>>
>>> 145:
>>> FactoryMapHolder.class.getModule().addUses(RandomGenerator.class);
>>> 146: return ServiceLoader
>>> 147
On Sun, 5 May 2024 05:28:07 GMT, Alan Bateman wrote:
>> Raffaello Giulietti has updated the pull request with a new target base due
>> to a merge or a rebase. The incremental webrev excludes the unrelated
>> changes brought in by the merge/rebase. The pull request contains seven
>> additional
25 matches
Mail list logo
