On Thu, 23 May 2024 19:26:10 GMT, Scott Gibbons wrote:
>> src/hotspot/cpu/x86/stubGenerator_x86_64_string.cpp line 268:
>>
>>> 266: __ cmpq(needle_len_p, 0);
>>> 267: __ jg_b(L_nextCheck);
>>> 268: __ xorq(rax, rax);
>>
>> out of curiosity, is there any advantage to using `xorq` instead o
On Fri, 24 May 2024 05:26:40 GMT, Joe Wang wrote:
>> Add two sample configuration files:
>>
>> jaxp-strict.properties: used to set strict configuration, stricter than
>> jaxp.properties in previous versions such as JDK 22
>>
>>> jaxp-compat.properties: used to regain compatibility from any
On Wed, 22 May 2024 08:52:42 GMT, Magnus Ihse Bursie wrote:
>> Joe Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> add a note to module-info
>
> make/modules/java.xml/Copy.gmk line 35:
>
>> 33: $(eval $(call SetupCopyFiles, COPY_XM
> Add two sample configuration files:
>
> jaxp-strict.properties: used to set strict configuration, stricter than
> jaxp.properties in previous versions such as JDK 22
>
>> jaxp-compat.properties: used to regain compatibility from any more
>> restricted configuration than previous versions
This issue is reproducible with and without `--mac-sign`. jpackage will
"_ad-hoc_" sign application bundle when `--mac-sign` is not specified by using
pseudo-identity "_-_". This is why jpackage tries to sign added files and this
is expected behavior by jpackage. "codesign" fails since added con
On Thu, 23 May 2024 23:12:42 GMT, Scott Gibbons wrote:
>> Re-write the IndexOf code without the use of the pcmpestri instruction, only
>> using AVX2 instructions. This change accelerates String.IndexOf on average
>> 1.3x for AVX2. The benchmark numbers:
>>
>>
>> Benchmark
On Thu, 23 May 2024 23:12:42 GMT, Scott Gibbons wrote:
>> Re-write the IndexOf code without the use of the pcmpestri instruction, only
>> using AVX2 instructions. This change accelerates String.IndexOf on average
>> 1.3x for AVX2. The benchmark numbers:
>>
>>
>> Benchmark
On Thu, 23 May 2024 03:28:30 GMT, Chen Liang wrote:
> Please review this change that convert dynamic proxies implementations to
> hidden classes, intended to target JDK 24.
>
> Summary:
> 1. Adds new implementation while preserving the old implementation behind
> `-Djdk.reflect.useLegacyProxyI
> Re-write the IndexOf code without the use of the pcmpestri instruction, only
> using AVX2 instructions. This change accelerates String.IndexOf on average
> 1.3x for AVX2. The benchmark numbers:
>
>
> BenchmarkScore
> Latest
On Wed, 22 May 2024 14:47:43 GMT, Yudi Zheng wrote:
>> Moving array construction within BigInteger.implMultiplyToLen intrinsic
>> candidate to its caller simplifies the intrinsic implementation in JIT
>> compiler.
>
> Yudi Zheng has updated the pull request incrementally with one additional
>
> Reflection is not retrieving generic type information for mandated
> parameters. This is a known issue which has been explicitly stated in the API
> of some reflection methods. Fix for
> [JDK-8292275](https://bugs.openjdk.org/browse/JDK-8292275) made the
> parameters of compact constructors o
On Thu, 23 May 2024 22:06:38 GMT, Vladimir Kozlov wrote:
>> Scott Gibbons has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addressing review comments
>
> src/hotspot/cpu/x86/stubGenerator_x86_64.hpp line 582:
>
>> 580:
>> 581: #ifdef CO
On Thu, 23 May 2024 21:56:39 GMT, Vladimir Kozlov wrote:
>> src/hotspot/cpu/x86/stubGenerator_x86_64.cpp line 4250:
>>
>>> 4248: generate_chacha_stubs();
>>> 4249:
>>> 4250: if ((UseAVX == 2) && EnableX86ECoreOpts &&
>>> VM_Version::supports_avx2()) {
>>
>> `#ifdef COMPILER2` around this
> Reflection is not retrieving generic type information for mandated
> parameters. This is a known issue which has been explicitly stated in the API
> of some reflection methods. Fix for
> [JDK-8292275](https://bugs.openjdk.org/browse/JDK-8292275) made the
> parameters of compact constructors o
On Thu, 23 May 2024 21:50:15 GMT, Vladimir Kozlov wrote:
>> Scott Gibbons has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addressing review comments
>
> src/hotspot/cpu/x86/stubGenerator_x86_64.cpp line 4250:
>
>> 4248: generate_chach
On Thu, 23 May 2024 19:54:39 GMT, Scott Gibbons wrote:
>> Re-write the IndexOf code without the use of the pcmpestri instruction, only
>> using AVX2 instructions. This change accelerates String.IndexOf on average
>> 1.3x for AVX2. The benchmark numbers:
>>
>>
>> Benchmark
> Reflection is not retrieving generic type information for mandated
> parameters. This is a known issue which has been explicitly stated in the API
> of some reflection methods. Fix for
> [JDK-8292275](https://bugs.openjdk.org/browse/JDK-8292275) made the
> parameters of compact constructors o
> Reflection is not retrieving generic type information for mandated
> parameters. This is a known issue which has been explicitly stated in the API
> of some reflection methods. Fix for
> [JDK-8292275](https://bugs.openjdk.org/browse/JDK-8292275) made the
> parameters of compact constructors o
> Re-write the IndexOf code without the use of the pcmpestri instruction, only
> using AVX2 instructions. This change accelerates String.IndexOf on average
> 1.3x for AVX2. The benchmark numbers:
>
>
> BenchmarkScore
> Latest
On Thu, 23 May 2024 19:02:05 GMT, Daniel Jeliński wrote:
>> Scott Gibbons has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix for IndexOf.java on mac
>
> src/hotspot/cpu/x86/stubGenerator_x86_64_string.cpp line 268:
>
>> 266: __ cmpq(
On Thu, 23 May 2024 17:25:34 GMT, Scott Gibbons wrote:
>> Re-write the IndexOf code without the use of the pcmpestri instruction, only
>> using AVX2 instructions. This change accelerates String.IndexOf on average
>> 1.3x for AVX2. The benchmark numbers:
>>
>>
>> Benchmark
On Thu, 23 May 2024 16:42:39 GMT, Severin Gehwolf wrote:
> Do you think you'll be able to review this next week?
Yes, I want to help you get this one over the line.
-
PR Comment: https://git.openjdk.org/jdk/pull/14787#issuecomment-2127828050
On Thu, 23 May 2024 17:14:19 GMT, Pavel Rappo wrote:
>> Please review this PR which introduces the `java.io.IO` top-level class and
>> three methods to `java.io.Console` for [Implicitly Declared Classes and
>> Instance Main Methods (Third Preview)].
>>
>> This PR has been obtained as `git merg
On Thu, 23 May 2024 11:39:11 GMT, Per Minborg wrote:
> This PR proposes to fix a broken link in the `MemorySegment.Scope` class.
This pull request has now been integrated.
Changeset: 0a9d1f8c
Author:Per Minborg
URL:
https://git.openjdk.org/jdk/commit/0a9d1f8c89e946d99f01549515f6044e
> Re-write the IndexOf code without the use of the pcmpestri instruction, only
> using AVX2 instructions. This change accelerates String.IndexOf on average
> 1.3x for AVX2. The benchmark numbers:
>
>
> BenchmarkScore
> Latest
> Please review this PR which introduces the `java.io.IO` top-level class and
> three methods to `java.io.Console` for [Implicitly Declared Classes and
> Instance Main Methods (Third Preview)].
>
> This PR has been obtained as `git merge --squash` of a now obsolete [draft
> PR].
>
> [Implicitl
> Re-write the IndexOf code without the use of the pcmpestri instruction, only
> using AVX2 instructions. This change accelerates String.IndexOf on average
> 1.3x for AVX2. The benchmark numbers:
>
>
> BenchmarkScore
> Latest
On Thu, 16 May 2024 13:47:20 GMT, Alan Bateman wrote:
>>> If I understand you correctly, this would be no longer a build-time only
>>> approach to produce the "linkable runtime"? It would be some-kind of
>>> jlink-option driven approach (as it would run some code that should only
>>> run when
On Thu, 16 May 2024 02:37:02 GMT, Ioi Lam wrote:
> JavacBench is a test program that compiles 90 Java source files. It uses a
> fair amount of invokedynamic callsites, so it's good for testing CDS support
> for indy and lambda expressions.
>
> This test was first integrated into the
> [leyden
On Wed, 22 May 2024 16:49:36 GMT, Ioi Lam wrote:
>> JavacBench is a test program that compiles 90 Java source files. It uses a
>> fair amount of invokedynamic callsites, so it's good for testing CDS support
>> for indy and lambda expressions.
>>
>> This test was first integrated into the
>> [
On Thu, 23 May 2024 07:26:14 GMT, Matthias Baesken wrote:
>> When building with ubsan enabled (--enable-uban) on Linux x86_64 and doing
>> jtreg tests afterwards I run into this error :
>>
>> /jdk/src/java.base/unix/native/libjava/ProcessImpl_md.c:562:5: runtime
>> error: null pointer passed a
On Thu, 23 May 2024 11:39:11 GMT, Per Minborg wrote:
> This PR proposes to fix a broken link in the `MemorySegment.Scope` class.
The fix looks fine but the bug title sounds like you are modifying an html
file...
-
PR Comment: https://git.openjdk.org/jdk/pull/19366#issuecomment-212
On Wed, 22 May 2024 16:49:36 GMT, Ioi Lam wrote:
>> JavacBench is a test program that compiles 90 Java source files. It uses a
>> fair amount of invokedynamic callsites, so it's good for testing CDS support
>> for indy and lambda expressions.
>>
>> This test was first integrated into the
>> [
On Thu, 23 May 2024 11:39:11 GMT, Per Minborg wrote:
> This PR proposes to fix a broken link in the `MemorySegment.Scope` class.
Marked as reviewed by iris (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/19366#pullrequestreview-2074232921
> This set of changes address causes of poor utilization with small numbers of
> cores due to overly aggressive contention avoidance. A number of further
> adjustments were needed to still avoid most contention effects in deployments
> with large numbers of cores
Doug Lea has updated the pull r
On Wed, 22 May 2024 14:47:43 GMT, Yudi Zheng wrote:
>> Moving array construction within BigInteger.implMultiplyToLen intrinsic
>> candidate to its caller simplifies the intrinsic implementation in JIT
>> compiler.
>
> Yudi Zheng has updated the pull request incrementally with one additional
>
On Thu, 23 May 2024 07:26:14 GMT, Matthias Baesken wrote:
>> When building with ubsan enabled (--enable-uban) on Linux x86_64 and doing
>> jtreg tests afterwards I run into this error :
>>
>> /jdk/src/java.base/unix/native/libjava/ProcessImpl_md.c:562:5: runtime
>> error: null pointer passed a
> Re-write the IndexOf code without the use of the pcmpestri instruction, only
> using AVX2 instructions. This change accelerates String.IndexOf on average
> 1.3x for AVX2. The benchmark numbers:
>
>
> BenchmarkScore
> Latest
On Thu, 23 May 2024 13:28:16 GMT, Chen Liang wrote:
> I have updated the compatibility risk description of the CSR.
>
> My CSR proposes to allow dynamic unloading of the proxy implementation
> classes, but currently it's not implemented as they are strongly referenced
> in the ClassLoaderValue
On Thu, 23 May 2024 06:20:51 GMT, Alan Bateman wrote:
> > Further, I confirm that if I pass that option to jlink or jpackage when
> > creating a custom runtime, there is no warning.
>
> Great! What about jpackage without a custom runtime, wondering if
> --java-options can be tested.
Yes, poin
On Thu, 23 May 2024 07:26:14 GMT, Matthias Baesken wrote:
>> When building with ubsan enabled (--enable-uban) on Linux x86_64 and doing
>> jtreg tests afterwards I run into this error :
>>
>> /jdk/src/java.base/unix/native/libjava/ProcessImpl_md.c:562:5: runtime
>> error: null pointer passed a
> From: "-"
> To: "Remi Forax"
> Cc: "Chen Liang" , "core-libs-dev"
> , "hotspot-dev" ,
> "kulla-dev"
> Sent: Thursday, May 23, 2024 2:56:58 PM
> Subject: Re: RFR: 8242888: Convert dynamic proxy to hidden classes
> Hmm, I think Proxy being hidden in stacktraces might be an advantage; the same
>
On Thu, 23 May 2024 03:28:30 GMT, Chen Liang wrote:
> Please review this change that convert dynamic proxies implementations to
> hidden classes, intended to target JDK 24.
>
> Summary:
> 1. Adds new implementation while preserving the old implementation behind
> `-Djdk.reflect.useLegacyProxyI
Hmm, I think Proxy being hidden in stacktraces might be an advantage; the
same happens for lambdas.
The main advantage of hidden classes compared to an explicit class with
classData is that it supports flexible unloading, which might be useful for
Proxy.
I still believe the flexible unloading advan
On Mon, 20 May 2024 10:52:27 GMT, Claes Redestad wrote:
> We can fold the call to `Objects.checkIndex` into the code generated in
> generateTypeSwitchSkeleton instead of doing so by filtering the MH argument.
> This loads 9 less classes (of which 8 generated LFs and Species classes) on a
> min
On Thu, 23 May 2024 11:09:14 GMT, Claes Redestad wrote:
>> We can fold the call to `Objects.checkIndex` into the code generated in
>> generateTypeSwitchSkeleton instead of doing so by filtering the MH argument.
>> This loads 9 less classes (of which 8 generated LFs and Species classes) on
>> a
On Thu, 23 May 2024 11:39:11 GMT, Per Minborg wrote:
> This PR proposes to fix a broken link in the `MemorySegment.Scope` class.
Seams to work after the patch:
.../api/java.base/java/lang/foreign/Memor
On Thu, 23 May 2024 11:09:14 GMT, Claes Redestad wrote:
>> We can fold the call to `Objects.checkIndex` into the code generated in
>> generateTypeSwitchSkeleton instead of doing so by filtering the MH argument.
>> This loads 9 less classes (of which 8 generated LFs and Species classes) on
>> a
This PR proposes to fix a broken link in the `MemorySegment.Scope` class.
-
Commit messages:
- Fix link to section
Changes: https://git.openjdk.org/jdk/pull/19366/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19366&range=00
Issue: https://bugs.openjdk.org/browse/JDK-833
- Original Message -
> From: "Chen Liang"
> To: "core-libs-dev" , "hotspot-dev"
> , kulla-...@openjdk.org
> Sent: Thursday, May 23, 2024 1:28:01 PM
> Subject: Re: RFR: 8242888: Convert dynamic proxy to hidden classes
> On Thu, 23 May 2024 03:28:30 GMT, Chen Liang wrote:
>
>> Please rev
On Thu, 23 May 2024 11:25:00 GMT, Chen Liang wrote:
> A CSR targeting 24 describing the compatibility concerns and behavioral
> differences is here, somehow not linked by skara:
> https://bugs.openjdk.org/browse/JDK-8332770 The incompatibilities were much
> greater in the previous iterations o
On Thu, 23 May 2024 10:57:28 GMT, Magnus Ihse Bursie wrote:
>However, if we ever call this with a non-zero sp.dirlen and a null c->pdir,
>we'd be in trouble. In the old code, we would have
> crashed. Now, we will just silently ignore this, and God knows what will
> happen after that part.
In
On Thu, 23 May 2024 03:28:30 GMT, Chen Liang wrote:
> Please review this change that convert dynamic proxies implementations to
> hidden classes, intended to target JDK 24.
>
> Summary:
> 1. Adds new implementation while preserving the old implementation behind
> `-Djdk.reflect.useLegacyProxyI
On Thu, 23 May 2024 09:46:51 GMT, Jan Lahoda wrote:
>> Claes Redestad has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add type switch to HelloClasslist
>
> src/java.base/share/classes/java/lang/runtime/SwitchBootstraps.java line 53:
>
>
> We can fold the call to `Objects.checkIndex` into the code generated in
> generateTypeSwitchSkeleton instead of doing so by filtering the MH argument.
> This loads 9 less classes (of which 8 generated LFs and Species classes) on a
> minimal test, while being neutral on a throughput sanity test
On Thu, 23 May 2024 07:26:14 GMT, Matthias Baesken wrote:
>> When building with ubsan enabled (--enable-uban) on Linux x86_64 and doing
>> jtreg tests afterwards I run into this error :
>>
>> /jdk/src/java.base/unix/native/libjava/ProcessImpl_md.c:562:5: runtime
>> error: null pointer passed a
On Wed, 22 May 2024 14:47:43 GMT, Yudi Zheng wrote:
>> Moving array construction within BigInteger.implMultiplyToLen intrinsic
>> candidate to its caller simplifies the intrinsic implementation in JIT
>> compiler.
>
> Yudi Zheng has updated the pull request incrementally with one additional
>
On Wed, 22 May 2024 14:47:43 GMT, Yudi Zheng wrote:
>> Moving array construction within BigInteger.implMultiplyToLen intrinsic
>> candidate to its caller simplifies the intrinsic implementation in JIT
>> compiler.
>
> Yudi Zheng has updated the pull request incrementally with one additional
>
On Tue, 21 May 2024 09:01:32 GMT, Claes Redestad wrote:
>> We can fold the call to `Objects.checkIndex` into the code generated in
>> generateTypeSwitchSkeleton instead of doing so by filtering the MH argument.
>> This loads 9 less classes (of which 8 generated LFs and Species classes) on
>> a
On Thu, 16 May 2024 10:29:48 GMT, Sunmisc Unsafe wrote:
>> Doug Lea has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address review comments
>
> Maybe I don't quite understand, or I don't have proof, But wouldn't it be
> better if invoke
On Tue, 21 May 2024 14:28:38 GMT, Matthias Baesken wrote:
> When building with ubsan enabled (--enable-uban) on Linux x86_64 and doing
> jtreg tests afterwards I run into this error :
>
> /jdk/src/java.base/unix/native/libjava/ProcessImpl_md.c:562:5: runtime error:
> null pointer passed as arg
> When building with ubsan enabled (--enable-uban) on Linux x86_64 and doing
> jtreg tests afterwards I run into this error :
>
> /jdk/src/java.base/unix/native/libjava/ProcessImpl_md.c:562:5: runtime error:
> null pointer passed as argument 2, which is declared to never be null
> #0 0x7fd95
On Wed, 22 May 2024 14:47:43 GMT, Yudi Zheng wrote:
>> Moving array construction within BigInteger.implMultiplyToLen intrinsic
>> candidate to its caller simplifies the intrinsic implementation in JIT
>> compiler.
>
> Yudi Zheng has updated the pull request incrementally with one additional
>
63 matches
Mail list logo
