Please review this clean backport of #19708, to make javap recover and continue
after encountering undefined access flag bits set while still exiting with a
code of error, allowing it to error against improper bits while still providing
as much output as possible.
-
Commit messages
On Thu, 13 Jun 2024 17:50:38 GMT, Chen Liang wrote:
> Currently, javap crashes for class files that have set non-zero values for
> undefined access flag bits, as
> `java.lang.reflect.AccessFlag.maskToAccessFlag` and
> `java.lang.classfile.AccessFlags.flags` fail. In contrast, the JVMS, though
On Thu, 20 Jun 2024 20:11:06 GMT, Chen Liang wrote:
> Please review this patch, which is a backport of the fix in #19615 to JDK 23.
>
> This is not a clean patch, because the old patch was done on JDK-8333479
> (#19585) which was absent in JDK 23; however, the conflicts were small, and
> the o
On Fri, 21 Jun 2024 07:40:31 GMT, Hannes Greule wrote:
> Addresses two simple problems regarding javadocs in the FFM API.
Yes, javadoc fixes such as this can be backported. Just use the `/backport`
command:
https://wiki.openjdk.org/display/SKARA/Pull+Request+Commands#PullRequestCommands-/backp
On Thu, 20 Jun 2024 17:25:33 GMT, Alan Bateman wrote:
>> Something like that yes
>
> An altermative is to use ResolvedModule::reference to get a ModuleReference,
> then use its open method to open the contents of the module to get a
> ModuleReader. That will give you a stream over the names of
> This PR adds a new JDK tool, called `jnativescan`, that can be used to find
> code that accesses native functionality. Currently this includes `native`
> method declarations, and methods marked with `@Restricted`.
>
> The tool accepts a list of class path and module path entries through
> `--
> Please review this test-only clean up PR which converts the java.util.Base64
> tests to run under JUnit.
>
> In general, this allows for the tests to run independently, separates the
> data providers from the tests, as well being able to utilize the built in
> JUnit utility test methods to re
On Fri, 21 Jun 2024 18:38:07 GMT, Jorn Vernee wrote:
>> test/langtools/tools/jnativescan/TestJNativeScan.java line 174:
>>
>>> 172: "-add-modules",
>>> "org.singlejar,org.myapp",
>>> 173: "--print-native-access"))
>>> 174:
Thanks, filed 9077206.
Den fre. 21. jun. 2024 kl. 21.06 skrev Raffaello Giulietti <
raffaello.giulie...@oracle.com>:
> Hi,
>
> your observation seems correct.
>
> In order to file a properly tracked bug report, please proceed according
> to this guide:
>
>
> https://docs.oracle.com/en/java/javase
On Wed, 19 Jun 2024 15:15:43 GMT, Magnus Ihse Bursie wrote:
>> This patch contains a set of changes to improve static builds. They will
>> pave the way for implementing a full static-only java launcher. The changes
>> here will:
>>
>> 1) Make sure non-exported symbols are made local in the sta
On Wed, 19 Jun 2024 15:15:43 GMT, Magnus Ihse Bursie wrote:
>> This patch contains a set of changes to improve static builds. They will
>> pave the way for implementing a full static-only java launcher. The changes
>> here will:
>>
>> 1) Make sure non-exported symbols are made local in the sta
On Wed, 19 Jun 2024 15:15:43 GMT, Magnus Ihse Bursie wrote:
>> This patch contains a set of changes to improve static builds. They will
>> pave the way for implementing a full static-only java launcher. The changes
>> here will:
>>
>> 1) Make sure non-exported symbols are made local in the sta
On Wed, 19 Jun 2024 15:15:43 GMT, Magnus Ihse Bursie wrote:
>> This patch contains a set of changes to improve static builds. They will
>> pave the way for implementing a full static-only java launcher. The changes
>> here will:
>>
>> 1) Make sure non-exported symbols are made local in the sta
On Wed, 19 Jun 2024 15:15:43 GMT, Magnus Ihse Bursie wrote:
>> This patch contains a set of changes to improve static builds. They will
>> pave the way for implementing a full static-only java launcher. The changes
>> here will:
>>
>> 1) Make sure non-exported symbols are made local in the sta
On Fri, 21 Jun 2024 18:37:01 GMT, Jorn Vernee wrote:
>> src/jdk.jdeps/share/classes/com/sun/tools/jdeprscan/Main.java line 417:
>>
>>> 415: return false;
>>> 416: }
>>> 417: JavaFileManager fm =
>>> pp.getPlatformTrusted(release).getFileManager();
>>
>>
On Fri, 21 Jun 2024 18:31:00 GMT, Jan Lahoda wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> add extra test for missing root modules
>
> src/jdk.jdeps/share/classes/com/sun/tools/jdeprscan/Main.java line 417:
>
>>
On Wed, 19 Jun 2024 15:15:43 GMT, Magnus Ihse Bursie wrote:
>> This patch contains a set of changes to improve static builds. They will
>> pave the way for implementing a full static-only java launcher. The changes
>> here will:
>>
>> 1) Make sure non-exported symbols are made local in the sta
On Thu, 20 Jun 2024 17:44:54 GMT, Alan Bateman wrote:
>> src/jdk.jdeps/share/classes/com/sun/tools/jnativescan/JNativeScanTask.java
>> line 113:
>>
>>> 111: // Class-Path attribute specifies that jars that
>>> 112: // are not found are simply ignored. Do
On Thu, 20 Jun 2024 19:45:29 GMT, Jorn Vernee wrote:
>> This PR adds a new JDK tool, called `jnativescan`, that can be used to find
>> code that accesses native functionality. Currently this includes `native`
>> method declarations, and methods marked with `@Restricted`.
>>
>> The tool accepts
On Thu, 20 Jun 2024 16:58:55 GMT, Alan Bateman wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/platform/JDKPlatformProvider.java
>> line 93:
>>
>>> 91: }
>>> 92:
>>> 93: public PlatformDescription getPlatformTrusted(String platformName) {
>>
>> I noticed that `getPlatform
Hi,
your observation seems correct.
In order to file a properly tracked bug report, please proceed according
to this guide:
https://docs.oracle.com/en/java/javase/22/troubleshoot/submit-bug-report.html
Thanks
On 2024-06-21 19:12, Stig Rohde Døssing wrote:
Hi,
The Javadoc for RandomGener
Hi,
The Javadoc for RandomGenerator.nextLong(long origin, long bound) has this
to say:
Implementation Requirements:The default implementation checks that origin
and bound are positive longs
This doesn't seem to be true. The default implementation checks that origin
and bound are a valid range (t
On Fri, 21 Jun 2024 02:10:59 GMT, lingjun-cg wrote:
> If do that ,there is some performance degradation.
Thanks for taking the time to do benchmarks. If that is the case, then lets
stick with the proxy solution then.
-
PR Comment: https://git.openjdk.org/jdk/pull/19513#issuecommen
On Fri, 21 Jun 2024 00:49:33 GMT, SendaoYan wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [de8ee977](https://github.com/openjdk/jdk/commit/de8ee97718d7e12b541b310cf5b67f3e10e91ad9)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit being
On Fri, 21 Jun 2024 00:49:33 GMT, SendaoYan wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [de8ee977](https://github.com/openjdk/jdk/commit/de8ee97718d7e12b541b310cf5b67f3e10e91ad9)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit being
On Thu, 20 Jun 2024 18:35:00 GMT, Rajan Halade wrote:
> Updated all the tests that depend on external infrastructure services as
> manual. These tests may fail with external reasons, for instance - change in
> CA test portal, certificate status updates, or network issues.
This pull request has
On Fri, 21 Jun 2024 00:49:33 GMT, SendaoYan wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [de8ee977](https://github.com/openjdk/jdk/commit/de8ee97718d7e12b541b310cf5b67f3e10e91ad9)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit being
On Fri, 21 Jun 2024 16:11:34 GMT, Rajan Halade wrote:
>> Updated all the tests that depend on external infrastructure services as
>> manual. These tests may fail with external reasons, for instance - change in
>> CA test portal, certificate status updates, or network issues.
>
> Rajan Halade ha
On Fri, 21 Jun 2024 00:49:33 GMT, SendaoYan wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [de8ee977](https://github.com/openjdk/jdk/commit/de8ee97718d7e12b541b310cf5b67f3e10e91ad9)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit being
On Fri, 21 Jun 2024 13:10:00 GMT, Christoph Langer wrote:
>> Rajan Halade has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix typos
>
> test/jdk/security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java
> line 30:
> Updated all the tests that depend on external infrastructure services as
> manual. These tests may fail with external reasons, for instance - change in
> CA test portal, certificate status updates, or network issues.
Rajan Halade has updated the pull request incrementally with one additional
`ClassReader.readXxxEntry` were added before we had generic, type-aware
`readEntry` and `readEntryOrNull` APIs (#19330). We should remove these
specialized versions in favor of the generic version to reduce API bloating.
-
Commit messages:
- Copyright years
- 8334734: Remove speci
On Fri, 21 Jun 2024 14:05:51 GMT, Kevin Walls wrote:
> Man page update for JDK-8327793 which marked jstatd as deprecated for removal
> in JDK 24.
The updated man page looks like:
JSTATD(1) JDK
Commands
On Fri, 21 Jun 2024 14:38:44 GMT, Chen Liang wrote:
> In preparation of Class-File API exiting review, we are housekeeping our API
> surface. These 3 method removals are the most obvious and simple ones.
>
> This is separated from more throughout and (possibly controversial) changes
> for the
In preparation of Class-File API exiting review, we are housekeeping our API
surface. These 3 method removals are the most obvious and simple ones.
This is separated from more throughout and (possibly controversial) changes for
the future, to make reviews (both code and CSR) easier.
---
Hi,
Can you help to review this patch?
Thanks!
This is similar with previous JDK-8334396.
Added some tests.
### Test
| Tests | Scores | Errors | Unit
-- | -- | -- | -- | --
Intrinsic, +zbb, +rvv | Characters.reverseBytes | 1654.535 | 69.36 | ns/op
| Shorts.reverseBytes | 1795.403 | 44.015 |
On Mon, 10 Jun 2024 15:01:55 GMT, Ferenc Rakoczi wrote:
> This PR removes some unnecessary conversions between byte arrays and long
> arrays during SHA3 digest computations.
This pull request has now been integrated.
Changeset: 75bea280
Author:Ferenc Rakoczi
Committer: Weijun Wang
URL:
On Fri, 21 Jun 2024 07:40:31 GMT, Hannes Greule wrote:
> Addresses two simple problems regarding javadocs in the FFM API.
I think we can safely backport this to 23, as this is a doc-only fix (I've
labeled the JBS issue noreg-doc as well) allowed by JEP-3 for RDP 1 and 2.
-
PR Comm
Man page update for JDK-8327793 which marked jstatd as deprecated for removal
in JDK 24.
-
Commit messages:
- 8334287: Man page update for jstatd deprecation
Changes: https://git.openjdk.org/jdk/pull/19829/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19829&range=00
Is
On Fri, 21 Jun 2024 07:40:31 GMT, Hannes Greule wrote:
> Addresses two simple problems regarding javadocs in the FFM API.
Thank you for your review.
> Should we backport to 23?
I leave that up to you, I don't know how those things are handled normally. But
a backport would be very simple in t
On Tue, 11 Jun 2024 13:09:06 GMT, Kevin Walls wrote:
> jstatd is an RMI server application which monitors HotSpot VMs, and provides
> an interface to the monitoring tool jstat, for use across a remote RMI
> connection.
>
> RMI is not how modern applications communicate. It is an old transport
On Thu, 20 Jun 2024 20:12:39 GMT, Justin Lu wrote:
>> Please review this PR which incorporates the ISO 4217 Amendment 177 Update.
>>
>> Specifically, the introduction of the new currency, Zimbabwe Gold.
>
> Justin Lu has updated the pull request incrementally with one additional
> commit since
On Fri, 21 Jun 2024 13:13:38 GMT, Kevin Walls wrote:
>> jstatd is an RMI server application which monitors HotSpot VMs, and provides
>> an interface to the monitoring tool jstat, for use across a remote RMI
>> connection.
>>
>> RMI is not how modern applications communicate. It is an old trans
On Thu, 20 Jun 2024 18:35:00 GMT, Rajan Halade wrote:
> Updated all the tests that depend on external infrastructure services as
> manual. These tests may fail with external reasons, for instance - change in
> CA test portal, certificate status updates, or network issues.
Looks good, although
> jstatd is an RMI server application which monitors HotSpot VMs, and provides
> an interface to the monitoring tool jstat, for use across a remote RMI
> connection.
>
> RMI is not how modern applications communicate. It is an old transport with
> long term security concerns, and configuration
On Fri, 21 Jun 2024 12:28:20 GMT, Alan Bateman wrote:
>> For the Security Manager, the warning was worded a little differently:
>>
>> "WARNING: The Security Manager is deprecated and will be removed in a future
>> release"
>>
>> I think that wording is more clear. The current wording could be
On Thu, 20 Jun 2024 19:37:23 GMT, Jorn Vernee wrote:
> I've massaged the parsing code to where the help message now looks like this:
It is better but it might mean looking at HelpFormatter as you mentioned,.
Right now the usage message `--add-modules ` whereas the java --help
will print `--add
On Fri, 21 Jun 2024 12:31:05 GMT, Alan Bateman wrote:
> Looks like this has been accidentally created as a sub-task of the JEP issue,
> I assume you'll fix that. Will there be another issue to update the tests and
> drop `@enablePreview`?
I thought the implementation is usually created as a su
On Fri, 21 Jun 2024 11:56:37 GMT, Adam Sotona wrote:
> Class-File API is leaving preview.
> This is a removal of all `@PreviewFeature` annotations from Class-File API.
> It also bumps all `@since` tags and removes
> `jdk.internal.javac.PreviewFeature.Feature.CLASSFILE_API`.
>
> Please review.
>
On Fri, 21 Jun 2024 11:56:37 GMT, Adam Sotona wrote:
> Class-File API is leaving preview.
> This is a removal of all `@PreviewFeature` annotations from Class-File API.
> It also bumps all `@since` tags and removes
> `jdk.internal.javac.PreviewFeature.Feature.CLASSFILE_API`.
>
> Please review.
>
On Tue, 11 Jun 2024 21:09:14 GMT, Sean Mullan wrote:
>> I also think a period at the end is not necessary.
>
> For the Security Manager, the warning was worded a little differently:
>
> "WARNING: The Security Manager is deprecated and will be removed in a future
> release"
>
> I think that wor
On Fri, 21 Jun 2024 11:56:37 GMT, Adam Sotona wrote:
> Class-File API is leaving preview.
> This is a removal of all `@PreviewFeature` annotations from Class-File API.
> It also bumps all `@since` tags and removes
> `jdk.internal.javac.PreviewFeature.Feature.CLASSFILE_API`.
>
> Please review.
>
Class-File API is leaving preview.
This is a removal of all `@PreviewFeature` annotations from Class-File API.
It also bumps all `@since` tags and removes
`jdk.internal.javac.PreviewFeature.Feature.CLASSFILE_API`.
Please review.
Thanks,
Adam
-
Commit messages:
- bumped @since tag
On Thu, 20 Jun 2024 20:11:06 GMT, Chen Liang wrote:
> Please review this patch, which is a backport of the fix in #19615 to JDK 23.
>
> This is not a clean patch, because the old patch was done on JDK-8333479
> (#19585) which was absent in JDK 23; however, the conflicts were small, and
> the o
> jstatd is an RMI server application which monitors HotSpot VMs, and provides
> an interface to the monitoring tool jstat, for use across a remote RMI
> connection.
>
> RMI is not how modern applications communicate. It is an old transport with
> long term security concerns, and configuration
> jstatd is an RMI server application which monitors HotSpot VMs, and provides
> an interface to the monitoring tool jstat, for use across a remote RMI
> connection.
>
> RMI is not how modern applications communicate. It is an old transport with
> long term security concerns, and configuration
On Sun, 16 Jun 2024 21:00:41 GMT, Claes Redestad wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> code format
>
> src/java.base/share/classes/jdk/internal/math/ToDecimal.java line 171:
>
>> 169: /* Using the dep
On Thu, 20 Jun 2024 15:24:35 GMT, Kevin Walls wrote:
> 844: JMX attaching of Subject does not work when security manager not
> allowed
This pull request has now been integrated.
Changeset: 23f2c97f
Author:Kevin Walls
URL:
https://git.openjdk.org/jdk/commit/23f2c97f4ce42316fd512
On Thu, 20 Jun 2024 15:24:35 GMT, Kevin Walls wrote:
> 844: JMX attaching of Subject does not work when security manager not
> allowed
LGTM
-
Marked as reviewed by dfuchs (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/19810#pullrequestreview-2132226211
On Thu, 20 Jun 2024 15:24:35 GMT, Kevin Walls wrote:
> 844: JMX attaching of Subject does not work when security manager not
> allowed
Thanks Daniel. Testing automated and manual looks good in 24 and in this 23
backport, so I'll get this integrated.
-
PR Comment: https://git
On Fri, 21 Jun 2024 07:40:31 GMT, Hannes Greule wrote:
> Addresses two simple problems regarding javadocs in the FFM API.
Thanks! Should we backport to 23?
-
Marked as reviewed by mcimadamore (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/19820#pullrequestreview-213215539
Addresses two simple problems regarding javadocs in the FFM API.
-
Commit messages:
- fix two javadoc problems in FFM
Changes: https://git.openjdk.org/jdk/pull/19820/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19820&range=00
Issue: https://bugs.openjdk.org/browse/JDK-
On Fri, 21 Jun 2024 07:25:27 GMT, lingjun-cg wrote:
>> ### Performance regression of DecimalFormat.format
>> From the output of perf, we can see the hottest regions contain atomic
>> instructions. But when run with JDK 11, there is no such problem. The
>> reason is the removed biased locking.
> ### Performance regression of DecimalFormat.format
> From the output of perf, we can see the hottest regions contain atomic
> instructions. But when run with JDK 11, there is no such problem. The reason
> is the removed biased locking.
> The DecimalFormat uses StringBuffer everywhere, and St
> ### Performance regression of DecimalFormat.format
> From the output of perf, we can see the hottest regions contain atomic
> instructions. But when run with JDK 11, there is no such problem. The reason
> is the removed biased locking.
> The DecimalFormat uses StringBuffer everywhere, and St
65 matches
Mail list logo
