On Mon, 11 Jul 2022 11:46:21 GMT, Сергей Цыпанов wrote:
>> We can skip bounds check and null check for Charset in case we use the array
>> entirely and the Charset is either default one or proven to be non-null.
>>
>> Benchmark results:
>>
>> before
>>
>> Benchmark
On Mon, 11 Jul 2022 08:04:20 GMT, Joe wrote:
> 8289562: Change bugs.java.com and bugreport.java.com URL's to https
Looks fine to me. However the langtools / javadoc folks seem like they should
be primary reviewers since it is mostly messages from the tools.
-
Marked as reviewed by
On Wed, 10 Aug 2022 08:01:41 GMT, Andrey Turbanov wrote:
> It's a bit shorter and clearer.
Approving (just) the client change
-
Marked as reviewed by prr (Reviewer).
PR: https://git.openjdk.org/jdk/pull/9816
On Wed, 14 Sep 2022 14:09:52 GMT, Alan Bateman wrote:
>> Degrade Thread.stop to throw UOE unconditionally, deprecate ThreadDeath for
>> removal, and remove the remaining special handling of ThreadDeath from the
>> JDK.
>>
>> Thread.stop is inherently unsafe and has been deprecated since JDK 1.
On Fri, 30 Sep 2022 14:16:24 GMT, Weijun Wang wrote:
>> src/jdk.accessibility/windows/native/include/bridge/AccessBridgeCalls.h line
>> 34:
>>
>>> 32: * the following link:
>>> 33: *
>>> 34: *
>>> http://hg.openjdk.org/jdk9/jdk9/jdk/raw-file/tip/src/jdk.accessibility/windows/native/bridge/A
On Tue, 27 Sep 2022 12:14:23 GMT, Pavel Rappo wrote:
>> This adds exception documentation to JDK methods that would otherwise lose
>> that documentation once JDK-8287796 is integrated. While adding this
>> exception documentation now does not change [^1] the JDK API Documentation,
>> it will a
On Mon, 3 Oct 2022 17:29:45 GMT, Joe Darcy wrote:
>> With the domain change from openjdk.java.net to openjdk.org, references to
>> URLs in the sources should be updated.
>>
>> Updates were made using a shell script. I"ll run a copyright updater before
>> any push.
>
> Joe Darcy has updated the
On Mon, 3 Oct 2022 20:37:11 GMT, Joe Darcy wrote:
>> With the domain change from openjdk.java.net to openjdk.org, references to
>> URLs in the sources should be updated.
>>
>> Updates were made using a shell script. I"ll run a copyright updater before
>> any push.
>
> Joe Darcy has updated the
On Tue, 18 Oct 2022 11:55:06 GMT, Magnus Ihse Bursie wrote:
> This is a continuation of the effort to update all our URLs to the new
> top-level domain.
>
> This patch updates (most) URLs in testing code. There still exists references
> to openjdk.java.net, but that are not strictly used as no
On Fri, 21 Oct 2022 08:17:46 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to increas
On Fri, 28 Oct 2022 14:54:26 GMT, Daniel Fuchs wrote:
>> Deprecate URL constructors. Developers are encouraged to use `java.net.URI`
>> to parse or construct any URL.
>>
>> The `java.net.URL` class does not itself encode or decode any URL components
>> according to the escaping mechanism defin
On Tue, 1 Nov 2022 16:10:47 GMT, Daniel Fuchs wrote:
>> Deprecate URL constructors. Developers are encouraged to use `java.net.URI`
>> to parse or construct any URL.
>>
>> The `java.net.URL` class does not itself encode or decode any URL components
>> according to the escaping mechanism define
On Wed, 23 Nov 2022 18:57:03 GMT, Jonathan Gibbons wrote:
>> Please review a "somewhat automated" change to insert `@spec` tags into doc
>> comments, as appropriate, to leverage the recent new javadoc feature to
>> generate a new page listing the references to all external specifications
>> li
On Tue, 6 Dec 2022 15:20:26 GMT, Matthias Baesken wrote:
> We have a number of places in the codebase where a macro could help when we
> check an exception and afterwrads free something and return.
I'm OK with the idea and the specific desktop change.
I'll leave the rest to the appropriate com
On Fri, 16 Dec 2022 17:02:42 GMT, Damon Nguyen wrote:
>> Open l10n drop
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix missing dash
src/demo/share/jfc/SwingSet2/resources/swingset_zh_CN.properties
On Tue, 17 Jan 2023 13:35:25 GMT, Kevin Rushforth wrote:
>>> Normally, such changes in third-party libraries need to be done upstream,
>>> and not locally. @prrace can confirm.
>>
>> Thanks @kevinrushforth for your review.
>>
>> Yes, it had been fixed in the upstream and I just follow it.
>> P
On Sat, 14 Jan 2023 14:28:32 GMT, Jie Fu wrote:
> Hi all,
>
> Please review the fix for the build failure with clang-15.
>
> 1. -Wbitwise-instead-of-logical
>
>1) src/hotspot/share/oops/generateOopMap.cpp <--- fixed the
> warning
>2) src/hotspot/share/runtime/notificationThre
On Tue, 24 Jan 2023 22:12:26 GMT, Damon Nguyen wrote:
>> Open l10n drop. Files have been updated with translated versions. Whitespace
>> tool has been ran on files.
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revisi
On Thu, 2 Mar 2023 12:03:44 GMT, Pavel Rappo wrote:
> Please review this superficial documentation cleanup that was triggered by
> unrelated analysis of doc comments in JDK API.
>
> The only effect that this multi-area PR has on the JDK API Documentation
> (i.e. the observable effect on the ge
On Mon, 13 Mar 2023 21:16:24 GMT, Naoto Sato wrote:
> Proposing accessor methods to Emoji properties defined in [Unicode Technical
> Standard #51](https://unicode.org/reports/tr51/) in `java.lang.Character`
> class. This is per a request from the client group, as well as refining the
> current
On Thu, 6 Apr 2023 19:25:19 GMT, Roger Riggs wrote:
>> Define an internal jdk.internal.util.Architecture enumeration and static
>> methods to replace uses of the system property `os.arch`.
>> The enumeration values are defined to match those used in the build.
>> The initial values are: `X64, X8
On Fri, 31 Mar 2023 05:57:01 GMT, Julian Waters wrote:
>> A couple of spots wrongly refer to boolean and jboolean as the same thing.
>> While this does still compile thanks to a happy accident and implicit
>> conversions, they are not the same at all, and should be fixed before a
>> future com
On Fri, 28 Apr 2023 01:03:28 GMT, Jiangli Zhou wrote:
> Initial implementation for supporting building a fully statically linked
> (with a desired set of JDK native libraries and libjvm) Java launcher
> executable, which is named as 'javastatic'.
>
> In this PR, the support is only added for t
On Wed, 17 May 2023 12:28:47 GMT, Artem Semenov wrote:
> When using the clang compiler to build OpenJDk on Linux, we encounter various
> "warnings as errors".
> They can be fixed with small changes.
I don't like this approach at all. if github had a "reject" button I'd be
pushing it now.
updat
On Fri, 26 May 2023 08:31:46 GMT, JoKern65 wrote:
>> When using the new xlc17 compiler (based on a recent clang) to build OpenJDk
>> on AIX , we run into various "warnings as errors".
>> Some of those are in shared codebase and could be addressed by small
>> adjustments.
>> A lot of those chang
On Thu, 1 Jun 2023 11:49:24 GMT, Julian Waters wrote:
>> On Windows, the basic Java Integer types are defined as long and __int64
>> respectively. In particular, the former is rather problematic since it
>> breaks compilation as the Visual C++ becomes stricter and more compliant
>> with every
On Thu, 1 Jun 2023 11:49:24 GMT, Julian Waters wrote:
>> On Windows, the basic Java Integer types are defined as long and __int64
>> respectively. In particular, the former is rather problematic since it
>> breaks compilation as the Visual C++ becomes stricter and more compliant
>> with every
On Mon, 19 Jun 2023 06:55:52 GMT, Axel Boldt-Christmas
wrote:
>> The current implementation for testing generational ZGC with jtreg is
>> implemented with a filter on the mode flag `ZGenerational`. Because of this
>> only environments which set this flag explicitly will run most of the tests.
On Wed, 5 Jul 2023 14:51:31 GMT, Roger Riggs wrote:
> Source code cleanup.
> Add @since, remove unused imports and remove unnecessary SuppressWarnings of
> deprecation.
unless my eyes deceive me the suppresswarnings is still present.
-
Changes requested by prr (Reviewer).
PR Revi
On Wed, 5 Jul 2023 16:20:07 GMT, Roger Riggs wrote:
>> Source code cleanup.
>> Add @since, remove unused imports and remove unnecessary SuppressWarnings of
>> deprecation.
>
> Roger Riggs has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Rem
On Mon, 14 Aug 2023 07:48:00 GMT, Matthias Baesken wrote:
> Currently there is a number of functionality that would be interesting to
> have for shared lib load operations in the JDK C code.
> Some examples :
> Events::log_dll_message for hs-err files reporting
> JFR event NativeLibraryLoad
> Th
On Thu, 15 Feb 2024 12:19:31 GMT, Magnus Ihse Bursie wrote:
> Since jcheck only checks file in a commit, there is a possibility of us
> getting files in the repository that would not be accepted by jcheck. This
> can happen when extending the set of files checked by jcheck, or if jcheck
> chan
On Mon, 5 Feb 2024 10:58:17 GMT, Magnus Ihse Bursie wrote:
>> Inspired by (the later backed-out)
>> [JDK-8296115](https://bugs.openjdk.org/browse/JDK-8296115), I propose to
>> enable `-Wpedantic` for clang. This has already found some irregularities in
>> the code, like mistakenly using `#impo
On Thu, 18 Apr 2024 11:32:13 GMT, Per Minborg wrote:
>> While `SymbolLookup` correctly uses an `Optional` return to denote whether a
>> symbol has been found by the lookup or not (which enables composition of
>> symbol lookups), many clients end up just calling `Optional::get`, or
>> `Optional
On Fri, 26 Apr 2024 16:04:09 GMT, Jonathan Gibbons wrote:
>> Please review the updates to support a proposed new
>> `-Xlint:dangling-doc-comments` option.
>>
>> The work can be thought of as in 3 parts:
>>
>> 1. An update to the `javac` internal class `DeferredLintHandler` so that it
>> is po
On Thu, 2 May 2024 21:05:38 GMT, Alexander Zvegintsev
wrote:
> Trivial fix.
I'd love to approve this but could you please explain what this is about ?
I see the failure log in the bug report but I am none the wiser.
Why exactly is this a problem ?
-
PR Comment: https://git.openjd
On Thu, 2 May 2024 21:05:38 GMT, Alexander Zvegintsev
wrote:
> Trivial fix.
I see you added test.lib.Platform.isOnWayland() in this PR
https://github.com/openjdk/jdk/pull/18995/files#diff-a1fe81399728999601f16ae9aaf5caae27f009c394377d2cd86c71f6d5e0e54c
So, that helps me understand why it is a
On Thu, 2 May 2024 21:05:38 GMT, Alexander Zvegintsev
wrote:
> Trivial fix.
Marked as reviewed by prr (Reviewer).
OK. I see. The problem is that the test is out of sync with the actual usage of
Platform.
Arguably isOnWayland() and all these others should be in some OTHER class
entirely.
Some
On Mon, 13 May 2024 10:49:30 GMT, Maurizio Cimadamore
wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address review comments
>
> make/conf/module-loader-map.conf line 105:
>
>> 103: java.smartcardio \
On Fri, 17 May 2024 13:38:25 GMT, Maurizio Cimadamore
wrote:
>> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting
>> the use of JNI in the following ways:
>>
>> * `System::load` and `System::loadLibrary` are now restricted methods
>> * `Runtime::load` and `Runtime::loa
On Fri, 17 May 2024 13:38:25 GMT, Maurizio Cimadamore
wrote:
>> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting
>> the use of JNI in the following ways:
>>
>> * `System::load` and `System::loadLibrary` are now restricted methods
>> * `Runtime::load` and `Runtime::loa
On Fri, 7 Jun 2024 22:46:44 GMT, Damon Nguyen wrote:
> This issue is responsible for updating the translations of all the
> localize(able) resources in the JDK. Primarily, the changes between JDK 22
> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
>
> The translati
8318364: Add an FFM-based implementation of harfbuzz OpenType layout
-
Commit messages:
- remove tailing white space
- use scaling
- Fix windows build, remove perf. logging
- Add test, fix bug
- use allocateFrom
- add offset param
- suppressed restricted warnings, now builds bu
On Wed, 30 Aug 2023 02:55:34 GMT, Sergey Bylokhov wrote:
> @prrace did you check how this change affects the performance, especially
> startup? I have experimented with Panama for littlecms:
> https://bugs.openjdk.org/browse/JDK-8313344 and found that the biggest issue
> is a cold start, 8 ms
On Tue, 17 Oct 2023 11:50:20 GMT, Jorn Vernee wrote:
>> 8318364: Add an FFM-based implementation of harfbuzz OpenType layout
>
> src/java.desktop/share/classes/sun/font/HBShaper.java line 310:
>
>> 308: SequenceLayout glyphInfosLayout =
>> MemoryLayout.sequenceLayout(maxinfo, GlyphInfoL
On Wed, 18 Oct 2023 03:43:15 GMT, Jorn Vernee wrote:
> > I'm unclear why it is "better". It seems more obscure to me.
>
> Ok. I think it's better because it doesn't require creating a maximum size
> sequence layout in order to then make a var handle out of, which is a bit of
> a hack IMO. One
On Tue, 29 Aug 2023 22:04:40 GMT, Phil Race wrote:
> 8318364: Add an FFM-based implementation of harfbuzz OpenType layout
I've added a test, which although it does not check the rendering is correct,
it checks that the rendering would be identical in both the JNI and FFM cases.
So
On Wed, 18 Oct 2023 06:16:15 GMT, Jorn Vernee wrote:
>>> > I'm unclear why it is "better". It seems more obscure to me.
>>>
>>> Ok. I think it's better because it doesn't require creating a maximum size
>>> sequence layout in order to then make a var handle out of, which is a bit
>>> of a hack
On Tue, 29 Aug 2023 22:04:40 GMT, Phil Race wrote:
> 8318364: Add an FFM-based implementation of harfbuzz OpenType layout
That's interesting. As soon as this went RFR, skara started to send all the
emails from several weeks of already resolved discussions but with a current
timestamp,
> 8318364: Add an FFM-based implementation of harfbuzz OpenType layout
Phil Race has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains 18 commits:
- Merge remote-tracking branch 'upstream/master' into harfbuzz_panama
Me
> 8318364: Add an FFM-based implementation of harfbuzz OpenType layout
Phil Race has updated the pull request incrementally with one additional commit
since the last revision:
Use new arrayElementVarHandle method
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15476/fi
> 8318364: Add an FFM-based implementation of harfbuzz OpenType layout
Phil Race has updated the pull request incrementally with one additional commit
since the last revision:
indentation
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15476/files
- new: ht
On Mon, 6 Nov 2023 18:52:05 GMT, Sergey Bylokhov wrote:
> Since we plan to import it into jdk22, do you have some performance data to
> share? any positive or negative effects of this migration?
There's three phases - (1) startup, (2) warmup and (3) warmed up performance.
JNI has minimal star
On Mon, 6 Nov 2023 23:58:11 GMT, Sergey Bylokhov wrote:
> > So we have somewhere around a fixed 125ms startup cost for the FFM case -
> > as measured on my Mac,
> > but only 35-40ms of that is attributable to the specific needs of layout.
>
> That looks unfortunate. I guess if we will start to
On Wed, 23 Aug 2023 15:18:03 GMT, Matthias Baesken wrote:
>> Currently there is a number of functionality that would be interesting to
>> have for shared lib load operations in the JDK C code.
>> Some examples :
>> Events::log_dll_message for hs-err files reporting
>> JFR event NativeLibraryLoad
On Wed, 15 Nov 2023 15:52:43 GMT, Jayathirth D V wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> indentation
>
> src/java.desktop/share/classes/sun/font/HBShaper.java line 142:
>
> 8318364: Add an FFM-based implementation of harfbuzz OpenType layout
Phil Race has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains 21 commits:
- Merge remote-tracking branch 'upstream/master' into harfbuzz_pa
On Thu, 16 Nov 2023 19:35:53 GMT, Jorn Vernee wrote:
> > > > > layoutCnt=16000 total=193ms <<< app fully displayed
> > > > > vs
> > > > > layoutCnt=16000 total=453ms <<< app fully displayed
> > > >
> > > >
> > > > It looks strange that 16000 calls are not enough to warmup, and the
> > > > diff
On Wed, 15 Nov 2023 15:06:55 GMT, Jayathirth D V wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> indentation
>
> src/java.desktop/share/classes/sun/font/HBShaper.java line 66:
>
>
> 8318364: Add an FFM-based implementation of harfbuzz OpenType layout
Phil Race has updated the pull request incrementally with one additional commit
since the last revision:
8318364
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15476/files
- new: ht
On Thu, 16 Nov 2023 13:48:38 GMT, Prasanta Sadhukhan
wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> indentation
>
> src/java.desktop/share/classes/sun/font/HBShaper.java line 628:
&g
> 8318364: Add an FFM-based implementation of harfbuzz OpenType layout
Phil Race has updated the pull request incrementally with one additional commit
since the last revision:
8318364
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15476/files
- new: ht
On Tue, 29 Aug 2023 22:04:40 GMT, Phil Race wrote:
> 8318364: Add an FFM-based implementation of harfbuzz OpenType layout
This pull request has now been integrated.
Changeset: f69e6653
Author: Phil Race
URL:
https://git.openjdk.org/jdk/commit/f69e6653f86a7dd781db6c8523f114c0d3f7c
Many printing tests do not have the @printer keyword. This adds them to those
that need it.
I also found one test that has nothing to do with printing in the print folder
and moved it out.
-
Commit messages:
- 8320608
Changes: https://git.openjdk.org/jdk/pull/16785/files
Webrev:
On Thu, 23 Nov 2023 11:10:35 GMT, Alexey Ivanov wrote:
>> Many printing tests do not have the @printer keyword. This adds them to
>> those that need it.
>> I also found one test that has nothing to do with printing in the print
>> folder and moved it out.
>
> test/jdk/java/awt/PrintJob/EdgeTest
On Thu, 23 Nov 2023 07:02:54 GMT, Alan Bateman wrote:
>> Many printing tests do not have the @printer keyword. This adds them to
>> those that need it.
>> I also found one test that has nothing to do with printing in the print
>> folder and moved it out.
>
> test/jdk/TEST.ROOT line 15:
>
>> 13
On Thu, 23 Nov 2023 20:39:50 GMT, Alexey Ivanov wrote:
>> test/jdk/java/awt/print/PageFormat/SetOrient.java line 28:
>>
>>> 26: * @summary Confirm that the clip and transform of the Graphics2D is
>>> 27: * affected by the landscape orientation of the PageFormat.
>>> 28: */
>>
>> Sin
> Many printing tests do not have the @printer keyword. This adds them to those
> that need it.
> I also found one test that has nothing to do with printing in the print
> folder and moved it out.
Phil Race has updated the pull request incrementally with one additional commit
si
On Thu, 30 Nov 2023 15:59:29 GMT, Alexey Ivanov wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8320608
>
> test/jdk/java/awt/print/PageFormat/SmallPaperPrinting.java line 73:
>
&g
On Thu, 30 Nov 2023 15:41:28 GMT, Alexey Ivanov wrote:
>> "Should not" is strong. Why ? There's no requirement do to this even though
>> you can.
>> https://openjdk.org/jtreg/faq.html#can-i-use-the-author-run-etc.-tags-in-other-files
>
> That's the reason why I prefer you keep the `@run` tag in
On Thu, 30 Nov 2023 17:08:21 GMT, Alexey Ivanov wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8320608
>
> test/jdk/java/awt/print/PrinterJob/EmptyFill.java line 72:
>
> Many printing tests do not have the @printer keyword. This adds them to those
> that need it.
> I also found one test that has nothing to do with printing in the print
> folder and moved it out.
Phil Race has updated the pull request incrementally with one additional commit
si
On Thu, 30 Nov 2023 19:50:00 GMT, Sergey Bylokhov wrote:
> probably we can link this from our wiki page where we describe the usage of
> keywords?:
> https://wiki.openjdk.org/display/ClientLibs/Automated+client+GUI+testing+system+set+up+requirements
Good idea, once this is pushed, I'll add th
On Wed, 22 Nov 2023 19:26:40 GMT, Phil Race wrote:
> Many printing tests do not have the @printer keyword. This adds them to those
> that need it.
> I also found one test that has nothing to do with printing in the print
> folder and moved it out.
This pull request has now bee
On Tue, 11 Jun 2024 19:28:27 GMT, Damon Nguyen wrote:
>> This issue is responsible for updating the translations of all the
>> localize(able) resources in the JDK. Primarily, the changes between JDK 22
>> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
>>
>> The tra
On Tue, 16 Jul 2024 08:59:20 GMT, Julian Waters wrote:
>> snprintf has been available for all officially and unofficially supported
>> compilers for Windows, Visual Studio since version 2015 and gcc since, well,
>> forever. snprintf is conforming to C99 since the start when compiling using
>>
On Wed, 21 Aug 2024 22:14:40 GMT, Magnus Ihse Bursie wrote:
>> As a preparation for Hermetic Java, we need to have a way to look up during
>> runtime if we are using a statically linked library or not.
>>
>> This change will be the first step needed towards compiling the object files
>> only o
77 matches
Mail list logo
