Re: RFR: 8318971: Better Error Handling for Jar Tool Processing of "@File" [v5]

2023-11-28 Thread Ryan Wallace
ing to the > current directory. > The fix is to return false when a missing file is supplied and exit > immediately without continuing with any wasted processing. > > Thanks, > Ryan. Ryan Wallace has updated the pull request with a new target base due to a merge or a rebase. The in

Re: RFR: 8318971:Better Error Handling for Jar Tool Processing of "@File" [v4]

2023-11-21 Thread Ryan Wallace
ing to the > current directory. > The fix is to return false when a missing file is supplied and exit > immediately without continuing with any wasted processing. > > Thanks, > Ryan. Ryan Wallace has updated the pull request with a new target base due to a merge or a rebase. The in

Re: RFR: 8318971: jar v17 should either exit on error immediately or create archive as jar v1.8 did [v2]

2023-11-08 Thread Ryan Wallace
On Wed, 8 Nov 2023 09:42:25 GMT, Ryan Wallace wrote: >> Hi all, >> >> Please review this fix for jar tool not producing archive if there is a >> missing file supplied. Fix is to throw an exception and exit processing when >> a missing file is supplied. Current be

Re: RFR: 8318971: jar v17 should either exit on error immediately or create archive as jar v1.8 did [v3]

2023-11-08 Thread Ryan Wallace
ng and not produce the archive. Updated > ClassPath test to verify jar is not created. > > Thanks, > Ryan. Ryan Wallace has updated the pull request incrementally with one additional commit since the last revision: 8318971: jar v17 should either exit on error immediately or c

Re: RFR: 8318971: jar v17 should either exit on error immediately or create archive as jar v1.8 did [v2]

2023-11-08 Thread Ryan Wallace
ng and not produce the archive. Updated > ClassPath test to verify jar is not created. > > Thanks, > Ryan. Ryan Wallace has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/reb

Re: RFR: 8318971: jar v17 should either exit on error immediately or create archive as jar v1.8 did

2023-11-08 Thread Ryan Wallace
On Mon, 30 Oct 2023 16:16:52 GMT, Ryan Wallace wrote: > Hi all, > > Please review this fix for jar tool not producing archive if there is a > missing file supplied. Fix is to throw an exception and exit processing when > a missing file is supplied. Current behaviour will re

Re: RFR: 8318971: jar v17 should either exit on error immediately or create archive as jar v1.8 did

2023-11-07 Thread Ryan Wallace
On Mon, 30 Oct 2023 16:16:52 GMT, Ryan Wallace wrote: > Hi all, > > Please review this fix for jar tool not producing archive if there is a > missing file supplied. Fix is to throw an exception and exit processing when > a missing file is supplied. Current behaviour will re

Re: RFR: 8318971: jar v17 should either exit on error immediately or create archive as jar v1.8 did

2023-11-06 Thread Ryan Wallace
On Mon, 30 Oct 2023 16:16:52 GMT, Ryan Wallace wrote: > Hi all, > > Please review this fix for jar tool not producing archive if there is a > missing file supplied. Fix is to throw an exception and exit processing when > a missing file is supplied. Current behaviour will re

RFR: 8318971: jar v17 should either exit on error immediately or create archive as jar v1.8 did

2023-11-06 Thread Ryan Wallace
Hi all, Please review this fix for jar tool not producing archive if there is a missing file supplied. Fix is to throw an exception and exit processing when a missing file is supplied. Current behaviour will recognise missing file as an error but continue processing and not produce the archive.