Re: RFR: 8367603: Optimize exact division in BigDecimal [v22]

2025-10-02 Thread fabioromano1
On Mon, 29 Sep 2025 16:12:20 GMT, fabioromano1 wrote: >> A formula to lower the overestimate for the precision of an exact quotient, >> without introducing too expensive operations of division on numerator and >> denominator. > > fabioromano1 has updated the pull reques

Re: RFR: 8367603: Optimize exact division in BigDecimal [v22]

2025-09-29 Thread fabioromano1
> A formula to lower the overestimate for the precision of an exact quotient, > without introducing too expensive operations of division on numerator and > denominator. fabioromano1 has updated the pull request incrementally with two additional commits since the last

Re: RFR: 8367603: Optimize exact division in BigDecimal [v14]

2025-09-26 Thread fabioromano1
On Wed, 24 Sep 2025 12:26:32 GMT, Raffaello Giulietti wrote: >> fabioromano1 has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Small optimizations > > src/java.base/share/classes/java/math/BigDeci

Re: RFR: 8367603: Optimize exact division in BigDecimal [v19]

2025-09-26 Thread fabioromano1
> A formula to lower the overestimate for the precision of an exact quotient, > without introducing too expensive operations of division on numerator and > denominator. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8367603: Optimize exact division in BigDecimal [v20]

2025-09-26 Thread fabioromano1
> A formula to lower the overestimate for the precision of an exact quotient, > without introducing too expensive operations of division on numerator and > denominator. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision

Re: RFR: 8367603: Optimize exact division in BigDecimal [v18]

2025-09-26 Thread fabioromano1
> A formula to lower the overestimate for the precision of an exact quotient, > without introducing too expensive operations of division on numerator and > denominator. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8367603: Optimize exact division in BigDecimal [v17]

2025-09-26 Thread fabioromano1
> A formula to lower the overestimate for the precision of an exact quotient, > without introducing too expensive operations of division on numerator and > denominator. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision: Min

Re: RFR: 8367603: Optimize exact division in BigDecimal [v16]

2025-09-25 Thread fabioromano1
> A formula to lower the overestimate for the precision of an exact quotient, > without introducing too expensive operations of division on numerator and > denominator. fabioromano1 has updated the pull request incrementally with three additional commits since the last revision:

Re: RFR: 8367603: Optimize exact division in BigDecimal [v15]

2025-09-25 Thread fabioromano1
On Thu, 25 Sep 2025 12:26:27 GMT, fabioromano1 wrote: >> A formula to lower the overestimate for the precision of an exact quotient, >> without introducing too expensive operations of division on numerator and >> denominator. > > fabioromano1 has updated the pull reques

Re: RFR: 8367603: Optimize exact division in BigDecimal [v15]

2025-09-25 Thread fabioromano1
> A formula to lower the overestimate for the precision of an exact quotient, > without introducing too expensive operations of division on numerator and > denominator. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8367603: Optimize exact division in BigDecimal [v14]

2025-09-24 Thread fabioromano1
On Wed, 24 Sep 2025 12:26:32 GMT, Raffaello Giulietti wrote: >> fabioromano1 has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Small optimizations > > src/java.base/share/classes/java/math/BigDeci

Re: RFR: 8367603: Optimize exact division in BigDecimal [v14]

2025-09-20 Thread fabioromano1
> A formula to lower the overestimate for the precision of an exact quotient, > without introducing too expensive operations of division on numerator and > denominator. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8367603: Optimize exact division in BigDecimal [v5]

2025-09-19 Thread fabioromano1
> A formula to lower the overestimate for the precision of an exact quotient, > without introducing too expensive operations of division on numerator and > denominator. > [Here is a proof for the > formula.](https://github.com/user-attachments/files/22314648/frazioni_decimali.pdf

RFR: 8366478: BigDecimal roots

2025-09-17 Thread fabioromano1
An implementation of `BigDecimal.nthRoot(int, MathContext)`. - Commit messages: - Removed trailing whitespaces - Add BigDecimal.nthRoot() Changes: https://git.openjdk.org/jdk/pull/27148/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=27148&range=00 Issue: https://bugs.op

Re: RFR: 8367603: Optimize exact division in BigDecimal [v11]

2025-09-17 Thread fabioromano1
> A formula to lower the overestimate for the precision of an exact quotient, > without introducing too expensive operations of division on numerator and > denominator. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision: Opt

Re: RFR: 8367603: Optimize exact division in BigDecimal [v13]

2025-09-15 Thread fabioromano1
On Mon, 15 Sep 2025 16:50:03 GMT, Joe Darcy wrote: >> fabioromano1 has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Optimization > > HI @fabioromano1, > Ah, I haven't worked on that code for exact di

Re: RFR: 8367603: Optimize exact division in BigDecimal [v13]

2025-09-15 Thread fabioromano1
> A formula to lower the overestimate for the precision of an exact quotient, > without introducing too expensive operations of division on numerator and > denominator. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision: Opt

Re: RFR: 8367603: Optimize exact division in BigDecimal [v12]

2025-09-15 Thread fabioromano1
> A formula to lower the overestimate for the precision of an exact quotient, > without introducing too expensive operations of division on numerator and > denominator. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision: Opt

Re: RFR: 8367603: Optimize exact division in BigDecimal [v6]

2025-09-14 Thread fabioromano1
> A formula to lower the overestimate for the precision of an exact quotient, > without introducing too expensive operations of division on numerator and > denominator. > [Here is a proof for the > formula.](https://github.com/user-attachments/files/22314648/frazioni_decimali.pdf

Re: RFR: 8367603: Optimize exact division in BigDecimal [v10]

2025-09-14 Thread fabioromano1
> A formula to lower the overestimate for the precision of an exact quotient, > without introducing too expensive operations of division on numerator and > denominator. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision: Opt

Re: RFR: 8367603: Optimize exact division in BigDecimal [v9]

2025-09-14 Thread fabioromano1
> A formula to lower the overestimate for the precision of an exact quotient, > without introducing too expensive operations of division on numerator and > denominator. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision: Opti

Re: RFR: 8367603: Optimize exact division in BigDecimal [v8]

2025-09-14 Thread fabioromano1
> A formula to lower the overestimate for the precision of an exact quotient, > without introducing too expensive operations of division on numerator and > denominator. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision: Get

Re: RFR: 8367603: Optimize exact division in BigDecimal [v7]

2025-09-14 Thread fabioromano1
> A formula to lower the overestimate for the precision of an exact quotient, > without introducing too expensive operations of division on numerator and > denominator. > [Here is a proof for the > formula.](https://github.com/user-attachments/files/22314648/frazioni_decimali.pdf

Re: RFR: 8367603: Optimize exact division in BigDecimal [v4]

2025-09-13 Thread fabioromano1
> A formula to lower the overestimate for the precision of an exact quotient, > without introducing too expensive operations of division on numerator and > denominator. > [Here is a proof for the > formula.](https://github.com/user-attachments/files/22314648/frazioni_decimali.pdf

Re: RFR: 8367603: Optimize exact division in BigDecimal [v2]

2025-09-13 Thread fabioromano1
> A formula to lower the overestimate for the precision of an exact quotient, > without introducing too expensive operations of division on numerator and > denominator. > [Here is a proof for the > formula.](https://github.com/user-attachments/files/22314648/frazioni_decimali.pdf

Re: RFR: 8367603: Optimize exact division in BigDecimal [v3]

2025-09-13 Thread fabioromano1
> A formula to lower the overestimate for the precision of an exact quotient, > without introducing too expensive operations of division on numerator and > denominator. > [Here is a proof for the > formula.](https://github.com/user-attachments/files/22314648/frazioni_decimali.pdf

RFR: 8367603: Optimize exact division in BigDecimal

2025-09-13 Thread fabioromano1
A formula to lower the overestimate for the precision of an exact quotient, without introduce too expensive operations of division on numerator and denominator. [Here is a proof for the formula.](https://github.com/user-attachments/files/22314648/frazioni_decimali.pdf) - Commit mes

Re: RFR: 8366478: BigDecimal roots [v2]

2025-09-09 Thread fabioromano1
> An implementation of `BigDecimal.nthRoot(int, MathContext)`. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision: Code simplification - Changes: - all: https://git.openjdk.org/jdk/pull/27148/files - new: ht

Re: RFR: 8077587: BigInteger Roots [v83]

2025-09-08 Thread fabioromano1
> This PR implements nth root computation for BigIntegers using Newton method. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision: Removed MBI.valueOf(double) - Changes: - all: https://git.openjdk.org/jdk/pull/24898/fi

Re: RFR: 8366478: BigDecimal roots

2025-09-08 Thread fabioromano1
On Mon, 8 Sep 2025 16:25:00 GMT, fabioromano1 wrote: > An implementation of `BigDecimal.nthRoot(int, MathContext)`. @rgiulietti Here is the PR. - PR Comment: https://git.openjdk.org/jdk/pull/27148#issuecomment-3267146884

Integrated: 8077587: BigInteger Roots

2025-09-08 Thread fabioromano1
On Sat, 26 Apr 2025 16:15:29 GMT, fabioromano1 wrote: > This PR implements nth root computation for BigIntegers using Newton method. This pull request has now been integrated. Changeset: ab12fbfd Author:Fabio Romano Committer: Raffaello Giulietti URL: https://git.openjdk.org/

Re: RFR: 8077587: BigInteger Roots [v82]

2025-09-08 Thread fabioromano1
On Mon, 8 Sep 2025 15:08:24 GMT, Raffaello Giulietti wrote: >> fabioromano1 has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revision changes > > Personally I tend to remove code that is not used. >

Re: RFR: 8077587: BigInteger Roots [v82]

2025-09-08 Thread fabioromano1
On Mon, 8 Sep 2025 14:58:19 GMT, Raffaello Giulietti wrote: >> fabioromano1 has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revision changes > > @jddarcy @fabioromano1 It seems that `MutableBigInt

Re: RFR: 8077587: BigInteger Roots [v82]

2025-09-08 Thread fabioromano1
> This PR implements nth root computation for BigIntegers using Newton method. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision: Revision changes - Changes: - all: https://git.openjdk.org/jdk/pull/24898/files -

Re: RFR: 8077587: BigInteger Roots [v81]

2025-09-04 Thread fabioromano1
> This PR implements nth root computation for BigIntegers using Newton method. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision: Small optimization and format comments - Changes: - all: https://git.openjdk.org/jdk/p

Re: RFR: 8077587: BigInteger Roots [v78]

2025-09-03 Thread fabioromano1
On Wed, 3 Sep 2025 15:55:48 GMT, Raffaello Giulietti wrote: >> @rgiulietti The code of my implementation provides it. > > @fabioromano1 If nobody leaves a comment in the next few days, I'll approve > the PR around Monday next week. > > Thanks again for your hard wo

Re: RFR: 8077587: BigInteger Roots [v80]

2025-09-03 Thread fabioromano1
> This PR implements nth root computation for BigIntegers using Newton method. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision: Reduce max size of input test to spend less time - Changes: - all: https://git.openjdk.

Re: RFR: 8077587: BigInteger Roots [v78]

2025-09-03 Thread fabioromano1
On Wed, 3 Sep 2025 09:57:53 GMT, Raffaello Giulietti wrote: >> The way the radicand is determined is specified in the same comment below. > > What I mean is that "congruent" usually has a specific mathematical meaning, > which is not what is meant here, IIUC. Then maybe "suitable" is better th

Re: RFR: 8077587: BigInteger Roots [v79]

2025-09-03 Thread fabioromano1
> This PR implements nth root computation for BigIntegers using Newton method. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision: Apply suggestions from code review Co-authored-by: Raffaello Giulietti - Chan

Re: RFR: 8077587: BigInteger Roots [v78]

2025-09-03 Thread fabioromano1
On Wed, 3 Sep 2025 09:24:28 GMT, Raffaello Giulietti wrote: >> fabioromano1 has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revision changes > > src/java.base/share/classes/java/math/MutableBigInte

Re: RFR: 8077587: BigInteger Roots [v78]

2025-09-03 Thread fabioromano1
On Mon, 1 Sep 2025 13:05:50 GMT, Raffaello Giulietti wrote: >> fabioromano1 has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revision changes > > Is there some documentation proving your claims in the CSR

Re: RFR: 8077587: BigInteger Roots [v23]

2025-08-30 Thread fabioromano1
On Thu, 28 Aug 2025 17:04:52 GMT, Raffaello Giulietti wrote: >> @rgiulietti I haven't started yet to implement `BigDecimal.nthRoot()` by now. > > @fabioromano1 I'm asking because, as discussed in the past, your efforts on > this PR would make less sense to integrate in

Re: RFR: 8077587: BigInteger Roots [v78]

2025-08-29 Thread fabioromano1
> This PR implements nth root computation for BigIntegers using Newton method. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision: Revision changes - Changes: - all: https://git.openjdk.org/jdk/pull/24898/files -

Re: RFR: 8077587: BigInteger Roots [v77]

2025-08-29 Thread fabioromano1
> This PR implements nth root computation for BigIntegers using Newton method. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision: Grammar correction - Changes: - all: https://git.openjdk.org/jdk/pull/24898/files -

Re: RFR: 8077587: BigInteger Roots [v76]

2025-08-29 Thread fabioromano1
> This PR implements nth root computation for BigIntegers using Newton method. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision: Update comment - Changes: - all: https://git.openjdk.org/jdk/pull/24898/files -

Re: RFR: 8077587: BigInteger Roots [v75]

2025-08-28 Thread fabioromano1
> This PR implements nth root computation for BigIntegers using Newton method. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision: Revision changes - Changes: - all: https://git.openjdk.org/jdk/pull/24898/files -

Re: RFR: 8077587: BigInteger Roots [v23]

2025-08-28 Thread fabioromano1
On Thu, 28 Aug 2025 17:04:52 GMT, Raffaello Giulietti wrote: >> @rgiulietti I haven't started yet to implement `BigDecimal.nthRoot()` by now. > > @fabioromano1 I'm asking because, as discussed in the past, your efforts on > this PR would make less sense to integrate in

Re: RFR: 8077587: BigInteger Roots [v23]

2025-08-28 Thread fabioromano1
On Thu, 28 Aug 2025 15:08:55 GMT, Raffaello Giulietti wrote: >> @rgiulietti I think I'm not going to do other changes for now. > > @fabioromano1 BTW, are you already working on the `BigDecimal.nthRoot()` on > your local platform? @rgiulietti I haven't

Re: RFR: 8077587: BigInteger Roots [v74]

2025-08-28 Thread fabioromano1
> This PR implements nth root computation for BigIntegers using Newton method. fabioromano1 has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 120 commits: - Merge branch 'openjdk:master' into nth-root-branch -

Re: RFR: 8077587: BigInteger Roots [v73]

2025-08-16 Thread fabioromano1
> This PR implements nth root computation for BigIntegers using Newton method. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision: Ensure root's overestimate in for loop - Changes: - all: https://git.openjdk.org/

Re: RFR: 8077587: BigInteger Roots [v72]

2025-08-14 Thread fabioromano1
> This PR implements nth root computation for BigIntegers using Newton method. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision: Refine comment - Changes: - all: https://git.openjdk.org/jdk/pull/24898/files -

Re: RFR: 8077587: BigInteger Roots [v71]

2025-08-14 Thread fabioromano1
> This PR implements nth root computation for BigIntegers using Newton method. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision: Refine comment - Changes: - all: https://git.openjdk.org/jdk/pull/24898/files -

Re: RFR: 8077587: BigInteger Roots [v70]

2025-08-14 Thread fabioromano1
> This PR implements nth root computation for BigIntegers using Newton method. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision: Refine comments - Changes: - all: https://git.openjdk.org/jdk/pull/24898/files -

Re: RFR: 8077587: BigInteger Roots [v69]

2025-08-14 Thread fabioromano1
> This PR implements nth root computation for BigIntegers using Newton method. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision: Refine comments - Changes: - all: https://git.openjdk.org/jdk/pull/24898/files -

Re: RFR: 8077587: BigInteger Roots [v68]

2025-08-14 Thread fabioromano1
> This PR implements nth root computation for BigIntegers using Newton method. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision: An optimization - Changes: - all: https://git.openjdk.org/jdk/pull/24898/files -

Re: RFR: 8077587: BigInteger Roots [v67]

2025-08-01 Thread fabioromano1
> This PR implements nth root computation for BigIntegers using Newton method. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision: Code simplification - Changes: - all: https://git.openjdk.org/jdk/pull/24898/files -

Re: RFR: 8077587: BigInteger Roots [v66]

2025-08-01 Thread fabioromano1
> This PR implements nth root computation for BigIntegers using Newton method. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision: Removed dead code - Changes: - all: https://git.openjdk.org/jdk/pull/24898/files -

Re: RFR: 8077587: BigInteger Roots [v23]

2025-07-31 Thread fabioromano1
0 we should return >> 0, and zero raised to a negative exponent is undefined in real numbers, and >> so the remainder is. > > @fabioromano1 Let me know when your changes settle down and the code is ready > for another review round. I'd prefer to aim at a fixed rather than

Re: RFR: 8077587: BigInteger Roots [v61]

2025-07-31 Thread fabioromano1
On Wed, 30 Jul 2025 10:30:15 GMT, fabioromano1 wrote: >> fabioromano1 has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update javadoc > > src/java.base/share/classes/java/math/MutableBigInteger.java lin

Re: RFR: 8077587: BigInteger Roots [v65]

2025-07-31 Thread fabioromano1
> This PR implements nth root computation for BigIntegers using Newton method. fabioromano1 has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 111 commits: - Merge branch 'openjdk:master' into nth-root-bra

Re: RFR: 8077587: BigInteger Roots [v64]

2025-07-30 Thread fabioromano1
> This PR implements nth root computation for BigIntegers using Newton method. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision: Useless instruction - Changes: - all: https://git.openjdk.org/jdk/pull/24898/files -

Re: RFR: 8077587: BigInteger Roots [v63]

2025-07-30 Thread fabioromano1
> This PR implements nth root computation for BigIntegers using Newton method. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision: Optimization for large degree values - Changes: - all: https://git.openjdk.org/jdk/p

Re: RFR: 8077587: BigInteger Roots [v62]

2025-07-30 Thread fabioromano1
> This PR implements nth root computation for BigIntegers using Newton method. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision: Optimization for large degree's values - Changes: - all: https://git.openjdk.org/

Re: RFR: 8077587: BigInteger Roots [v61]

2025-07-30 Thread fabioromano1
On Wed, 30 Jul 2025 10:02:23 GMT, fabioromano1 wrote: >> This PR implements nth root computation for BigIntegers using Newton method. > > fabioromano1 has updated the pull request incrementally with one additional > commit since the last revision: > > Update javadoc

Re: RFR: 8077587: BigInteger Roots [v61]

2025-07-30 Thread fabioromano1
> This PR implements nth root computation for BigIntegers using Newton method. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision: Update javadoc - Changes: - all: https://git.openjdk.org/jdk/pull/24898/files -

Re: RFR: 8077587: BigInteger Roots [v60]

2025-07-30 Thread fabioromano1
> This PR implements nth root computation for BigIntegers using Newton method. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision: Refine comments - Changes: - all: https://git.openjdk.org/jdk/pull/24898/files -

Re: RFR: 8077587: BigInteger Roots [v59]

2025-07-29 Thread fabioromano1
> This PR implements nth root computation for BigIntegers using Newton method. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision: Refine the comment - Changes: - all: https://git.openjdk.org/jdk/pull/24898/files -

Re: RFR: 8077587: BigInteger Roots [v58]

2025-07-29 Thread fabioromano1
> This PR implements nth root computation for BigIntegers using Newton method. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision: Comment - Changes: - all: https://git.openjdk.org/jdk/pull/24898/files - new: ht

Re: RFR: 8077587: BigInteger Roots [v57]

2025-07-29 Thread fabioromano1
> This PR implements nth root computation for BigIntegers using Newton method. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision: More comments - Changes: - all: https://git.openjdk.org/jdk/pull/24898/files -

Re: RFR: 8077587: BigInteger Roots [v56]

2025-07-29 Thread fabioromano1
On Tue, 29 Jul 2025 14:36:57 GMT, Raffaello Giulietti wrote: > Here we have a kind of opposite case: rad can become very imprecise, up to > losing all bits from x and become 0. I think this deserves a quick comment. Later there is `rad = Math.nextUp(rad)`, that ensures `rad > 0.0`. --

Re: RFR: 8077587: BigInteger Roots [v56]

2025-07-29 Thread fabioromano1
On Tue, 29 Jul 2025 14:19:20 GMT, fabioromano1 wrote: >> This PR implements nth root computation for BigIntegers using Newton method. > > fabioromano1 has updated the pull request incrementally with one additional > commit since the last revision: > > Comment src/ja

Re: RFR: 8077587: BigInteger Roots [v56]

2025-07-29 Thread fabioromano1
> This PR implements nth root computation for BigIntegers using Newton method. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision: Comment - Changes: - all: https://git.openjdk.org/jdk/pull/24898/files - new: ht

Re: RFR: 8077587: BigInteger Roots [v52]

2025-07-29 Thread fabioromano1
On Tue, 29 Jul 2025 13:48:47 GMT, Raffaello Giulietti wrote: > starting at L.2034. This is the code that took most of my time. And at what line the obscure parts end? - PR Review Comment: https://git.openjdk.org/jdk/pull/24898#discussion_r2239917951

Re: RFR: 8077587: BigInteger Roots [v55]

2025-07-29 Thread fabioromano1
> This PR implements nth root computation for BigIntegers using Newton method. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision: Comment abbreviations - Changes: - all: https://git.openjdk.org/jdk/pull/24898/fi

Re: RFR: 8077587: BigInteger Roots [v54]

2025-07-29 Thread fabioromano1
> This PR implements nth root computation for BigIntegers using Newton method. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision: More comments - Changes: - all: https://git.openjdk.org/jdk/pull/24898/files -

Re: RFR: 8077587: BigInteger Roots [v52]

2025-07-29 Thread fabioromano1
On Tue, 29 Jul 2025 13:03:59 GMT, Raffaello Giulietti wrote: >>> To the above, we can also add >>> >>> ``` >>> * >>> * Noting that x ≥ 2^(bl-1) and ex ≥ 0, similarly to the >>> above we further get >>> * x 2^(-sh') ≥ 2^(ex+P-1) ≥ 2^(P-1)

Re: RFR: 8077587: BigInteger Roots [v53]

2025-07-29 Thread fabioromano1
> This PR implements nth root computation for BigIntegers using Newton method. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision: Further documentation - Changes: - all: https://git.openjdk.org/jdk/pull/24898/fi

Re: RFR: 8077587: BigInteger Roots [v52]

2025-07-29 Thread fabioromano1
On Tue, 29 Jul 2025 13:03:59 GMT, Raffaello Giulietti wrote: > Anyway, I hope I made my point clear: it is better to write proofs rather > than relying on readers to reverse-engineer them from the code. Surely, > there's no need to be pedantic in every single detail. Surely, the problem is to

Re: RFR: 8077587: BigInteger Roots [v52]

2025-07-29 Thread fabioromano1
On Tue, 29 Jul 2025 12:06:37 GMT, fabioromano1 wrote: >> To the above, we can also add >> >> * >> * Noting that x ≥ 2^(bl-1) and ex ≥ 0, similarly to the >> above we further get >> *

Re: RFR: 8077587: BigInteger Roots [v52]

2025-07-29 Thread fabioromano1
On Tue, 29 Jul 2025 11:14:15 GMT, Raffaello Giulietti wrote: >> The proof might help replacing the `if` condition bl - (sh - ex) ≤ ME with >> ex ≤ ME - P. > > To the above, we can also add > > * > * Noting that x ≥ 2^(bl-1) and ex ≥ 0, similarly to the > abo

Re: RFR: 8077587: BigInteger Roots [v52]

2025-07-28 Thread fabioromano1
On Mon, 28 Jul 2025 17:03:48 GMT, Raffaello Giulietti wrote: >> fabioromano1 has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Zimmermann suggestion > > src/java.base/share/classes/java/math/MutableBigInte

Re: RFR: 8077587: BigInteger Roots [v52]

2025-07-28 Thread fabioromano1
> This PR implements nth root computation for BigIntegers using Newton method. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision: Zimmermann suggestion - Changes: - all: https://git.openjdk.org/jdk/pull/24898/fi

Re: RFR: 8077587: BigInteger Roots [v50]

2025-07-28 Thread fabioromano1
On Sun, 27 Jul 2025 08:26:59 GMT, Thomas Zimmermann wrote: >> fabioromano1 has updated the pull request incrementally with one additional >> commit since the last revision: >> >> A zero root's shift can't be excluded > > src/java.base/share/cla

Re: RFR: 8077587: BigInteger Roots [v50]

2025-07-28 Thread fabioromano1
On Sun, 27 Jul 2025 08:26:59 GMT, Thomas Zimmermann wrote: >> fabioromano1 has updated the pull request incrementally with one additional >> commit since the last revision: >> >> A zero root's shift can't be excluded > > src/java.base/share/cla

Re: RFR: 8077587: BigInteger Roots [v51]

2025-07-27 Thread fabioromano1
> This PR implements nth root computation for BigIntegers using Newton method. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision: Minor changes - Changes: - all: https://git.openjdk.org/jdk/pull/24898/files -

Re: RFR: 8077587: BigInteger Roots [v50]

2025-07-27 Thread fabioromano1
On Sun, 27 Jul 2025 07:56:59 GMT, fabioromano1 wrote: >> This PR implements nth root computation for BigIntegers using Newton method. > > fabioromano1 has updated the pull request incrementally with one additional > commit since the last revision: > > A zero root'

Re: RFR: 8077587: BigInteger Roots [v50]

2025-07-27 Thread fabioromano1
> This PR implements nth root computation for BigIntegers using Newton method. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision: A zero root's shift can't be excluded - Changes: - all: https://git.openjdk

Re: RFR: 8077587: BigInteger Roots [v49]

2025-07-27 Thread fabioromano1
> This PR implements nth root computation for BigIntegers using Newton method. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision: Minor optimization - Changes: - all: https://git.openjdk.org/jdk/pull/24898/files -

Re: RFR: 8077587: BigInteger Roots [v48]

2025-07-26 Thread fabioromano1
> This PR implements nth root computation for BigIntegers using Newton method. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision: Code simplification - Changes: - all: https://git.openjdk.org/jdk/pull/24898/files -

Re: RFR: 8077587: BigInteger Roots [v47]

2025-07-26 Thread fabioromano1
> This PR implements nth root computation for BigIntegers using Newton method. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision: Avoid overflow after first iteration - Changes: - all: https://git.openjdk.org/jdk/p

Re: RFR: 8077587: BigInteger Roots [v46]

2025-07-25 Thread fabioromano1
> This PR implements nth root computation for BigIntegers using Newton method. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision: Revision changes - Changes: - all: https://git.openjdk.org/jdk/pull/24898/files -

Re: RFR: 8077587: BigInteger Roots [v45]

2025-07-25 Thread fabioromano1
On Fri, 25 Jul 2025 15:24:22 GMT, fabioromano1 wrote: >> src/java.base/share/classes/java/math/MutableBigInteger.java line 1967: >> >>> 1965: sToN1 = BigInteger.unsignedLongPow(sLong, n - 1); >>> 1966: u = ((n - 1) *

Re: RFR: 8077587: BigInteger Roots [v45]

2025-07-25 Thread fabioromano1
On Fri, 25 Jul 2025 15:23:32 GMT, Raffaello Giulietti wrote: >> In this case, `final` serves to indicate that the value of `n` is never >> modified by the method. > > Of course. > To the caller, a `final` parameter does not convey any information, and makes > the method/constructor header less

Re: RFR: 8077587: BigInteger Roots [v45]

2025-07-25 Thread fabioromano1
On Fri, 25 Jul 2025 14:57:10 GMT, Raffaello Giulietti wrote: >> fabioromano1 has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Round up to do less iterations >> >> With the 1st iteration out

Re: RFR: 8077587: BigInteger Roots [v45]

2025-07-25 Thread fabioromano1
On Fri, 25 Jul 2025 14:56:47 GMT, Raffaello Giulietti wrote: >> fabioromano1 has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Round up to do less iterations >> >> With the 1st iteration out

Re: RFR: 8077587: BigInteger Roots [v45]

2025-07-25 Thread fabioromano1
On Fri, 25 Jul 2025 14:56:09 GMT, Raffaello Giulietti wrote: >> fabioromano1 has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Round up to do less iterations >> >> With the 1st iteration out

Re: RFR: 8077587: BigInteger Roots [v45]

2025-07-24 Thread fabioromano1
> This PR implements nth root computation for BigIntegers using Newton method. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision: Round up to do less iterations With the 1st iteration outside the loop, it is more conveni

Re: RFR: 8077587: BigInteger Roots [v44]

2025-07-24 Thread fabioromano1
> This PR implements nth root computation for BigIntegers using Newton method. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision: Code simplification - Changes: - all: https://git.openjdk.org/jdk/pull/24898/files -

Re: RFR: 8077587: BigInteger Roots [v43]

2025-07-24 Thread fabioromano1
> This PR implements nth root computation for BigIntegers using Newton method. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision: Update BigIntegerTest.java Adjust pow-nthRoot roundtrip tests to handle negative base with e

Re: RFR: 8077587: BigInteger Roots [v42]

2025-07-24 Thread fabioromano1
> This PR implements nth root computation for BigIntegers using Newton method. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision: Use checkResult() in pow-nthRoot roundtrip tests - Changes: - all: https://git.openjdk.

  1   2   3   4   5   6   7   >