> PR for Sequenced Collections implementation.
Stuart Marks has updated the pull request incrementally with one additional
commit since the last revision:
Simplify handling of cached keySet, values, and entrySet views.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/7387/fil
On Tue, 28 Mar 2023 02:37:22 GMT, Stuart Marks wrote:
>> PR for Sequenced Collections implementation.
>
> Stuart Marks has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Simplify handling of cached keySet, values, and entrySet views.
Hi Erik,
On Wed, 29 Mar 2023 11:28:39 GMT, Rémi Forax wrote:
> Hi Erik, I think you misunderstood me, currently Oracle supports most of the
> development of the OpenJDK financially, that's a fact and i'm glad that
> Oracle has taken that mantle because I'm remembering very well the sad state
> of Java
On Tue, 28 Mar 2023 02:37:22 GMT, Stuart Marks wrote:
>> PR for Sequenced Collections implementation.
>
> Stuart Marks has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Simplify handling of cached keySet, values, and entrySet views.
This is
On Tue, 28 Mar 2023 02:37:22 GMT, Stuart Marks wrote:
>> PR for Sequenced Collections implementation.
>
> Stuart Marks has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Simplify handling of cached keySet, values, and entrySet views.
> This i
On Tue, 28 Mar 2023 02:37:22 GMT, Stuart Marks wrote:
>> PR for Sequenced Collections implementation.
>
> Stuart Marks has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Simplify handling of cached keySet, values, and entrySet views.
src/java
On Wed, 29 Mar 2023 19:06:20 GMT, Chen Liang wrote:
>> Stuart Marks has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Simplify handling of cached keySet, values, and entrySet views.
>
> src/java.base/share/classes/java/util/SequencedCollec
On Wed, 29 Mar 2023 19:20:16 GMT, Rémi Forax wrote:
>> src/java.base/share/classes/java/util/SequencedCollection.java line 107:
>>
>>> 105: */
>>> 106: default void addFirst(E e) {
>>> 107: throw new UnsupportedOperationException();
>>
>> Can this be defaulted to `this.reversed
On Wed, 29 Mar 2023 19:54:48 GMT, Tagir F. Valeev wrote:
>> In the same spirit, `reversed()` should also have a default implementation
>> equivalent to
>>
>>
>> Collections.unmodifiableSequenceCollection(Arrays.asList(this.toArray())).reversed()
>
> @forax but this would not be a view: chang
On Tue, 28 Mar 2023 02:37:22 GMT, Stuart Marks wrote:
>> PR for Sequenced Collections implementation.
>
> Stuart Marks has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Simplify handling of cached keySet, values, and entrySet views.
In the J
On Wed, 29 Mar 2023 20:54:15 GMT, Chen Liang wrote:
>> Yes,
>> The spec says :"Changes to the underlying collection might or might not be
>> visible in this reversed view, depending upon the implementation." so i
>> believe the default implementation i proposed is a valid implementation
>
> In
On Wed, 29 Mar 2023 20:05:10 GMT, Rémi Forax wrote:
>> @forax but this would not be a view: changes in the underlying collection
>> won't be reflected
>
> Yes,
> The spec says :"Changes to the underlying collection might or might not be
> visible in this reversed view, depending upon the implem
On Wed, 29 Mar 2023 21:18:04 GMT, Rémi Forax wrote:
>> In the JEP, it says:
>>> Any modifications to the original collection are visible in the view.
>>
>> If we don't have an efficient reversed view, I don't see a point of
>> declaring a collection sequenced; same reason for declaring a
>> se
On Wed, 29 Mar 2023 13:09:52 GMT, Rémi Forax wrote:
>> Stuart Marks has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Simplify handling of cached keySet, values, and entrySet views.
>
> This is taking a personal turn and I do not see the p
On Wed, 29 Mar 2023 21:18:02 GMT, Chen Liang wrote:
>> Stuart Marks has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Simplify handling of cached keySet, values, and entrySet views.
>
> In the JEP:
>> A sequenced collection supports common
On Fri, 24 Mar 2023 21:39:09 GMT, Tagir F. Valeev wrote:
>> Stuart Marks has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Simplify handling of cached keySet, values, and entrySet views.
>
> src/java.base/share/classes/java/util/LinkedHash
On Tue, 28 Mar 2023 02:37:22 GMT, Stuart Marks wrote:
>> PR for Sequenced Collections implementation.
>
> Stuart Marks has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Simplify handling of cached keySet, values, and entrySet views.
src/java
On Thu, 30 Mar 2023 06:41:38 GMT, Stuart Marks wrote:
>> In the JEP:
>>> A sequenced collection supports common operations at either end, and it
>>> supports processing the elements from first to last and from last to first
>>> (i.e., forward and reverse).
>>
>>> The reverse-ordered view enabl
On Wed, 29 Mar 2023 21:18:02 GMT, Chen Liang wrote:
>> Stuart Marks has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Simplify handling of cached keySet, values, and entrySet views.
>
> In the JEP:
>> A sequenced collection supports common
On Thu, 30 Mar 2023 09:39:14 GMT, Tagir F. Valeev wrote:
>> Stuart Marks has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Simplify handling of cached keySet, values, and entrySet views.
>
> src/java.base/share/classes/java/util/LinkedHash
On Thu, 30 Mar 2023 09:20:16 GMT, Tagir F. Valeev wrote:
>> Stuart Marks has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Simplify handling of cached keySet, values, and entrySet views.
>
> src/java.base/share/classes/java/util/SequencedC
On Thu, 30 Mar 2023 11:33:14 GMT, Chen Liang wrote:
>> In the JEP:
>>> A sequenced collection supports common operations at either end, and it
>>> supports processing the elements from first to last and from last to first
>>> (i.e., forward and reverse).
>>
>>> The reverse-ordered view enables
On Thu, 30 Mar 2023 09:23:04 GMT, Tagir F. Valeev wrote:
>> Stuart Marks has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Simplify handling of cached keySet, values, and entrySet views.
>
> src/java.base/share/classes/java/util/SequencedC
On Thu, 30 Mar 2023 09:56:58 GMT, Tagir F. Valeev wrote:
>> @liach
>>
>> I understand that you're suggesting adding various default implementations
>> in order to make it easier for people to bring up implementations of
>> SequencedCollections. However, adding default implementations to
>> S
On Tue, 28 Mar 2023 02:37:22 GMT, Stuart Marks wrote:
>> PR for Sequenced Collections implementation.
>
> Stuart Marks has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Simplify handling of cached keySet, values, and entrySet views.
Removing
25 matches
Mail list logo
