Original description for JDK-8307194 change:
-
This PR is branched from the makefile changes for
https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
handling the JDK/hotspot static libraries:
- Build hotspot libjvm.a and JDK static libraries for
static-libs-image/sta
8307858: [REDO] JDK-8307194 Add make target for optionally building a complete
set of all JDK and hotspot libjvm static libraries
-
Commit messages:
- Backport 45414fc2dfa41cbbfc6de7fec15eb47f41cf8986
Changes: https://git.openjdk.org/jdk21/pull/26/files
Webrev: https://webrevs.ope
On Fri, 19 May 2023 20:18:53 GMT, Jiangli Zhou wrote:
> Original description for JDK-8307194 change:
> -
> This PR is branched from the makefile changes for
> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
> handling the JDK/hotspot static libraries:
>
> - Buil
On Fri, 19 May 2023 21:20:19 GMT, Erik Joelsson wrote:
> I ran this patch in our internal build and test system and got failures on
> macos and windows.
Thanks a lot, @erikj79! I was going to ask your help for testing the patch.
> I think I know the cause for the mac failure, but the Windows
On Fri, 19 May 2023 21:13:24 GMT, Erik Joelsson wrote:
>> Original description for JDK-8307194 change:
>> -
>> This PR is branched from the makefile changes for
>> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
>> handling the JDK/hotspot static libraries:
>>
>>
On Fri, 19 May 2023 22:45:16 GMT, Erik Joelsson wrote:
>> make/common/NativeCompilation.gmk line 1208:
>>
>>> 1206: $$(call ExecuteWithLog,
>>> $$($1_OBJECT_DIR)/$$($1_SAFE_NAME)_partial_link, \
>>> 1207:$$($1_LD) $(LDFLAGS_CXX_PARTIAL_LINKING)
>>> $(LD_OUT_OPTION)$$($1_TAR
On Mon, 22 May 2023 19:10:57 GMT, Jiangli Zhou wrote:
> Thanks @erikj79. Could you please help provide some more info on the build
> failure:
>
> Which macOs version ran into the build issue? My mac is on Ventura 13.3.1
> (a). It builds successfully for the `static-libs-image` target.
>
> Doe
On Fri, 16 Jun 2023 20:36:07 GMT, Jiangli Zhou wrote:
> 8307858: [REDO] JDK-8307194 Add make target for optionally building a
> complete set of all JDK and hotspot libjvm static libraries
As a P4 enhancement, this doesn't meet the criteria for integration into JDK 21
during [Rampdown Phase
1]
On Fri, 16 Jun 2023 20:52:13 GMT, Kevin Rushforth wrote:
> As a P4 enhancement, this doesn't meet the criteria for integration into JDK
> 21 during [Rampdown Phase
> 1](https://mail.openjdk.org/pipermail/jdk-dev/2023-June/007911.html). You
> could request late approval to get this enhancement
On Fri, 16 Jun 2023 20:36:07 GMT, Jiangli Zhou wrote:
> 8307858: [REDO] JDK-8307194 Add make target for optionally building a
> complete set of all JDK and hotspot libjvm static libraries
GHA is failing on windows; is this related to this PR or something else?
@erikj - You did a round of Mach5
On Fri, 16 Jun 2023 22:08:19 GMT, Daniel D. Daugherty
wrote:
> GHA is failing on windows; is this related to this PR or something else?
The windows build failures occur with other PRs as well, e.g.
https://github.com/openjdk/jdk21/pull/24/checks?check_run_id=14317258603. They
should be unrela
> Original description for JDK-8307194 change:
> -
> This PR is branched from the makefile changes for
> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
> handling the JDK/hotspot static libraries:
>
> - Build hotspot libjvm.a and JDK static libraries for
> stati
On Mon, 22 May 2023 19:21:52 GMT, Jiangli Zhou wrote:
>> Thanks @erikj79. Could you please help provide some more info on the build
>> failure:
>>
>> Which macOs version ran into the build issue? My mac is on Ventura 13.3.1
>> (a). It builds successfully for the `static-libs-image` target.
>>
On Mon, 22 May 2023 19:40:00 GMT, Jiangli Zhou wrote:
>> Original description for JDK-8307194 change:
>> -
>> This PR is branched from the makefile changes for
>> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
>> handling the JDK/hotspot static libraries:
>>
>>
On Mon, 22 May 2023 19:54:59 GMT, Erik Joelsson wrote:
>> Jiangli Zhou has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 12 commits:
>>
>> - Merge branch 'master' into JDK-8307858
>> - Merge branch 'master' into JDK-8307858
>> -
> Original description for JDK-8307194 change:
> -
> This PR is branched from the makefile changes for
> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
> handling the JDK/hotspot static libraries:
>
> - Build hotspot libjvm.a and JDK static libraries for
> stati
On Mon, 22 May 2023 19:52:42 GMT, Erik Joelsson wrote:
>> Jiangli Zhou has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 12 commits:
>>
>> - Merge branch 'master' into JDK-8307858
>> - Merge branch 'master' into JDK-8307858
>> -
> Original description for JDK-8307194 change:
> -
> This PR is branched from the makefile changes for
> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
> handling the JDK/hotspot static libraries:
>
> - Build hotspot libjvm.a and JDK static libraries for
> stati
On Fri, 19 May 2023 21:20:19 GMT, Erik Joelsson wrote:
>> Jiangli Zhou has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> - Add $$($1_LD) $$($1_SYSROOT_LDFLAGS) to $1_VARDEPS if $(TOOLCHAIN_TYPE)
>> is gcc or clang, as suggested by @erikj7
On Fri, 19 May 2023 21:20:19 GMT, Erik Joelsson wrote:
>> Jiangli Zhou has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> - Add $$($1_LD) $$($1_SYSROOT_LDFLAGS) to $1_VARDEPS if $(TOOLCHAIN_TYPE)
>> is gcc or clang, as suggested by @erikj7
On Mon, 22 May 2023 21:27:58 GMT, Jiangli Zhou wrote:
>> Original description for JDK-8307194 change:
>> -
>> This PR is branched from the makefile changes for
>> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
>> handling the JDK/hotspot static libraries:
>>
>>
On Wed, 24 May 2023 20:29:09 GMT, Erik Joelsson wrote:
> My build job is still running, but it has failed in two distinct ways
> already. See below for mac fix. Our cross build of arm32 fails with this
> message:
>
> ```
> [2023-05-24T19:25:15,310Z]
> /opt/mach5/mesos/work_dir/jib-master/inst
On Wed, 24 May 2023 20:52:38 GMT, Erik Joelsson wrote:
>> My build job is still running, but it has failed in two distinct ways
>> already. See below for mac fix. Our cross build of arm32 fails with this
>> message:
>>
>>
>> [2023-05-24T19:25:15,310Z]
>> /opt/mach5/mesos/work_dir/jib-master/
> Original description for JDK-8307194 change:
> -
> This PR is branched from the makefile changes for
> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
> handling the JDK/hotspot static libraries:
>
> - Build hotspot libjvm.a and JDK static libraries for
> stati
On Wed, 24 May 2023 20:52:38 GMT, Erik Joelsson wrote:
> > My build job is still running, but it has failed in two distinct ways
> > already. See below for mac fix. Our cross build of arm32 fails with this
> > message:
> > ```
> > [2023-05-24T19:25:15,310Z]
> > /opt/mach5/mesos/work_dir/jib-ma
On Wed, 24 May 2023 21:47:49 GMT, Jiangli Zhou wrote:
> > > My build job is still running, but it has failed in two distinct ways
> > > already. See below for mac fix. Our cross build of arm32 fails with this
> > > message:
> > > ```
> > > [2023-05-24T19:25:15,310Z]
> > > /opt/mach5/mesos/work
On Thu, 25 May 2023 01:19:11 GMT, Jiangli Zhou wrote:
> > > > My build job is still running, but it has failed in two distinct ways
> > > > already. See below for mac fix. Our cross build of arm32 fails with
> > > > this message:
> > > > ```
> > > > [2023-05-24T19:25:15,310Z]
> > > > /opt/mach
On Wed, 24 May 2023 21:02:00 GMT, Jiangli Zhou wrote:
>> Original description for JDK-8307194 change:
>> -
>> This PR is branched from the makefile changes for
>> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
>> handling the JDK/hotspot static libraries:
>>
>>
On Fri, 26 May 2023 20:26:02 GMT, Jiangli Zhou wrote:
> > Another possibility might be the user provided `BUILD_LDCXX` includes extra
> > options in the testing build (?). If that's the case, we probably could
> > define a separate `BUILD_LD_PARTIAL` with no added options. In our
> > prototype
On Thu, 1 Jun 2023 16:18:24 GMT, Erik Joelsson wrote:
> > > Another possibility might be the user provided `BUILD_LDCXX` includes
> > > extra options in the testing build (?). If that's the case, we probably
> > > could define a separate `BUILD_LD_PARTIAL` with no added options. In our
> > > p
On Thu, 1 Jun 2023 23:38:03 GMT, Jiangli Zhou wrote:
> Sounds good for solving the macosx `ar` limitation differently. I'll change
> that. We can also exclude the partial linking part for gcc (due the older
> tool issue that you've found). Any concerns with including partial linking
> step for
On Fri, 19 May 2023 21:20:19 GMT, Erik Joelsson wrote:
>> Jiangli Zhou has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update make/common/NativeCompilation.gmk
>>
>> Thanks you!
>>
>> Co-authored-by: Erik Joelsson <37597443+eri
> Original description for JDK-8307194 change:
> -
> This PR is branched from the makefile changes for
> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
> handling the JDK/hotspot static libraries:
>
> - Build hotspot libjvm.a and JDK static libraries for
> stati
> Original description for JDK-8307194 change:
> -
> This PR is branched from the makefile changes for
> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
> handling the JDK/hotspot static libraries:
>
> - Build hotspot libjvm.a and JDK static libraries for
> stati
On Fri, 2 Jun 2023 14:04:23 GMT, Erik Joelsson wrote:
> > Sounds good for solving the macosx `ar` limitation differently. I'll change
> > that. We can also exclude the partial linking part for gcc (due the older
> > tool issue that you've found). Any concerns with including partial linking
> >
On Thu, 8 Jun 2023 20:34:15 GMT, Jiangli Zhou wrote:
>> Original description for JDK-8307194 change:
>> -
>> This PR is branched from the makefile changes for
>> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
>> handling the JDK/hotspot static libraries:
>>
>>
On Fri, 9 Jun 2023 20:03:23 GMT, Erik Joelsson wrote:
> All our builds succeeded, so this is looking pretty good now. Just a minor
> suggestion left.
Thanks a lot!
> This combination of conditions is repeated 3 times. Maybe we could assign the
> result to a variable (e.g. `$1_ENABLE_PARTIAL_L
> Original description for JDK-8307194 change:
> -
> This PR is branched from the makefile changes for
> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
> handling the JDK/hotspot static libraries:
>
> - Build hotspot libjvm.a and JDK static libraries for
> stati
On Fri, 9 Jun 2023 23:04:33 GMT, Jiangli Zhou wrote:
>> Original description for JDK-8307194 change:
>> -
>> This PR is branched from the makefile changes for
>> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
>> handling the JDK/hotspot static libraries:
>>
>>
> Original description for JDK-8307194 change:
> -
> This PR is branched from the makefile changes for
> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
> handling the JDK/hotspot static libraries:
>
> - Build hotspot libjvm.a and JDK static libraries for
> stati
On Fri, 16 Jun 2023 20:36:07 GMT, Jiangli Zhou wrote:
> 8307858: [REDO] JDK-8307194 Add make target for optionally building a
> complete set of all JDK and hotspot libjvm static libraries
The changes look ok.
-
Marked as reviewed by erikj (Reviewer).
PR Review: https://git.openjd
On Fri, 16 Jun 2023 22:10:08 GMT, Daniel D. Daugherty
wrote:
> @erikj - You did a round of Mach5 testing on the JDK22 version of this fix.
> Do you have plans to redo that testing for the JDK21 backport?
I have done testing of the JDK 21 version of the patch and it's running cleanly.
On Tue, 20 Jun 2023 17:24:03 GMT, Erik Joelsson wrote:
> > @erikj - You did a round of Mach5 testing on the JDK22 version of this fix.
> > Do you have plans to redo that testing for the JDK21 backport?
>
> I have done testing of the JDK 21 version of the patch and it's running
> cleanly.
Than
On Tue, 20 Jun 2023 17:25:16 GMT, Erik Joelsson wrote:
> The changes look ok.
Thanks. I'll wait for approval on https://bugs.openjdk.org/browse/JDK-8307858
as well.
-
PR Comment: https://git.openjdk.org/jdk21/pull/26#issuecomment-1599256118
On Fri, 16 Jun 2023 20:36:07 GMT, Jiangli Zhou wrote:
> 8307858: [REDO] JDK-8307194 Add make target for optionally building a
> complete set of all JDK and hotspot libjvm static libraries
Since this Enhancement was rejected for JDK 21, this PR should be closed.
-
PR Comment: https
On Wed, 21 Jun 2023 17:09:58 GMT, Kevin Rushforth wrote:
> Since this Enhancement was rejected for JDK 21, this PR should be closed.
Closing without integration accordingly, thanks.
-
PR Comment: https://git.openjdk.org/jdk21/pull/26#issuecomment-1601273074
46 matches
Mail list logo
