On Mon, 26 Jun 2023 13:33:38 GMT, Adam Sotona wrote:
>> Classfile context object and multi-state options have been discussed at
>> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
>> This patch implements the proposed changes in Classfile API and fixes all
>> affected c
> Classfile context object and multi-state options have been discussed at
> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
> This patch implements the proposed changes in Classfile API and fixes all
> affected code across JDK sources and tests.
>
> Please review.
>
>
On Mon, 26 Jun 2023 08:52:13 GMT, Adam Sotona wrote:
>> Classfile context object and multi-state options have been discussed at
>> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
>> This patch implements the proposed changes in Classfile API and fixes all
>> affected c
> Classfile context object and multi-state options have been discussed at
> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
> This patch implements the proposed changes in Classfile API and fixes all
> affected code across JDK sources and tests.
>
> Please review.
>
>
> Classfile context object and multi-state options have been discussed at
> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
> This patch implements the proposed changes in Classfile API and fixes all
> affected code across JDK sources and tests.
>
> Please review.
>
>
On Wed, 21 Jun 2023 06:29:40 GMT, Adam Sotona wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> ClassfileBenchmark::transformWithNewMaps changed to transformWithAddedNOP
>
> I think we've resolved controversy about gl
> Classfile context object and multi-state options have been discussed at
> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
> This patch implements the proposed changes in Classfile API and fixes all
> affected code across JDK sources and tests.
>
> Please review.
>
>
On Thu, 15 Jun 2023 17:22:32 GMT, Adam Sotona wrote:
>> Classfile context object and multi-state options have been discussed at
>> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
>> This patch implements the proposed changes in Classfile API and fixes all
>> affected c
On Wed, 21 Jun 2023 06:50:20 GMT, Chen Liang wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> ClassfileBenchmark::transformWithNewMaps changed to transformWithAddedNOP
>
> src/java.base/share/classes/jdk/internal/cla
On Thu, 15 Jun 2023 17:22:32 GMT, Adam Sotona wrote:
>> Classfile context object and multi-state options have been discussed at
>> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
>> This patch implements the proposed changes in Classfile API and fixes all
>> affected c
On Thu, 15 Jun 2023 17:22:32 GMT, Adam Sotona wrote:
>> Classfile context object and multi-state options have been discussed at
>> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
>> This patch implements the proposed changes in Classfile API and fixes all
>> affected c
> Classfile context object and multi-state options have been discussed at
> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
> This patch implements the proposed changes in Classfile API and fixes all
> affected code across JDK sources and tests.
>
> Please review.
>
>
> Classfile context object and multi-state options have been discussed at
> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
> This patch implements the proposed changes in Classfile API and fixes all
> affected code across JDK sources and tests.
>
> Please review.
>
>
> Classfile context object and multi-state options have been discussed at
> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
> This patch implements the proposed changes in Classfile API and fixes all
> affected code across JDK sources and tests.
>
> Please review.
>
>
On Thu, 1 Jun 2023 19:25:19 GMT, Adam Sotona wrote:
>> src/java.base/share/classes/jdk/internal/classfile/Classfile.java line 55:
>>
>>> 53:
>>> 54: static Classfile of() {
>>> 55: return new ClassfileImpl();
>>
>> We can create a static final field in `ClassfileImpl` holding a def
> Classfile context object and multi-state options have been discussed at
> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
> This patch implements the proposed changes in Classfile API and fixes all
> affected code across JDK sources and tests.
>
> Please review.
>
>
> Classfile context object and multi-state options have been discussed at
> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
> This patch implements the proposed changes in Classfile API and fixes all
> affected code across JDK sources and tests.
>
> Please review.
>
>
On Tue, 13 Jun 2023 09:34:17 GMT, Chen Liang wrote:
>StackMapsOption doesn't fit in with other options, they should be
>ALWAYS_STACK_MAPS, NEVER_STACK_MAPS, etc.)
What about `STACK_MAPS_WHEN_REQUIRED`, `GENERATE_STACK_MAPS` and
`DROP_STACK_MAPS`?
-
PR Comment: https://git.openjdk
On Tue, 13 Jun 2023 11:32:59 GMT, Adam Sotona wrote:
>> Classfile context object and multi-state options have been discussed at
>> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
>> This patch implements the proposed changes in Classfile API and fixes all
>> affected c
On Tue, 13 Jun 2023 09:15:13 GMT, Chen Liang wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> ClassHierarchyResolver.DEFAULT_RESOLVER gets info from system class loader
>> and does not cache
>> method-level cachin
On Tue, 13 Jun 2023 09:19:00 GMT, Chen Liang wrote:
>> Adam Sotona has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 38 commits:
>>
>> - Merge branch 'master' into JDK-8308899-context
>> - Revert of DirectCodeBuilder.needsStackMap
> Classfile context object and multi-state options have been discussed at
> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
> This patch implements the proposed changes in Classfile API and fixes all
> affected code across JDK sources and tests.
>
> Please review.
>
>
> Classfile context object and multi-state options have been discussed at
> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
> This patch implements the proposed changes in Classfile API and fixes all
> affected code across JDK sources and tests.
>
> Please review.
>
>
On Mon, 12 Jun 2023 15:55:49 GMT, Adam Sotona wrote:
>> Classfile context object and multi-state options have been discussed at
>> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
>> This patch implements the proposed changes in Classfile API and fixes all
>> affected c
On Mon, 12 Jun 2023 15:55:49 GMT, Adam Sotona wrote:
>> Classfile context object and multi-state options have been discussed at
>> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
>> This patch implements the proposed changes in Classfile API and fixes all
>> affected c
> Classfile context object and multi-state options have been discussed at
> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
> This patch implements the proposed changes in Classfile API and fixes all
> affected code across JDK sources and tests.
>
> Please review.
>
>
On Mon, 12 Jun 2023 11:20:40 GMT, Adam Sotona wrote:
>> Classfile context object and multi-state options have been discussed at
>> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
>> This patch implements the proposed changes in Classfile API and fixes all
>> affected c
> Classfile context object and multi-state options have been discussed at
> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
> This patch implements the proposed changes in Classfile API and fixes all
> affected code across JDK sources and tests.
>
> Please review.
>
>
> Classfile context object and multi-state options have been discussed at
> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
> This patch implements the proposed changes in Classfile API and fixes all
> affected code across JDK sources and tests.
>
> Please review.
>
>
From: kulla-dev on behalf of Brian Goetz
> I think there's something fishy going on.
Yes, transformation lambdas become significantly slower when moved from
ClassModel to Classfile (unless I missed anything else).
I’ll do some experiments to get the performance back.
On Thu, 8 Jun 2023 16:37:22 GMT, Adam Sotona wrote:
>> Classfile context object and multi-state options have been discussed at
>> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
>> This patch implements the proposed changes in Classfile API and fixes all
>> affected co
On Thu, 8 Jun 2023 16:37:22 GMT, Adam Sotona wrote:
>> Classfile context object and multi-state options have been discussed at
>> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
>> This patch implements the proposed changes in Classfile API and fixes all
>> affected co
Observation: It's dramatic how injecting a tiny amount of shared mutable
state ripples throughout the design.
After thinking about this some more, I think the main problem is that we
are still trying to have the cache be transparent, which means that
Classfile is taking on all the complexity o
: Adam Sotona , core-libs-dev@openjdk.org
, kulla-...@openjdk.org
Subject: Re: RFR: 8308899: Introduce Classfile.Context and improve
Classfile.Option(s) [v9]
I still don't understand this point. Why are separate tests sharing a context
at all?
On 6/8/2023 9:26 AM, Adam Sotona wrote:
Unfortun
On Thu, 8 Jun 2023 16:37:22 GMT, Adam Sotona wrote:
>> Classfile context object and multi-state options have been discussed at
>> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
>> This patch implements the proposed changes in Classfile API and fixes all
>> affected co
On Thu, 8 Jun 2023 16:35:28 GMT, Brian Goetz wrote:
> I have a hard time imagining heavy parallel use here; concurrency against the
> same cache would most likely come from accidental sharing. So this is not
> necessarily a problem. Are you imagining differnet use cases?
I think it is common
I still don't understand this point. Why are separate tests sharing a
context at all?
On 6/8/2023 9:26 AM, Adam Sotona wrote:
Unfortunately thread-unsafe context makes sharing of it in tests executed in
parallel a nightmare.
I can fix our Corpus tests and hope the race condition won't raise a
> Classfile context object and multi-state options have been discussed at
> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
> This patch implements the proposed changes in Classfile API and fixes all
> affected code across JDK sources and tests.
>
> Please review.
>
>
On Thu, 8 Jun 2023 13:37:33 GMT, Adam Sotona wrote:
>> Classfile context object and multi-state options have been discussed at
>> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
>> This patch implements the proposed changes in Classfile API and fixes all
>> affected co
On Thu, 8 Jun 2023 14:07:24 GMT, Brian Goetz wrote:
> Here are a few options:
- Make the CHA cache thread-safe using, say, CHM;
This is current solution for the default system CH cache.
We may also use a bit less strict custom semi-synchronization (just enough to
be thread safe) instead o
From: core-libs-dev on behalf of Brian Goetz
Most entities in the system are immutable and therefore freely sharable
without additional coordination. Some have lazily-inflated single-field
caches that conform to the "benign race" (there is only one possible
non-default value) criteria.
The
On Thu, 8 Jun 2023 13:37:33 GMT, Adam Sotona wrote:
>> Classfile context object and multi-state options have been discussed at
>> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
>> This patch implements the proposed changes in Classfile API and fixes all
>> affected co
> Classfile context object and multi-state options have been discussed at
> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
> This patch implements the proposed changes in Classfile API and fixes all
> affected code across JDK sources and tests.
>
> Please review.
>
>
On Thu, 8 Jun 2023 11:26:39 GMT, Adam Sotona wrote:
>> Classfile context object and multi-state options have been discussed at
>> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
>> This patch implements the proposed changes in Classfile API and fixes all
>> affected co
On Thu, 8 Jun 2023 11:07:21 GMT, Chen Liang wrote:
>> Adam Sotona has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 29 commits:
>>
>> - removal of ClassHierarchyImpl.DEFAULT_RESOLVER
>>introduction of ClassHierarchyResolver::of
> Classfile context object and multi-state options have been discussed at
> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
> This patch implements the proposed changes in Classfile API and fixes all
> affected code across JDK sources and tests.
>
> Please review.
>
>
On Thu, 8 Jun 2023 09:26:10 GMT, Adam Sotona wrote:
>> Classfile context object and multi-state options have been discussed at
>> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
>> This patch implements the proposed changes in Classfile API and fixes all
>> affected co
On Thu, 8 Jun 2023 09:26:10 GMT, Adam Sotona wrote:
>> Classfile context object and multi-state options have been discussed at
>> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
>> This patch implements the proposed changes in Classfile API and fixes all
>> affected co
> Classfile context object and multi-state options have been discussed at
> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
> This patch implements the proposed changes in Classfile API and fixes all
> affected code across JDK sources and tests.
>
> Please review.
>
>
> Classfile context object and multi-state options have been discussed at
> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
> This patch implements the proposed changes in Classfile API and fixes all
> affected code across JDK sources and tests.
>
> Please review.
>
>
On Mon, 5 Jun 2023 15:14:35 GMT, Brian Goetz wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed copyright header
>
> src/java.base/share/classes/jdk/internal/classfile/Classfile.java line 50:
>
>> 48: /**
>> 49:
> Classfile context object and multi-state options have been discussed at
> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
> This patch implements the proposed changes in Classfile API and fixes all
> affected code across JDK sources and tests.
>
> Please review.
>
>
On Mon, 5 Jun 2023 16:30:16 GMT, Brian Goetz wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed copyright header
>
> src/java.base/share/classes/jdk/internal/classfile/constantpool/ConstantPoolBuilder.java
> lin
On Mon, 5 Jun 2023 14:42:32 GMT, Adam Sotona wrote:
>> Classfile context object and multi-state options have been discussed at
>> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
>> This patch implements the proposed changes in Classfile API and fixes all
>> affected co
> Classfile context object and multi-state options have been discussed at
> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
> This patch implements the proposed changes in Classfile API and fixes all
> affected code across JDK sources and tests.
>
> Please review.
>
>
> Classfile context object and multi-state options have been discussed at
> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
> This patch implements the proposed changes in Classfile API and fixes all
> affected code across JDK sources and tests.
>
> Please review.
>
>
> Classfile context object and multi-state options have been discussed at
> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
> This patch implements the proposed changes in Classfile API and fixes all
> affected code across JDK sources and tests.
>
> Please review.
>
>
On Thu, 1 Jun 2023 19:23:05 GMT, Adam Sotona wrote:
>> src/java.base/share/classes/java/lang/Module.java line 1593:
>>
>>> 1591: private Class loadModuleInfoClass(InputStream in) throws
>>> IOException {
>>> 1592: final String MODULE_INFO = "module-info";
>>> 1593: var cc =
On Thu, 1 Jun 2023 15:14:52 GMT, Chen Liang wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed benchmarks
>
> src/java.base/share/classes/jdk/internal/classfile/impl/StackMapGenerator.java
> line 840:
>
>> 838:
On Thu, 1 Jun 2023 15:04:00 GMT, Chen Liang wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed benchmarks
>
> src/java.base/share/classes/java/lang/Module.java line 1593:
>
>> 1591: private Class loadModuleI
On Thu, 1 Jun 2023 15:20:27 GMT, Adam Sotona wrote:
>> Classfile context object and multi-state options have been discussed at
>> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
>> This patch implements the proposed changes in Classfile API and fixes all
>> affected co
> Classfile context object and multi-state options have been discussed at
> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
> This patch implements the proposed changes in Classfile API and fixes all
> affected code across JDK sources and tests.
>
> Please review.
>
>
Classfile context object and multi-state options have been discussed at
https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
This patch implements the proposed changes in Classfile API and fixes all
affected code across JDK sources and tests.
Please review.
Thanks,
Adam
--
On Wed, 31 May 2023 05:42:58 GMT, Chen Liang wrote:
>> Classfile context object and multi-state options have been discussed at
>> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
>> This patch implements the proposed changes in Classfile API and fixes all
>> affected co
On Fri, 26 May 2023 14:56:57 GMT, Adam Sotona wrote:
> Classfile context object and multi-state options have been discussed at
> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
> This patch implements the proposed changes in Classfile API and fixes all
> affected code
65 matches
Mail list logo
