Re: RFR: 8308899: Introduce Classfile.Context and improve Classfile.Option(s) [v5]

2023-06-05 Thread Adam Sotona
On Mon, 5 Jun 2023 15:14:35 GMT, Brian Goetz wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixed copyright header > > src/java.base/share/classes/jdk/internal/classfile/Classfile.java line 50: > >> 48: /** >> 49:

Re: RFR: 8308899: Introduce Classfile.Context and improve Classfile.Option(s) [v5]

2023-06-05 Thread Adam Sotona
On Mon, 5 Jun 2023 16:30:16 GMT, Brian Goetz wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixed copyright header > > src/java.base/share/classes/jdk/internal/classfile/constantpool/ConstantPoolBuilder.java > lin

Re: RFR: 8308899: Introduce Classfile.Context and improve Classfile.Option(s) [v5]

2023-06-05 Thread Brian Goetz
On Mon, 5 Jun 2023 14:42:32 GMT, Adam Sotona wrote: >> Classfile context object and multi-state options have been discussed at >> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html >> This patch implements the proposed changes in Classfile API and fixes all >> affected co

Re: RFR: 8308899: Introduce Classfile.Context and improve Classfile.Option(s) [v5]

2023-06-05 Thread Adam Sotona
> Classfile context object and multi-state options have been discussed at > https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html > This patch implements the proposed changes in Classfile API and fixes all > affected code across JDK sources and tests. > > Please review. > >