On Wed, 3 Jan 2024 11:11:40 GMT, Alan Bateman wrote:
>> Tim Prinzing has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> add select timeout field to the event
>
> src/java.base/share/classes/sun/nio/ch/SelectorImpl.java line 153:
>
>> 151:
On Mon, 26 Feb 2024 14:14:21 GMT, Daniel Fuchs wrote:
> Maybe that's OK - and maybe in that case the onus is on the user to set a
> threshold greater than 1500ms?
The threshold is 20ms so these timed-select ops in the HTTP client will record
an event when they timeout.
-
PR Revie
On Mon, 26 Feb 2024 17:40:59 GMT, Alan Bateman wrote:
>> Is n == 0 intended to detect a spinning condition where the selector goes
>> back into select when the event has not been handled?
>>
>> In that case should we still emit an event if a timeout is present and the
>> duration is greater th
On Thu, 11 Apr 2024 09:12:30 GMT, Daniel Fuchs wrote:
>>> Maybe that's OK - and maybe in that case the onus is on the user to set a
>>> threshold greater than 1500ms?
>>
>> The threshold is 20ms so these timed-select ops in the HTTP client will
>> record an event when they timeout.
>
> We shou
On Thu, 11 Apr 2024 16:08:31 GMT, Alan Bateman wrote:
>> We should probably find a way to not emit the event if n == 0 and the
>> operation was interrupted by `Selector.wakeUp`. Since we have another issue
>> logged to emit a spin event, I wonder if we should only commit the event
>> here if `
On Thu, 11 Apr 2024 16:39:24 GMT, Daniel Fuchs wrote:
>> I think it's okay for now. If there is another phase of this work to help
>> diagnose spinning issues then it will need to re-visited. I'm very concerned
>> about the possible changes for that second phase, but this first phase of
>> ins
On Mon, 29 Apr 2024 21:53:02 GMT, Tim Prinzing wrote:
> Should I set the default to be fairly high (like maybe 1600ms)? I think to be
> useful people will have to set the threshold to something that fits their
> needs anyway.
I wonder about the usefulness of this event if the default threshold
> Added mirror event with static methods: jdk.internal.event.SelectionEvent
> that provides the duration of select calls and the count of how many keys are
> available.
>
> Emit the event from SelectorImpl::lockAndDoSelect
>
> Test at jdk.jfr.event.io.TestSelectionEvents
Tim Prinzing has updat
On Wed, 13 Dec 2023 22:20:55 GMT, Tim Prinzing wrote:
>> Added mirror event with static methods: jdk.internal.event.SelectionEvent
>> that provides the duration of select calls and the count of how many keys
>> are available.
>>
>> Emit the event from SelectorImpl::lockAndDoSelect
>>
>> Test
