On Thu, 7 Sep 2023 16:21:18 GMT, Aleksey Shipilev wrote:
>> Similar to other issues in the same area. I have no PPC32 machine to test
>> the build on, but this matches other fixes for other architectures
>> (https://github.com/openjdk/jdk/commit/83c096d6e20cd6e1164bc666df1be197a10431eb)
>>
On Thu, 7 Sep 2023 16:21:18 GMT, Aleksey Shipilev wrote:
>> Similar to other issues in the same area. I have no PPC32 machine to test
>> the build on, but this matches other fixes for other architectures
>> (https://github.com/openjdk/jdk/commit/83c096d6e20cd6e1164bc666df1be197a10431eb)
>>
On Thu, 7 Sep 2023 16:21:18 GMT, Aleksey Shipilev wrote:
>> Similar to other issues in the same area. I have no PPC32 machine to test
>> the build on, but this matches other fixes for other architectures
>> (https://github.com/openjdk/jdk/commit/83c096d6e20cd6e1164bc666df1be197a10431eb)
>>
On Thu, 7 Sep 2023 13:54:25 GMT, Martin Doerr wrote:
>> Aleksey Shipilev has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>>
On Thu, 7 Sep 2023 14:07:05 GMT, Roger Riggs wrote:
>> Aleksey Shipilev has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>>
On Thu, 7 Sep 2023 14:07:05 GMT, Roger Riggs wrote:
>> Aleksey Shipilev has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>>
On Thu, 7 Sep 2023 13:51:31 GMT, Aleksey Shipilev wrote:
>> Similar to other issues in the same area. I have no PPC32 machine to test
>> the build on, but this matches other fixes for other architectures
>> (https://github.com/openjdk/jdk/commit/83c096d6e20cd6e1164bc666df1be197a10431eb)
>>
> Similar to other issues in the same area. I have no PPC32 machine to test the
> build on, but this matches other fixes for other architectures
> (https://github.com/openjdk/jdk/commit/83c096d6e20cd6e1164bc666df1be197a10431eb)
> after this fix the PPC32 Zero build completes fine.
Aleksey
On Thu, 7 Sep 2023 13:51:31 GMT, Aleksey Shipilev wrote:
>> Similar to other issues in the same area. I have no PPC32 machine to test
>> the build on, but this matches other fixes for other architectures
>> (https://github.com/openjdk/jdk/commit/83c096d6e20cd6e1164bc666df1be197a10431eb)
>>
On Thu, 7 Sep 2023 13:45:50 GMT, Aleksey Shipilev wrote:
>> One might expect `isPPC()` to return true on PPC64 because it technically
>> is. This is the only drawback I see.
>
> I don't have a strong opinion here, so if you want PPC32, you got it in new
> commit :)
Yeah, at least for the
On Thu, 7 Sep 2023 13:51:31 GMT, Aleksey Shipilev wrote:
>> Similar to other issues in the same area. I have no PPC32 machine to test
>> the build on, but this matches other fixes for other architectures
>> (https://github.com/openjdk/jdk/commit/83c096d6e20cd6e1164bc666df1be197a10431eb)
>>
On Thu, 7 Sep 2023 12:45:14 GMT, Martin Doerr wrote:
>> Yeah, we can technically change to `PPC32`. But the current thing follows
>> what build system uses as `OPENJDK_TARGET_CPU` (`ppc`) and what would be
>> used as `os.arch` because of that. So, choosing which way to deviate:
>> towards
> Similar to other issues in the same area. I have no PPC32 machine to test the
> build on, but this matches other fixes for other architectures
> (https://github.com/openjdk/jdk/commit/83c096d6e20cd6e1164bc666df1be197a10431eb)
> after this fix the PPC32 Zero build completes fine.
Aleksey
On Thu, 7 Sep 2023 12:02:02 GMT, Aleksey Shipilev wrote:
>> src/java.base/share/classes/jdk/internal/util/Architecture.java line 164:
>>
>>> 162: public static boolean isPPC() {
>>> 163: return PlatformProps.TARGET_ARCH_IS_PPC;
>>> 164: }
>>
>> Maybe `isPPC32()` would be a
On Mon, 4 Sep 2023 19:54:46 GMT, Martin Doerr wrote:
>> Similar to other issues in the same area. I have no PPC32 machine to test
>> the build on, but this matches other fixes for other architectures
>> (https://github.com/openjdk/jdk/commit/83c096d6e20cd6e1164bc666df1be197a10431eb)
>> after
On Mon, 4 Sep 2023 07:26:37 GMT, Aleksey Shipilev wrote:
> Similar to other issues in the same area. I have no PPC32 machine to test the
> build on, but this matches other fixes for other architectures
> (https://github.com/openjdk/jdk/commit/83c096d6e20cd6e1164bc666df1be197a10431eb)
> after
Similar to other issues in the same area. I have no PPC32 machine to test the
build on, but this matches other fixes for other architectures
(https://github.com/openjdk/jdk/commit/83c096d6e20cd6e1164bc666df1be197a10431eb)
after this fix the PPC32 Zero build completes fine.
-
17 matches
Mail list logo
