On Fri, 17 Nov 2023 08:38:37 GMT, Andrey Turbanov wrote:
>> The map contains several entries so I think the plural form is appropriate
>> here.
>
> Current naming highlights the difference in values in this maps:
> `FIRST_DAY_OF_WEEK` vs `MINIMAL_DAYS_IN_FIRST_WEEK`.
> I like this approach.
On Fri, 17 Nov 2023 08:13:05 GMT, Per Minborg wrote:
>> src/java.base/share/classes/sun/util/cldr/CLDRCalendarDataProviderImpl.java
>> line 48:
>>
>>> 46: public class CLDRCalendarDataProviderImpl extends
>>> CalendarDataProviderImpl {
>>> 47:
>>> 48: private static final Map firstDays =
On Thu, 16 Nov 2023 17:08:58 GMT, Naoto Sato wrote:
>> Andrey Turbanov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8316557: Make fields final in 'sun.util' package
>>
>> rename 'firstDay' to 'firstDays' to match 'minDays'
On Thu, 16 Nov 2023 08:56:05 GMT, Andrey Turbanov wrote:
>> A few classes in `sun.util` package have non-final fields which could easily
>> be marked `final`.
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8316557:
> A few classes in `sun.util` package have non-final fields which could easily
> be marked `final`.
Andrey Turbanov has updated the pull request incrementally with one additional
commit since the last revision:
8316557: Make fields final in 'sun.util' package
rename 'firstDay' to
On Mon, 13 Nov 2023 11:40:27 GMT, Per Minborg wrote:
>> Andrey Turbanov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8316557: Make fields final in 'sun.util' package
>>
>> rename 'firstDay' to 'firstDays' to match 'minDays'
