Re: RFR: 8323183: ClassFile API performance improvements [v8]

2024-03-04 Thread Claes Redestad
On Mon, 4 Mar 2024 12:00:18 GMT, Adam Sotona wrote: >> ClassFile API performance related improvements have been separated from >> #17121 into this PR. >> >> These improvements are important to minimize performance regression of >> 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to u

Re: RFR: 8323183: ClassFile API performance improvements [v7]

2024-03-04 Thread Adam Sotona
On Mon, 4 Mar 2024 10:08:27 GMT, Claes Redestad wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update >> src/java.base/share/classes/jdk/internal/classfile/impl/StackMapDecoder.java >> >> Co-authored-by: Andr

Re: RFR: 8323183: ClassFile API performance improvements [v8]

2024-03-04 Thread Adam Sotona
> ClassFile API performance related improvements have been separated from > #17121 into this PR. > > These improvements are important to minimize performance regression of > 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to use the > Classfile API to generate proxy classes #17121 >

Re: RFR: 8323183: ClassFile API performance improvements [v7]

2024-03-04 Thread Claes Redestad
On Mon, 15 Jan 2024 12:01:37 GMT, Adam Sotona wrote: >> ClassFile API performance related improvements have been separated from >> #17121 into this PR. >> >> These improvements are important to minimize performance regression of >> 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to

Re: RFR: 8323183: ClassFile API performance improvements [v7]

2024-03-04 Thread Adam Sotona
On Mon, 15 Jan 2024 12:01:37 GMT, Adam Sotona wrote: >> ClassFile API performance related improvements have been separated from >> #17121 into this PR. >> >> These improvements are important to minimize performance regression of >> 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to

Re: RFR: 8323183: ClassFile API performance improvements [v7]

2024-01-15 Thread Adam Sotona
> ClassFile API performance related improvements have been separated from > #17121 into this PR. > > These improvements are important to minimize performance regression of > 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to use the > Classfile API to generate proxy classes #17121 >

Re: RFR: 8323183: ClassFile API performance improvements [v6]

2024-01-14 Thread Andrey Turbanov
On Tue, 9 Jan 2024 13:30:58 GMT, Adam Sotona wrote: >> ClassFile API performance related improvements have been separated from >> #17121 into this PR. >> >> These improvements are important to minimize performance regression of >> 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to u

Re: RFR: 8323183: ClassFile API performance improvements [v6]

2024-01-09 Thread Adam Sotona
On Tue, 9 Jan 2024 13:30:58 GMT, Adam Sotona wrote: >> ClassFile API performance related improvements have been separated from >> #17121 into this PR. >> >> These improvements are important to minimize performance regression of >> 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to u

Re: RFR: 8323183: ClassFile API performance improvements [v6]

2024-01-09 Thread Adam Sotona
> ClassFile API performance related improvements have been separated from > #17121 into this PR. > > These improvements are important to minimize performance regression of > 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to use the > Classfile API to generate proxy classes #17121 >

Re: RFR: 8323183: ClassFile API performance improvements [v5]

2024-01-09 Thread Adam Sotona
> ClassFile API performance related improvements have been separated from > #17121 into this PR. > > These improvements are important to minimize performance regression of > 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to use the > Classfile API to generate proxy classes #17121 >

Re: RFR: 8323183: ClassFile API performance improvements [v4]

2024-01-08 Thread Chen Liang
On Mon, 8 Jan 2024 16:17:47 GMT, Adam Sotona wrote: >> ClassFile API performance related improvements have been separated from >> #17121 into this PR. >> >> These improvements are important to minimize performance regression of >> 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to u

Re: RFR: 8323183: ClassFile API performance improvements

2024-01-08 Thread Adam Sotona
On Mon, 8 Jan 2024 14:43:58 GMT, Chen Liang wrote: > You need to update the slot counting from `DirectCodeBuilder` and > `StackMapDecoder` to fully avoid creating any MethodTypeDesc. It would be good to avoid all bottlenecks, however not all of them have equal effect. This patch avoids MTD con

Re: RFR: 8323183: ClassFile API performance improvements [v4]

2024-01-08 Thread Adam Sotona
On Mon, 8 Jan 2024 14:19:12 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> applied suggested changes > > src/java.base/share/classes/jdk/internal/classfile/impl/StackCounter.java > line 3

Re: RFR: 8323183: ClassFile API performance improvements [v4]

2024-01-08 Thread Adam Sotona
> ClassFile API performance related improvements have been separated from > #17121 into this PR. > > These improvements are important to minimize performance regression of > 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to use the > Classfile API to generate proxy classes #17121 >

Re: RFR: 8323183: ClassFile API performance improvements [v2]

2024-01-08 Thread Adam Sotona
> ClassFile API performance related improvements have been separated from > #17121 into this PR. > > These improvements are important to minimize performance regression of > 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to use the > Classfile API to generate proxy classes #17121 >

Re: RFR: 8323183: ClassFile API performance improvements [v3]

2024-01-08 Thread Adam Sotona
On Mon, 8 Jan 2024 14:20:17 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> applied suggested changes > > src/java.base/share/classes/jdk/internal/classfile/impl/StackCounter.java > line 4

Re: RFR: 8323183: ClassFile API performance improvements [v3]

2024-01-08 Thread Adam Sotona
> ClassFile API performance related improvements have been separated from > #17121 into this PR. > > These improvements are important to minimize performance regression of > 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to use the > Classfile API to generate proxy classes #17121 >

Re: RFR: 8323183: ClassFile API performance improvements

2024-01-08 Thread Chen Liang
On Mon, 8 Jan 2024 13:38:16 GMT, Adam Sotona wrote: > ClassFile API performance related improvements have been separated from > #17121 into this PR. > > These improvements are important to minimize performance regression of > 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to use th

Re: RFR: 8323183: ClassFile API performance improvements

2024-01-08 Thread Maurizio Cimadamore
On Mon, 8 Jan 2024 13:38:16 GMT, Adam Sotona wrote: > ClassFile API performance related improvements have been separated from > #17121 into this PR. > > These improvements are important to minimize performance regression of > 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to use th

Re: RFR: 8323183: ClassFile API performance improvements

2024-01-08 Thread Maurizio Cimadamore
On Mon, 8 Jan 2024 13:38:16 GMT, Adam Sotona wrote: > ClassFile API performance related improvements have been separated from > #17121 into this PR. > > These improvements are important to minimize performance regression of > 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to use th

Re: RFR: 8323183: ClassFile API performance improvements

2024-01-08 Thread Maurizio Cimadamore
On Mon, 8 Jan 2024 14:14:29 GMT, Maurizio Cimadamore wrote: >> ClassFile API performance related improvements have been separated from >> #17121 into this PR. >> >> These improvements are important to minimize performance regression of >> 8294961: Convert java.base/java.lang.reflect.ProxyGener

RFR: 8323183: ClassFile API performance improvements

2024-01-08 Thread Adam Sotona
ClassFile API performance related improvements have been separated from #17121 into this PR. These improvements are important to minimize performance regression of 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to use the Classfile API to generate proxy classes #17121 Please review