Re: RFR: 8327729: Remove deprecated xxxObject methods from jdk.internal.misc.Unsafe [v2]

2024-03-10 Thread Eirik Bjørsnøs
> Please review this PR which removes the 19 deprecated `xxObject*` alias > methods from `jdk.internal.misc.Unsafe`. > > These methods were added in JDK-8213043 (JDK 12), presumably to allow > `jsr166.jar` to be used across JDK versions. This was a follow-up fix after > JDK-8207146 had renamed

Re: RFR: 8327729: Remove deprecated xxxObject methods from jdk.internal.misc.Unsafe [v2]

2024-03-10 Thread Eirik Bjørsnøs
On Sun, 10 Mar 2024 08:14:02 GMT, Eirik Bjørsnøs wrote: >> Please review this PR which removes the 19 deprecated `xxObject*` alias >> methods from `jdk.internal.misc.Unsafe`. >> >> These methods were added in JDK-8213043 (JDK 12), presumably to allow >> `jsr166.jar` to be used across JDK versi

Re: RFR: 8327729: Remove deprecated xxxObject methods from jdk.internal.misc.Unsafe [v2]

2024-03-10 Thread Jaikiran Pai
On Sun, 10 Mar 2024 08:14:02 GMT, Eirik Bjørsnøs wrote: >> Please review this PR which removes the 19 deprecated `xxObject*` alias >> methods from `jdk.internal.misc.Unsafe`. >> >> These methods were added in JDK-8213043 (JDK 12), presumably to allow >> `jsr166.jar` to be used across JDK versi

Re: RFR: 8327729: Remove deprecated xxxObject methods from jdk.internal.misc.Unsafe [v2]

2024-03-10 Thread Alan Bateman
On Sun, 10 Mar 2024 08:24:42 GMT, Eirik Bjørsnøs wrote: > GHA revealed two call sites for `getAndSetObject` in the test > `test/hotspot/jtreg/gc/shenandoah/compiler/TestUnsafeLoadStoreMergedHeapStableTests.java`. > > I have replaced these with the `getAndSetReference`, grepped for any > remain

Re: RFR: 8327729: Remove deprecated xxxObject methods from jdk.internal.misc.Unsafe [v2]

2024-03-10 Thread Eirik Bjørsnøs
On Sun, 10 Mar 2024 12:18:02 GMT, Alan Bateman wrote: > Yes, you'll need to run all tests to make sure that there aren't any others, > e.g. test/hotspot/jtreg/compiler/stable/TestUnstableStable.java. I've updated `TestUnstableStable` to use `putReference` and also fixed a stray code comment re

Re: RFR: 8327729: Remove deprecated xxxObject methods from jdk.internal.misc.Unsafe [v2]

2024-03-10 Thread Jaikiran Pai
On Sun, 10 Mar 2024 10:17:23 GMT, Jaikiran Pai wrote: >> Eirik Bjørsnøs has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Use getAndSetReference instead of getAndSetObject in >> test/hotspot/jtreg/gc/shenandoah/compiler/TestUnsafeLoadStor

Re: RFR: 8327729: Remove deprecated xxxObject methods from jdk.internal.misc.Unsafe [v2]

2024-03-11 Thread Eirik Bjørsnøs
On Sun, 10 Mar 2024 13:47:43 GMT, Eirik Bjørsnøs wrote: > Yes, you'll need to run all tests to make sure that there aren't any others, > e.g. test/hotspot/jtreg/compiler/stable/TestUnstableStable.java. Alan, With @jaikiran running Oracle CI tier1, tier2, tier3 and observing only the now-fixed