On Tue, 11 Jun 2024 19:01:45 GMT, Weijun Wang wrote:
>> Thanks I'll go through the above comments and update - some of the changes I
>> see are unnecessary and from when I was trying migrating to callAs, and
>> doPrivileged, and yes they can be simpler.
>>
>> On the allowSecurityMananger check
On Wed, 12 Jun 2024 14:06:39 GMT, Kevin Walls wrote:
>> For the same reason you should be able to just call `Subject.current` in the
>> tests. I don't think you need the `SimpleStandard.useGetSubjectACC` property
>> to toggle the testing of either old or replacement APIs as long as the test
>>
On Tue, 11 Jun 2024 20:31:03 GMT, Sean Mullan wrote:
>> src/java.management/share/classes/com/sun/jmx/remote/internal/ServerNotifForwarder.java
>> line 350:
>>
>>> 348: @SuppressWarnings("removal")
>>> 349: private Subject getSubject() {
>>> 350: Subject subject = null;
>>
>> J
On Tue, 11 Jun 2024 16:55:44 GMT, Weijun Wang wrote:
>> Kevin Walls has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Sean comments
>
> src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnectionImpl.java
> line 1633:
On Tue, 11 Jun 2024 16:53:09 GMT, Weijun Wang wrote:
>> Kevin Walls has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Sean comments
>
> src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnectionImpl.java
> line 1438:
On Tue, 11 Jun 2024 20:58:54 GMT, Sean Mullan wrote:
>> src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnectionImpl.java
>> line 1436:
>>
>>> 1434: } else {
>>> 1435: // ACC is present, we have a Subject and SM is
>>> permitted:
>>> 1436:
On Tue, 11 Jun 2024 16:59:31 GMT, Weijun Wang wrote:
>> Kevin Walls has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Sean comments
>
> src/java.management/share/classes/javax/management/monitor/Monitor.java line
> 1541:
>
>> 1539:
On Tue, 11 Jun 2024 16:51:11 GMT, Weijun Wang wrote:
>> Kevin Walls has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Sean comments
>
> src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnectionImpl.java
> line 1436:
On Tue, 11 Jun 2024 18:04:45 GMT, Kevin Walls wrote:
>> src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnectionImpl.java
>> line 1301:
>>
>>> 1299: }
>>> 1300: };
>>> 1301: if (acc == null) {
>>
>> This is a comment to all the
On Tue, 11 Jun 2024 17:03:58 GMT, Weijun Wang wrote:
>> Kevin Walls has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Sean comments
>
> src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnectionImpl.java
> line 1301:
On Tue, 11 Jun 2024 16:18:23 GMT, Kevin Walls wrote:
>> JMX uses APIs related to the Security Mananger which are deprecated. Use of
>> AccessControlContext will be removed when Security Manager is removed.
>>
>> Until then, updates are needed to not require setting
>> -Djava.security.manager
> JMX uses APIs related to the Security Mananger which are deprecated. Use of
> AccessControlContext will be removed when Security Manager is removed.
>
> Until then, updates are needed to not require setting
> -Djava.security.manager=allow to use JMX authentication.
Kevin Walls has updated t
12 matches
Mail list logo
