[coreutils] [PATCH] maint: ignore *.xz files

2010-03-10 Thread Eric Blake
* .gitignore: Ignore *.xz created by 'make dist', now that we no longer produce *.lzma. --- Should patches go to bug-coreutils@, or is coreutils@ the preferred place now-a-days? Or does it depend on contents - bug fix patches to the former, and maint stuff like this to the latter? Is it worth ke

Re: [coreutils] [PATCH] maint: ignore *.xz files

2010-03-10 Thread Eric Blake
On 03/10/2010 04:26 PM, Dmitry V. Levin wrote: > On Wed, Mar 10, 2010 at 04:15:34PM -0700, Eric Blake wrote: > [...] >> Should patches go to bug-coreutils@, or is coreutils@ the preferred >> place now-a-days? Or does it depend on contents - bug fix patches >> to the form

Re: [coreutils] Coreutil translations?

2010-05-17 Thread Eric Blake
an I translate coreutils? http://translationproject.org/domain/coreutils.html -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

bug#6453: coreutils: date -- Add new options for ISO 8601 date formats (-O)

2010-06-18 Thread Eric Blake
ing common ISO layouts. > References: > > Standard - Date - ISO 9601 (Markus Kuhn) Did you mean 8601? -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

bug#6544: Fwd: bug in util du (du (GNU coreutils) 7.4), OS Ubuntu 9.10 Rus.

2010-06-30 Thread Eric Blake
/coreutils/faq/#df-Size-and-Used-and-Available-do-not-add-up -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [coreutils] Additional suffix for split

2010-07-02 Thread Eric Blake
ladly review any patch written by someone else. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [coreutils] [PATCH] fadvise: new module providing a simpler interface to posix_fadvise

2010-07-20 Thread Eric Blake
file_x, struct fstatus *fstatus) } else { + fdadvise (fd, 0, 0, FADVISE_SEQUENTIAL); while ((bytes_read = safe_read (fd, buf, BUFFER_SIZE)) > 0) Wonky indentation. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library h

[coreutils] suggested cmp optimization for sparse files

2010-07-23 Thread Eric Blake
optimization to make it faster to run cmp on two large but sparse files, since you could efficiently skip runs of 0. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org

Re: [coreutils] How to figure out all the hard links that link to the same file?

2010-07-27 Thread Eric Blake
t allow determining that information). But would that belong under stat(1), or some other tool? -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [coreutils] [PATCH] sort: fix --debug display with very large offsets

2010-07-27 Thread Eric Blake
unlocked, because of the locking and unlocking it must do on every call). I'd rather see something along the lines of: while (INT_MAX < offset) { printf ("%*s", INT_MAX, ""); offset -= INT_MAX; } printf ("%*s", (int) offset), ""); so that the

Re: [coreutils] [PATCH] init.sh: work around trap limitation of some shells

2010-08-03 Thread Eric Blake
ance maint.mk to add a target to make it easier to update gnulib, including re-copying ./bootstrap. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [coreutils] [PATCH] sort: tune and refactor --debug code, and fix minor underlining bug

2010-08-05 Thread Eric Blake
'1Mi Mi' | ../coreutils/src/sort --debug -k1,1h -k2,2h ../coreutils/src/sort: using `en_US.UTF-8' sorting rules 1Mi Mi ___ __ __ Without a suffix B, I don't think the lone 'i' should be considered as part of the -h suffix. -- Eric Blake ebl...@redhat.com

Re: [coreutils] How to change the "Change" time? (touch)

2010-08-06 Thread Eric Blake
n action that updates ctime to the current moment, then restore the system's current time. But since it is generally a privileged action to alter system time, that means that ordinary users cannot change ctime to anything other than the current time. -- Eric Blake ebl...@redhat.com+1-8

Re: [coreutils] How to change the "Change" time? (touch)

2010-08-06 Thread Eric Blake
On 08/06/2010 04:09 PM, Eric Blake wrote: > On 08/06/2010 03:50 PM, Peng Yu wrote: >> Hi, >> >> It seems that the 'change' time is not changed to yesterday. Could >> anybody let me know how to change the 'change' time? Just out of curiosity, why do

Re: [coreutils] How to change the "Change" time? (touch)

2010-08-09 Thread Eric Blake
[re-adding the coreutils list] On 08/06/2010 06:56 PM, Peng Yu wrote: > On Fri, Aug 6, 2010 at 5:12 PM, Eric Blake wrote: >> On 08/06/2010 04:09 PM, Eric Blake wrote: >>> On 08/06/2010 03:50 PM, Peng Yu wrote: >>>> Hi, >>>> >>>> It seems tha

bug#6053: cp, ls, and mv bug: unknown error (252)

2010-08-09 Thread Eric Blake
e need to float that definition higher. Just to double-check, what exactly did you define it to? And can you confirm what config.h contains for USE_ACL and HAVE_ACL_GET_FILE? In other words, Pádraig's patch is incomplete until we also tweak acl-internal.h. -- Eric Blake ebl...@r

[coreutils] [PATCH] tests: silence 'make syntax-check'

2010-08-09 Thread Eric Blake
* gl/tests/test-rand-isaac.c (main): Avoid warnings from syntax-check. --- Committing as obvious. The set_program_name hack is borrowed liberally from test-ino-map.c. gl/tests/test-rand-isaac.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/gl/tests/test-rand-isaac.c

bug#6053: cp, ls, and mv bug: unknown error (252)

2010-08-10 Thread Eric Blake
On 08/09/2010 04:07 PM, Eric Blake wrote: > On 08/09/2010 03:50 PM, Callahan, Patrick M. wrote: >> As a quick "fix" without investigating what is being defined I simply added >> the line below to copy-acl.c. I make no claim that this is correct. >> >>

[coreutils] [PATCH] maint: avoid a hung 'make syntax-check' in VPATH build

2010-08-10 Thread Eric Blake
* cfg.mk (sc_system_h_headers): Look for files in correct location. --- OK to commit? Without it, 'make syntax-check' hangs on a VPATH build, since the grep inside $() has no matches, meaning the grep outside is passed no file names and tries to read stdin. cfg.mk |2 +- 1 files changed, 1

Re: [coreutils] [PATCH] tests: silence 'make syntax-check'

2010-08-11 Thread Eric Blake
c files in gl/tests from this check > * gl/tests/test-di-set.c: Remove the hack to work around > the set_program_name syntax-check > * gl/tests/test-ino-map.c: Likewise > * gl/tests/test-rand-isaac.c: Likewise Looks good to me ;) -- Eric Blake ebl...@redhat.com

Re: [coreutils] ignore-value.h considered harmful

2010-08-11 Thread Eric Blake
way to conveniently ignore the warning on the few places where ignoring the result is intentional. Ultimately, ignore_value(x) looks a lot better than (void)x, so we're still complying with the letter of the "no casts to void" if not the spirit. -- Eric Blake ebl...@redhat

Re: [coreutils] Bug (?) in sort -R

2010-08-16 Thread Eric Blake
4 -k 5,5 a sort: using simple byte comparison a b c d g _ _ a b c d e _ _ a b c d f _ _ a b c e e _ _ a b c e f _ _ -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [coreutils] stat read crtime from ext4

2010-08-20 Thread Eric Blake
st ext4 and NTFS). It's just that no one has yet written the code to make stat(1) take advantage of this code in the stat-times module. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

[coreutils] Re: added some options to uniq

2010-08-23 Thread Eric Blake
F? More details about the coreutils patch submission process can be found here: http://git.sv.gnu.org/cgit/coreutils.git/tree/HACKING -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [coreutils] A more forgiving rm.

2010-08-24 Thread Eric Blake
e more than welcome to run your custom rm in your environment, and get the benefits that you see in your patch, even if you have not managed to convince others of the same. I wish more people would approach feature requests with patches rather than proposals. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org

[coreutils] Re: [Bug-tar] [PATCH] improved sparse file detection

2010-08-24 Thread Eric Blake
so I quit reading it to avoid any copyright issues. Would you be willing to assign copyright to the FSF? If so, we can start the paperwork process off-list. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org

Re: [coreutils] [PATCH] maint: avoid a hung 'make syntax-check' in VPATH build

2010-08-26 Thread Eric Blake
On 08/10/2010 11:04 AM, Eric Blake wrote: * cfg.mk (sc_system_h_headers): Look for files in correct location. --- OK to commit? Without it, 'make syntax-check' hangs on a VPATH build, since the grep inside $() has no matches, meaning the grep outside is passed no file names and tri

Re: [coreutils] [PATCH] tests: work around a failure with dash 0.5.4

2010-09-07 Thread Eric Blake
quot; = xpass&& #dash 0.5.4 fails so check first + { test "x$(env sh -c '\c=d echo fail')" = xpass || fail=1; } Looks good to me. For the record, at least dash 0.5.5.1 no longer has this bug. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org

Re: [coreutils] cut feature request

2010-09-07 Thread Eric Blake
think about it. If we do it, I'd like to see it done uniformly across all the coreutils that take partial field specifications. And although I probably won't be the one writing such a patch, it does sound like it still might be justifiable. -- Eric Blake ebl...@redhat.com

[coreutils] Adding xstat support

2010-09-08 Thread Eric Blake
nel support exists. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org

[coreutils] exit status in man pages

2010-09-09 Thread Eric Blake
o get help2man to add that in for us, possibly by modifying all of our man/*.x files. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org

bug#7007: cannot pipe or redirect output from cut

2010-09-10 Thread Eric Blake
tly also fails to treat >> as an append operator, and instead treats it as an argument. It seems to me that your real problem is that you are using the wrong shell for your expectations. Have you considered using cygwin (see cygwin.com), which comes with bash or tcsh pre-built for Windows, and where you can blindly use Unix shell conventions without having to worry about the brain-dead semantics of cmd? -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org

bug#7008: On "touch" command

2010-09-10 Thread Eric Blake
On 09/10/2010 08:47 AM, Eric Blake wrote: On 09/10/2010 03:30 AM, Dibyajyoti Ghosh wrote: Hi, I needed to change the timestamp of a directory structure of very high depth. and in each level there are lots of files and folders. So I expected a recursive operation of "touch" (like -R i

Re: [coreutils] Coreutils Solaris extensions

2010-09-10 Thread Eric Blake
implementation is a good argument for inclusion in coreutils under the same option letter, provided it doesn't conflict with existing usage in coreutils. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org

Re: [coreutils] [PATCH] dircolors: add rxvt-unicode-256color terminal type

2010-09-13 Thread Eric Blake
;. Signed-off-by: Dmitry V. Levin --- src/dircolors.hin |1 + 1 files changed, 1 insertions(+), 0 deletions(-) Pushed. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org

[coreutils] testsuite failures on Fedora

2010-09-16 Thread Eric Blake
t-stat-mount.jXje + rm -rf /home/remote/eblake/coreutils/tests/gt-stat-mount.jXje + exit 1 Here, the failure is that I have /home bind-mounted on /shared/home, and since I ran the test under /home, the mount location reported by df is different than the one reported by stat -c%m. This is a new test, and I'm not sure what to do about the issue (whether stat needs fixing to deal with bind mounts, or whether the test is at fault). -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org

bug#6402: [PATCH] rm: remove no-op -d option

2010-09-16 Thread Eric Blake
* src/rm.c (long_opts, main): Resolve a fixme. * NEWS: Document the change. Based on a report by William Plusnick. --- Jim, what do you think of this alternative patch, which avoids the issue of a new translation string by instead letting getopt parsing reject -d like any other unknown option? N

bug#7042: df --help does not show `-m' option

2010-09-16 Thread Eric Blake
documented way to get what you want is to do 'df --block-size=M', or 'export DF_BLOCK_SIZE=M' into your environment. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org

[coreutils] [PATCH] maint: update to latest gnulib

2010-09-16 Thread Eric Blake
* gnulib: Update to latest. * bootstrap.conf (gnulib_modules): Add fdutimensat. * src/touch.c (touch): Use fdutimensat instead of gl_futimens. --- In light of Paul's desire to use fdutimensat in tar, this is the matching change to get coreutils to use it. Okay to apply? bootstrap.conf |1 +

Re: [coreutils] [PATCH] maint: update to latest gnulib

2010-09-17 Thread Eric Blake
On 09/17/2010 03:07 AM, Jim Meyering wrote: Eric Blake wrote: * gnulib: Update to latest. * bootstrap.conf (gnulib_modules): Add fdutimensat. * src/touch.c (touch): Use fdutimensat instead of gl_futimens. --- In light of Paul's desire to use fdutimensat in tar, this is the matching chan

Re: [coreutils] [PATCH] maint: update to latest gnulib

2010-09-17 Thread Eric Blake
On 09/17/2010 10:16 AM, Pádraig Brady wrote: On 17/09/10 00:43, Eric Blake wrote: * gnulib: Update to latest. * bootstrap.conf (gnulib_modules): Add fdutimensat. * src/touch.c (touch): Use fdutimensat instead of gl_futimens. Just compiled latest coreutils and got: cc1: warnings being treated

[coreutils] [PATCH] maint: update to latest gnulib

2010-09-17 Thread Eric Blake
* gnulib: Update to latest. * src/copy.c (copy_reg): Use fdutimens instead of gl_futimens. * src/touch.c (touch): Adjust parameter order. * tests/init.sh: Resync from upstream. --- There's been some upstream churn, for the better. I'm pushing this to match. gnulib|2 +- src/copy.c

Re: [coreutils] -avrd option ?

2010-09-20 Thread Eric Blake
mandatory arguments, such as cp -t, you can omit the space between the option and its argument, so these are the same: cp -a -t . foo cp -at. foo -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org

Re: [coreutils] Re: [PATCH] join: support multi-byte character encodings

2010-09-20 Thread Eric Blake
s also invalid byte sequences. Emacs handles this requirement by extending UTF-8. But this approach is unique to Emacs: libunistring and other software support plain UTF-8, not extended UTF-8. Does it make sense to add some extended UTF-8 support into libunistring, then? -- Eric Blake ebl...@

Re: [coreutils] tr: case mapping anomaly

2010-09-24 Thread Eric Blake
command line option, neither of which I think is necessary. So I see no reason to copy the BSD behavior of allowing any character class. Is it OK to change tr like this? I can't see anything depending on that. Seems reasonable to me, once we decide on the error message wording. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org

Re: [coreutils] tr: case mapping anomaly

2010-09-29 Thread Eric Blake
isting. I think this should be 'abc...' not '00c...' for the expected results. +# Ensure the size of the case classes are accounted +# for as a unit. +echo 'a' | +tr -t '[:lower:]a' '[:upper:]0' >out || _fail=1 +e

Re: [coreutils] tr: case mapping anomaly

2010-09-29 Thread Eric Blake
clarification from the Austin Group, I suppose. But given existing practice, I guess the argument should be that tr is explicitly different than m4. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org

Re: [coreutils] tr: case mapping anomaly

2010-09-29 Thread Eric Blake
On 09/29/2010 08:01 AM, Eric Blake wrote: Time for me to ask for clarification from the Austin Group, I suppose. But given existing practice, I guess the argument should be that tr is explicitly different than m4. Now raised with the Austin Group: http://austingroupbugs.net/view.php?id=325

Re: [coreutils] DF utility

2010-09-30 Thread Eric Blake
on of getmntent to include the directories that you are referring to. Coreutils can do no better than the getmntent() emulation layer provided by the system (whether that system be cygwin, mingw, or some other windows port), so there's not much we can do to help you on this list.

[coreutils] [PATCH] maint: update gnulib

2010-09-30 Thread Eric Blake
* gnulib: Update to latest. * bootstrap.conf (gnulib_modules): Reflect new module name. * bootstrap: Resync from upstream. --- I'm pushing this. * gnulib 77a06aa...7aa768c (4): > bootstrap: support ACLOCAL_FLAGS during aclocal > bootstrap: use glibtoolize on MacOS > poll: fix typo that brok

Re: [coreutils] [PATCH] maint: update gnulib

2010-09-30 Thread Eric Blake
On 09/30/2010 03:33 PM, Eric Blake wrote: * gnulib: Update to latest. * bootstrap.conf (gnulib_modules): Reflect new module name. * bootstrap: Resync from upstream. --- I'm pushing this. Two minutes too soon :) I just missed Bruno's patch that renamed get_date.texi. Otherwise,

[coreutils] [PATCH 2/2] stat: print timestamps to full resolution

2010-09-30 Thread Eric Blake
* src/stat.c (epoch_time): New function. (print_stat): Use it for %[WXYZ]. * NEWS: Document this. * tests/touch/60-seconds: Adjust test to match. --- It bugs me that %x has more information than %X in 'stat --format', especially, since we don't support any format modifiers for getting at the addit

[coreutils] [PATCH 1/2] stat: support printing birthtime

2010-09-30 Thread Eric Blake
* src/stat.c (print_stat): New %w and %W formats. (do_stat): Include %w in verbose format. (usage): Document them. * doc/coreutils.texi (stat invocation): Likewise. * NEWS: Likewise. Suggested by Andre "Osku" Schmidt. --- I've tested that this works on cygwin. On Fedora 13 with an ext4 partition,

Re: [coreutils] what belongs in the next coreutils release?

2010-09-30 Thread Eric Blake
g, is there anything people would like to see included? Support for stat(1) birthtime would be nice. I've just posted patches. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org

Re: [coreutils] [PATCH 1/2] stat: support printing birthtime

2010-10-01 Thread Eric Blake
conds + sleep 1;; # should be adequate for any system with subsecond resolution +esac + +touch a || fail=1 +test "x$btime" = x$(stat --format %W a) || fail=1 +test "x$atime" != x$(stat --format %X a) || fail=1 +test "x$mtime" != x$(stat --format %Y a) || fail=1 +test "

Re: [coreutils] [PATCH 1/2] stat: support printing birthtime

2010-10-01 Thread Eric Blake
On 10/01/2010 09:01 AM, Pádraig Brady wrote: On 01/10/10 15:34, Eric Blake wrote: diff --git c/tests/misc/stat-birthtime i/tests/misc/stat-birthtime + +if test "$VERBOSE" = yes; then + set -x + stat --version +fi + +. $srcdir/test-lib.sh New tests should do this instead of the abo

Re: [coreutils] [PATCH 1/2] stat: support printing birthtime

2010-10-01 Thread Eric Blake
On 10/01/2010 09:11 AM, Jim Meyering wrote: Eric Blake wrote: ... +# Whether birthtime is supported or not, it better not change even when +# [acm]time are modified. :) +touch a || fail=1 +btime=$(stat --format %W a) || fail=1 +atime=$(stat --format %X a) || fail=1 +mtime=$(stat --format %Y a

Re: [coreutils] [PATCH 2/2] stat: print timestamps to full resolution

2010-10-01 Thread Eric Blake
sufficient if %X showed nanoseconds - sleep 1;; # should be adequate for any system with subsecond resolution + *) sleep .1;; # should be adequate for any system with subsecond resolution esac touch a || fail=1 -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org

Re: [coreutils] [PATCH 1/2] stat: support printing birthtime

2010-10-01 Thread Eric Blake
On 10/01/2010 09:03 AM, Eric Blake wrote: On 10/01/2010 09:01 AM, Pádraig Brady wrote: On 01/10/10 15:34, Eric Blake wrote: diff --git c/tests/misc/stat-birthtime i/tests/misc/stat-birthtime + +if test "$VERBOSE" = yes; then + set -x + stat --version +fi + +. $srcdir/test-lib.sh

Re: [coreutils] [PATCH 2/2] stat: print timestamps to full resolution

2010-10-01 Thread Eric Blake
On 10/01/2010 09:03 AM, Eric Blake wrote: time_t can be a float on weird platforms I think? If you use nstrftime, no one can complain ;-) Correct - time_t need not be integral, but do we have any proof of a system using a floating-point time_t? My understanding of POSIX is that time_t was

Re: [coreutils] [PATCH 1/2] stat: support printing birthtime

2010-10-01 Thread Eric Blake
2). Which is why patch 2/2 deletes the FIXME, and goes with sleep .1, because %X is fixed to add nanoseconds. No second case statement needed. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org

[coreutils] [PATCH] maint: update sample test template

2010-10-01 Thread Eric Blake
* tests/sample-test: Recommend modern idiom. --- tests/sample-test |7 +-- 1 files changed, 1 insertions(+), 6 deletions(-) diff --git a/tests/sample-test b/tests/sample-test index 85a61cf..85b779f 100644 --- a/tests/sample-test +++ b/tests/sample-test @@ -16,12 +16,7 @@ # You should hav

[coreutils] stat and SELinux context

2010-10-01 Thread Eric Blake
of a distro-specific patch to override -Z being a no-op, you would in the future ALWAYS get %C output without having to use -Z. Besides, now's the perfect time to change the default output to include %C where available, given that we're already changing it to add %w birthtime ;) --

[coreutils] [PATCH] stat: print SELinux context when available

2010-10-01 Thread Eric Blake
* src/stat.c (do_stat, do_statfs): Include context when present. * NEWS: Update blurb explaining the replacement for -Z. --- I know Pádraig already expressed 60:40 against, but sometimes, seeing the actual patch can help discussion. Hmm, in looking at this, I'm wondering if an even better patch w

[coreutils] [PATCH] stat: optimize and translate default format strings

2010-10-01 Thread Eric Blake
* src/stat.c (main): Hoist default format computation out of loop. (do_statfs, do_stat): Move default format generation... (default_format): ...into new function. Allocate the result in pieces, rather than repeating mostly-similar chunks. Allow translation of verbose format. Pass a second format

[coreutils] [PATCHv2] stat: print SELinux context when available

2010-10-01 Thread Eric Blake
* src/stat.c (default_format): Include context when present. * NEWS: Update blurb explaining the replacement for -Z. --- Definitely nicer than the first attempt, but still controversial on whether we want to do this at all. I'm 70:30 for (I use Fedora's stat -Z regularly, and would hate to make F

Re: [coreutils] [PATCH] stat: optimize and translate default format strings

2010-10-01 Thread Eric Blake
On 10/01/2010 02:44 PM, Jim Meyering wrote: Eric Blake wrote: * src/stat.c (main): Hoist default format computation out of loop. This one should be uncontroversial, but just to be safe: OK to push? Yes. Thank you for the factoring. Did you do any before/after testing, to be sure that

Re: [coreutils] [PATCH] maint: update sample test template

2010-10-01 Thread Eric Blake
r* the path_prepend_ invocation. test "$VERBOSE" = yes&& FIXME --version What do you think? I'll add that back to the template, and to the last few recently-added tests. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org

[coreutils] [PATCH] tests: output --version of program under test

2010-10-01 Thread Eric Blake
This touches all new tests added since commit b062bbd9, when init.cfg was added. Older tests still exist that could use conversion, but we can address those later. * tests/sample-test: Restore hint for --version output. * tests/misc/stat-birthtime: Include --version if verbose. * tests/misc/tr-ca

Re: [coreutils] [PATCH 2/2] stat: print timestamps to full resolution

2010-10-01 Thread Eric Blake
On 10/01/2010 09:19 AM, Eric Blake wrote: Correct - time_t need not be integral, but do we have any proof of a system using a floating-point time_t? I think I'm going to write a POSIX bug requesting that time_t be tightened to integral in light of the fact that subsecond support i

Re: [coreutils] [PATCH 1/2] stat: support printing birthtime

2010-10-04 Thread Eric Blake
-- +check_timestamps_updated() +{ + local delay="$1" I guess we're blindly assuming that coreutils testsuite is requiring a shell that supports 'local'? -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org

bug#7157: df should default to -P if output is not a tty

2010-10-04 Thread Eric Blake
sable in a long-line context. But this still doesn't help the case that logwatch should have been using -P in the first place. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org

bug#7157: df should default to -P if output is not a tty

2010-10-04 Thread Eric Blake
in the case where the output is usable in a long-line context. But this still doesn't help the case that logwatch should have been using -P in the first place. Agreed. I now also reported the problem to Kirk Bauer from logwatch. Glad to hear it. -- Eric Blake ebl...@redhat.com+1-80

Re: [coreutils] [PATCHv2] stat: print SELinux context when available

2010-10-05 Thread Eric Blake
d not vice versa. Good catches. Thanks! The above fixes sound fine. If %C only operates on files, and not file systems, then why do we support %C under -f in the first place? Wouldn't the better patch be to completely remove %C from -f? -- Eric Blake ebl...@redhat.com+1-801-349-26

[coreutils] [PATCH] stat: drop %C support when printing file system details

2010-10-05 Thread Eric Blake
* src/stat.c (print_statfs, usage): Drop %C, since it applies to files, not file systems. (out_file_context): Match style of other out_* functions. (print_stat): Update caller. * doc/coreutils.texi (stat invocation): Document %C. * NEWS: Document the change. --- How does this look? I went to remo

Re: [coreutils] [PATCH] stat: drop %C support when printing file system details

2010-10-05 Thread Eric Blake
On 10/05/2010 09:06 AM, Eric Blake wrote: * src/stat.c (print_statfs, usage): Drop %C, since it applies to files, not file systems. (out_file_context): Match style of other out_* functions. (print_stat): Update caller. * doc/coreutils.texi (stat invocation): Document %C. * NEWS: Document the

[coreutils] [PATCH] build: complete the rename of get_date

2010-10-05 Thread Eric Blake
* gnulib: Update to latest. * src/date.c (includes, batch_convert, main): Track rename. * src/touch.c (includes, get_reldate): Likewise. * doc/coreutils.texi (Top, Date input formats): Likewise. * bootstrap.conf (gnulib_modules): Likewise. * doc/Makefile.am (EXTRA_DIST): Likewise. * doc/.gitignore:

Re: [coreutils] snapshot deferred by another day: bison vs. openbsd

2010-10-07 Thread Eric Blake
n bison, and inability to develop from coreutils.git on OpenBSD is less severe than inability to compile a tarball. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org

Re: [Coreutils] Sort enhancement request: 1 < 1K < 1M < 1G etc.

2010-10-08 Thread Eric Blake
g human readable suffixes like KiB and MB etc. The latest stable version is 8.5, with 8.6 due shortly. Consider upgrading. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org

Re: [coreutils] [PATCH 2/2] stat: print timestamps to full resolution

2010-10-08 Thread Eric Blake
On 10/01/2010 04:34 PM, Eric Blake wrote: On 10/01/2010 09:19 AM, Eric Blake wrote: Correct - time_t need not be integral, but do we have any proof of a system using a floating-point time_t? I think I'm going to write a POSIX bug requesting that time_t be tightened to integral in light o

Re: [coreutils] Re: [PATCH 2/2] stat: print timestamps to full resolution

2010-10-21 Thread Eric Blake
to POSIX 2008, back when subsecond resolution was not mandatory; but now that POSIX requires nanosecond information (even if the file system itself has less granularity), I see no reason to hide that fact, even if a few scripts need to be adjusted to be more robust to potential nanosecond informa

Re: [coreutils] Re: [PATCH 2/2] stat: print timestamps to full resolution

2010-10-21 Thread Eric Blake
On 10/21/2010 08:09 AM, Andreas Schwab wrote: Eric Blake writes: On 10/21/2010 03:22 AM, Andreas Schwab wrote: Jim Meyering writes: And besides, with coreutils-8.6 already released, reverting the change is no longer an option. Why? I'm pretty sure more breakage will pop up over

Re: [coreutils] Re: [PATCH 2/2] stat: print timestamps to full resolution

2010-10-21 Thread Eric Blake
of confusion, and given that date(1) already supports %:z. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org

Re: [coreutils] Re: [PATCH 2/2] stat: print timestamps to full resolution

2010-10-21 Thread Eric Blake
has a minimum width of min(precision,9), and 0 padding is only needed if you want a width greater than 9. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org

Re: [coreutils] Re: [PATCH 2/2] stat: print timestamps to full resolution

2010-10-21 Thread Eric Blake
ction when reducing precision. I'm inclined to say: If you care, don't truncate in the first place, or use another tool, e.g., printf, to format the floating point number. Agreed. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org

Re: [coreutils] Re: crtime on ext4 or ntfs

2010-10-22 Thread Eric Blake
pported in coreutils-8.6's stat program. By the way, this works out of the box on BSD and Cygwin systems where birthtime is part of stat(2), but for Linux, you'll have to wait until the kernel implements xstat(2) before coreutils can print anything meaningful. -- Eric Blake ebl...

Re: [coreutils] Re: Builds of coreutils-8.6.19-1369f

2010-11-06 Thread Eric Blake
sion as the declaration. This is a good habit to get into anyways, since: local s=$(false); echo $? 0 local t; t=$(false); echo $? 1 that is, local is an expression of its own, and succeeds if the assignment completed, throwing out the status of any command substitutions used to compute that val

Re: [coreutils] Is, 'df' when run as UID=0 NOT privileged ? Re, FAQ question 32 and tune2fs manpage

2010-11-12 Thread Eric Blake
it up with them. But given the high cost of adding or altering syscalls, I'm not holding my breath. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

bug#7444: Undocumented option -I ?

2010-11-19 Thread Eric Blake
precated because we feel badly about supporting an output format that we can't reparse as an input format). -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [coreutils] coredump segmentation fault using coreutils 6.4 sparc solaris using mv or touch

2010-11-23 Thread Eric Blake
8.7. > > Do we need to upgrade to a newer version of coreutils Yes. Oracle's latest kernel patches to Solaris exposed a latent bug that had been hiding in earlier coreutils releases when it comes to setting file timestamps. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Lib

bug#7523: chmod example in docs

2010-12-01 Thread Eric Blake
;, which is reproduced in 'man chmod', or the official documentation 'info coreutils chmod'? However, you are correct that the info pages do not currently have any example for chmod; would you care to help us write a patch? -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libv

Re: [coreutils] Mailing list problem

2010-12-09 Thread Eric Blake
eration was queued at various places, and based on delay times of those various queues, is just now percolating through the system. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [coreutils] default behavior to truncate

2010-12-10 Thread Eric Blake
is that it is worth making the user do a bit of extra typing to imply that they meant it. And you can always write a shell function or alias to supply the argument automatically, if you like the ease of a shorter command in an interactive environment. -- Eric Blake ebl...@redhat.com

Re: [coreutils] Making md5sum aware of MSDOS line ending feasible?

2010-12-15 Thread Eric Blake
bothered enough by the current state of things to write the patch (using d2u on the checksum file before handing it to md5sum is usually a decent workaround to having to teach md5sum about alternate line endings). -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualizat

[coreutils] Re: [PATCH] snprintf: port snprintf (NULL, 0, ...) to Solaris 8 and 9

2010-12-21 Thread Eric Blake
printf, so it will enlarge quite a few of the binaries to start replacing snprintf. Maybe a compromise is to change src/csplit to use vasprintf instead of snprintf, and not trigger the snprintf(NULL,0) bug in the first place since we already have the vasprintf wrapper. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

[coreutils] [PATCH] maint: allow gettext 0.17 again

2010-12-30 Thread Eric Blake
Commit 041c9c47 traded the 'gettext' module for the lighter 'gettext-h' module, so as to not require the latest gettext release (we only need the latest release if we ship gettext as a dependent library, but coreutils has long preferred to use it as an external library). But that commit overlooked

[coreutils] testsuite worthless on cygwin

2010-12-30 Thread Eric Blake
flicts with [.exe) rather than giving up on the entire directory. Any other opinions, or should I go ahead and propose a patch? -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

[coreutils] [PATCH] tests: avoid failing coreutils tests on cygwin

2010-12-30 Thread Eric Blake
* tests/init.sh (find_exe_basenames_): Exempt [.exe. (create_exe_shims_): Return 0 when skipping. --- This lets me get to the point where the few remaining test failures of coreutils testsuite on cygwin are worth investigating individually, rather than failing almost everything up front. If you l

Re: [coreutils] [PATCH] maint: allow gettext 0.17 again

2010-12-30 Thread Eric Blake
On 12/30/2010 02:38 PM, Jim Meyering wrote: > Eric Blake wrote: >> Commit 041c9c47 traded the 'gettext' module for the lighter 'gettext-h' >> module, so as to not require the latest gettext release (we only need >> the latest release if we ship gettext as

[coreutils] Re: [PATCH] tests: avoid failing coreutils tests on cygwin

2010-12-31 Thread Eric Blake
On 12/30/2010 05:07 PM, Paul Eggert wrote: > On 12/30/2010 01:24 PM, Eric Blake wrote: >> If you like it, I'll >> push to gnulib first and then synchronize coreutils to the latest. > > Either order is fine, thanks, but we should try to keep them in sync. I've now p

  1   2   3   4   5   6   7   >