[PATCH setup 2/3] Change the interpretation of '#' in setup.rc

2017-11-28 Thread Ken Brown
'#' was treated as a comment character in all circumstances. Since saved gpg keys contain '#', this caused the "extrakeys" user setting to get truncated. Change this so that '#' only indicates a comment if it's the first non-whitespace character in a line. --- UserSettings.cc | 8 1 fil

[PATCH setup 0/3] Fix "extrakeys" issues

2017-11-28 Thread Ken Brown
is patch series attempts to fix all these problems. In the case of '#', the fix is to treat '#' as a comment character only if it's the first non-whitespace character on a line. I don't think this will cause problems for any existing uses of '#', but I haven

[PATCH setup 1/3] Fix the reading and writing of the "extrakeys" user setting

2017-11-28 Thread Ken Brown
ExtraKeysSetting::keybuffer is terminated by LF rather than NUL. So we have to replace NUL by LF after calling UserSettings::get("extrakeys") in the ExtraKeysSetting constructor. Otherwise the last saved key is discarded. Also, bufsize has to be set appropriately before the call to count_keys(),

[PATCH setup 3/3] Remove references to "last-extrakeys"

2017-11-28 Thread Ken Brown
Extra gpg keys used to be stored in a file /etc/setup/last-extrakeys. These keys are now saved in the "extrakeys" user setting, but there were still references to "last-extrakeys" in comments and in a help string. --- KeysSetting.h | 2 +- crypto.cc | 8 2 files changed, 5 insertions(

Re: [PATCH setup] Don't write garbage into the "extrakeys" user setting

2017-11-28 Thread Ken Brown
On 11/28/2017 7:58 AM, Ken Brown wrote: On 11/27/2017 9:14 PM, Ken Brown wrote: On 11/27/2017 5:19 PM, Ken Brown wrote: On 11/27/2017 4:35 PM, Ken Brown wrote: The ExtraKeysSetting destructor called UserSettings::set() on a string that was terminated by LF instead of NUL.  This led to garbage

Re: [PATCH setup] Don't write garbage into the "extrakeys" user setting

2017-11-28 Thread Ken Brown
On 11/27/2017 9:14 PM, Ken Brown wrote: On 11/27/2017 5:19 PM, Ken Brown wrote: On 11/27/2017 4:35 PM, Ken Brown wrote: The ExtraKeysSetting destructor called UserSettings::set() on a string that was terminated by LF instead of NUL.  This led to garbage at the end of the "extrakeys&quo

Re: [PATCH setup] Don't write garbage into the "extrakeys" user setting

2017-11-27 Thread Ken Brown
On 11/27/2017 5:19 PM, Ken Brown wrote: On 11/27/2017 4:35 PM, Ken Brown wrote: The ExtraKeysSetting destructor called UserSettings::set() on a string that was terminated by LF instead of NUL.  This led to garbage at the end of the "extrakeys" setting that was written into setup.rc.

Re: [PATCH setup] Don't write garbage into the "extrakeys" user setting

2017-11-27 Thread Ken Brown
On 11/27/2017 4:35 PM, Ken Brown wrote: The ExtraKeysSetting destructor called UserSettings::set() on a string that was terminated by LF instead of NUL. This led to garbage at the end of the "extrakeys" setting that was written into setup.rc. Fix this by replacing the final LF by

[PATCH setup] Don't write garbage into the "extrakeys" user setting

2017-11-27 Thread Ken Brown
The ExtraKeysSetting destructor called UserSettings::set() on a string that was terminated by LF instead of NUL. This led to garbage at the end of the "extrakeys" setting that was written into setup.rc. Fix this by replacing the final LF by NUL before calling set(). --- KeysSetting.cc | 6 +-

[ITA] lcms2-2.9-1

2017-11-27 Thread Ken Brown
My cygport file is attached. Package files = D=http://sanibeltranquility.com/cygwin ${D}/x86/release/lcms2/lcms2-2.9-1-src.tar.xz ${D}/x86/release/lcms2/lcms2-2.9-1.hint ${D}/x86/release/lcms2/lcms2-2.9-1.tar.xz ${D}/x86/release/lcms2/lcms2-debuginfo/lcms2-debuginfo-2.9-1.hint ${D}/x

Re: [PATCH] make setup mirror list more like web page not just urls

2017-11-25 Thread Ken Brown
On 11/24/2017 4:47 PM, Brian Inglis wrote: I am suggesting we split get_site_list to create the setup.rc cached list at the start, flag entries false, So you're throwing away the information that the entries in the cached site list came from mirrors.lst in a previous setup run? merge the la

[PATCH setup, v2] site.cc, site.h: code cleanup

2017-11-24 Thread Ken Brown
Remove site_list_type::init(), which was introduced to work around a problem with gcc-2.95. Add a bool member 'from_mirrors_lst' to the site_list_type class. Use it to distinguish mirrors listed in mirrors.lst from user-added sites. This replaces the (undocumented) use of site_list_type::serverna

Re: [PATCH] make setup mirror list more like web page not just urls

2017-11-24 Thread Ken Brown
On 11/24/2017 1:23 AM, Brian Inglis wrote: On 2017-11-23 14:07, Ken Brown wrote: On 11/22/2017 11:42 AM, Brian Inglis wrote: On 2017-11-20 15:59, Ken Brown wrote: On 11/20/2017 4:30 PM, Brian Inglis wrote: On 2017-11-17 06:53, Jon Turney wrote: On 11/17/2017 8:48 AM, Ken Brown wrote: On 15

Re: [PATCH] make setup mirror list more like web page not just urls

2017-11-23 Thread Ken Brown
On 11/22/2017 11:42 AM, Brian Inglis wrote: On 2017-11-20 15:59, Ken Brown wrote: On 11/20/2017 4:30 PM, Brian Inglis wrote: On 2017-11-17 06:53, Jon Turney wrote: On 11/17/2017 8:48 AM, Ken Brown wrote: On 15/11/2017 21:35, Brian Inglis wrote: The issue of recognizing a URL that's al

Re: [PATCH setup] site.cc, site.h: code cleanup

2017-11-23 Thread Ken Brown
On 11/22/2017 12:02 PM, Jon Turney wrote: On 20/11/2017 01:26, Ken Brown wrote: Remove site_list_type::init(), which was introduced to work around a problem with gcc-2.95. Please tell me we're not actually using a placement new for these things :S Add a bool member 'is_offici

Re: [PATCH setup 00/14] Use libsolv, solve all our problems... (WIP)

2017-11-23 Thread Ken Brown
On 11/23/2017 1:10 PM, Jon Turney wrote: On 06/09/2017 03:52, Ken Brown wrote: On 9/5/2017 2:40 PM, Achim Gratz wrote: Jon Turney writes: Yeah, I'm not sure if putting the test packages into a separate repo which is disabled unless explicitly enabled is the right approach. (Instead, pe

Re: [PATCH] make setup mirror list more like web page not just urls

2017-11-20 Thread Ken Brown
On 11/20/2017 5:59 PM, Ken Brown wrote: On 11/20/2017 4:30 PM, Brian Inglis wrote: On 2017-11-17 06:53, Jon Turney wrote: On 11/17/2017 8:48 AM, Ken Brown wrote: On 15/11/2017 21:35, Brian Inglis wrote: Thanks for your comments, I understand all your points, and agree with them. I merged

Re: [PATCH] make setup mirror list more like web page not just urls

2017-11-20 Thread Ken Brown
On 11/20/2017 4:30 PM, Brian Inglis wrote: On 2017-11-17 06:53, Jon Turney wrote: On 11/17/2017 8:48 AM, Ken Brown wrote: On 15/11/2017 21:35, Brian Inglis wrote: Thanks for your comments, I understand all your points, and agree with them. I merged the posts and responses as they addressed

Re: [ITA] libXpm-noX 3.5.12

2017-11-20 Thread Ken Brown
On 11/20/2017 11:42 AM, Jon Turney wrote: On 15/11/2017 17:30, Ken Brown wrote: My cygport file and other files needed for reproducing the build are attached. I added this to your uploads, but this fails to build for me: libXpm-nox/libXpm-noX-3.5.12-1.src/libXpm-noX-3.5.12-1.x86_6/src/libXpm

[PATCH setup] site.cc, site.h: code cleanup

2017-11-19 Thread Ken Brown
Remove site_list_type::init(), which was introduced to work around a problem with gcc-2.95. Add a bool member 'is_official' to the site_list_type class. Use it to distinguish official mirrors (listed in mirrors.lst) from user-added sites. This replaces the (undocumented) use of site_list_type::s

Re: [PATCH] make setup mirror list more like web page not just urls

2017-11-19 Thread Ken Brown
On 11/17/2017 8:48 AM, Ken Brown wrote: which that fails.  Also, you shouldn't be relying on the servername field being filled in. One further comment about the servername field: AFAICT, the only use that's made of this field is to distinguish "official" mirrors (those l

Re: perl-Unicode-Collate

2017-11-18 Thread Ken Brown
On 11/18/2017 1:08 PM, Achim Gratz wrote: Ken Brown writes: The most recent Biber release requires Unicode::Collate >= 1.21, but the version bundled with perl-5.26 is 1.19. The latest upstream release seems to be 1.23. Could you update this when you get a chance? Done. Thanks. Ken

Re: [PATCH] make setup mirror list more like web page not just urls

2017-11-17 Thread Ken Brown
On 11/15/2017 4:35 PM, Brian Inglis wrote: Hi folks, [reposted without text attachment to see if patch gets thru] Working on a FAST_CWD FAQ, looking at the Setup mirror site page and the web page, I wondered if we could usefully add the mirrors.lst region and territory (called area and location

[ITA] libXpm-noX 3.5.12

2017-11-15 Thread Ken Brown
My cygport file and other files needed for reproducing the build are attached. Package files = D=http://sanibeltranquility.com/cygwin ${D}/x86/release/libXpm-noX/libXpm-noX-3.5.12-1-src.tar.xz ${D}/x86/release/libXpm-noX/libXpm-noX-3.5.12-1.hint ${D}/x86/release/libXpm-noX/libXpm-noX

perl-Unicode-Collate

2017-11-13 Thread Ken Brown
Achim, The most recent Biber release requires Unicode::Collate >= 1.21, but the version bundled with perl-5.26 is 1.19. The latest upstream release seems to be 1.23. Could you update this when you get a chance? Thanks. Ken

[PATCH setup 5/5] Limit the number of packages shown in the IDD_DOWNLOAD_ERROR listbox

2017-11-10 Thread Ken Brown
--- download.cc | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/download.cc b/download.cc index b059bf5..6e6d6e8 100644 --- a/download.cc +++ b/download.cc @@ -188,6 +188,7 @@ download_one (packagesource & pkgsource, HWND owner) static std::vector download_failure

[PATCH setup 2/5] Fix off-by-one error in download retry report

2017-11-10 Thread Ken Brown
'retries' was decremented after it was tested but before it was reported in the log, so the reported number was always 1 too low. --- download.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/download.cc b/download.cc index f6aa6fc..a430f7f 100644 --- a/download.cc +++ b/

[PATCH setup 4/5] Query user after download error in interactive mode

2017-11-10 Thread Ken Brown
Instead of just giving the user a "Try again?" Yes/No choice that goes to IDD_SITE on Yes, create a dialog IDD_DOWNLOAD_ERROR with the following choices: 'Retry' (retry the download), 'Back' (return to IDD_CHOOSE), 'Continue' (ignore the errors), or 'Cancel' (exit). The dialog lists the packages t

[PATCH setup 3/5] Remove "Try again?" from exit message.

2017-11-10 Thread Ken Brown
--- download.cc | 2 +- res.rc | 1 + resource.h | 1 + 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/download.cc b/download.cc index a430f7f..841f680 100644 --- a/download.cc +++ b/download.cc @@ -266,7 +266,7 @@ do_download_thread (HINSTANCE h, HWND owner) if (source ==

[PATCH setup 1/5] Just retry download after error in unattended mode

2017-11-10 Thread Ken Brown
After a download error, setup was going back to IDD_SITE. This is pointless in unattended mode, since no changes in the mirrors or packages can be made. Change misleading comment about retries in unattended mode; the Yes/No dialog is not used in that case. --- download.cc | 9 +++-- 1 file c

[PATCH setup 0/5] Improve behavior after download error, v2

2017-11-10 Thread Ken Brown
mode, pop up a dialog showing which packages had download errors and giving the user the following options: - Retry (retries download) - Back (return to the package selection page) - Continue, with a warning - Cancel (exit) Ken Brown (5): Just retry download after error in una

Re: [PATCH setup 0/2] Improve behavior after download error

2017-11-10 Thread Ken Brown
On 11/9/2017 11:42 AM, Ken Brown wrote: On 11/9/2017 8:21 AM, Jon Turney wrote: On 08/11/2017 18:52, Brian Inglis wrote: On 2017-11-08 07:35, Ken Brown wrote: On 11/7/2017 1:56 PM, Jon Turney wrote: On 07/11/2017 04:28, Brian Inglis wrote: On 2017-11-06 14:49, Ken Brown wrote: This is a

Re: [PATCH setup 0/2] Improve behavior after download error

2017-11-09 Thread Ken Brown
On 11/9/2017 8:21 AM, Jon Turney wrote: On 08/11/2017 18:52, Brian Inglis wrote: On 2017-11-08 07:35, Ken Brown wrote: On 11/7/2017 1:56 PM, Jon Turney wrote: On 07/11/2017 04:28, Brian Inglis wrote: On 2017-11-06 14:49, Ken Brown wrote: This is a followup to https://sourceware.org/ml

Re: [PATCH setup 0/2] Improve behavior after download error

2017-11-08 Thread Ken Brown
On 11/7/2017 1:56 PM, Jon Turney wrote: On 07/11/2017 04:28, Brian Inglis wrote: On 2017-11-06 14:49, Ken Brown wrote: This is a followup to https://sourceware.org/ml/cygwin-apps/2017-11/msg3.html.  The focus of that thread was a crash that occurs on the topic/libsolv branch.  Here I&#

Re: [setup topic/libsolv] Crash after incomplete download

2017-11-07 Thread Ken Brown
On 11/7/2017 1:15 PM, Jon Turney wrote: On 02/11/2017 19:25, Ken Brown wrote: On 11/2/2017 1:22 PM, Jon Turney wrote: On 01/11/2017 20:38, Ken Brown wrote: If there is a download failure and the user clicks Yes in response to "Download Incomplete.  Try again?", then setup will c

[PATCH setup 2/2] Whitespace fixes

2017-11-06 Thread Ken Brown
--- download.cc | 146 ++-- 1 file changed, 73 insertions(+), 73 deletions(-) diff --git a/download.cc b/download.cc index 6ee64c1..89e2b7d 100644 --- a/download.cc +++ b/download.cc @@ -199,95 +199,95 @@ do_download_thread (HINSTANCE h, HWN

[PATCH setup 0/2] Improve behavior after download error

2017-11-06 Thread Ken Brown
nt code in a retry loop. This should require indentation of a large amount of code. To keep the patch readable, I've saved the indentation for a separate patch. Ken Brown (2): Improve behavior after download error Whitespace fixes download.cc | 161 -

[PATCH setup 1/2] Improve behavior after download error

2017-11-06 Thread Ken Brown
If the user answers "Yes" to "Download incomplete. Try again?", simply try the download again, as the message suggests, instead of going back to the site page. If the user answers no, don't proceed with the install unless the user confirms that this is what they want. The rationale for the previ

Re: [setup topic/libsolv] Crash after incomplete download

2017-11-02 Thread Ken Brown
On 11/2/2017 1:22 PM, Jon Turney wrote: On 01/11/2017 20:38, Ken Brown wrote: If there is a download failure and the user clicks Yes in response to "Download Incomplete.  Try again?", then setup will crash.  The crash occurs at PickView.cc:447 because i->source() is NULL. Thank

[setup topic/libsolv] Crash after incomplete download

2017-11-01 Thread Ken Brown
If there is a download failure and the user clicks Yes in response to "Download Incomplete. Try again?", then setup will crash. The crash occurs at PickView.cc:447 because i->source() is NULL. I haven't yet analyzed this in further detail, but the crux of the issue seems to be that we call d

Changes on sourceware for ghostscript fonts

2017-11-01 Thread Ken Brown
The attached patch updates cygwin-pkg-maint accordingly. Thanks. Ken From 837a6fc4d43563d2ad155d3118682c345bc0e2c5 Mon Sep 17 00:00:00 2001 From: Ken Brown Date: Wed, 1 Nov 2017 08:14:59 -0400 Subject: [PATCH] Remove ghostscript-fonts-std and add urw-base35-fonts --- cygwin-pkg-maint | 2 +- 1

Re: [ITA] ghostscript, ghostscript-fonts-std, ghostscript-fonts-other

2017-10-31 Thread Ken Brown
On 10/31/2017 12:56 PM, Ken Brown wrote: On 10/30/2017 5:55 PM, Yaakov Selkowitz wrote: It would also be nice if the updated URW fonts[2] would also be installed under e.g. /usr/share/fonts/urw-base35. Is the attached what you had in mind?  Following Fedora, I only packaged *.t1 and *.afm

Re: [ITA] ghostscript, ghostscript-fonts-std, ghostscript-fonts-other

2017-10-31 Thread Ken Brown
On 10/30/2017 5:55 PM, Yaakov Selkowitz wrote: It would also be nice if the updated URW fonts[2] would also be installed under e.g. /usr/share/fonts/urw-base35. Is the attached what you had in mind? Following Fedora, I only packaged *.t1 and *.afm files, even though the source package also co

[ITA] ghostscript, ghostscript-fonts-std, ghostscript-fonts-other

2017-10-30 Thread Ken Brown
My cygport files and patch are attached. The two fonts packages don't need updating, but their cygport files had to be updated, so I'm attaching them for future reference. In the case of ghostscript, the current version is 9.22, but it doesn't work with preview-latex: https://bugs.ghostscript.

Re: [[PATCH setup topic/libsolv] 1/2] packagedb::removeEmptyCategories: Don't remove "Base"

2017-10-30 Thread Ken Brown
On 10/30/2017 11:59 AM, Jon Turney wrote: This is all a bit broken though.  Because we've forgotten the categories of installed packages, if we're run without a setup.ini, we'll merrily let packages in the base category get uninstalled without complaint... Maybe we need to add something to the

Re: [[PATCH setup topic/libsolv] 1/2] packagedb::removeEmptyCategories: Don't remove "Base"

2017-10-29 Thread Ken Brown
On 10/29/2017 1:24 PM, Jon Turney wrote: On 28/10/2017 13:29, Ken Brown wrote: This can be empty if no setup.ini files are found.  Removing it causes setup to hang. ---   package_db.cc | 2 +-   1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package_db.cc b/package_db.cc index

[PATCH setup, revised 2/2] Avoid clobbering installed.db when no setup.ini is found

2017-10-28 Thread Ken Brown
If no setup.ini is found, do_ini_thread is never called. But we need to ensure that packagedb::read is called, or else installed.db gets emptied. Move the calls to packagedb::read and other packagedb functions from do_ini_thread to ChooserPage::OnInit. --- choose.cc | 8 +++- ini.cc| 7 -

Re: [[PATCH setup topic/libsolv] 2/2] Avoid clobbering installed.db when no setup.ini is found

2017-10-28 Thread Ken Brown
On 10/28/2017 8:29 AM, Ken Brown wrote: Move the calls to packagedb::read and other packagedb functions from do_ini_thread to ChooserPage::OnInit. If no setup.ini is found, do_ini_thread is never called. But we need to ensure that packagedb::read is called, or else installed.db gets emptied

Re: setup with experimental libsolv-based dependency solving

2017-10-28 Thread Ken Brown
On 10/27/2017 3:52 PM, Ken Brown wrote: On 10/27/2017 2:57 PM, Ken Brown wrote: On 10/25/2017 3:18 PM, Jon Turney wrote: This has a lot of internal changes, so could use some wider testing. Please test. I've just discovered a serious bug.  When installing from a local directory

[[PATCH setup topic/libsolv] 2/2] Avoid clobbering installed.db when no setup.ini is found

2017-10-28 Thread Ken Brown
Move the calls to packagedb::read and other packagedb functions from do_ini_thread to ChooserPage::OnInit. If no setup.ini is found, do_ini_thread is never called. But we need to ensure that packagedb::read is called, or else installed.db gets emptied. --- choose.cc | 5 + ini.cc| 7

[[PATCH setup topic/libsolv] 1/2] packagedb::removeEmptyCategories: Don't remove "Base"

2017-10-28 Thread Ken Brown
This can be empty if no setup.ini files are found. Removing it causes setup to hang. --- package_db.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package_db.cc b/package_db.cc index ac9387c..b104073 100644 --- a/package_db.cc +++ b/package_db.cc @@ -596,7 +596,7 @@ packag

Re: setup with experimental libsolv-based dependency solving

2017-10-27 Thread Ken Brown
On 10/27/2017 2:57 PM, Ken Brown wrote: On 10/25/2017 3:18 PM, Jon Turney wrote: This has a lot of internal changes, so could use some wider testing. Please test. I've just discovered a serious bug.  When installing from a local directory that either doesn't exist or isn

Re: [[PATCH setup] 0/3] Prepare for colons in version numbers

2017-10-27 Thread Ken Brown
On 10/27/2017 3:26 PM, Achim Gratz wrote: Ken Brown writes: A future version of setup might allow version numbers of the form e:v-r, where is an epoch. Currently setup doesn't parse these correctly when reading installed.db. In case ScanFindVisitor is used, there is an additional probl

Re: setup with experimental libsolv-based dependency solving

2017-10-27 Thread Ken Brown
On 10/25/2017 3:18 PM, Jon Turney wrote: This has a lot of internal changes, so could use some wider testing. Please test. I've just discovered a serious bug. When installing from a local directory that either doesn't exist or isn't a valid repository, setup doesn't correctly read/write th

[[PATCH setup] 3/3] Remove the ScanFindVisitor class

2017-10-27 Thread Ken Brown
This class was used for local installs in which the repository contains no setup.ini file. It didn't correctly handle filenames with colons, and it could become a maintenance burden to continue to support it. There are now good instructions at https://cygwin.com/package-server.html#overlay for cr

[[PATCH setup] 2/3] Bump the installed.db version to 4

2017-10-27 Thread Ken Brown
Starting with the commit 'Remove the function filemanip.cc:base', setup correctly parses version numbers of the form e:v-r in installed.db. Bump the version of installed.db to reflect the fact that older setup doesn't parse filenames containing colons correctly. --- package_db.cc | 19 +++

[[PATCH setup] 0/3] Prepare for colons in version numbers

2017-10-27 Thread Ken Brown
ne by Win32 functions, and the illegal characters like ':' aren't translated. Ken Brown (3): Remove the function filemanip.cc:base Bump the installed.db version to 4 Remove the ScanFindVisitor class IniDBBuilderPackage.h | 6 -- Makefile.am | 2 -- ScanFi

[[PATCH setup] 1/3] Remove the function filemanip.cc:base

2017-10-27 Thread Ken Brown
This was called only on plain filenames, not full pathnames, so it was not needed. Moreover, it wasn't correctly handling filenames containing colons. --- filemanip.cc | 18 +- filemanip.h | 1 - 2 files changed, 1 insertion(+), 18 deletions(-) diff --git a/filemanip.cc b/filem

Re: setup and colons in filenames

2017-10-27 Thread Ken Brown
On 10/27/2017 9:44 AM, Jon Turney wrote: I've worked on [1] a bit so it now contains some instructions how to do this, rather than the previous state of affairs, which was "genini exists, work it out yourself" [1] https://cygwin.com/package-server.html#overlay (*) Or better: A user version o

Re: setup and colons in filenames

2017-10-26 Thread Ken Brown
On 10/26/2017 12:14 PM, Jon Turney wrote: On 25/10/2017 20:23, Jon Turney wrote: On 25/10/2017 16:50, Ken Brown wrote: This is a followup to the thread started here:    https://cygwin.com/ml/cygwin-patches/2017-q4/msg00012.html Currently setup's parse_filename is not correctly pa

setup and colons in filenames

2017-10-25 Thread Ken Brown
This is a followup to the thread started here: https://cygwin.com/ml/cygwin-patches/2017-q4/msg00012.html Currently setup's parse_filename is not correctly parsing filenames in /etc/setup/installed.db that contain colons, as explained in the above thread. It would be easy to fix this by jus

Re: [setup topic/libsolv] Does "obsoletes:" work?

2017-10-24 Thread Ken Brown
On 10/24/2017 4:37 PM, Jon Turney wrote: On 24/10/2017 21:24, Ken Brown wrote: On 10/24/2017 4:09 PM, Jon Turney wrote: On 23/10/2017 18:43, Ken Brown wrote: On 10/23/2017 7:38 AM, Jon Turney wrote: On 21/10/2017 21:18, Ken Brown wrote: On 10/20/2017 6:24 PM, Ken Brown wrote: Have you ever

Re: [setup topic/libsolv] Does "obsoletes:" work?

2017-10-24 Thread Ken Brown
On 10/24/2017 4:09 PM, Jon Turney wrote: On 23/10/2017 18:43, Ken Brown wrote: On 10/23/2017 7:38 AM, Jon Turney wrote: On 21/10/2017 21:18, Ken Brown wrote: On 10/20/2017 6:24 PM, Ken Brown wrote: Have you ever tested the "obsoletes:" feature of setup/libsolv?  I tried adding an

Re: [Attn. Maintainers] Perl 5.26.1 (release is imminent)

2017-10-24 Thread Ken Brown
On 10/23/2017 3:20 PM, Achim Gratz wrote: Achim Gratz writes: Please upload your packages to sourceware _without_ the !ready cookies (i.e. don't use cygport upload) and instead place !perl cookies. This way the staged uploads can all be activated at the same time so that no inconsistent interme

Re: [Attn. Maintainers] Perl 5.26.1 (release is imminent)

2017-10-23 Thread Ken Brown
On 10/23/2017 1:38 PM, Jon Turney wrote: On 23/10/2017 18:17, Yaakov Selkowitz wrote: On 2017-10-18 17:15, David Rothenberger wrote: On 10/18/2017 11:20 AM, Achim Gratz wrote: subversion-perl: A version control system (perl bindings) I've uploaded new subversion packages. Everything el

Re: [setup topic/libsolv] Does "obsoletes:" work?

2017-10-23 Thread Ken Brown
On 10/23/2017 7:38 AM, Jon Turney wrote: On 21/10/2017 21:18, Ken Brown wrote: On 10/20/2017 6:24 PM, Ken Brown wrote: Have you ever tested the "obsoletes:" feature of setup/libsolv?  I tried adding an "obsoletes:" line to setup.ini, and it didn't seem to have any ef

Re: [setup topic/libsolv] Packages contained in multiple repositories

2017-10-21 Thread Ken Brown
On 10/19/2017 9:36 AM, Jon Turney wrote: On 18/10/2017 17:41, Achim Gratz wrote: Ken Brown writes: In retrospect, I'm not sure this patch is right, but I'm sending it anyway for the sake of discussion.  My hesitation comes from the fact that libsolv might have a good reason for pref

Re: [setup topic/libsolv] Does "obsoletes:" work?

2017-10-21 Thread Ken Brown
On 10/20/2017 6:24 PM, Ken Brown wrote: Jon, Have you ever tested the "obsoletes:" feature of setup/libsolv?  I tried adding an "obsoletes:" line to setup.ini, and it didn't seem to have any effect. It turns out that it *is* working (after a minor fix, attached), bu

[setup topic/libsolv] Does "obsoletes:" work?

2017-10-20 Thread Ken Brown
Jon, Have you ever tested the "obsoletes:" feature of setup/libsolv? I tried adding an "obsoletes:" line to setup.ini, and it didn't seem to have any effect. Ken

Re: [PATCH] Revert "Don't override a Keep selection"

2017-10-20 Thread Ken Brown
On 10/19/2017 5:36 PM, Ken Brown wrote: Here's a related question.  Currently if libsolv decides I should install something and I choose Skip instead, it will get installed anyway (with no problem report).  Maybe we should have a taskSkip that generates a SOLVER_LOCK in that case, analogo

Re: [PATCH] Revert "Don't override a Keep selection"

2017-10-19 Thread Ken Brown
On 10/19/2017 11:05 AM, Ken Brown wrote: On 10/18/2017 11:01 PM, Ken Brown wrote: On 10/17/2017 3:31 PM, Ken Brown wrote: On 10/17/2017 2:43 PM, Jon Turney wrote: On 16/10/2017 20:13, Ken Brown wrote: This reverts (the rest of) commit b43b697.  Part of that commit was already reverted in

Re: [PATCH] Revert "Don't override a Keep selection"

2017-10-19 Thread Ken Brown
On 10/18/2017 11:01 PM, Ken Brown wrote: On 10/17/2017 3:31 PM, Ken Brown wrote: On 10/17/2017 2:43 PM, Jon Turney wrote: On 16/10/2017 20:13, Ken Brown wrote: This reverts (the rest of) commit b43b697.  Part of that commit was already reverted in commit ff0bb3d.  The rest is not needed

Re: [PATCH] Revert "Don't override a Keep selection"

2017-10-18 Thread Ken Brown
On 10/17/2017 3:31 PM, Ken Brown wrote: On 10/17/2017 2:43 PM, Jon Turney wrote: On 16/10/2017 20:13, Ken Brown wrote: This reverts (the rest of) commit b43b697.  Part of that commit was already reverted in commit ff0bb3d.  The rest is not needed either since we no longer send the upgrade flag

Re: [Attn. Maintainers] Perl 5.26.1 (release is imminent)

2017-10-18 Thread Ken Brown
On 10/18/2017 2:20 PM, Achim Gratz wrote: I've just uploaded the files for the update of Perl to version 5.26 to sourceware. Unfortunatley only a single other package has been staged there (znc), so we need to wait for the rest of the maintainers to do their uploads. Please upload your package

Re: [PATCH setup 00/14] Use libsolv, solve all our problems... (WIP)

2017-10-18 Thread Ken Brown
On 10/18/2017 11:28 AM, Ken Brown wrote: Similar considerations apply to the other public member functions of SolvableVersion.  So my inclination is to go with something like my patch... ...with perhaps one tweak. Maybe we should test 'id' rather than 'pool', since id be

Re: [PATCH setup 00/14] Use libsolv, solve all our problems... (WIP)

2017-10-18 Thread Ken Brown
On 10/17/2017 2:46 PM, Jon Turney wrote: On 17/10/2017 13:44, Ken Brown wrote: On 10/10/2017 7:18 AM, Ken Brown wrote: On 9/29/2017 4:33 PM, Ken Brown wrote: I'll resume my testing after I return. I've just started testing (based on the current HEAD of topic/libsolv), and so far

[setup topic/libsolv] Packages contained in multiple repositories

2017-10-18 Thread Ken Brown
it chose, e.g., if we've assigned priorities to the repos. On the other hand, if we've gone to the trouble of assigning priorities, shouldn't packagemeta reflect our choice? I'm of two minds here. Ken From 2c0c1edbecad7cdce69a02cef0506b93fe5d7981 Mon Sep 17 00:00:00 2001 Fr

Re: [PATCH] Revert "Don't override a Keep selection"

2017-10-17 Thread Ken Brown
On 10/17/2017 2:43 PM, Jon Turney wrote: On 16/10/2017 20:13, Ken Brown wrote: This reverts (the rest of) commit b43b697.  Part of that commit was already reverted in commit ff0bb3d.  The rest is not needed either since we no longer send the upgrade flag to the solver after the user has made

Re: [PATCH setup 00/14] Use libsolv, solve all our problems... (WIP)

2017-10-17 Thread Ken Brown
On 10/10/2017 7:18 AM, Ken Brown wrote: On 9/29/2017 4:33 PM, Ken Brown wrote: I'll resume my testing after I return. I've just started testing (based on the current HEAD of topic/libsolv), and so far everything looks good. I came across a situation where a SolvableVersion method

[PATCH] Revert "Don't override a Keep selection"

2017-10-16 Thread Ken Brown
This reverts (the rest of) commit b43b697. Part of that commit was already reverted in commit ff0bb3d. The rest is not needed either since we no longer send the upgrade flag to the solver after the user has made their selections. --- libsolv.cc | 14 +++--- libsolv.h | 1 - pac

Re: [Attn. Maintainers] Perl 5.26.1 (prepare for release)

2017-10-12 Thread Ken Brown
On 10/12/2017 3:32 PM, Achim Gratz wrote: As I haven't heard from most of the maintainers yet, here's a reminder that I would like to update Perl either on the upcoming weekend or from Wednesday in the week following. My packages are ready for upload: biber perl-PAR-Packer [without Tk sup

Re: lftp version override help

2017-10-11 Thread Ken Brown
On 10/11/2017 1:14 PM, Andrew Schulman wrote: As I described elsewhere here, I'm trying to dump lftp 4.8.0-1, which is partly broken, and promote 4.7.8-1 to current. I thought I could do that by uploading override.hint with: prev: 4.7.7-1 curr: 4.7.8-1 test: 4.7.8-1 But calm doesn't like that:

Re: [PATCH setup 00/14] Use libsolv, solve all our problems... (WIP)

2017-10-10 Thread Ken Brown
On 9/29/2017 4:33 PM, Ken Brown wrote: I'll resume my testing after I return. I've just started testing (based on the current HEAD of topic/libsolv), and so far everything looks good. My only suggestion is a cosmetic one. Now that you've made "Test" a checkbox,

Re: [Attn. Maintainers] Perl 5.26.1

2017-10-09 Thread Ken Brown
On 9/29/2017 2:06 PM, Yaakov Selkowitz wrote: The following are mine and are ready for upload: gnumeric graphviz hexchat libproxy link-grammar marisa ming openbabel openwsman rxvt-unicode vim xfconf zbar zinnia Yaakov, Have you also rebuilt your perl-Tk* packages? If so, can you make them a

[ITA] xpdf-4.00-1

2017-10-09 Thread Ken Brown
My cygport file and patches are attached. Note that there has been a change in the build system since the last release. It now uses cmake and libQt. For comparison, I'm also attaching the cygport file from the previous release. Package files = D=http://sanibeltranquility.com/cy

Re: [PATCH cygport] Add a command to make a test release

2017-10-05 Thread Ken Brown
On 10/5/2017 10:23 AM, Andrew Schulman wrote: Sometimes more complicated situations come up. We have one with lftp right now: prev: 4.7.7-1 curr: 4.8.0-1 test: 4.7.8-1 This happened because 4.8.0-1 turns out to be broken, and later versions won't build in Cygwin yet. So I had to promote 4.7.8-1

Re: [Attn. Maintainers] Perl 5.26.1

2017-10-02 Thread Ken Brown
On 10/2/2017 4:39 PM, Achim Gratz wrote: Ken Brown writes: On 9/30/2017 4:52 AM, Achim Gratz wrote: Am 29.09.2017 um 20:06 schrieb Yaakov Selkowitz: texinfo Installs under /usr/share/texinfo and seems to use captive Perl distributions, maybe we should change that (i.e. move perl-libintl

Re: Dr. Volker Zell's packages

2017-10-02 Thread Ken Brown
On 9/28/2017 11:31 AM, Yaakov Selkowitz wrote: Unfortunately, we haven't heard from Dr. Volker Zell in quite some time, and a number of his packages are in need of updates or rebuilds. I have marked them ORPHANED in the maintainer list. ITAs welcome. I plan to adopt xpdf, but it will be a wee

Re: [Attn. Maintainers] Perl 5.26.1

2017-09-30 Thread Ken Brown
On 9/30/2017 4:52 AM, Achim Gratz wrote: Am 29.09.2017 um 20:06 schrieb Yaakov Selkowitz: texinfo Installs under /usr/share/texinfo and seems to use captive Perl distributions, maybe we should change that (i.e. move perl-libintl-perl, perl-Text-Unidecode etc. to their own CPAN derived packag

Re: [PATCH setup 00/14] Use libsolv, solve all our problems... (WIP)

2017-09-29 Thread Ken Brown
On 9/29/2017 1:38 PM, Jon Turney wrote: On 27/09/2017 21:33, Ken Brown wrote: On 9/27/2017 3:14 PM, Jon Turney wrote: On 26/09/2017 17:06, Ken Brown wrote: On 9/26/2017 10:50 AM, Jon Turney wrote: On 15/09/2017 17:53, Ken Brown wrote: On 9/15/2017 11:15 AM, Jon Turney wrote: [...] If we

Re: Dr. Volker Zell's packages

2017-09-29 Thread Ken Brown
On 9/28/2017 11:31 AM, Yaakov Selkowitz wrote: Unfortunately, we haven't heard from Dr. Volker Zell in quite some time, and a number of his packages are in need of updates or rebuilds. I have marked them ORPHANED in the maintainer list. ITAs welcome. One of those orphaned packages, texi2html,

Re: [PATCH setup 00/14] Use libsolv, solve all our problems... (WIP)

2017-09-27 Thread Ken Brown
On 9/27/2017 3:14 PM, Jon Turney wrote: On 26/09/2017 17:06, Ken Brown wrote: On 9/26/2017 10:50 AM, Jon Turney wrote: On 15/09/2017 17:53, Ken Brown wrote: On 9/15/2017 11:15 AM, Jon Turney wrote: [...] If we select 'curr', then the latest version of all installed packages is s

Re: [PATCH setup 00/14] Use libsolv, solve all our problems... (WIP)

2017-09-26 Thread Ken Brown
On 9/26/2017 10:50 AM, Jon Turney wrote: On 15/09/2017 17:53, Ken Brown wrote: On 9/15/2017 11:15 AM, Jon Turney wrote: On 08/09/2017 19:54, Ken Brown wrote: Finally, I have a question for you, Jon: You introduced PrereqChecker::upgrade, which is true if and only if the user selects Current

Re: [Attn. Maintainers] Perl 5.26.1-RC1

2017-09-26 Thread Ken Brown
On 9/25/2017 5:21 PM, Yaakov Selkowitz wrote: On 2017-09-18 15:00, Ken Brown wrote: On 9/18/2017 2:00 PM, Achim Gratz wrote: Ken Brown writes: After the install you should be able to create test packages with and for the new Perl. Thanks.  I've successfully built everything I need.

Re: [Attn. Maintainers] Perl 5.26.1

2017-09-24 Thread Ken Brown
On 9/24/2017 11:59 AM, Achim Gratz wrote: Please build and prepare packages meant for release to Cygwin with this Perl version, but preferrably do no yet actually upload. Have you decided yet how you want to handle the upgrade when the time comes? I think last time you asked people to upload

Re: [PATCH setup 00/14] Use libsolv, solve all our problems... (WIP)

2017-09-19 Thread Ken Brown
On 9/19/2017 12:46 PM, Jon Turney wrote: On 19/09/2017 13:24, Ken Brown wrote: On 9/16/2017 12:21 PM, Ken Brown wrote: On 9/15/2017 3:24 PM, Jon Turney wrote: Can you rebase your and my patches onto master, and push to sourceware in a topic/libsolv branch? I've done the first part,

Re: [PATCH setup 00/14] Use libsolv, solve all our problems... (WIP)

2017-09-19 Thread Ken Brown
On 9/16/2017 12:21 PM, Ken Brown wrote: On 9/15/2017 3:24 PM, Jon Turney wrote: Can you rebase your and my patches onto master, and push to sourceware in a topic/libsolv branch? I've done the first part, but I don't seem to have the right permissions for the second: $ git push

Re: [Attn. Maintainers] Perl 5.26.1-RC1

2017-09-18 Thread Ken Brown
On 9/18/2017 2:00 PM, Achim Gratz wrote: Ken Brown writes: After the install you should be able to create test packages with and for the new Perl. Thanks. I've successfully built everything I need. …and that would have been? Anything that we need to add? I built biber, both the cu

Re: [Attn. Maintainers] Perl 5.26.1-RC1

2017-09-18 Thread Ken Brown
On 9/17/2017 4:05 PM, Achim Gratz wrote: Things took a bit longer than expected, but the RC1 plus all Cygwin modules that I maintain or co-maintain are now available. Please point setup to http://cygwin.stromeko.net/perl-5.26 as an additional installation source and it should let you update. T

Re: [PATCH setup 00/14] Use libsolv, solve all our problems... (WIP)

2017-09-17 Thread Ken Brown
On 9/15/2017 4:56 PM, cyg Simple wrote: On 9/15/2017 12:53 PM, Ken Brown wrote: On 9/15/2017 11:15 AM, Jon Turney wrote: On 08/09/2017 19:54, Ken Brown wrote: Finally, I have a question for you, Jon: You introduced PrereqChecker::upgrade, which is true if and only if the user selects Current

<    1   2   3   4   5   6   7   8   9   10   >