RE: Setup disabling of nonexistent virus scanners

2003-10-07 Thread Gary R. Van Sickle
> On Tue, 2003-10-07 at 21:33, Gary R. Van Sickle wrote: > > I don't understand. In proppage.{h,cc} (the base class) and in any > overrides > > (i.e. root and AntiVirus) both I and CVS have: > > > > virtual bool wantsActivation() const [etc...] > > CVS was missing the const. See the most rece

RE: Setup disabling of nonexistent virus scanners

2003-10-07 Thread Robert Collins
On Tue, 2003-10-07 at 21:33, Gary R. Van Sickle wrote: > I don't understand. In proppage.{h,cc} (the base class) and in any overrides > (i.e. root and AntiVirus) both I and CVS have: > > virtual bool wantsActivation() const [etc...] CVS was missing the const. See the most recent commit to prop

RE: Setup disabling of nonexistent virus scanners

2003-10-07 Thread Gary R. Van Sickle
> On Tue, 2003-10-07 at 11:32, Gary R. Van Sickle wrote: > > > Hmmm, yeah, I'll look at this. I wonder why I don't get this and (I assume) > > others don't > > Incorrect const clause on wantsActivation in the base class lead to > inconsistent method signatures. I don't understand. In proppag

Re: Setup disabling of nonexistent virus scanners

2003-10-07 Thread Robert Collins
On Tue, 2003-10-07 at 11:32, Gary R. Van Sickle wrote: > Hmmm, yeah, I'll look at this. I wonder why I don't get this and (I assume) > others don't Incorrect const clause on wantsActivation in the base class lead to inconsistent method signatures. I fixed this this morning, but have been rus

RE: base class wantsActivation is *always* called. (Re: Setup disabling of nonexistent virus scanners)

2003-10-06 Thread Gary R. Van Sickle
[sorry for the wrong reply-to Max] > > Note that detect() did in fact correctly determine that McAffe is not > > installed, so KnownAVIsPresent must be false, but the disable antivirus > page > > was displayed regardless. > > I investigated, and it seems that the base class wantsActivation is alwa

BUG: base class wantsActivation is *always* called. (Re: Setup disabling of nonexistent virus scanners)

2003-10-06 Thread Max Bowsher
[EMAIL PROTECTED] wrote: > Hello, all - > > I have noticed recently that Cygwin setup will prompt to disable a virus > scanner on my machine. This is odd, because I do not have a virus scanner > running. > > After looking in the code (setup/AntiVirus.cc from CVS, v2.5 Tue Jul 29 > 14:14:06 2003 UTC