Re: [darktable-dev] Feature request: camera model in export module

2015-11-24 Thread Šarūnas Burdulis
On 11/20/2015 04:33 PM, Pedro Côrte-Real wrote: > On Fri, Nov 20, 2015 at 8:54 PM, Šarūnas Burdulis > wrote: >> would someone care to take a look at the attached patch? It ads >> $(EXIF_MODEL) to recognized variables in the export to files on disk >> file naming field. I used darktable-org/darktab

Re: [darktable-dev] Feature request: camera model in export module

2015-11-24 Thread Tobias Ellinghaus
Am Freitag, 20. November 2015, 23:40:47 schrieb Pedro Côrte-Real: [...] > As for submitting the patch ideally you'd do a pull request on github. > It's easier to review there and that way you actually get credited in > the commit history. If that's too inconvenient a patch attached to > email as

Re: [darktable-dev] Feature request: camera model in export module

2015-11-20 Thread Pedro Côrte-Real
On Fri, Nov 20, 2015 at 10:29 PM, Šarūnas Burdulis wrote: > Frankly, I didn't even think about what else might be available in img > struct. So yes, let's use whichever element looks best for showing the > camera model in most of the cases (I only tested with files from Olympus > E-M5 and Moto X c

Re: [darktable-dev] Feature request: camera model in export module

2015-11-20 Thread Šarūnas Burdulis
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/20/2015 05:29 PM, Šarūnas Burdulis wrote: > On 11/20/2015 04:33 PM, Pedro Côrte-Real wrote: >> On Fri, Nov 20, 2015 at 8:54 PM, Šarūnas Burdulis >> wrote: >>> would someone care to take a look at the attached patch? It ads >>> $(EXIF_MODEL) to r

Re: [darktable-dev] Feature request: camera model in export module

2015-11-20 Thread Šarūnas Burdulis
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/20/2015 04:33 PM, Pedro Côrte-Real wrote: > On Fri, Nov 20, 2015 at 8:54 PM, Šarūnas Burdulis > wrote: >> would someone care to take a look at the attached patch? It ads >> $(EXIF_MODEL) to recognized variables in the export to files on disk >>

Re: [darktable-dev] Feature request: camera model in export module

2015-11-20 Thread Pedro Côrte-Real
On Fri, Nov 20, 2015 at 8:54 PM, Šarūnas Burdulis wrote: > would someone care to take a look at the attached patch? It ads > $(EXIF_MODEL) to recognized variables in the export to files on disk > file naming field. I used darktable-org/darktable master branch to start > with. Is exif_model actual

Re: [darktable-dev] Feature request: camera model in export module

2015-11-20 Thread Šarūnas Burdulis
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/19/2015 02:39 PM, Šarūnas Burdulis wrote: > Hello, > > Would it be possible to make camera model variable, e.g. $(EXIF_MODEL), > available in lighttable > export > storage options? Hello, developers, would someone care to take a look at the att

[darktable-dev] Feature request: camera model in export module

2015-11-19 Thread Šarūnas Burdulis
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hello, Would it be possible to make camera model variable, e.g. $(EXIF_MODEL), available in lighttable > export > storage options? And thanks for making darktable! - -- Šarūnas Burdulis http://math.dartmouth.edu/~sarunas -BEGIN PGP SIGNATURE---