RE: [PATCH 6/6] i2c: davinci: bus recovery procedure to clear the bus

2010-01-31 Thread Nori, Sekhar
Hi Philby, On Wed, Jan 27, 2010 at 05:11:33, Kevin Hilman wrote: > From: Philby John > > Come out of i2c time out condition by following the > bus recovery procedure outlined in the i2c protocol v3 spec. > The kernel must be robust enough to gracefully recover > from i2c bus failure without havin

Re: [PATCH 6/6] i2c: davinci: bus recovery procedure to clear the bus

2010-02-01 Thread Kevin Hilman
"Nori, Sekhar" writes: > Hi Philby, > > On Wed, Jan 27, 2010 at 05:11:33, Kevin Hilman wrote: >> From: Philby John >> >> Come out of i2c time out condition by following the >> bus recovery procedure outlined in the i2c protocol v3 spec. >> The kernel must be robust enough to gracefully recover >

Re: [PATCH 6/6] i2c: davinci: bus recovery procedure to clear the bus

2010-02-05 Thread Philby John
Hello Sekhar, My apologies for the late mail. Had trouble with our mail server and I seem to have lost mails. Pulling this thread from the list. Comments inline... On Mon, Feb 1, 2010 at 11:27 AM, Nori, Sekhar wrote: > Hi Philby, > > On Wed, Jan 27, 2010 at 05:11:33, Kevin Hilman wrote: >> From

RE: [PATCH 6/6] i2c: davinci: bus recovery procedure to clear the bus

2010-02-08 Thread Nori, Sekhar
Hi Philby, On Fri, Feb 05, 2010 at 19:23:43, Philby John wrote: > Hello Sekhar, > [...] > >> +/* Generate a pulse on the i2c clock pin. */ > >> +static void generic_i2c_clock_pulse(unsigned int scl_pin) > >> +{ > >> + u16 i; > >> + > >> + if (scl_pin) { > >> + /* Send high an

Re: [PATCH 6/6] i2c: davinci: bus recovery procedure to clear the bus

2010-02-08 Thread Philby John
Hello Sekhar, On 02/08/2010 04:05 PM, Nori, Sekhar wrote: +static void generic_i2c_clock_pulse(unsigned int scl_pin) +{ + u16 i; + + if (scl_pin) { + /* Send high and low on the SCL line */ + for (i = 0; i< 9; i++) { + gpio_set_value(scl_pin,

RE: [PATCH 6/6] i2c: davinci: bus recovery procedure to clear the bus

2010-02-08 Thread Nori, Sekhar
On Mon, Feb 08, 2010 at 20:43:27, Philby John wrote: > Hello Sekhar, > > On 02/08/2010 04:05 PM, Nori, Sekhar wrote: > +static void generic_i2c_clock_pulse(unsigned int scl_pin) > +{ > + u16 i; > + > + if (scl_pin) { > + /* Send high and low on the

Re: [PATCH 6/6] i2c: davinci: bus recovery procedure to clear the bus

2010-02-09 Thread Philby John
On 02/08/2010 09:33 PM, Nori, Sekhar wrote: On Mon, Feb 08, 2010 at 20:43:27, Philby John wrote: Hello Sekhar, On 02/08/2010 04:05 PM, Nori, Sekhar wrote: +static void generic_i2c_clock_pulse(unsigned int scl_pin) +{ + u16 i; + + if (scl_pin) { + /* Send high and low on the

RE: [PATCH 6/6] i2c: davinci: bus recovery procedure to clear the bus

2010-02-09 Thread Nori, Sekhar
On Tue, Feb 09, 2010 at 15:45:15, Philby John wrote: > On 02/08/2010 09:33 PM, Nori, Sekhar wrote: > > On Mon, Feb 08, 2010 at 20:43:27, Philby John wrote: > >> Hello Sekhar, > >> > >> On 02/08/2010 04:05 PM, Nori, Sekhar wrote: > >> +static void generic_i2c_clock_pulse(unsigned int scl_pin) >

RE: [PATCH 6/6] i2c: davinci: bus recovery procedure to clear the bus

2010-03-05 Thread Griffis, Brad
> > Right. I was also hoping to rid of cpu_is_xxx usage. The only other way > > I could think of is to add pinmux index into i2c platform data struct. > > What do you think is the best approach? > > > > I think passing pinmux index through platform data is fair. > > Thanks, > Sekhar I recently w

Re: [PATCH 6/6] i2c: davinci: bus recovery procedure to clear the bus

2010-03-08 Thread Philby John
On 03/05/2010 08:50 PM, Griffis, Brad wrote: Right. I was also hoping to rid of cpu_is_xxx usage. The only other way I could think of is to add pinmux index into i2c platform data struct. What do you think is the best approach? I think passing pinmux index through platform data is fair. Thank

Re: [PATCH 6/6] i2c: davinci: bus recovery procedure to clear the bus

2010-03-08 Thread Philby John
On 02/08/2010 04:05 PM, Nori, Sekhar wrote: Hi Philby, On Fri, Feb 05, 2010 at 19:23:43, Philby John wrote: Hello Sekhar, [...] +/* Generate a pulse on the i2c clock pin. */ +static void generic_i2c_clock_pulse(unsigned int scl_pin) +{ + u16 i; + + if (scl_pin) { + /* S

RE: [PATCH 6/6] i2c: davinci: bus recovery procedure to clear the bus

2010-03-11 Thread Griffis, Brad
> -Original Message- > From: Philby John [mailto:pj...@mvista.com] > Sent: Monday, March 08, 2010 7:37 AM > To: Griffis, Brad > Cc: Nori, Sekhar; davinci-linux-open-source@linux.davincidsp.com; linux- > i...@vger.kernel.org > Subject: Re: [PATCH 6/6] i2c: davinci: bus

Re: [PATCH 6/6] i2c: davinci: bus recovery procedure to clear the bus

2010-03-16 Thread Kevin Hilman
Philby John writes: > On 02/08/2010 04:05 PM, Nori, Sekhar wrote: >> Hi Philby, >> >> On Fri, Feb 05, 2010 at 19:23:43, Philby John wrote: >>> Hello Sekhar, >>> >> >> [...] >> > +/* Generate a pulse on the i2c clock pin. */ > +static void generic_i2c_clock_pulse(unsigned int scl_pin)

Re: [PATCH 6/6] i2c: davinci: bus recovery procedure to clear the bus

2010-03-17 Thread Philby John
On 03/17/2010 02:20 AM, Kevin Hilman wrote: Philby John writes: On 02/08/2010 04:05 PM, Nori, Sekhar wrote: Hi Philby, On Fri, Feb 05, 2010 at 19:23:43, Philby John wrote: Hello Sekhar, [...] +/* Generate a pulse on the i2c clock pin. */ +static void generic_i2c_clock_pulse(unsigned in

RE: [PATCH 6/6] i2c: davinci: bus recovery procedure to clear the bus

2010-03-17 Thread Nori, Sekhar
Hi Philby, On Wed, Mar 17, 2010 at 16:58:44, Philby John wrote: > On 03/17/2010 02:20 AM, Kevin Hilman wrote: > > Philby John writes: > > > >> On 02/08/2010 04:05 PM, Nori, Sekhar wrote: > >>> Hi Philby, > >>> > >>> On Fri, Feb 05, 2010 at 19:23:43, Philby John wrote: > Hello Sekhar, >

Re: [PATCH 6/6] i2c: davinci: bus recovery procedure to clear the bus

2010-03-17 Thread Philby John
On 03/17/2010 06:48 PM, Nori, Sekhar wrote: Hi Philby, On Wed, Mar 17, 2010 at 16:58:44, Philby John wrote: On 03/17/2010 02:20 AM, Kevin Hilman wrote: Philby John writes: On 02/08/2010 04:05 PM, Nori, Sekhar wrote: Hi Philby, On Fri, Feb 05, 2010 at 19:23:43, Philby John wrote: Hello S

Re: [PATCH 6/6] i2c: davinci: bus recovery procedure to clear the bus

2010-09-13 Thread Pablo Bitton
Hi Philby, On Wed, Jan 27, 2010 at 1:41 AM, Kevin Hilman wrote: > From: Philby John > > Come out of i2c time out condition by following the > bus recovery procedure outlined in the i2c protocol v3 spec. > The kernel must be robust enough to gracefully recover > from i2c bus failure without havin

Re: [PATCH 6/6] i2c: davinci: bus recovery procedure to clear the bus

2010-09-27 Thread Philby John
Hello Pablo, On Mon, 2010-09-13 at 16:23 +0200, Pablo Bitton wrote: > Hi Philby, > i2c_davinci_wait_bus_not_busy(struct davinci_i2c_dev *dev, > char allow_sleep) > { >unsigned long timeout; > + static u1