reduced to 58 cpu, and 100 reduced to 68.
Those are impressive gains!
BTW, this change is literally thousands of lines of code so if you depend on
DBD::Oracle I'd get a copy of the subversion trunk and try it.
Thanks for doing the work Martin!
Tim.
to
treat the return value of the post-call callback as the value to be
returned to the application, so the callback would end with
return $sth-fetchrow_arrayref;
Tim.
),\
%sOCIServerRelease(%p)=%s\n,\
OciTp, sc,oci_status_name(stat)),stat \
: stat
Tim.
On Wed, Mar 14, 2012 at 08:24:36AM +0100, H.Merijn Brand wrote:
On Tue, 13 Mar 2012 21:44:06 +, Tim Bunce tim.bu...@pobox.com
wrote:
On Fri, Mar 02, 2012 at 03:11:17PM +, Tim Bunce wrote:
The second patch, which makes DBIS more efficient, is a lot more
complex
On Wed, Mar 14, 2012 at 08:52:38AM +, Martin J. Evans wrote:
On 13/03/12 21:44, Tim Bunce wrote:
On Fri, Mar 02, 2012 at 03:11:17PM +, Tim Bunce wrote:
The second patch, which makes DBIS more efficient, is a lot more complex,
and more likely to break things (especially as it's
to
DBIh_SET_ERR_CHAR/DBIc_TRACE, pass the real imp_*h and cast it and
avoid a call to dbih_getcom2?
Yes. imp_xxh_t gives access to those struct elements that are common
to all handles. It's always safe to cast a imp_??h_t to imp_xxh_t.
Tim.
On Fri, Mar 02, 2012 at 03:11:17PM +, Tim Bunce wrote:
The second patch, which makes DBIS more efficient, is a lot more complex,
and more likely to break things (especially as it's changing a bunch of
macros that are directly #included by the DBD drivers. You may need to
bump API
that one's not a problem (and Dave's has reworked the method
cache so it'll change for the next release).
Tim.
On Sat, Feb 25, 2012 at 02:18:56PM -0800, Jonathan Leffler wrote:
On Sat, Feb 25, 2012 at 12:47, Tim Bunce [1]tim.bu...@pobox.com wrote:
DBI 1.618 installed fine for me on MacOS X 10.7.3 with Perl 5.14.1
Great.
I'm slightly puzzled by a couple of the tests skipping because
On Wed, Feb 22, 2012 at 08:40:09PM +, Martin J. Evans wrote:
I've applied Dave's patch and tested in on Windows with Perl 5.8.9
and it now compiles without errors.
Also the patch from Manoj Kumar is applied and this fixes gofer tests.
Great. Thanks Martin.
I'd suggest you (Tim) did one
this may be an issue with ActivePerl.
Tim.
p.s. I wish we had more windows users as cpantesters, especially as automated
smoke testers.
the OS vers (5.1 vs 5.2) may be significant here.
Can anyone help with either of these?
Tim.
p.s. Once these are fixed I'll probably release DBI 1.618 without the
DBIS change as I've not had time to consider that in the detail it needs.
something we've missed.
Driver authors should do likewise.
Tim.
On Thu, Feb 16, 2012 at 02:42:32PM +, Martin J. Evans wrote:
On 16/02/12 12:46, Tim Bunce wrote:
On Tue, Feb 14, 2012 at 02:06:30PM +, Martin J. Evans wrote:
Should we be updating dbipport.h before next release.
I'll do it we think it should be done. I believe we have 3.19 and 3.20
the PERL_ENDING bit.
Just check PL_dirty. That's the one indicating the world is being torn apart.
Tim.
://matrix.cpantesters.org/?dist=DBI+1.617_901
The issue seems to be undefined symbol: mro_meta_init e.g.:
http://www.cpantesters.org/cpan/report/ba083076-540a-11e1-a48f-e7fb434ae6f1
Any ideas?
Tim.
apply it till
we've discussed any issues (which are most likely to be around how to
minimize the pain of synchronized updates of DBI and drivers). It might
even make sense to support both old and new mechanisms for a while.
There's also the mro_meta_init issue.
Tim.
*/
+ HvMROMETA(stash)-cache_gen
#endif
It turns out that the function mro_meta_init wasn't exported in 5.10.0,
only in 5.10.1 onwards. I'll work up a fix.
Now attached.
Thanks Dave.
I've released it as DBI-1.617_903.tar.gz for cpantesters
Tim.
is
called during a CLONE sure seems like a bug worthy of a ticket for p5p.
Thanks Jan!
Tim.
On Fri, Feb 10, 2012 at 03:27:24PM +, Dave Mitchell wrote:
On Thu, Jan 26, 2012 at 12:26:44PM +, Tim Bunce wrote:
I attach two patches; the first replaces dPERINTERP with dMY_THX,
while the second extends this to the DBIS stuff too.
The headline figure (YMMV etc
is not the default.
All tests then pass
I'm sure a patch to the docs, expressing the above, would be welcome.
Tim.
the file handle to binary) but I've not
got around to looking into it.
Any volunteers?
Tim.
reported this
problem in 5.10.1, 5.14.0 and 5.14.2. I can reproduce on my wife's netbook
which is strawberry perl 5.12.0.
As you'll see from the Changes file the only 2 entries added were:
Enhanced performance for threaded perls (Dave Mitchell, Tim Bunce)
Added note to DBI::Profile
On Sun, Feb 05, 2012 at 09:04:23PM +, Dave Mitchell wrote:
On Mon, Jan 30, 2012 at 10:56:37PM +, Tim Bunce wrote:
dbih_getcom2 does the first part of that when looking up DBI hande
magic. I never added the move to the top because I figured it would be
very rare for magic to get
.
You can. You need to pass some extra args to install_method().
Something like install_method(odbc_getdiagrec, { O=0x0004 });
That's the value of the IMA_KEEP_ERR flag. See the #define IMA_*'s in
DBI.xs and the O=... in DBI.pm
Tim.
On Mon, Jan 30, 2012 at 12:48:32PM +, Dave Mitchell wrote:
On Sun, Jan 29, 2012 at 10:06:58PM +, Tim Bunce wrote:
On Sun, Jan 29, 2012 at 06:12:50PM +, Dave Mitchell wrote:
The code itself (see diff below) just attaches some magic to the outer CV
that caches the GV
to thrash out what the docs should say... [starting
in a new thread please]
Tim.
(or DBI?) could provide a way for users to specify
which 'DiagIdentifier's they'd like to have automatically checked for
and appended to errstr. Something like:
$h-{AutoDiagnostics} = [ $SQL_DIAG_COLUMN_NUMBER, $SQL_DIAG_ROW_NUMBER ];
Tim.
much time I
burn on the cache issue, I may have time to look at threaded issues too,
specifically the dPERINTERP rewrite using MY_CXT - assuming that no one
beats me to it!
That would be great. Thanks again Dave.
Dave.
Index: DBI.xs
Looks good.
Tim.
I'd like to make a formal DBI release soon.
DBI-1.616_901 tested well and I've just uploaded DBI-1.616_902.
Any reason I shouldn't upload as DBI-1.617 soon?
Tim.
On Wed, Jan 25, 2012 at 08:17:27PM +, Tim Bunce wrote:
On Wed, Jan 25, 2012 at 04:14:07PM +, Dave Mitchell wrote:
The DBI is always allowed to cheat in the name of performance!
My simple but effective xsbypass hack doesn't seem to have caused
problems in the years it's been
On Fri, Jan 27, 2012 at 03:33:51PM +, Dave Mitchell wrote:
On Fri, Jan 27, 2012 at 02:53:47PM +, Tim Bunce wrote:
On Wed, Jan 25, 2012 at 08:17:27PM +, Tim Bunce wrote:
On Wed, Jan 25, 2012 at 04:14:07PM +, Dave Mitchell wrote:
Just out of curiosity, why can't threaded
On Wed, Jan 25, 2012 at 05:37:13PM -0800, Jan Dubois wrote:
On Wed, 25 Jan 2012, Tim Bunce wrote:
On Wed, Jan 25, 2012 at 04:14:07PM +, Dave Mitchell wrote:
PS - I'm specifically being paid only to fix a performance issue on
non-threaded builds, so I won't be looking at threaded
On Wed, Jan 25, 2012 at 04:14:07PM +, Dave Mitchell wrote:
On Tue, Jan 24, 2012 at 08:42:28PM +, Tim Bunce wrote:
Given that my hacky cache for fetch() lookup reduced overall execution
time by 16.5%, that reduces overall XS_DBI_dispatch percentage from 33.2%
to 16.7%, i.e. nearly
) but is this the intention of DBI?
Yes.
Tim.
is much
faster than creating a new connection. This might provide
a workaround for you.
Would be good if that could be made available via install_method:
$dbh-ora_reauthenticate('', '')
would be both cleaner and, importantly, honour RaiseError etc.
Tim.
On Mon, Nov 28, 2011 at 09:26:02PM -0600, David Nicol wrote:
An annual minor maintenance version release schedule would be cool, in
my opinion.
Maybe. Life's crazy busy at the moment.
Tim.
and smDiskIoIntervalTable.
Perhaps quote the schema indentifier to enable embedded periods:
SELECT * FROM enterprises.smart-snmpd.20.1.smDiskIoTable
Tim [who is happy to know almost nothing about snmp]
can't think of anything better
(treed_ or trd_ were the best I could come up with) so go ahead.
Thanks.
Release early, release often!
Remind me to patch DBI once they're released.
Tim.
On Sun, Nov 13, 2011 at 02:07:25PM +0100, H.Merijn Brand wrote:
On Sun, 13 Nov 2011 10:42:34 +, Tim Bunce tim.bu...@pobox.com,
H.Merijn Brand h.m.br...@xs4all.nl wrote:
On Thu, Nov 10, 2011 at 09:15:43AM -0800, hmbr...@cvs.perl.org wrote:
+} elsif ($driver eq 'Unify
'Unify';
for consistency with the others.
Thanks!
Tim.
into the (recently updated)
version in the DBI svn repo?
Tim.
could report local LANG / LC_ALL env var value
so when others report their results we'll have that context.
Thanks again. I've only given it a quick skim. I'll read it again before LPW.
Meanwhile, it would be great if people could contribute the info for #1.
Tim.
p.s. Using data_diff() http
On Tue, Nov 08, 2011 at 02:45:39PM +, Martin J. Evans wrote:
On 08/11/11 13:16, Tim Bunce wrote:
On Mon, Nov 07, 2011 at 01:37:38PM +, Martin J. Evans wrote:
2. Try to make a data-driven common test script.
There is already one attached to the bottom of the post and referred
On Tue, Oct 04, 2011 at 11:24:51PM +0100, Martin J. Evans wrote:
On 04/10/2011 22:38, Tim Bunce wrote:
I've not had time to devote to this thread. Sorry.
I'd be grateful if someone could post a summary of it if/when it
approaches some kind of consensus.
I don't think there is a kind
::Class, will handle most differences in SQL dialects
for you, and give you a way to include fragments of literal SQL if you
need to.
Tim.
I've not had time to devote to this thread. Sorry.
I'd be grateful if someone could post a summary of it if/when it
approaches some kind of consensus.
Thanks.
Tim.
Would it be an actual DBI driver?
Could you post some examples or docs?
I'm uncomfortable with it having such a generic name.
Two words after the DBD would be better.
Tim.
On Wed, Sep 21, 2011 at 02:58:09AM +, Byrd, Brendan wrote:
I think I'm going to end up going the route of a new
On Wed, Sep 21, 2011 at 03:17:53PM +, Byrd, Brendan wrote:
It basically takes whatever Perl tree object you throw at it and turns
it into a database.
Cool.
Given that description I'd suggest a name like DBD::TreeDataMumble
e.g., DBD::TreeDataWrapper with tdw_ as the prefix.
Tim
the prefix registration?
Yes. The only current use is for the install_method() method.
Tim.
On Mon, Sep 12, 2011 at 01:13:58PM -0700, Darren Duncan wrote:
To be brief, ...
Darren, if you want to do something really directly useful for the DBI
ecosystem I would encorage you (or anyone else) to work on creating a
DBI test suite that's independent of the DBI distribution.
Tim.
p.s. I'm
On Sun, Sep 11, 2011 at 11:25:20PM +0100, Andrew Ford wrote:
I suggest that we move this discussion to dbi-dev.
[dbi-users dropped]
On 11/09/11 18:14, Tim Bunce wrote:
On Fri, Sep 09, 2011 at 03:50:53PM +0100, Andrew Ford wrote:
my $next_middleware = $go_transport-middleware
On Wed, Jun 29, 2011 at 03:28:19PM +0100, Martin J. Evans wrote:
Don't know however, I am inclined to change the error to a warning as Tim
suggested. It simplifies things for people who might be calling fetch on a
non-select. However, it isn't going to happen soon unless someone screams
as an optimization, and code using a DBI
proxy generally doesn't either.
Tim.
On Fri, Jun 10, 2011 at 10:13:09AM -0500, David Nicol wrote:
in my opinion this facility should be formally defined as undefined and a
note should go in the selectall* docs recommending do instead for
non-select SQL.
+1
Patch welcome.
Tim.
Fixed (r14873) Thanks!
Tim.
On Mon, May 23, 2011 at 10:21:13PM +0200, Steffen Winkler wrote:
Hello together,
the error is in a code block:
my $cb = {
‘connect_cached.reused’ = sub { delete $_[4]-{AutoCommit} },
};
^^ ^^
Be greeted from
Steffen
Thanks guys.
Tim.
On Mon, May 16, 2011 at 05:00:48PM -0400, yan...@babyl.dyndns.org wrote:
On Mon, May 16, 2011 at 08:23:55PM +0100, Tim Bunce wrote:
On Fri, May 13, 2011 at 07:07:31PM +0100, Martin J. Evans wrote:
http://www.easysoft.com/dbi.avi
ftp://ftp.easysoft.com/pub/dbi.avi
() then return PL_sv_undef (or whatever's
appropriate for an error).
Tim.
needed to use VLC to watch it.
Any chance someone convert it to .mov?
I could host it somewhere.
Tim.
it to the previous behaviour. I could
have done it the other way around but this default seems more
logical to me.
If you have any comments before I make this change I'd be happy to
hear them.
Sounds good to me. Thanks.
Tim.
is started by either
setting the ‘async’ attribute to a true value
... that should be 'mysql_async'. I.e., the name of the driver-private
attribute should include the drivers prefix.
Please add mysql_async and deprecate async in the next release.
Tim.
be altered to assume utf8
at the client end and have the server or client libs automatically
convert for you? If so, that's a good way to go.
Tim.
On Fri, Mar 11, 2011 at 10:27:16PM +, Martin J. Evans wrote:
On 11/03/2011 16:53, Tim Bunce wrote:
Time's in very short supply at the moment, but if someone can contribute
tests for these (ideally as patches to existing test scripts) then I'll
fix'em as soon as I get a moment.
Both
/Display.html?id=64330
Tim.
by the mg_get(*svp);)
I've no time to dig deeper, sorry. (I'll copy the above to the ticket.)
Tim.
Martin
--
Martin J. Evans
Easysoft Limited
http://www.easysoft.com
On 13/01/11 18:53, Martin J. Evans wrote:
I briefly looked at the DBD::Pg rt ticket
https://rt.cpan.org/Ticket/Display.html?id
Funny (or unfortunate...), I had submitted a patch for
this as well, just two months ago. It's in 1.28 (which right
now is at RC 2).
Fix is similar, only addition is resetting the attributes on bind,
around line 3212 in trunk. (Or it would have gone in line 3058
in 1.26.)
- Tim
Chamberlin
On Sun, Feb 06, 2011 at 02:39:09PM +, Martin J. Evans wrote:
On 06/02/2011 13:00, Tim Bunce wrote:
On Sat, Feb 05, 2011 at 01:27:11PM +, Martin J. Evans wrote:
ok, the 3 new trace flags are in and I added macros (slight shame
you cannot use them in DBI.pm too but not a great deal).
I
On Sun, Feb 06, 2011 at 12:16:33PM +0100, H.Merijn Brand wrote:
On Sat, 5 Feb 2011 12:29:09 +, Tim Bunce tim.bu...@pobox.com
wrote:
As you note above, the current trace settings are encoded into an int:
# 0xddrL (driver, DBI, reserved, Level)
Where L is the DBI
it
out. t/09trace.t could be extended for that purpose. (I'm not sure how
much effort it would be to keep DBI::PurePerl in sync with this work.)
Tim.
a corresponding DBDc_TRACE(...) macro
with an extra driver_level argument. I'm not sure it's worth it,
but then I'm not sure what semantics you're looking for.
Tim.
On Fri, Feb 04, 2011 at 08:00:13PM +, Martin J. Evans wrote:
Tim,
At the LPW I think I promised to add connection and encoding trace
flags to DBI which add to the already existing SQL flag. I never got
around to it and Merijn reminded me today on #dbi. The change is
trivial and once
.
Tim.
On Tue, Feb 01, 2011 at 09:02:26PM +, Martin J. Evans wrote:
On 01/02/2011 20:50, Tim Bunce wrote:
On Tue, Feb 01, 2011 at 10:58:14AM -0500, John Scoles wrote:
My only concern is when it does error (no matter what the setting of
AutoCommit) you always get unef;
Umm, yes. Returning undef
but it requires Multiple
# Active Statements and although I can find ODBC drivers which do this
# it is not easy (if at all possible) to know if an ODBC driver can
# handle MAS or not.
Perhaps try to run it and if it gets an error, and the error indicates
lack of MAS, then skip the test.
Tim
of affected rows should not sum a load of
-1s affected to be -N.
Yes. The spec ought to say that if any tuple gets a -1 then -1 gets
returned as the 'sum', even if other tuples return other values.
Tim.
On Tue, Feb 01, 2011 at 10:58:14AM -0500, John Scoles wrote:
On 01/02/2011 10:48 AM, Tim Bunce wrote:
On Mon, Jan 31, 2011 at 08:39:40PM +, Martin J. Evans wrote:
I imagine most DBDs [if not all] that implement execute_array
[Just a reminder that drivers can opt to implement just
have as a prerequisite. That would contain tests in
modules. The DBI and DBDs would have a test file that uses the
DBI::TestSuite module and calls a function that runs the tests.
This issue could provide the first test.
Tim.
it is not
wrong.
Agreed. There may be room for practical improvements if there are clear
problems with the current behavior.
Tim.
, and editorial work is needed.
Anyone fancy tackling that?
Tim.
Cheers
John Scoles
On Tue, Dec 14, 2010 at 10:39 AM, Tim Oertel t...@samasher.com
mailto:t...@samasher.com wrote:
Hi,
We were recently trying to pass an array to a stored procedure.
It worked fine the first call, but subsequent calls were receiving
the wrong array size
Great. Thanks Martin.
Tim.
On Tue, Dec 14, 2010 at 03:26:41PM +, Martin J. Evans wrote:
On 13/12/10 21:00, Tim Bunce wrote:
On Mon, Dec 13, 2010 at 05:30:10PM +, Martin J. Evans wrote:
See RT http://rt.cpan.org/Public/Bug/Display.html?id=63550 which started
this off.
DBD
, also running on
Linux.
If I've screwed up formatting, or need to do this differently, let me
know, and I'll try to fix it. If the fixes are wrong, I'm all ears
on that too.
--
Tim Oertel |Why should I be content to simply
VP Engineering | live in this world, when I, as a
Ashergroup, Inc
selfish reasons so thanks for that:)
It will be going into 1.28 as 1.27 is reserved for a PERL_POLLUTE release which
should be out soon
Cheers
John Scoles
On 14/12/2010 10:39 AM, Tim Oertel wrote:
Hi,
We were recently trying to pass an array to a stored procedure.
It worked fine the first call
.
The docs for drivers using this approach should note the fact that a
statement handle isn't created, and that error handlers like HandleErr
will be called with the $dbh.
Tim.
the default
path lightweight seems worthwhile:
local @SIG{ @{ $attr-{ora_local_signals}||[] } }
if $attr-{ora_local_signals};
Tim
On Sun, Nov 07, 2010 at 08:14:47PM +, Tim Bunce wrote:
I have to say I would be strongly against returning all signals to
their original state after a connect call. I know for a fact that
some oracle clients (depending on how you connect to Oracle) install
a SIGCHLD handler
be provided to restore the current unreasonable way.
Tim.
On Wed, Nov 03, 2010 at 09:13:38PM -0400, Rudy Lippan wrote:
Hi Tim, al.,
I am working on writing a DBD for mongoDB, but before I get too far into
the code, I'd like to get an official prefix for it. I am leaning
towards 'hu_'* this way I won't have to worry about any of my names
On Mon, Aug 30, 2010 at 07:28:31AM -0400, John Scoles wrote:
Tim Bunce wrote:
Looks like DBD::Oracle as PERL_POLLUTE as well.
Lucy!!! You have some renaming to do!!!
A project of 1.26 perhaps
As 5.13.x comes closer to being 5.14 this issue is becoming more urgent.
John, I've asked s
have deleted it :)
Thanks!
Tim.
when it is never retrieved
in the script? I don't think it used to (perhaps a long time ago).
What does trace show?
Tim.
Try r14463 :)
Tim.
p.s. The redundant FETCH has been happening for years.
On Wed, Oct 06, 2010 at 07:15:03PM +0100, Martin J. Evans wrote:
Hi,
Hoping someone can help me identify what might be going on here but
it looks to me like something in DBI has changed.
use strict;
use DBI
On Tue, Sep 21, 2010 at 10:35:16PM +0200, Jens Rehsack wrote:
2010/9/21 Tim Bunce tim.bu...@pobox.com:
Tim suggest that Pure-Perl DBD development can happen in branches and
they should be merged into the trunk when they are ready. Well, I had
merged the state of r14409, because I rated
a dev release from the branch.
If that tests well I'll merge it into the trunk.
Does that sound ok?
Tim.
:)
Probably we need more branches - depending on the task, let's
see.
Tim, would it be OK to release dev versions of `other' branches to CPAN?
So the CPANTESTERS can pick up what goes wrong
Yes. That's what I meant by:
When the SqlEngine team is ready to release it can merge in the latest
trunk
worth it.
Tim suggest that Pure-Perl DBD development can happen in branches and
they should be merged into the trunk when they are ready. Well, I had
merged the state of r14409, because I rated it ready, but I hadn't merge a
day before a final release.
I'm not sure what you're saying here
On Wed, Sep 15, 2010 at 03:41:36PM +0200, Jens Rehsack wrote:
2010/9/15 Tim Bunce tim.bu...@pobox.com:
On Mon, Aug 09, 2010 at 10:13:03PM +0300, Gabor Szabo wrote:
The next European PostgreSQL day is going to be between 6-8 December
in Stuttgart, Germany. http://www.pgday.eu/
It seems
On Mon, Sep 20, 2010 at 02:45:27PM +0200, Jens Rehsack wrote:
2010/9/19 Craig A. Berry craigbe...@mac.com:
In article 20100911171359.gb2...@timac.local,
tim.bu...@pobox.com (Tim Bunce) wrote:
On Thu, Sep 09, 2010 at 06:05:09PM -0500, Craig A. Berry wrote:
In article 4c88ecbf.8040
conventions).
Tim.
the code to github to make it easier, presumably, for
others to work together on branches without affecting the mainline.)
Tim.
On Thu, Sep 16, 2010 at 01:59:36PM -0700, rehs...@cvs.perl.org wrote:
Author: REHSACK
Date: Thu Sep 16 13:59:35 2010
New Revision: 14409
Modified:
dbi/trunk/lib
301 - 400 of 1464 matches
Mail list logo
