Bug#715461: Bug#718129: Re: Re: Bug#715461: libsdl-mixer1.2: no sf2 sound fonts loaded by default

2013-10-09 Thread Manuel A. Fernandez Montecelo
Hi, I just uploaded another fix for this in -9, thanks Fabian. http://anonscm.debian.org/gitweb/?p=pkg-sdl/packages/sdl-mixer1.2.git;a=commitdiff;h=396542188f997d14a066d8ddcb4007ca72667509 If you could check it when you have the opportunity and report here that everything works as expected, it

Bug#715461: Bug#718129: Re: Re: Bug#715461: libsdl-mixer1.2: no sf2 sound fonts loaded by default

2013-09-13 Thread Manuel A. Fernandez Montecelo
2013/9/1 Fabian Greffrath fab...@greffrath.com: In the patch for debian/rules the quotation marks have to get escaped. This somehow got lost by attaching it to my mail. Sorry for the delay but I'm quite busy at the moment. I will try to review and get this new patch integrated soonish.

Bug#715461: Bug#718129: Re: Re: Bug#715461: libsdl-mixer1.2: no sf2 sound fonts loaded by default

2013-09-01 Thread Fabian Greffrath
Am Freitag, den 30.08.2013, 11:50 +0100 schrieb Manuel A. Fernandez Montecelo: Do you think that it could be modified to be less system dependent, in a way that it would be accepted upstream? Perhaps passing it at compilation time, instead of having to patch or export at runtime? How about

Bug#715461: Bug#718129: Re: Re: Bug#715461: libsdl-mixer1.2: no sf2 sound fonts loaded by default

2013-09-01 Thread Fabian Greffrath
In the patch for debian/rules the quotation marks have to get escaped. This somehow got lost by attaching it to my mail. - Fabian -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#715461: Bug#718129: Re: Re: Bug#715461: libsdl-mixer1.2: no sf2 sound fonts loaded by default

2013-08-30 Thread Manuel A. Fernandez Montecelo
2013/8/26 Fabian Greffrath fab...@greffrath.com: Am Dienstag, den 20.08.2013, 09:58 +0200 schrieb Fabian Greffrath: Yes, it does. However, I would have added a check if the pointer is already set prior to resetting it, e.g. if (!soundfont_paths) soundfont_paths = SDL_strdup(...); But this

Bug#715461: Bug#718129: Re: Re: Bug#715461: libsdl-mixer1.2: no sf2 sound fonts loaded by default

2013-08-26 Thread Fabian Greffrath
Am Dienstag, den 20.08.2013, 09:58 +0200 schrieb Fabian Greffrath: Yes, it does. However, I would have added a check if the pointer is already set prior to resetting it, e.g. if (!soundfont_paths) soundfont_paths = SDL_strdup(...); But this is really just nit-picking. Wait, does

Bug#715461: Bug#718129: Re: Re: Bug#715461: libsdl-mixer1.2: no sf2 sound fonts loaded by default

2013-08-20 Thread Fabian Greffrath
Sorry for my late response, I have been on vacation last week. Am Montag, den 12.08.2013, 00:29 +0100 schrieb Manuel A. Fernandez Montecelo: So... does this look OK to both of you (I didn't actually upload, waiting for your confirmation)? Yes, it does. However, I would have added a check if

Bug#715461: Re: Bug#718129: Re: Re: Bug#715461: libsdl-mixer1.2: no sf2 sound fonts loaded by default

2013-08-12 Thread Dominique Dumont
On Monday 12 August 2013 00:29:34 Manuel A. Fernandez Montecelo wrote: So... does this look OK to both of you (I didn't actually upload, waiting for your confirmation)? Looks good. SDL-perl tests are fine with your updated patch All the best signature.asc Description: This is a digitally

Bug#715461: Re: Bug#718129: Re: Re: Bug#715461: libsdl-mixer1.2: no sf2 sound fonts loaded by default

2013-08-12 Thread Manuel A. Fernandez Montecelo
2013/8/12 Dominique Dumont d...@debian.org: On Monday 12 August 2013 00:29:34 Manuel A. Fernandez Montecelo wrote: So... does this look OK to both of you (I didn't actually upload, waiting for your confirmation)? Looks good. SDL-perl tests are fine with your updated patch All the best

Bug#715461: Bug#718129: Re: Re: Bug#715461: libsdl-mixer1.2: no sf2 sound fonts loaded by default

2013-08-11 Thread Manuel A. Fernandez Montecelo
2013/8/9 Dominique Dumont d...@debian.org: On Thursday 08 August 2013 19:13:24 Manuel A. Fernandez Montecelo wrote: I meant to modify the first patch bug-715461-soundfont_paths.patch so when that variable soundfont_paths is assigned, it's done with SDL_strdup() (it's done in several places in

Bug#715461: Re: Re: Bug#715461: libsdl-mixer1.2: no sf2 sound fonts loaded by default

2013-08-09 Thread Dominique Dumont
On Thursday 08 August 2013 19:13:24 Manuel A. Fernandez Montecelo wrote: I meant to modify the first patch bug-715461-soundfont_paths.patch so when that variable soundfont_paths is assigned, it's done with SDL_strdup() (it's done in several places in the code --that's where I got the idea

Bug#715461: Re: Bug#715461: libsdl-mixer1.2: no sf2 sound fonts loaded by default

2013-08-08 Thread Dominique Dumont
On Wednesday 07 August 2013 22:13:49 you wrote: For example, one fix that comes to mind is to change the line in the first patch: char* soundfont_paths = /usr/share/sounds/sf2/TimGM6mb.sf2:/usr/share/sounds/sf2/FluidR3_GM.sf2; to this: char* soundfont_paths =

Bug#715461: Re: Bug#715461: libsdl-mixer1.2: no sf2 sound fonts loaded by default

2013-08-08 Thread Manuel A. Fernandez Montecelo
2013/8/8 Dominique Dumont d...@debian.org: On Wednesday 07 August 2013 22:13:49 you wrote: For example, one fix that comes to mind is to change the line in the first patch: char* soundfont_paths = /usr/share/sounds/sf2/TimGM6mb.sf2:/usr/share/sounds/sf2/FluidR3_GM.sf2; to this: char*

Bug#715461: AW: Re: Re: Bug#715461: libsdl-mixer1.2: no sf2 sound fonts loaded by default

2013-08-08 Thread Fabian Greffrath
...@greffrath.com,715...@bugs.debian.org,718...@bugs.debian.org Betreff: Re: Re: Bug#715461: libsdl-mixer1.2: no sf2 sound fonts loaded by default 2013/8/8 Dominique Dumont d...@debian.org: On Wednesday 07 August 2013 22:13:49 you wrote: For example, one fix that comes to mind is to change

Bug#715461: libsdl-mixer1.2: no sf2 sound fonts loaded by default

2013-08-07 Thread Manuel A. Fernandez Montecelo
Hi, For reference, I think that bug-715461-soundfont_paths.patch created the recent problem in #718129. Instead of adding another patch (the one fixing #718129, included in revision -7 of the package), perhaps the pach to include soundfonts can be modified to avoid having the second one. I

Bug#715461: libsdl-mixer1.2: no sf2 sound fonts loaded by default

2013-08-07 Thread Fabian Greffrath
Am Mittwoch, den 07.08.2013, 22:13 +0100 schrieb Manuel A. Fernandez Montecelo: char* soundfont_paths = SDL_strdup(/usr/share/sounds/sf2/TimGM6mb.sf2:/usr/share/sounds/sf2/FluidR3_GM.sf2); What do you think? Feels less intrusive than having a second patch. Good idea! Feels much cleaner

Bug#715461: libsdl-mixer1.2: no sf2 sound fonts loaded by default

2013-07-12 Thread Fabian Greffrath
Am Donnerstag, den 11.07.2013, 14:47 +0100 schrieb Manuel A. Fernandez Montecelo: I'm going to upload the fixes now, would you please test if it's working as you expect when you have some time availale? I'd say it works exactly as expected. Thanks for the prompt upload! :) - Fabian -- To

Bug#715461: libsdl-mixer1.2: no sf2 sound fonts loaded by default

2013-07-12 Thread Manuel A. Fernandez Montecelo
2013/7/12 Fabian Greffrath fab...@greffrath.com: Am Donnerstag, den 11.07.2013, 14:47 +0100 schrieb Manuel A. Fernandez Montecelo: I'm going to upload the fixes now, would you please test if it's working as you expect when you have some time availale? I'd say it works exactly as expected.

Bug#715461: libsdl-mixer1.2: no sf2 sound fonts loaded by default

2013-07-11 Thread Manuel A. Fernandez Montecelo
Hi Fabian, Thanks for the reports and the fixes. 2013/7/9 Fabian Greffrath fab...@greffrath.com: Recommends: musescore-soundfont-gm, fluid-soundfont-gm, freepats This again is alternative dependencies, right? Recommends: musescore-soundfont-gm | fluid-soundfont-gm | freepats Cheers. --

Bug#715461: libsdl-mixer1.2: no sf2 sound fonts loaded by default

2013-07-11 Thread Fabian Greffrath
Am Donnerstag, den 11.07.2013, 12:37 +0100 schrieb Manuel A. Fernandez Montecelo: This again is alternative dependencies, right? Recommends: musescore-soundfont-gm | fluid-soundfont-gm | freepats Yes, sure, sorry. I am still not sure, however, if fluid-soundfont-gm should get precedence over

Bug#715461: libsdl-mixer1.2: no sf2 sound fonts loaded by default

2013-07-11 Thread Manuel A. Fernandez Montecelo
2013/7/11 Fabian Greffrath fab...@greffrath.com: Am Donnerstag, den 11.07.2013, 12:37 +0100 schrieb Manuel A. Fernandez Montecelo: This again is alternative dependencies, right? Recommends: musescore-soundfont-gm | fluid-soundfont-gm | freepats Yes, sure, sorry. I am still not sure,

Bug#715461: libsdl-mixer1.2: no sf2 sound fonts loaded by default

2013-07-11 Thread Fabian Greffrath
Am Donnerstag, den 11.07.2013, 14:47 +0100 schrieb Manuel A. Fernandez Montecelo: There are patches doing something similar with freepats for ages, so I think that it's sensible to try this route with better quality sound. Yes, I know that patch. ;) I'm going to upload the fixes now, would

Bug#715461: libsdl-mixer1.2: no sf2 sound fonts loaded by default

2013-07-09 Thread Fabian Greffrath
Package: libsdl-mixer1.2 Version: 1.2.12-5 Severity: normal Hello, the current version of libsdl-mixer1.2 is able to use fluidsynth for midi playback, which is far superior compared to the embedded copy of timidity which relies on sound fonts in the obsolete pat format (and thus requires the

Bug#715461: libsdl-mixer1.2: no sf2 sound fonts loaded by default

2013-07-09 Thread Fabian Greffrath
Am Dienstag, den 09.07.2013, 11:07 +0200 schrieb Fabian Greffrath: + Recommends: musescore-soundfont-gm, fluid-soundfont-gm, freepats Recommends: musescore-soundfont-gm | freepats Of course, these should be alternative dependencies. I have dropped fluid-soundfont-gm, see below: + char*

Bug#715461: libsdl-mixer1.2: no sf2 sound fonts loaded by default

2013-07-09 Thread Fabian Greffrath
tags -1 + patch Am Dienstag, den 09.07.2013, 11:48 +0200 schrieb Fabian Greffrath: The Mix_EachSoundFont() function return()s when one of the passed sound font files cannot be handled. So instead of requiring both sound fonts to be installed, let's concentrate on one instead (I have decided