Bug#883840: RFS: spglib/1.10.3-1 [ITP]

2018-04-23 Thread Andrius Merkys
On 04/23/2018 06:43 PM, Lumin wrote: > Oh, I forgot to tell you that the failure is due to output to stderr. > By redirecting > the stderr to e.g. stdout, this failure can be fixed. Thanks for pointing this out :) I had similar idea, but it would have taken me much longer to solve it. > Please

Bug#883840: RFS: spglib/1.10.3-1 [ITP]

2018-04-23 Thread Lumin
On 23 April 2018 at 14:11, Andrius Merkys wrote: >> 6. tests: your autopkgtest testsuite failed: > > I will look into this. It is possible that I invoke the Python tests > incorrectly. Oh, I forgot to tell you that the failure is due to output to stderr. By redirecting

Bug#883840: RFS: spglib/1.10.3-1 [ITP]

2018-04-23 Thread Andrius Merkys
Dear Lumin, many thanks for reviewing the package! Please find my comments in-line. On 04/23/2018 10:35 AM, Lumin wrote: > 1. There seems to be ruby binding available, why isn't it packaged? I have too little experience with Ruby. However, I will look at how to package it. > 2. control: Your

Bug#883840: RFS: spglib/1.10.3-1 [ITP]

2018-04-23 Thread Lumin
control: owner -1 ! control: tag -1 +moreinfo Hi Andrius, Thank you for the package. Here are some nitpicking about your package: 1. There seems to be ruby binding available, why isn't it packaged? 2. control: Your -dev package should also depend on the lib package. Depends: