Bug#825693: RFS: nlohmann-json/1.1.0-1 [ITP]

2016-06-18 Thread Muri Nicanor
hi, On 06/17/2016 03:03 PM, Andrey Rahmatullin wrote: > "No embedded code copies" is not a blind rule, it has its reasons, and I > think none of them applies here. It would be nice to use the Debian copy > after it is updated but I don't think it's a blocker. oke, sounds like a good plan > If

Bug#825693: RFS: nlohmann-json/1.1.0-1 [ITP]

2016-06-17 Thread Andrey Rahmatullin
Control: owner -1 ! On Fri, Jun 17, 2016 at 02:56:13PM +0200, Muri Nicanor wrote: > i'm not exactly sure how to proceed here. catch.hpp is 'only' used for > the unit tests, but nevertheless its an embedded code copy. i guess the > correct way would be to ask for (via bug report?) or create an

Bug#825693: RFS: nlohmann-json/1.1.0-1 [ITP]

2016-06-17 Thread Muri Nicanor
thanks for the explanation, andrey and christian- i did indeed not know that the repackaging has to be done by uscan before the build (i thought that was done during pdebuild). in the end the Files-Excluded field worked which lead to the unit tests not being successful (the catch.hpp is only used

Bug#825693: RFS: nlohmann-json/1.1.0-1 [ITP]

2016-06-13 Thread Andrey Rahmatullin
On Mon, Jun 13, 2016 at 05:06:55PM +0200, Muri Nicanor wrote: > > debian/copyright: > > It has Files-Excluded: test/catch.hpp but the tarball still contains this > > file. > i don't know what i'm doing wrong. i've tried multiple sytaxes, but the > file somehow resists of being excluded of the

Bug#825693: RFS: nlohmann-json/1.1.0-1 [ITP]

2016-06-13 Thread Christian Seiler
Am 2016-06-13 17:06, schrieb Muri Nicanor: On 06/13/2016 02:35 PM, Andrey Rahmatullin wrote: debian/copyright: It has Files-Excluded: test/catch.hpp but the tarball still contains this file. i don't know what i'm doing wrong. i've tried multiple sytaxes, but the file somehow resists of being

Bug#825693: RFS: nlohmann-json/1.1.0-1 [ITP]

2016-06-13 Thread Muri Nicanor
Hi Andrey, thank you for your review! On 06/13/2016 02:35 PM, Andrey Rahmatullin wrote: > debian/nlohmann-json-dev.doc-base: > "Document: json" is too generic, remember it must be unique. fixed, it matches the package name nonw > debian/rules: > There is too many commented out dh_make example

Bug#825693: RFS: nlohmann-json/1.1.0-1 [ITP]

2016-06-13 Thread Andrey Rahmatullin
Control: tags -1 + moreinfo Here are some notes about the packaging: debian/nlohmann-json-dev.doc-base: "Document: json" is too generic, remember it must be unique. debian/rules: There is too many commented out dh_make example lines, you should remove them if you don't need them.

Bug#825693: RFS: nlohmann-json/1.1.0-1 [ITP]

2016-05-28 Thread Muri Nicanor
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package "nlohmann-json" * Package name: nlohmann-json Version : 1.1.0-1 Upstream Author : Niels Lohmann * URL : https://github.com/nlohmann/json * License : MIT