Bug#832941: RFS: 4pane

Dear Sean, >Sorry, I assumed that uscan would redownload the .pgp file, but it was >using the old one. Apologies for wasting your time with that. That's OK, I've wasted plenty of yours ;) >While you previously said that everything remaining in .build/ is your >own work, the file wxwin.m4 is

Bug#832941: RFS: 4pane

Dear David, On Tue, Mar 28, 2017 at 01:36:03PM +0100, David Hart wrote: > Hmm, I can't make it fail here. e.g. Sorry, I assumed that uscan would redownload the .pgp file, but it was using the old one. Apologies for wasting your time with that. While you previously said that everything

Bug#832941: RFS: 4pane

Dear Sean, >I can't review your latest work because the PGP signature for the >tarball fails to verify: >iris ~/rfs/4pane % origtargz -u >W: Unable to locate package 4pane >Trying uscan --download-current-version ... >uscan: Newest version of 4pane on remote site is 4.0, specified

Bug#832941: RFS: 4pane

Dear David, I can't review your latest work because the PGP signature for the tarball fails to verify: iris ~/rfs/4pane % origtargz -u W: Unable to locate package 4pane Trying uscan --download-current-version ... uscan: Newest version of 4pane on remote site is 4.0, specified

Bug#832941: RFS: 4pane

Dear Sean, >>> Files in .build/ remain, and are not given in d/copyright. >> The remaining ones are my own files. Won't they be covered by '*'? >Oh, sorry, I assumed you hadn't written 4pane.m4. Not so many people >know m4, as I understand it :) I believe you; it's not my idea of light

Bug#832941: RFS: 4pane

Dear David, On Wed, Mar 15, 2017 at 11:37:58AM +, David Hart wrote: > >- Various stanzas do not include the copyright years, yet these are > > available in the files. The Copyright: field is meant to contain the > > copyright claim as it was stated by the upstream author.. > > May I ask

Bug#832941: RFS: 4pane

Dear Sean, >Hopefully a final review (of b74e630): >- your copyright on debian/ is out-of-date -- you need s/2016/2017/ >By the way, you can merge the '*' and 'debian/*' stanzas. Done >- Various stanzas do not include the copyright years, yet these are > available in the files. The

Bug#832941: RFS: 4pane

Dear David, Hopefully a final review (of b74e630): - you forgot `dch -r` - your copyright on debian/ is out-of-date -- you need s/2016/2017/ By the way, you can merge the '*' and 'debian/*' stanzas. - Files: bitmaps/iceweasel.png Copyright: Uncertain Files: bitmaps/kedit.xpm Copyright:

Bug#832941: RFS: 4pane

Dear Sean, >Unfortunately, your watch file still isn't working: > >hephaestus ~/rfs/4pane-debian-dir % uscan --download-current-version >uscan warn: In debian/watch no matching hrefs for version 4.0 in watch line > http://www.4Pane.co.uk/4pane-(.*)\.tar\.gz Ah, I wasn't testing with

Bug#832941: RFS: 4pane

Dear David, Unfortunately, your watch file still isn't working: hephaestus ~/rfs/4pane-debian-dir % uscan --download-current-version uscan warn: In debian/watch no matching hrefs for version 4.0 in watch line http://www.4Pane.co.uk/4pane-(.*)\.tar\.gz Remember that by default,

Bug#832941: RFS: 4pane

Dear Sean, >> I've uploaded a +dfsg tarball to the 4Pane website and altered d/watch to >> download it. uscan and lintian seem happy, so hopefully I've done this >> correctly. > >This won't work because your changelog still has 4.0-1 as the version >number.. >While we're at it, why do you have an

Bug#832941: RFS: 4pane

Dear David, On Wed, Mar 08, 2017 at 09:10:26PM +, David Hart wrote: > I've uploaded a +dfsg tarball to the 4Pane website and altered d/watch to > download it. uscan and lintian seem happy, so hopefully I've done this > correctly. This won't work because your changelog still has 4.0-1 as the

Bug#832941: RFS: 4pane

Dear Sean, >I've just reviewed revision 5e12184 of your packaging repository, and >compared it against the points of my previous review. I'm happy to see >that almost everything was handled. I also built and installed the >package and tried out 4Pane. > >There are two remaining issues. > >1)

Bug#832941: RFS: 4pane

Dear David, Thank you for your updated package! I've just reviewed revision 5e12184 of your packaging repository, and compared it against the points of my previous review. I'm happy to see that almost everything was handled. I also built and installed the package and tried out 4Pane. There

Bug#832941: RFS: 4pane

Dear Sean, I'd not lost interest, just slowed down during the stretch freeze. I've now uploaded an altered d/ >> Many thanks for the offer. I don't mind packaging Bakefile, and it shouldn't >> be difficult to do. >> >> However will it be accepted into debian? The project is moribund... >> Do

Bug#832941: RFS: 4pane (debian: to exclusive)

On Sun, Dec 25, 2016 at 3:53 AM, David Hart wrote: > However will it be accepted into debian? The project is moribund: apart from a > single commit 3 years ago, it's been unmaintained for 6 years. That was > supposed to give time for a rewrite which hasn't happened. I might be a good idea for

Bug#832941: RFS: 4pane (debian: to exclusive)

Hello David, On Sat, Dec 24, 2016 at 07:53:09PM +, David Hart wrote: > Many thanks for the offer. I don't mind packaging Bakefile, and it shouldn't > be > difficult to do. > > However will it be accepted into debian? The project is moribund: apart from a > single commit 3 years ago, it's

Bug#832941: RFS: 4pane (debian: to exclusive)

Dear Sean, >Thank you for revising your work in light of my review. We're too late >to get 4Pane into stretch, so there's no longer any time pressure on >this review process. I know. It missed the jessie freeze too ;) >So I'd like to reply regarding only the Bakefile >issue, since that's the

Bug#832941: RFS: 4pane (debian: to exclusive)

Dear David, Thank you for revising your work in light of my review. We're too late to get 4Pane into stretch, so there's no longer any time pressure on this review process. So I'd like to reply regarding only the Bakefile issue, since that's the biggest blocker to uploading this. Once we've

Bug#832941: RFS: 4pane (debian: to exclusive)

Dear Sean, Many thanks for your further input. >Here's another review, based on your 4pane-debian-dir repo. >Must-fixes >1. At least one of the files added by AddExtraM4Files.patch isn't accounted >for in d/copyright. //snip >9. Lots of files in .build/ are not accounted for in d/copyright.

Bug#832941: RFS: 4pane (debian: to exclusive)

Dear David, Here's another review, based on your 4pane-debian-dir repo. Must-fixes -- 1. At least one of the files added by AddExtraM4Files.patch isn't accounted for in d/copyright. 2. Vcs-* still point to the upstream code, not your 4pane-debian-dir repo. 3. d/copyright says that

Bug#832941: RFS: 4pane (debian: to exclusive)

Dear Sean, >1. Why do you have a folder full of patches, when you are the upstream >author of 4Pane? Have they been applied upstream, but there hasn't been >a release of 4Pane recently? Yes. They are implementing your previous suggestions. There hasn't been a recent 4Pane release and, unless

Bug#832941: RFS: 4pane (debian: to exclusive)

Dear David, 1. Why do you have a folder full of patches, when you are the upstream author of 4Pane? Have they been applied upstream, but there hasn't been a release of 4Pane recently? DEP-3 has a patch header to indicate that they have been merged upstream, if this is indeed the case. 2. I see

Bug#832941: RFS: 4pane (debian: to exclusive)

Dear Sean, >> >I'd recommend including the upstream code in the git repository, too. >> >But what you've done is fine -- thanks! >> >> I've now added that too. > >I think you misunderstood what I was suggesting. I'm certain I did ;) >You've committed the >tarball to git, but I meant adding the

Bug#832941: RFS: 4pane

Dear David, On Wed, Nov 09, 2016 at 05:17:29PM +, David Hart wrote: > Dear Sean, > > Thank you for your comments. > > >I'd recommend including the upstream code in the git repository, too. > >But what you've done is fine -- thanks! > > I've now added that too. I think you misunderstood

Bug#832941: RFS: 4pane

Dear Sean, Thank you for your comments. >I'd recommend including the upstream code in the git repository, too. >But what you've done is fine -- thanks! I've now added that too. >> >12. Please consider using dh_autoreconf to ensure that the package's >> >build system can be reproduced from the

Bug#832941: RFS: 4pane (debian: message 7 of 20)

On Sat, Oct 08, 2016 at 09:37:48AM -0700, Sean Whitton wrote: > On Fri, Sep 30, 2016 at 03:40:33PM +0100, David Hart wrote: > > >2. Why doesn't 4pane work on archs other than i386, amd64, hurd-i386? > > I didn't think it would. However after discussion on debian-mentors I've now > > shown it works

Bug#832941: RFS: 4pane (debian: message 7 of 20)

Dear David, A few comments on your reply. On Fri, Sep 30, 2016 at 03:40:33PM +0100, David Hart wrote: > >2. Why doesn't 4pane work on archs other than i386, amd64, hurd-i386? > I didn't think it would. However after discussion on debian-mentors I've now > shown it works on armel, and it builds

Bug#832941: RFS: 4pane (debian: message 7 of 20)

Dear Sean, Many thanks for taking the time to write such a detailed review. Of the must-fixes: >1. The changelog should contain exactly one entry, closing the ITP. Ah, that not only makes sense but is easier. Done. >2. Why doesn't 4pane work on archs other than i386, amd64, hurd-i386? I didn't

Bug#832941: RFS: 4pane

control: tag -1 +moreinfo control: owner -1 ! Dear David, Thank you for your work to bring this new package to Debian! I can't sponsor the upload, but I hope this review is useful to you. I've split it into two sections: things that I would consider must-fixes before an upload to Debian, and

Bug#832941: RFS: 4pane [ITP] (updated package)

Package: sponsorship-requests Severity: wishlist Dear mentors, I am looking for a sponsor for my package "4pane" * Package name: 4pane Version : 4.0-1 Upstream Author : David Hart * URL : http://4Pane.co.uk * License : GPL3