[jira] Created: (DERBY-3276) Order by on aggregate always does a sort even if the sort is not needed.

2007-12-14 Thread Manish Khettry (JIRA)
Order by on aggregate always does a sort even if the sort is not needed. Key: DERBY-3276 URL: https://issues.apache.org/jira/browse/DERBY-3276 Project: Derby Issue

[jira] Commented: (DERBY-3231) Sorting on COUNT with OR and GROUP BY delivers wrong results.

2007-12-14 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551905 ] Manish Khettry commented on DERBY-3231: --- DERBY-3236. Mike, I'll take a look at DERBY-3257. Sorting on

[jira] Issue Comment Edited: (DERBY-3231) Sorting on COUNT with OR and GROUP BY delivers wrong results.

2007-12-14 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551905 ] mkhettry edited comment on DERBY-3231 at 12/14/07 11:18 AM: -- DERBY-3276 Mike,

[jira] Commented: (DERBY-3231) Sorting on COUNT with OR and GROUP BY delivers wrong results.

2007-12-12 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551194 ] Manish Khettry commented on DERBY-3231: --- Well, I thought it was better to fix the wrong results and look at

[jira] Commented: (DERBY-3231) Sorting on COUNT with OR and GROUP BY delivers wrong results.

2007-12-12 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551206 ] Manish Khettry commented on DERBY-3231: --- I did not look into the phantom column behavior; just getting rid of

[jira] Commented: (DERBY-3231) Sorting on COUNT with OR and GROUP BY delivers wrong results.

2007-12-11 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12550648 ] Manish Khettry commented on DERBY-3231: --- I ran the junit lang suite. 1. Prior to 681, the query would get

[jira] Updated: (DERBY-3231) Sorting on COUNT with OR and GROUP BY delivers wrong results.

2007-12-10 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manish Khettry updated DERBY-3231: -- Attachment: order_by_bug.diff.txt Sorting on COUNT with OR and GROUP BY delivers wrong

[jira] Updated: (DERBY-3231) Sorting on COUNT with OR and GROUP BY delivers wrong results.

2007-12-10 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manish Khettry updated DERBY-3231: -- Derby Info: [Patch Available, Existing Application Impact, Regression] (was: [Regression,

[jira] Commented: (DERBY-3231) Sorting on COUNT with OR and GROUP BY delivers wrong results.

2007-12-10 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12550273 ] Manish Khettry commented on DERBY-3231: --- The problem was missing methods isConstant and isConstantExpression

[jira] Assigned: (DERBY-2457) Use of column aliases in group by / having clauses can cause queries to fail

2007-12-05 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manish Khettry reassigned DERBY-2457: - Assignee: (was: Manish Khettry) Don't have the time to look into this right now.

[jira] Assigned: (DERBY-3231) Sorting on COUNT with OR and GROUP BY delivers wrong results.

2007-12-04 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manish Khettry reassigned DERBY-3231: - Assignee: Manish Khettry Sorting on COUNT with OR and GROUP BY delivers wrong results.

[jira] Commented: (DERBY-3231) Sorting on COUNT with OR and GROUP BY delivers wrong results.

2007-12-04 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12548551 ] Manish Khettry commented on DERBY-3231: --- Interestingly if you leave out the where clause, the query works just

[jira] Issue Comment Edited: (DERBY-3231) Sorting on COUNT with OR and GROUP BY delivers wrong results.

2007-12-04 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12548557 ] mkhettry edited comment on DERBY-3231 at 12/4/07 10:58 PM: - A.B, did this query work

[jira] Commented: (DERBY-3231) Sorting on COUNT with OR and GROUP BY delivers wrong results.

2007-12-04 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12548557 ] Manish Khettry commented on DERBY-3231: --- A.B, did this query work before svn revision 516454? Sorting on

[jira] Commented: (DERBY-3050) Convert groupBy.sql tests to JUnit and include them in GroupByTest.java

2007-09-07 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-3050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12525779 ] Manish Khettry commented on DERBY-3050: --- A few thoughts on the test case. 1. The testcase creates and drops

[jira] Commented: (DERBY-2911) Implement a buffer manager using java.util.concurrent classes

2007-09-04 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12524802 ] Manish Khettry commented on DERBY-2911: --- One thought on the ConcurrentCache class. Since this is a Java 5

[jira] Commented: (DERBY-3024) Validation of shared plans hurts scalability

2007-08-23 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-3024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12522204 ] Manish Khettry commented on DERBY-3024: --- That is very interesting. A couple of thoughts on this. First, the

[jira] Commented: (DERBY-3002) Add support for GROUP BY ROLLUP

2007-08-20 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12521273 ] Manish Khettry commented on DERBY-3002: --- If I read the diff correctly, you're sorting the same data multiple

[jira] Updated: (DERBY-2689) Deadlock with GenericPreparedStatement

2007-07-03 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manish Khettry updated DERBY-2689: -- Attachment: (was: deadlock3.patch.txt) Deadlock with GenericPreparedStatement

[jira] Updated: (DERBY-2689) Deadlock with GenericPreparedStatement

2007-07-03 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manish Khettry updated DERBY-2689: -- Attachment: deadlock3.patch.txt another one with license granted. I've already signed an

[jira] Updated: (DERBY-2689) Deadlock with GenericPreparedStatement

2007-07-02 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manish Khettry updated DERBY-2689: -- Attachment: deadlock3.patch.txt Deadlock with GenericPreparedStatement

[jira] Commented: (DERBY-2689) Deadlock with GenericPreparedStatement

2007-07-02 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12509745 ] Manish Khettry commented on DERBY-2689: --- fyi-- I attached another patch. Deadlock with

[jira] Commented: (DERBY-2689) Deadlock with GenericPreparedStatement

2007-06-26 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12508340 ] Manish Khettry commented on DERBY-2689: --- Thanks for looking at the patch. As far as 2 goes-- if we set

[jira] Commented: (DERBY-2689) Deadlock with GenericPreparedStatement

2007-06-26 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12508388 ] Manish Khettry commented on DERBY-2689: --- re: walking the acts list, Dan in DERBY-418, suggested that we

[jira] Updated: (DERBY-2689) Deadlock with GenericPreparedStatement

2007-06-25 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manish Khettry updated DERBY-2689: -- Attachment: deadlock.patch.txt I have moved the logic that closes unused activations. Earlier

[jira] Updated: (DERBY-2689) Deadlock with GenericPreparedStatement

2007-06-25 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manish Khettry updated DERBY-2689: -- Derby Info: [Patch Available] Deadlock with GenericPreparedStatement

[jira] Updated: (DERBY-2794) Document ansi trim functionality

2007-06-13 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manish Khettry updated DERBY-2794: -- Attachment: trim_doc A first cut at the ansi trim functionality. Document ansi trim

[jira] Updated: (DERBY-2794) Document ansi trim functionality

2007-06-13 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manish Khettry updated DERBY-2794: -- Derby Info: [Patch Available] Document ansi trim functionality

[jira] Commented: (DERBY-2689) Deadlock with GenericPreparedStatement

2007-06-11 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12503705 ] Manish Khettry commented on DERBY-2689: --- Thought I'd update the bug with what I'm trying right now--I think

[jira] Commented: (DERBY-1623) Add ANSI TRIM implementation

2007-06-08 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12502891 ] Manish Khettry commented on DERBY-1623: --- Sorry, I guess not all issues were addressed. re: space vs tabs--

[jira] Created: (DERBY-2794) Document ansi trim functionality

2007-06-08 Thread Manish Khettry (JIRA)
Document ansi trim functionality Key: DERBY-2794 URL: https://issues.apache.org/jira/browse/DERBY-2794 Project: Derby Issue Type: Sub-task Components: Documentation Reporter: Manish

[jira] Assigned: (DERBY-2689) Deadlock with GenericPreparedStatement

2007-06-08 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manish Khettry reassigned DERBY-2689: - Assignee: Manish Khettry Deadlock with GenericPreparedStatement

[jira] Commented: (DERBY-2689) Deadlock with GenericPreparedStatement

2007-06-08 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12502920 ] Manish Khettry commented on DERBY-2689: --- Since nobody has claimed this as yet and its critical, I can take a

[jira] Assigned: (DERBY-2794) Document ansi trim functionality

2007-06-08 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manish Khettry reassigned DERBY-2794: - Assignee: Manish Khettry Document ansi trim functionality

[jira] Updated: (DERBY-1623) Add ANSI TRIM implementation

2007-06-07 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manish Khettry updated DERBY-1623: -- Attachment: 1623_take2.patch.txt Followup patch. Addresses all the issues raised by A. B. Ran

[jira] Commented: (DERBY-1623) Add ANSI TRIM implementation

2007-06-06 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12502197 ] Manish Khettry commented on DERBY-1623: --- Thanks for reviewing the code. All your points are valid and 1 is a

[jira] Updated: (DERBY-1623) Add ANSI TRIM implementation

2007-06-02 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manish Khettry updated DERBY-1623: -- Attachment: 1623.patch.txt Add ANSI TRIM implementation

[jira] Updated: (DERBY-1623) Add ANSI TRIM implementation

2007-06-02 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manish Khettry updated DERBY-1623: -- Derby Info: [Patch Available] I apologize for not being able to wrap this up sooner-- work has

[jira] Commented: (DERBY-1623) Add ANSI TRIM implementation

2007-06-02 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12500988 ] Manish Khettry commented on DERBY-1623: --- The bugfix is in the attachment, 1623.patch.txt Add ANSI TRIM

[jira] Commented: (DERBY-1623) Add ANSI TRIM implementation

2007-04-22 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12490737 ] Manish Khettry commented on DERBY-1623: --- Thanks Andrew-- if you have those queries saved up, it would be a

[jira] Updated: (DERBY-1623) Add ANSI TRIM implementation

2007-04-21 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manish Khettry updated DERBY-1623: -- Attachment: sqlgrammar.jj.diff I think this grammar would work. What do you think Andrew?

[jira] Commented: (DERBY-1623) Add ANSI TRIM implementation

2007-04-14 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12488871 ] Manish Khettry commented on DERBY-1623: --- Andrew, I am going by snippets of the spec posted in this bug. I did

[jira] Commented: (DERBY-1623) Add ANSI TRIM implementation

2007-04-13 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12488822 ] Manish Khettry commented on DERBY-1623: --- Andrew Thanks for taking the time to take a look at this. I took

[jira] Updated: (DERBY-1623) Add ANSI TRIM implementation

2007-04-13 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manish Khettry updated DERBY-1623: -- Attachment: AnsiTrimTest.java Unit test for parsing trim expressions. Add ANSI TRIM

[jira] Commented: (DERBY-1623) Add ANSI TRIM implementation

2007-04-09 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12487668 ] Manish Khettry commented on DERBY-1623: --- I have spent several days but I cannot seem to express the grammar

[jira] Commented: (DERBY-1623) Add ANSI TRIM implementation

2007-03-27 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12484510 ] Manish Khettry commented on DERBY-1623: --- Yes, I agree the better thing to do is to implement the sql standard

[jira] Resolved: (DERBY-681) Eliminate the parser's rewriting of the abstract syntax tree for queries with GROUP BY and/or HAVING clauses

2007-03-26 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manish Khettry resolved DERBY-681. -- Resolution: Fixed This commit by Army, http://svn.apache.org/viewvc?view=revrev=518687,

[jira] Commented: (DERBY-1623) Add ANSI TRIM implementation

2007-03-26 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12484245 ] Manish Khettry commented on DERBY-1623: --- I'm thinking of adding an optional argument to the existing LTRIM and

[jira] Commented: (DERBY-1623) Add ANSI TRIM implementation

2007-03-26 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12484256 ] Manish Khettry commented on DERBY-1623: --- Its pretty much in the description of this bug. I found this as well

[jira] Closed: (DERBY-2442) Remove code made redundant by DERBY-681

2007-03-21 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manish Khettry closed DERBY-2442. - Remove code made redundant by DERBY-681 ---

[jira] Assigned: (DERBY-2457) Use of column aliases in group by / having clauses can cause queries to fail

2007-03-21 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manish Khettry reassigned DERBY-2457: - Assignee: Manish Khettry Use of column aliases in group by / having clauses can cause

[jira] Assigned: (DERBY-1623) Consider ANSI TRIM implementation

2007-03-21 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manish Khettry reassigned DERBY-1623: - Assignee: Manish Khettry Consider ANSI TRIM implementation

[jira] Updated: (DERBY-2442) Remove code made redundant by DERBY-681

2007-03-20 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manish Khettry updated DERBY-2442: -- Attachment: post681.refactor2.txt ValueNod#clause RIP. I ran derbylang, junit-all.

[jira] Commented: (DERBY-2442) Remove code made redundant by DERBY-681

2007-03-20 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12482440 ] Manish Khettry commented on DERBY-2442: --- This is the last patch for this bug. Remove code made redundant

[jira] Updated: (DERBY-2442) Remove code made redundant by DERBY-681

2007-03-20 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manish Khettry updated DERBY-2442: -- Derby Info: [Patch Available] Remove code made redundant by DERBY-681

[jira] Reopened: (DERBY-2442) Remove code made redundant by DERBY-681

2007-03-19 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manish Khettry reopened DERBY-2442: --- Sorry, to reopen this but there is atleast another set of changes that are coming up. Thanks

[jira] Updated: (DERBY-2442) Remove code made redundant by DERBY-681

2007-03-16 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manish Khettry updated DERBY-2442: -- Attachment: post681.refactor1.txt Remove code made redundant by DERBY-681

[jira] Commented: (DERBY-2442) Remove code made redundant by DERBY-681

2007-03-16 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12481763 ] Manish Khettry commented on DERBY-2442: --- the second patch, performs cleanup on FromSubquery and FromList--

[jira] Commented: (DERBY-2463) Create runtime statistics parser for junit tests

2007-03-16 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12481777 ] Manish Khettry commented on DERBY-2463: --- These questions may be silly but here goes 1. Is it possible that

[jira] Commented: (DERBY-2442) Remove code made redundant by DERBY-681

2007-03-15 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12481317 ] Manish Khettry commented on DERBY-2442: --- I'm sorry-- I had two different sets of changes in my environment. If

[jira] Updated: (DERBY-2442) Remove code made redundant by DERBY-681

2007-03-15 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manish Khettry updated DERBY-2442: -- Derby Info: [Patch Available] Remove code made redundant by DERBY-681

[jira] Updated: (DERBY-681) Eliminate the parser's rewriting of the abstract syntax tree for queries with GROUP BY and/or HAVING clauses

2007-03-14 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manish Khettry updated DERBY-681: - Attachment: followup.patch.txt query with a having clause but without a group by has a generated

[jira] Updated: (DERBY-2442) Remove code made redundant by DERBY-681

2007-03-14 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manish Khettry updated DERBY-2442: -- Attachment: post681.refactor.txt In SelectNode, the instance variables

[jira] Updated: (DERBY-2442) Remove code made redundant by DERBY-681

2007-03-14 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manish Khettry updated DERBY-2442: -- Derby Info: [Patch Available] Remove code made redundant by DERBY-681

[jira] Commented: (DERBY-681) Eliminate the parser's rewriting of the abstract syntax tree for queries with GROUP BY and/or HAVING clauses

2007-03-13 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12480501 ] Manish Khettry commented on DERBY-681: -- OK. Do you think it makes sense to mark this bug as resolved and another

[jira] Commented: (DERBY-681) Eliminate the parser's rewriting of the abstract syntax tree for queries with GROUP BY and/or HAVING clauses

2007-03-12 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12480221 ] Manish Khettry commented on DERBY-681: -- hmmm, thanks for catching all of these. I should have thought about them

[jira] Commented: (DERBY-2416) Provide a shell for a subclass of SQLChar which will use the passed Collator to do the collation rather than SQLChar's default collation of UCS_BASIC

2007-03-09 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12479698 ] Manish Khettry commented on DERBY-2416: --- A couple of thoughts. 1. The name can simply be

[jira] Commented: (DERBY-2416) Provide a shell for a subclass of SQLChar which will use the passed Collator to do the collation rather than SQLChar's default collation of UCS_BASIC

2007-03-09 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12479740 ] Manish Khettry commented on DERBY-2416: --- I am not sure what you mean by penalize SQLChar? If you mean runtime

[jira] Assigned: (DERBY-2442) Remove code made redundant by DERBY-681

2007-03-09 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manish Khettry reassigned DERBY-2442: - Assignee: Manish Khettry Remove code made redundant by DERBY-681

[jira] Updated: (DERBY-681) Eliminate the parser's rewriting of the abstract syntax tree for queries with GROUP BY and/or HAVING clauses

2007-03-08 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manish Khettry updated DERBY-681: - Attachment: 681.patch3.txt removed runtest, runsuite. fixed views. Eliminate the parser's

[jira] Updated: (DERBY-681) Eliminate the parser's rewriting of the abstract syntax tree for queries with GROUP BY and/or HAVING clauses

2007-03-07 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manish Khettry updated DERBY-681: - Attachment: 681.patch2.txt Again, thanks for very detailed and constructive review and for

[jira] Commented: (DERBY-681) Eliminate the parser's rewriting of the abstract syntax tree for queries with GROUP BY and/or HAVING clauses

2007-02-14 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12473218 ] Manish Khettry commented on DERBY-681: -- Just a quick note to address two issues raised by Army. DERBY-1624: It

[jira] Commented: (DERBY-681) Eliminate the parser's rewriting of the abstract syntax tree for queries with GROUP BY and/or HAVING clauses

2007-02-12 Thread Manish Khettry (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12472439 ] Manish Khettry commented on DERBY-681: -- Thanks for reviewing the patch. It will take me sometime to make the

[jira] Updated: (DERBY-681) Eliminate the parser's rewriting of the abstract syntax tree for queries with GROUP BY and/or HAVING clauses

2006-12-19 Thread Manish Khettry (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-681?page=all ] Manish Khettry updated DERBY-681: - Attachment: 681.patch.txt This patch removes the wrap group by's in a subselect rewrite in the parser. It preserves the having clause through bind and

[jira] Updated: (DERBY-681) Eliminate the parser's rewriting of the abstract syntax tree for queries with GROUP BY and/or HAVING clauses

2006-12-19 Thread Manish Khettry (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-681?page=all ] Manish Khettry updated DERBY-681: - Attachment: notes.txt Notes on this patch. Eliminate the parser's rewriting of the abstract syntax tree for queries with GROUP BY and/or HAVING clauses

[jira] Updated: (DERBY-681) Eliminate the parser's rewriting of the abstract syntax tree for queries with GROUP BY and/or HAVING clauses

2006-12-19 Thread Manish Khettry (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-681?page=all ] Manish Khettry updated DERBY-681: - Derby Info: [Patch Available] Eliminate the parser's rewriting of the abstract syntax tree for queries with GROUP BY and/or HAVING clauses

[jira] Commented: (DERBY-64) Create a table with a query

2006-12-09 Thread Manish Khettry (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-64?page=comments#action_12457097 ] Manish Khettry commented on DERBY-64: - I spent some time looking at the patch and it looks like a good first stab at the compile and bind phase. The execution

[jira] Commented: (DERBY-681) Eliminate the parser's rewriting of the abstract syntax tree for queries with GROUP BY and/or HAVING clauses

2006-12-03 Thread Manish Khettry (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-681?page=comments#action_12455195 ] Manish Khettry commented on DERBY-681: -- Thanks Andrew. I hope that I can eliminate the group/having query rewrite and this should fix DERBY-1624. On the

[jira] Commented: (DERBY-2016) ArrayIndexOutOfBoundsException for COALESCE with aggregate functions

2006-11-25 Thread Manish Khettry (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-2016?page=comments#action_12452589 ] Manish Khettry commented on DERBY-2016: --- The visit method is used to traverse the parse tree and in this case, replace aggregates with ColumnReferences. See

[jira] Assigned: (DERBY-681) Eliminate the parser's rewriting of the abstract syntax tree for queries with GROUP BY and/or HAVING clauses

2006-11-25 Thread Manish Khettry (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-681?page=all ] Manish Khettry reassigned DERBY-681: Assignee: Manish Khettry Eliminate the parser's rewriting of the abstract syntax tree for queries with GROUP BY and/or HAVING clauses

[jira] Commented: (DERBY-2014) NullPointerException with NULLIF in GROUP BY clause

2006-10-30 Thread Manish Khettry (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-2014?page=comments#action_12445682 ] Manish Khettry commented on DERBY-2014: --- The change to ConstantNode is fine. Thanks for finding and fixing this. On adding tests for this bug: Would it be

[jira] Commented: (DERBY-883) Enhance GROUP BY clause to support expressions instead of just column references.

2006-09-01 Thread Manish Khettry (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-883?page=comments#action_12432263 ] Manish Khettry commented on DERBY-883: -- I think the issue can be closed. I'm not sure if we want to allow the use of grouping expressions in the having

[jira] Updated: (DERBY-883) Enhance GROUP BY clause to support expressions instead of just column references.

2006-08-25 Thread Manish Khettry (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-883?page=all ] Manish Khettry updated DERBY-883: - Attachment: 883.patch7.txt Synced to rev 434408. Use the new JUnit test case/test setup classes. Passed derbylang. Enhance GROUP BY clause to support

[jira] Commented: (DERBY-883) Enhance GROUP BY clause to support expressions instead of just column references.

2006-08-25 Thread Manish Khettry (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-883?page=comments#action_12430672 ] Manish Khettry commented on DERBY-883: -- I'm not sure what you mean by function changes-- one new function has been added to BaseJDBCTestCase (although it was

[jira] Commented: (DERBY-883) Enhance GROUP BY clause to support expressions instead of just column references.

2006-08-25 Thread Manish Khettry (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-883?page=comments#action_12430681 ] Manish Khettry commented on DERBY-883: -- no functional changes, so if you've fixed up patch 6 to work, then go with it. Enhance GROUP BY clause to support

[jira] Commented: (DERBY-1624) use of direct column name rather than alias make aggregation fail (Hibernate depends on that)

2006-08-17 Thread Manish Khettry (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-1624?page=comments#action_12428846 ] Manish Khettry commented on DERBY-1624: --- Here is a description of the problem. Derby rewrite queries involving group by's by adding an outer select and

[jira] Commented: (DERBY-1624) use of direct column name rather than alias make aggregation fail (Hibernate depends on that)

2006-08-16 Thread Manish Khettry (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-1624?page=comments#action_12428453 ] Manish Khettry commented on DERBY-1624: --- This has to do with the way Derby rewrites querys with a groupby. What I find odd is that the query works without

[jira] Updated: (DERBY-883) Enhance GROUP BY clause to support expressions instead of just column references.

2006-08-10 Thread Manish Khettry (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-883?page=all ] Manish Khettry updated DERBY-883: - Attachment: 883.patch6.txt svn update to revision 430199. Hopefully this patch will apply cleanly. Enhance GROUP BY clause to support expressions instead

[jira] Updated: (DERBY-883) Enhance GROUP BY clause to support expressions instead of just column references.

2006-08-10 Thread Manish Khettry (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-883?page=all ] Manish Khettry updated DERBY-883: - Attachment: 883.patch6.txt Minor correction to previous patch. Enhance GROUP BY clause to support expressions instead of just column references.

[jira] Commented: (DERBY-883) Enhance GROUP BY clause to support expressions instead of just column references.

2006-08-10 Thread Manish Khettry (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-883?page=comments#action_12427381 ] Manish Khettry commented on DERBY-883: -- Dan could you try the last patch file attached with this bug? Enhance GROUP BY clause to support expressions instead

[jira] Updated: (DERBY-883) Enhance GROUP BY clause to support expressions instead of just column references.

2006-07-28 Thread Manish Khettry (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-883?page=all ] Manish Khettry updated DERBY-883: - Attachment: 883.patch5.txt This patch addresses issues raised by Army and Yip. 1. Flag error for aggregate in group by list. Changes to sqlgrammar.jj,

[jira] Commented: (DERBY-1574) NullPointerException in UPDATE with COALESCE and subquery

2006-07-27 Thread Manish Khettry (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-1574?page=comments#action_12423885 ] Manish Khettry commented on DERBY-1574: --- To me it seems CoalesceFunctionNode should provide a preprocess method but I'm not an authority either! While

[jira] Updated: (DERBY-883) Enhance GROUP BY clause to support expressions instead of just column references.

2006-07-26 Thread Manish Khettry (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-883?page=all ] Manish Khettry updated DERBY-883: - Attachment: 883.patch4.txt I found a problem in one of my changes. Also got rid of a lot of white space only diffs. Enhance GROUP BY clause to support

[jira] Updated: (DERBY-883) Enhance GROUP BY clause to support expressions instead of just column references.

2006-07-25 Thread Manish Khettry (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-883?page=all ] Manish Khettry updated DERBY-883: - Attachment: 883.patch3.txt incorporate feedback from code review. Enhance GROUP BY clause to support expressions instead of just column references.

[jira] Updated: (DERBY-883) Enhance GROUP BY clause to support expressions instead of just column references.

2006-07-16 Thread Manish Khettry (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-883?page=all ] Manish Khettry updated DERBY-883: - Attachment: 883.patch.txt Enhance GROUP BY clause to support expressions instead of just column references.

[jira] Updated: (DERBY-883) Enhance GROUP BY clause to support expressions instead of just column references.

2006-07-16 Thread Manish Khettry (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-883?page=all ] Manish Khettry updated DERBY-883: - Derby Info: [Patch Available] Functionally, this patch supports expressions in the group by list. An expression in the group by list can also be used in the

[jira] Updated: (DERBY-578) Grouped select from temporary table raises null pointer exception in byte code generator

2006-06-17 Thread Manish Khettry (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-578?page=all ] Manish Khettry updated DERBY-578: - Attachment: 578.diff.new.txt Try this one-- it is a complete patch and it should work. Grouped select from temporary table raises null pointer exception in

[jira] Updated: (DERBY-578) Grouped select from temporary table raises null pointer exception in byte code generator

2006-06-15 Thread Manish Khettry (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-578?page=all ] Manish Khettry updated DERBY-578: - Attachment: predicatePushdown.out.patch Looks like the join order changed between when I generated the patch and now. Try this version of predicatePushdown.

[jira] Resolved: (DERBY-578) Grouped select from temporary table raises null pointer exception in byte code generator

2006-06-06 Thread Manish Khettry (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-578?page=all ] Manish Khettry resolved DERBY-578: -- Resolution: Fixed Derby Info: [Patch Available] Grouped select from temporary table raises null pointer exception in byte code generator

[jira] Commented: (DERBY-883) Enhance GROUP BY clause to support expressions instead of just column references.

2006-05-15 Thread Manish Khettry (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-883?page=comments#action_12402467 ] Manish Khettry commented on DERBY-883: -- I have a few questions on this, largely functional. 1. In terms of syntax, do we allow expressions in the group by list or

  1   2   >