[
http://issues.apache.org/jira/browse/DERBY-1516?page=comments#action_12427263 ]
David Van Couvering commented on DERBY-1516:
Hi, Craig. I merged your patch into my sandbox and ran derbyall, and I'm sorry
to say I had a test
[
http://issues.apache.org/jira/browse/DERBY-1516?page=comments#action_12427294 ]
Craig Russell commented on DERBY-1516:
--
Hi David,
From my comments 31-Jul-2006:
I did not update master/DerbyNet/blobclob4BLOB.out canon because this canon
[
http://issues.apache.org/jira/browse/DERBY-1516?page=comments#action_12427062 ]
David Van Couvering commented on DERBY-1516:
I'm working on comitting this patch
Inconsistent behavior for getBytes and getSubString for embedded
[
http://issues.apache.org/jira/browse/DERBY-1516?page=comments#action_12426525 ]
Kathey Marsden commented on DERBY-1516:
---
Thanks Craig for the change, adding the test cases, and making sure client and
embedded have the same behavior.
[
http://issues.apache.org/jira/browse/DERBY-1516?page=comments#action_12426621 ]
Daniel John Debrunner commented on DERBY-1516:
--
Since this has been a tricky area to get correct, it seems that adding Javadoc
comments to the
[
http://issues.apache.org/jira/browse/DERBY-1516?page=comments#action_12426647 ]
Craig Russell commented on DERBY-1516:
--
Dan observes:
Since this has been a tricky area to get correct, it seems that adding
Javadoc comments to the
[
http://issues.apache.org/jira/browse/DERBY-1516?page=comments#action_12426674 ]
Craig Russell commented on DERBY-1516:
--
Here's a proposed javadoc comment for EmbedClob.getSubString:
* Valid pos values require that 0 pos clob.length
[
http://issues.apache.org/jira/browse/DERBY-1516?page=comments#action_12426687 ]
Daniel John Debrunner commented on DERBY-1516:
--
I mean comments clarifying the length position arguments passed in and the
valid ranges etc. Though
[
http://issues.apache.org/jira/browse/DERBY-1516?page=comments#action_12426707 ]
Craig Russell commented on DERBY-1516:
--
Hi Dan,
Thanks for your comments.
I mean comments clarifying the length position arguments passed in and the
[
http://issues.apache.org/jira/browse/DERBY-1516?page=comments#action_12426714 ]
Daniel John Debrunner commented on DERBY-1516:
--
thanks Craig, that's good reasoning, and the type of useful information I would
like to see in the
[
http://issues.apache.org/jira/browse/DERBY-1516?page=comments#action_12426397 ]
Craig Russell commented on DERBY-1516:
--
I have run derby-all with these changes, and no errors were reported.
Any other comments before I check this in?
[
http://issues.apache.org/jira/browse/DERBY-1516?page=comments#action_12425568 ]
Dag H. Wanvik commented on DERBY-1516:
--
If you are modelling this on the java.lang.String modulo indexing, it
seems to me that this is slightly wrong:
The
[
http://issues.apache.org/jira/browse/DERBY-1516?page=comments#action_12425588 ]
Craig Russell commented on DERBY-1516:
--
Hi Dag,
You know, I read this a hundred times and did not read it as allowing
t2.substring(1,1), since clearly 1 is
[
http://issues.apache.org/jira/browse/DERBY-1516?page=comments#action_12425340 ]
Craig Russell commented on DERBY-1516:
--
There is different behavior between embedded and network in other areas as well
as the one I'm looking at here. I'd
[
http://issues.apache.org/jira/browse/DERBY-1516?page=comments#action_12424850 ]
Kathey Marsden commented on DERBY-1516:
---
The new positive cases sound fine to me.
If I understand all you wrote, you are saying that getSubstring(pos,0)
[
http://issues.apache.org/jira/browse/DERBY-1516?page=comments#action_12424887 ]
Craig Russell commented on DERBY-1516:
--
Thanks for the feedback. I'll make some positive and negative test cases and
update the patch.
Yes, I'm suggesting
Kathey Marsden [EMAIL PROTECTED] writes:
One interesting test with 0 length is the case for getSubString(1,0)
for a zero length lob.
Should it throw an exception or return a zero length string?
The API working doesn't give much help to resolve this, the wording
for the exception in JDK 1.6 is
[
http://issues.apache.org/jira/browse/DERBY-1516?page=comments#action_12424636 ]
Kathey Marsden commented on DERBY-1516:
---
Thanks Craig for updating the masters.
I thiink it is really neat how specifying the patch of the same name grays
Hi Dag,
I'd appreciate discussion on specific JIRA issues to be done in JIRA
instead on on the mailing list. I have a hard time tracking
discussions that are forked.
I'll comment on your comment in the JIRA.
Thanks,
Craig
On Jul 31, 2006, at 1:16 PM, Kathey Marsden (JIRA) wrote:
[
[
http://issues.apache.org/jira/browse/DERBY-1516?page=comments#action_12424673 ]
Craig Russell commented on DERBY-1516:
--
Including the discussion from the alias referenced immediately above:
One interesting test with 0 length is the case
Craig Russell (JIRA) wrote:
[ http://issues.apache.org/jira/browse/DERBY-1516?page=comments#action_12424673 ]
Craig Russell commented on DERBY-1516:
--
Including the discussion from the alias referenced immediately above:
[
http://issues.apache.org/jira/browse/DERBY-1516?page=comments#action_12424448 ]
Craig Russell commented on DERBY-1516:
--
Hi Kathey,
Thanks for the feedback on the patch. A few notes:
1. I've added myself to the derby-developers list so I
Craig Russell (JIRA) wrote:
2. The differences in the master blobclob4BLOB.out files shows the
inconsistency of the behaviors quite nicely.
Yes I think analyzing (and eliminating) the master differences for
client and embedded would be a great task associated with DERBY-310.
3.
Craig Russell (JIRA) wrote:
what we should test.
One interesting test with 0 length is the case for getSubString(1,0) for
a zero length lob.
Should it throw an exception or return a zero length string?
Kathey
24 matches
Mail list logo
