[jira] Commented: (DERBY-1547) Add svn version number to DatabaseMetaData getDatabaseProductVersion and getDriverVersion() to improve supportability

2006-10-04 Thread John H. Embretsen (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-1547?page=comments#action_12439758 ] John H. Embretsen commented on DERBY-1547: -- When using the primary 10.2.1.6 release (i.e. the -src distribution, built by the user), 12 tests in derbyall

[jira] Commented: (DERBY-1547) Add svn version number to DatabaseMetaData getDatabaseProductVersion and getDriverVersion() to improve supportability

2006-10-04 Thread V.Narayanan (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-1547?page=comments#action_12439787 ] V.Narayanan commented on DERBY-1547: Thanx for pointing this out john. I will generate a patch for this. Add svn version number to DatabaseMetaData

[jira] Commented: (DERBY-1547) Add svn version number to DatabaseMetaData getDatabaseProductVersion and getDriverVersion() to improve supportability

2006-09-19 Thread Andrew McIntyre (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-1547?page=comments#action_12436038 ] Andrew McIntyre commented on DERBY-1547: Missed two files on the checkin. Committed with revision 448003. Add svn version number to DatabaseMetaData

[jira] Commented: (DERBY-1547) Add svn version number to DatabaseMetaData getDatabaseProductVersion and getDriverVersion() to improve supportability

2006-09-19 Thread V.Narayanan (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-1547?page=comments#action_12436117 ] V.Narayanan commented on DERBY-1547: Thanx for the commit Andrew!!! Thanx for the guidance and reviews Everyone!!! Narayanan Add svn version number to

[jira] Commented: (DERBY-1547) Add svn version number to DatabaseMetaData getDatabaseProductVersion and getDriverVersion() to improve supportability

2006-09-18 Thread John H. Embretsen (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-1547?page=comments#action_12435458 ] John H. Embretsen commented on DERBY-1547: -- Thanks for uploading a new patch so quickly, Narayanan! The only comment I have from reading the diff is

[jira] Commented: (DERBY-1547) Add svn version number to DatabaseMetaData getDatabaseProductVersion and getDriverVersion() to improve supportability

2006-09-18 Thread V.Narayanan (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-1547?page=comments#action_12435460 ] V.Narayanan commented on DERBY-1547: Thanx a ton for pointing it out john! sorry! will do and post it! Narayanan Add svn version number to DatabaseMetaData

[jira] Commented: (DERBY-1547) Add svn version number to DatabaseMetaData getDatabaseProductVersion and getDriverVersion() to improve supportability

2006-09-16 Thread John H. Embretsen (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-1547?page=comments#action_12435247 ] John H. Embretsen commented on DERBY-1547: -- Andrew McIntyre commented on DERBY-1547: Since svn versions can

[jira] Commented: (DERBY-1547) Add svn version number to DatabaseMetaData getDatabaseProductVersion and getDriverVersion() to improve supportability

2006-09-16 Thread Andrew McIntyre (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-1547?page=comments#action_12435259 ] Andrew McIntyre commented on DERBY-1547: Bad habits die hard. :-) Good point, John, ' - [(][0-9]+:?[0-9]*M?[)]' is more specific to the pattern we are

[jira] Commented: (DERBY-1547) Add svn version number to DatabaseMetaData getDatabaseProductVersion and getDriverVersion() to improve supportability

2006-09-15 Thread John H. Embretsen (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-1547?page=comments#action_12435003 ] John H. Embretsen commented on DERBY-1547: -- I looked a bit closer at some of the substitution patterns in the latest patch, 'DERBY-1547-sed-v1.diff ',

[jira] Commented: (DERBY-1547) Add svn version number to DatabaseMetaData getDatabaseProductVersion and getDriverVersion() to improve supportability

2006-09-15 Thread Andrew McIntyre (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-1547?page=comments#action_12435064 ] Andrew McIntyre commented on DERBY-1547: Since svn versions can be of the form {rev} or {rev}:{rev} where rev is an integer, and the M may or may not be

[jira] Commented: (DERBY-1547) Add svn version number to DatabaseMetaData getDatabaseProductVersion and getDriverVersion() to improve supportability

2006-09-13 Thread John H. Embretsen (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-1547?page=comments#action_12434416 ] John H. Embretsen commented on DERBY-1547: -- Narayanan, I was curious about the regular expressions and decided to take a look. I'm wondering, why are you

Re: [jira] Commented: (DERBY-1547) Add svn version number to DatabaseMetaData getDatabaseProductVersion and getDriverVersion() to improve supportability

2006-09-12 Thread Andrew McIntyre
On 9/11/06, V.Narayanan (JIRA) derby-dev@db.apache.org wrote: getDatabaseProductVersion(): 10.3.0.0 alpha-(1) getDriverVersion(): 10.3.0.0 alpha-(1) Test Failed. Can you please answer the following questions for me 1) Is this behaviour observed by you when running only with the classes

[jira] Commented: (DERBY-1547) Add svn version number to DatabaseMetaData getDatabaseProductVersion and getDriverVersion() to improve supportability

2006-09-12 Thread V.Narayanan (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-1547?page=comments#action_12434097 ] V.Narayanan commented on DERBY-1547: thanx for the email Andrew. I will fix this one. Narayanan Add svn version number to DatabaseMetaData

[jira] Commented: (DERBY-1547) Add svn version number to DatabaseMetaData getDatabaseProductVersion and getDriverVersion() to improve supportability

2006-09-11 Thread Deepa Remesh (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-1547?page=comments#action_12434012 ] Deepa Remesh commented on DERBY-1547: - Hi Narayanan, I applied your DERBY-1547-sed.diff patch. I am also seeing the same failure seen by Kathey when running

[jira] Commented: (DERBY-1547) Add svn version number to DatabaseMetaData getDatabaseProductVersion and getDriverVersion() to improve supportability

2006-09-11 Thread V.Narayanan (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-1547?page=comments#action_12434062 ] V.Narayanan commented on DERBY-1547: Hi, If you notice the failure pointed out (i.e.) The sed scripts are working fine because the subversion number has been

[jira] Commented: (DERBY-1547) Add svn version number to DatabaseMetaData getDatabaseProductVersion and getDriverVersion() to improve supportability

2006-09-11 Thread V.Narayanan (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-1547?page=comments#action_12434066 ] V.Narayanan commented on DERBY-1547: I am sorry for my previous comment. I got confused. I am able to reproduce the error u are seeing if I change the sed

[jira] Commented: (DERBY-1547) Add svn version number to DatabaseMetaData getDatabaseProductVersion and getDriverVersion() to improve supportability

2006-09-10 Thread V.Narayanan (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-1547?page=comments#action_12433768 ] V.Narayanan commented on DERBY-1547: Hi, It passed for me. I have enumerated the details of the settings I use to run the tests below pls point out in case

[jira] Commented: (DERBY-1547) Add svn version number to DatabaseMetaData getDatabaseProductVersion and getDriverVersion() to improve supportability

2006-09-08 Thread Kathey Marsden (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-1547?page=comments#action_12433435 ] Kathey Marsden commented on DERBY-1547: --- Hi Narayan, Is there a problem running pointing to the classes directory instead of jars with the sed files? I am

[jira] Commented: (DERBY-1547) Add svn version number to DatabaseMetaData getDatabaseProductVersion and getDriverVersion() to improve supportability

2006-09-07 Thread Kathey Marsden (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-1547?page=comments#action_12433298 ] Kathey Marsden commented on DERBY-1547: --- Hi Narayan, Thank you for the patch. I have a question about the changes to NetworkServerControlImpl. I am not

[jira] Commented: (DERBY-1547) Add svn version number to DatabaseMetaData getDatabaseProductVersion and getDriverVersion() to improve supportability

2006-09-07 Thread V.Narayanan (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-1547?page=comments#action_12433301 ] V.Narayanan commented on DERBY-1547: Hi, Thank You for the review on the patch The patch DERBY-1547-sed.diff has this diff for NetworkServerControlImpl.java

[jira] Commented: (DERBY-1547) Add svn version number to DatabaseMetaData getDatabaseProductVersion and getDriverVersion() to improve supportability

2006-09-07 Thread Kathey Marsden (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-1547?page=comments#action_12433303 ] Kathey Marsden commented on DERBY-1547: --- My bad, I was diffing with the head of trunk after applying the patch and had not yet synched up with DERBY-1710

[jira] Commented: (DERBY-1547) Add svn version number to DatabaseMetaData getDatabaseProductVersion and getDriverVersion() to improve supportability

2006-09-05 Thread Kathey Marsden (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-1547?page=comments#action_12432697 ] Kathey Marsden commented on DERBY-1547: --- Hello Narayan, I am back from vacation and see the testing conversation on this issue is holding it up. I think

Re: [jira] Commented: (DERBY-1547) Add svn version number to DatabaseMetaData getDatabaseProductVersion and getDriverVersion() to improve supportability

2006-09-05 Thread Mike Matrigali
Kathey Marsden (JIRA) wrote: [ http://issues.apache.org/jira/browse/DERBY-1547?page=comments#action_12432697 ] Kathey Marsden commented on DERBY-1547: --- Hello Narayan, I am back from vacation and see the testing conversation on this

[jira] Commented: (DERBY-1547) Add svn version number to DatabaseMetaData getDatabaseProductVersion and getDriverVersion() to improve supportability

2006-09-05 Thread V.Narayanan (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-1547?page=comments#action_12432737 ] V.Narayanan commented on DERBY-1547: Hi, You would'nt know how glad I am to see u back. I was totally held up trying the ProductVersionHolder way and was on

[jira] Commented: (DERBY-1547) Add svn version number to DatabaseMetaData getDatabaseProductVersion and getDriverVersion() to improve supportability

2006-08-22 Thread V.Narayanan (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-1547?page=comments#action_12429677 ] V.Narayanan commented on DERBY-1547: Thank you for the comments on the patch. Going by your comments of using existing property files would it be possible to

[jira] Commented: (DERBY-1547) Add svn version number to DatabaseMetaData getDatabaseProductVersion and getDriverVersion() to improve supportability

2006-08-21 Thread V.Narayanan (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-1547?page=comments#action_12429383 ] V.Narayanan commented on DERBY-1547: The four kinds of pattern strings that need to be searched for in the tests output while solving this are the following

[jira] Commented: (DERBY-1547) Add svn version number to DatabaseMetaData getDatabaseProductVersion and getDriverVersion() to improve supportability

2006-08-21 Thread Andrew McIntyre (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-1547?page=comments#action_12429478 ] Andrew McIntyre commented on DERBY-1547: The above solution has been based on the suggestions received for this issue in using a property file as the

[jira] Commented: (DERBY-1547) Add svn version number to DatabaseMetaData getDatabaseProductVersion and getDriverVersion() to improve supportability

2006-08-18 Thread V.Narayanan (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-1547?page=comments#action_12428985 ] V.Narayanan commented on DERBY-1547: Possible solution - 1) Find out in the tests where the input stream returned upon starting the

[jira] Commented: (DERBY-1547) Add svn version number to DatabaseMetaData getDatabaseProductVersion and getDriverVersion() to improve supportability

2006-08-16 Thread V.Narayanan (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-1547?page=comments#action_12428354 ] V.Narayanan commented on DERBY-1547: Hi, Thanx a ton for taking a look at the issue. But if u look at the failure the specific failure in this case is due to

[jira] Commented: (DERBY-1547) Add svn version number to DatabaseMetaData getDatabaseProductVersion and getDriverVersion() to improve supportability

2006-08-16 Thread Kathey Marsden (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-1547?page=comments#action_12428380 ] Kathey Marsden commented on DERBY-1547: --- I always thought instead of masters with the version output it would be good to have a test properties file that

[jira] Commented: (DERBY-1547) Add svn version number to DatabaseMetaData getDatabaseProductVersion and getDriverVersion() to improve supportability

2006-08-16 Thread V.Narayanan (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-1547?page=comments#action_12428400 ] V.Narayanan commented on DERBY-1547: Hi, Thanx for taking time to look at the issue and offering guidance. In relation to the suggestion for having a

[jira] Commented: (DERBY-1547) Add svn version number to DatabaseMetaData getDatabaseProductVersion and getDriverVersion() to improve supportability

2006-08-16 Thread Kathey Marsden (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-1547?page=comments#action_12428405 ] Kathey Marsden commented on DERBY-1547: --- I agree that the need to regenerate could cause potential issues. I think for the build number it may be good

[jira] Commented: (DERBY-1547) Add svn version number to DatabaseMetaData getDatabaseProductVersion and getDriverVersion() to improve supportability

2006-08-16 Thread Kathey Marsden (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-1547?page=comments#action_12428408 ] Kathey Marsden commented on DERBY-1547: --- Looking back at your original post asking about using the sed test harness capability, if you go that route. I

[jira] Commented: (DERBY-1547) Add svn version number to DatabaseMetaData getDatabaseProductVersion and getDriverVersion() to improve supportability

2006-08-16 Thread Deepa Remesh (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-1547?page=comments#action_12428414 ] Deepa Remesh commented on DERBY-1547: - Narayanan, Sorry for the confusion. I had seen the same failures which you reported when I ran derbyall in the new

[jira] Commented: (DERBY-1547) Add svn version number to DatabaseMetaData getDatabaseProductVersion and getDriverVersion() to improve supportability

2006-08-16 Thread V.Narayanan (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-1547?page=comments#action_12428566 ] V.Narayanan commented on DERBY-1547: Hi, Absolutely no problem! Thanx a ton for taking time off to look at the issue and give ur invaluable comments. Thanx to

[jira] Commented: (DERBY-1547) Add svn version number to DatabaseMetaData getDatabaseProductVersion and getDriverVersion() to improve supportability

2006-08-09 Thread Stan Bradbury (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-1547?page=comments#action_12426992 ] Stan Bradbury commented on DERBY-1547: -- In response to an email request for impact assessment = Excerpt: ..Does anyone see any issues with this

Re: [jira] Commented: (DERBY-1547) Add svn version number to DatabaseMetaData getDatabaseProductVersion and getDriverVersion() to improve supportability

2006-08-09 Thread Deepa Remesh
On 8/8/06, Andrew McIntyre (JIRA) derby-dev@db.apache.org wrote: [ http://issues.apache.org/jira/browse/DERBY-1547?page=comments#action_12426832 ] Andrew McIntyre commented on DERBY-1547: I think this is as simple as: Index:

[jira] Commented: (DERBY-1547) Add svn version number to DatabaseMetaData getDatabaseProductVersion and getDriverVersion() to improve supportability

2006-08-09 Thread Andrew McIntyre (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-1547?page=comments#action_12427056 ] Andrew McIntyre commented on DERBY-1547: No, it was not intended. I thought I had reverted the file. Thank you very much for spotting that, Deepa! Backed

[jira] Commented: (DERBY-1547) Add svn version number to DatabaseMetaData getDatabaseProductVersion and getDriverVersion() to improve supportability

2006-08-08 Thread Andrew McIntyre (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-1547?page=comments#action_12426832 ] Andrew McIntyre commented on DERBY-1547: I think this is as simple as: Index: java/engine/org/apache/derby/impl/jdbc/EmbedDatabaseMetaData.java