[
http://issues.apache.org/jira/browse/DERBY-1965?page=comments#action_12442990 ]
Mamta A. Satoor commented on DERBY-1965:
Dan, I looked through the patch and wondered why do you do closeSocket(); in
the finally block for methods
[
http://issues.apache.org/jira/browse/DERBY-1965?page=comments#action_12443033 ]
Daniel John Debrunner commented on DERBY-1965:
--
Thanks for the review - I used finally blocks to avoid having to re-write the
return statement of the
[
http://issues.apache.org/jira/browse/DERBY-1965?page=comments#action_12443046 ]
Knut Anders Hatlen commented on DERBY-1965:
---
I'm not sure that's the best use of try/finally. Take this code for example:
try {
setUpSocket();
[
http://issues.apache.org/jira/browse/DERBY-1965?page=comments#action_12443049 ]
Daniel John Debrunner commented on DERBY-1965:
--
Yep, closeSocket() needs to be more defensive.
NetworkServerControlImpl never closes the socket or
