[GitHub] accumulo pull request: ACCUMULO-3321 Logging ThriftScanner excepti...

2014-11-10 Thread arielvalentin
Github user arielvalentin commented on the pull request: https://github.com/apache/accumulo/pull/18#issuecomment-62402671 @joshelser I agree that because the client may recover from the is strictly not an error case, however I feel it is good to have breadcrumbs available when trying

[GitHub] accumulo pull request: ACCUMULO-3321 Logging ThriftScanner excepti...

2014-11-10 Thread joshelser
Github user joshelser commented on the pull request: https://github.com/apache/accumulo/pull/18#issuecomment-62410025 That's a good point too. Ultimately, I'm worried about inundating the client with WARN level logging. Maybe warning on the first occurrence of the inability to get the

[GitHub] accumulo pull request: ACCUMULO-3321 Logging ThriftScanner excepti...

2014-11-10 Thread busbey
Github user busbey commented on the pull request: https://github.com/apache/accumulo/pull/18#issuecomment-62410572 Can we reuse the log message back off from the balancer warnings about "I can't balance because foo" ? --- If your project is set up for it, you can reply to this email

[GitHub] accumulo pull request: ACCUMULO-3321 Logging ThriftScanner excepti...

2014-11-10 Thread arielvalentin
Github user arielvalentin commented on the pull request: https://github.com/apache/accumulo/pull/18#issuecomment-62414640 @busbey I am afraid I am not sure what you are referring to. Would you be able to elaborate a bit for me? @joshelser I empathize with that concern because I don

[GitHub] accumulo pull request: ACCUMULO-3321 Logging ThriftScanner excepti...

2014-11-10 Thread busbey
Github user busbey commented on the pull request: https://github.com/apache/accumulo/pull/18#issuecomment-62419110 Over here: https://github.com/apache/accumulo/blob/master/server/base/src/main/java/org/apache/accumulo/server/master/balancer/TabletBalancer.java#L95 line ~95 -

[GitHub] accumulo pull request: ACCUMULO-3321 Logging ThriftScanner excepti...

2014-11-10 Thread arielvalentin
Github user arielvalentin commented on the pull request: https://github.com/apache/accumulo/pull/18#issuecomment-62422047 @busbey Thanks for the hint. @joshelser had mentioned a different ticket [ticket|https://issues.apache.org/jira/browse/ACCUMULO-1268] that tries to address some de

[GitHub] accumulo pull request: ACCUMULO-3321 Logging ThriftScanner excepti...

2014-11-10 Thread joshelser
Github user joshelser commented on the pull request: https://github.com/apache/accumulo/pull/18#issuecomment-62422466 Short-term, I think improving the logging to help you debug cases like this in the future is a good idea. Lot's of ways to actually do this, with a few suggestions her

[GitHub] accumulo pull request: ACCUMULO-3321 Logging ThriftScanner excepti...

2014-11-10 Thread keith-turner
Github user keith-turner commented on the pull request: https://github.com/apache/accumulo/pull/18#issuecomment-62422710 What are the pros and cons of putting the following in your log4j config vs this change? org.apache.accumulo.core.client.impl.ThriftScanner=DEBUG --- If y

Contribute Examples/Exercises

2014-11-10 Thread Adam J. Shook
I had just finished finalizing the training materials for a basic and advanced Accumulo class my company ClearEdge IT offers. I think some of the more advanced code tutorials would be valuable to contribute to the Accumulo examples library. The examples all work with status updates from Twitter a

[GitHub] accumulo pull request: ACCUMULO-3321 Logging ThriftScanner excepti...

2014-11-10 Thread arielvalentin
Github user arielvalentin commented on the pull request: https://github.com/apache/accumulo/pull/18#issuecomment-62435090 @keith-turner Normally I would be uncomfortable with it but I think your suggestion will work for me in the meantime. After taking another look at the code the Thr

[GitHub] accumulo pull request: ACCUMULO-3321 Logging ThriftScanner excepti...

2014-11-10 Thread joshelser
Github user joshelser commented on the pull request: https://github.com/apache/accumulo/pull/18#issuecomment-62440337 @keith-turner while there is something to be said about just increasing the log-level via log4j, there's also the question of knowing to do that. For one, logging the

[GitHub] accumulo pull request: ACCUMULO-3321 Logging ThriftScanner excepti...

2014-11-10 Thread keith-turner
Github user keith-turner commented on the pull request: https://github.com/apache/accumulo/pull/18#issuecomment-62443647 > there's also the question of knowing to do that. Thats a con. Also, the implementation could move to another package in different major versions.

[GitHub] accumulo pull request: ACCUMULO-3321 Logging ThriftScanner excepti...

2014-11-10 Thread keith-turner
Github user keith-turner commented on the pull request: https://github.com/apache/accumulo/pull/18#issuecomment-62444055 What I was thinking about the metrics routes is that it makes the info available to anyone who seeks w/o spamming those who are not interested. I suppose debug log

Review Request 27829: ACCUMULO-1085

2014-11-10 Thread Eric Newton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27829/ --- Review request for accumulo. Repository: accumulo Description --- Allow

[GitHub] accumulo pull request: ACCUMULO-3321 Logging ThriftScanner excepti...

2014-11-10 Thread arielvalentin
Github user arielvalentin commented on the pull request: https://github.com/apache/accumulo/pull/18#issuecomment-62459363 Although I haven't used it before I am curious about how circuit breakers like [hystrix](https://github.com/Netflix/Hystrix) might help in situations like this. It

Re: Review Request 27829: ACCUMULO-1085

2014-11-10 Thread Mike Drob
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27829/#review60681 --- core/src/main/java/org/apache/accumulo/core/conf/Property.java

Instructions on running test suites

2014-11-10 Thread Fagan, Michael
Hi, I am looking for instructions on running the Accumulo test suites to verify my build works properly in my Hadoop environment. Can someone point me in the right direction? Regards, Mike Fagan

Re: Review Request 27829: ACCUMULO-1085

2014-11-10 Thread Eric Newton
> On Nov. 10, 2014, 9:38 p.m., Mike Drob wrote: > > test/src/test/java/org/apache/accumulo/test/AssignmentThreadsIT.java, line > > 34 > > > > > > Plkease add a test that only one recovery will happen at a time. Any id

Re: Review Request 27829: ACCUMULO-1085

2014-11-10 Thread Josh Elser
> On Nov. 10, 2014, 9:38 p.m., Mike Drob wrote: > > test/src/test/java/org/apache/accumulo/test/AssignmentThreadsIT.java, line > > 34 > > > > > > Plkease add a test that only one recovery will happen at a time. > > Er

Re: Review Request 27829: ACCUMULO-1085

2014-11-10 Thread Josh Elser
> On Nov. 10, 2014, 9:38 p.m., Mike Drob wrote: > > test/src/test/java/org/apache/accumulo/test/AssignmentThreadsIT.java, line > > 44 > > > > > > Is this just chars 0-9 & a-f? > > Eric Newton wrote: > yes; origina

Re: Instructions on running test suites

2014-11-10 Thread Josh Elser
Hi Mike, All of the fully automated test suites are standalone tests; they aren't presently capable of using an existing installation. These are what are referred to as our unit and integration tests. Unit tests: run `mvn package` Integration tests: run `mvn verify` (note that the verify life