[GitHub] accumulo pull request #242: ACCUMULO-2181/3005 REST API and new Monitor UI

2017-04-06 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/242#discussion_r110289116 --- Diff: server/monitor/src/main/java/org/apache/accumulo/monitor/rest/replication/ReplicationResource.java --- @@ -0,0 +1,204 @@ +/* + * Licens

[GitHub] accumulo pull request #242: ACCUMULO-2181/3005 REST API and new Monitor UI

2017-04-06 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/242#discussion_r110288818 --- Diff: server/monitor/src/main/java/org/apache/accumulo/monitor/rest/tables/TablesResource.java --- @@ -0,0 +1,232 @@ +/* + * Licensed to the

[GitHub] accumulo pull request #240: ACCUMULO-4618 Updates from additional code revie...

2017-04-06 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/240#discussion_r110286306 --- Diff: maven-plugin/pom.xml --- @@ -68,6 +68,7 @@ xml-apis xml-apis + provided --- End diff -- ```

[GitHub] accumulo pull request #240: ACCUMULO-4618 Updates from additional code revie...

2017-04-06 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/240#discussion_r110285913 --- Diff: maven-plugin/pom.xml --- @@ -68,6 +68,7 @@ xml-apis xml-apis + provided --- End diff -- I l

[GitHub] accumulo issue #243: ACCUMULO-4619 fix split hanging on Error

2017-04-06 Thread mjwall
Github user mjwall commented on the issue: https://github.com/apache/accumulo/pull/243 +1 Nice cleanup Keith. I went back to https://issues.apache.org/jira/browse/ACCUMULO-4332 to see if we could do something similar but didn't see anything. --- If your project is set up for

[GitHub] accumulo issue #242: ACCUMULO-2181/3005 REST API and new Monitor UI

2017-04-06 Thread ctubbsii
Github user ctubbsii commented on the issue: https://github.com/apache/accumulo/pull/242 I think the data model in the classes could be improved/refactored a bit, but it's the REST API we want to make consumable, not the internal implementation. I don't think it matters whether these

[GitHub] accumulo pull request #242: ACCUMULO-2181/3005 REST API and new Monitor UI

2017-04-06 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/accumulo/pull/242#discussion_r110254394 --- Diff: server/monitor/src/main/java/org/apache/accumulo/monitor/rest/replication/ReplicationResource.java --- @@ -0,0 +1,204 @@ +/* + * Licen

[GitHub] accumulo pull request #242: ACCUMULO-2181/3005 REST API and new Monitor UI

2017-04-06 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/accumulo/pull/242#discussion_r110254199 --- Diff: server/monitor/src/main/java/org/apache/accumulo/monitor/rest/tservers/TabletServerResource.java --- @@ -0,0 +1,336 @@ +/* + * License

[GitHub] accumulo pull request #242: ACCUMULO-2181/3005 REST API and new Monitor UI

2017-04-06 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/accumulo/pull/242#discussion_r110254019 --- Diff: server/monitor/src/main/java/org/apache/accumulo/monitor/rest/tables/TablesResource.java --- @@ -0,0 +1,232 @@ +/* + * Licensed to the

[GitHub] accumulo pull request #242: ACCUMULO-2181/3005 REST API and new Monitor UI

2017-04-06 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/242#discussion_r110253880 --- Diff: server/monitor/src/main/resources/templates/index.ftl --- @@ -0,0 +1,72 @@ + + + +${title} - Accumulo ${version} +

[GitHub] accumulo pull request #242: ACCUMULO-2181/3005 REST API and new Monitor UI

2017-04-06 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/242#discussion_r110253445 --- Diff: server/monitor/src/main/resources/resources/functions.js --- @@ -0,0 +1,686 @@ +/* +* Licensed to the Apache Software Foundation (ASF) un

[GitHub] accumulo pull request #242: ACCUMULO-2181/3005 REST API and new Monitor UI

2017-04-06 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/242#discussion_r110253032 --- Diff: server/monitor/src/main/resources/resources/functions.js --- @@ -0,0 +1,686 @@ +/* +* Licensed to the Apache Software Foundation (ASF) un

[GitHub] accumulo issue #239: ACCUMULO-4618 Enforce dependency analysis during build

2017-04-06 Thread mjwall
Github user mjwall commented on the issue: https://github.com/apache/accumulo/pull/239 +1 Late to comment here, sorry. I am in favor of convergence and started working it in https://issues.apache.org/jira/browse/ACCUMULO-762. Thanks for doing this Mike --- If your proje

[GitHub] accumulo pull request #242: ACCUMULO-2181/3005 REST API and new Monitor UI

2017-04-06 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/242#discussion_r110252576 --- Diff: server/monitor/src/main/java/org/apache/accumulo/monitor/rest/tservers/TabletServerResource.java --- @@ -0,0 +1,336 @@ +/* + * Licensed

[GitHub] accumulo pull request #242: ACCUMULO-2181/3005 REST API and new Monitor UI

2017-04-06 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/242#discussion_r110252042 --- Diff: server/monitor/src/main/java/org/apache/accumulo/monitor/rest/tables/TablesResource.java --- @@ -0,0 +1,232 @@ +/* + * Licensed to the

[GitHub] accumulo pull request #242: ACCUMULO-2181/3005 REST API and new Monitor UI

2017-04-06 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/242#discussion_r110250805 --- Diff: server/monitor/src/main/java/org/apache/accumulo/monitor/rest/replication/ReplicationResource.java --- @@ -0,0 +1,204 @@ +/* + * Licens

[GitHub] accumulo pull request #242: ACCUMULO-2181/3005 REST API and new Monitor UI

2017-04-06 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/242#discussion_r110246658 --- Diff: server/monitor/src/main/java/org/apache/accumulo/monitor/rest/master/MasterResource.java --- @@ -0,0 +1,235 @@ +/* + * Licensed to the

[GitHub] accumulo pull request #242: ACCUMULO-2181/3005 REST API and new Monitor UI

2017-04-06 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/242#discussion_r110242657 --- Diff: server/monitor/src/main/java/org/apache/accumulo/monitor/EmbeddedWebServer.java --- @@ -118,19 +98,17 @@ public void start() { }

Draft Board Report for Apr 2017

2017-04-06 Thread Michael Wall
Hello, The Apache Accumulo PMC decided to draft its quarterly board reports on the dev list. Here is a draft of our report which is due by Wednesday, Apr 12 . Please let me know if you have any suggestions, I plan to submit on 11 Apr. Mike --- ## Description: - The Apache

[GitHub] accumulo pull request #242: ACCUMULO-2181/3005 REST API and new Monitor UI

2017-04-06 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/242#discussion_r110241650 --- Diff: test/src/main/java/org/apache/accumulo/test/ThriftServerBindsBeforeZooKeeperLockIT.java --- @@ -94,7 +94,7 @@ public void testMonitorService()

[GitHub] accumulo pull request #242: ACCUMULO-2181/3005 REST API and new Monitor UI

2017-04-06 Thread lstav
Github user lstav commented on a diff in the pull request: https://github.com/apache/accumulo/pull/242#discussion_r110241064 --- Diff: server/monitor/src/main/java/org/apache/accumulo/monitor/Monitor.java --- @@ -461,25 +452,9 @@ public void run(String hostname) { try {

[GitHub] accumulo issue #200: Accumulo 4558 Added shell command to display server sta...

2017-04-06 Thread lstav
Github user lstav commented on the issue: https://github.com/apache/accumulo/pull/200 I just pushed the rebasing onto master and recompiling of thrift. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

Re: [VOTE] Accumulo 1.7.3-rc2 - vote closed (passed)

2017-04-06 Thread Christopher
Awesome! Thanks, Mike! On Thu, Apr 6, 2017 at 1:56 PM Michael Wall wrote: > Downloads page actually updated now. > > On Thu, Apr 6, 2017 at 1:37 PM Michael Wall wrote: > > > Oops, missed committing my updates to the download pages somehow. Fixing > > now > > > > On Thu, Apr 6, 2017 at 1:36 PM

[ANNOUNCE] Apache Accumulo 1.7.3 Released

2017-04-06 Thread Michael Wall
The Accumulo team is proud to announce the release of Accumulo version 1.7.3! This release contains changes from more than 75 issues, comprised of bug-fixes, performance improvements, build quality improvements, and more. This is a maintenance (patch) release. Users of any previous 1.7.x release ar

Re: [VOTE] Accumulo 1.7.3-rc2 - vote closed (passed)

2017-04-06 Thread Michael Wall
Downloads page actually updated now. On Thu, Apr 6, 2017 at 1:37 PM Michael Wall wrote: > Oops, missed committing my updates to the download pages somehow. Fixing > now > > On Thu, Apr 6, 2017 at 1:36 PM Michael Wall wrote: > > Completed the following > > - Updated downloads page > - Finished

Re: [VOTE] Accumulo 1.7.3-rc2 - vote closed (passed)

2017-04-06 Thread Michael Wall
Oops, missed committing my updates to the download pages somehow. Fixing now On Thu, Apr 6, 2017 at 1:36 PM Michael Wall wrote: > Completed the following > > - Updated downloads page > - Finished release notes > - Generated new javadocs > - Updated example text files by hand based on diff > - A

Re: [VOTE] Accumulo 1.7.3-rc2 - vote closed (passed)

2017-04-06 Thread Michael Wall
Completed the following - Updated downloads page - Finished release notes - Generated new javadocs - Updated example text files by hand based on diff - Archived 1.7.2 artifact in svn Getting read to draft and send an announcement email. Please let me know if you see any issues on the website. T

[GitHub] accumulo issue #242: ACCUMULO-2181/3005 REST API and new Monitor UI

2017-04-06 Thread lstav
Github user lstav commented on the issue: https://github.com/apache/accumulo/pull/242 >> I changed to use the public variables at the suggestion of @ctubbsii, but we could discuss the best approach and change it to that. >> > Ok. Mostly I was thinking that if we are moving the

[GitHub] accumulo pull request #242: ACCUMULO-2181/3005 REST API and new Monitor UI

2017-04-06 Thread lstav
Github user lstav commented on a diff in the pull request: https://github.com/apache/accumulo/pull/242#discussion_r110216056 --- Diff: server/monitor/src/main/resources/templates/index.ftl --- @@ -0,0 +1,72 @@ + + + +${title} - Accumulo ${version} +

[GitHub] accumulo pull request #242: ACCUMULO-2181/3005 REST API and new Monitor UI

2017-04-06 Thread lstav
Github user lstav commented on a diff in the pull request: https://github.com/apache/accumulo/pull/242#discussion_r110215947 --- Diff: server/monitor/src/main/resources/resources/functions.js --- @@ -0,0 +1,686 @@ +/* +* Licensed to the Apache Software Foundation (ASF) under

[GitHub] accumulo pull request #242: ACCUMULO-2181/3005 REST API and new Monitor UI

2017-04-06 Thread lstav
Github user lstav commented on a diff in the pull request: https://github.com/apache/accumulo/pull/242#discussion_r110215877 --- Diff: server/monitor/src/main/resources/resources/functions.js --- @@ -0,0 +1,686 @@ +/* +* Licensed to the Apache Software Foundation (ASF) under

[GitHub] accumulo pull request #242: ACCUMULO-2181/3005 REST API and new Monitor UI

2017-04-06 Thread lstav
Github user lstav commented on a diff in the pull request: https://github.com/apache/accumulo/pull/242#discussion_r110195086 --- Diff: server/monitor/src/main/java/org/apache/accumulo/monitor/rest/logs/DeadLoggerInformation.java --- @@ -0,0 +1,57 @@ +/* + * Licensed to the

[GitHub] accumulo pull request #242: ACCUMULO-2181/3005 REST API and new Monitor UI

2017-04-06 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/accumulo/pull/242#discussion_r110193783 --- Diff: server/monitor/src/main/java/org/apache/accumulo/monitor/rest/logs/DeadLoggerInformation.java --- @@ -0,0 +1,57 @@ +/* + * Licensed to

[GitHub] accumulo issue #242: ACCUMULO-2181/3005 REST API and new Monitor UI

2017-04-06 Thread joshelser
Github user joshelser commented on the issue: https://github.com/apache/accumulo/pull/242 > I changed to use the public variables at the suggestion of @ctubbsii, but we could discuss the best approach and change it to that. Ok. Mostly I was thinking that if we are moving these

[GitHub] accumulo pull request #242: ACCUMULO-2181/3005 REST API and new Monitor UI

2017-04-06 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/accumulo/pull/242#discussion_r110192525 --- Diff: server/monitor/src/main/resources/templates/index.ftl --- @@ -0,0 +1,72 @@ + + + +${title} - Accumulo ${version} +

[GitHub] accumulo pull request #242: ACCUMULO-2181/3005 REST API and new Monitor UI

2017-04-06 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/accumulo/pull/242#discussion_r110192467 --- Diff: server/monitor/src/main/resources/templates/index.ftl --- @@ -0,0 +1,72 @@ + + + +${title} - Accumulo ${version} +

[GitHub] accumulo pull request #242: ACCUMULO-2181/3005 REST API and new Monitor UI

2017-04-06 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/accumulo/pull/242#discussion_r110192245 --- Diff: server/monitor/src/main/java/org/apache/accumulo/monitor/rest/replication/ReplicationResource.java --- @@ -0,0 +1,204 @@ +/* + * Licen

[GitHub] accumulo pull request #242: ACCUMULO-2181/3005 REST API and new Monitor UI

2017-04-06 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/accumulo/pull/242#discussion_r110192139 --- Diff: server/monitor/src/main/resources/resources/functions.js --- @@ -0,0 +1,686 @@ +/* +* Licensed to the Apache Software Foundation (ASF) u

[GitHub] accumulo pull request #242: ACCUMULO-2181/3005 REST API and new Monitor UI

2017-04-06 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/accumulo/pull/242#discussion_r110192066 --- Diff: server/monitor/src/main/resources/resources/functions.js --- @@ -0,0 +1,686 @@ +/* +* Licensed to the Apache Software Foundation (ASF) u

[GitHub] accumulo issue #242: ACCUMULO-2181/3005 REST API and new Monitor UI

2017-04-06 Thread lstav
Github user lstav commented on the issue: https://github.com/apache/accumulo/pull/242 Thanks for the feedback @joshelser, I'll start working on it ASAP. Here is an answer for the general comments you left outside the code: - **I see some pojo classes have @XmlAttribute on the

[GitHub] accumulo pull request #242: ACCUMULO-2181/3005 REST API and new Monitor UI

2017-04-06 Thread lstav
Github user lstav commented on a diff in the pull request: https://github.com/apache/accumulo/pull/242#discussion_r110162252 --- Diff: test/src/main/java/org/apache/accumulo/test/ThriftServerBindsBeforeZooKeeperLockIT.java --- @@ -94,7 +94,7 @@ public void testMonitorService() thr

[GitHub] accumulo pull request #242: ACCUMULO-2181/3005 REST API and new Monitor UI

2017-04-06 Thread lstav
Github user lstav commented on a diff in the pull request: https://github.com/apache/accumulo/pull/242#discussion_r110162027 --- Diff: server/monitor/src/main/resources/templates/index.ftl --- @@ -0,0 +1,72 @@ + + + +${title} - Accumulo ${version} +

[GitHub] accumulo pull request #242: ACCUMULO-2181/3005 REST API and new Monitor UI

2017-04-06 Thread lstav
Github user lstav commented on a diff in the pull request: https://github.com/apache/accumulo/pull/242#discussion_r110161691 --- Diff: server/monitor/src/main/resources/templates/index.ftl --- @@ -0,0 +1,72 @@ + + + +${title} - Accumulo ${version} +

[GitHub] accumulo pull request #242: ACCUMULO-2181/3005 REST API and new Monitor UI

2017-04-06 Thread lstav
Github user lstav commented on a diff in the pull request: https://github.com/apache/accumulo/pull/242#discussion_r110161076 --- Diff: server/monitor/src/main/resources/resources/functions.js --- @@ -0,0 +1,686 @@ +/* +* Licensed to the Apache Software Foundation (ASF) under

[GitHub] accumulo pull request #242: ACCUMULO-2181/3005 REST API and new Monitor UI

2017-04-06 Thread lstav
Github user lstav commented on a diff in the pull request: https://github.com/apache/accumulo/pull/242#discussion_r110160756 --- Diff: server/monitor/src/main/resources/resources/functions.js --- @@ -0,0 +1,686 @@ +/* +* Licensed to the Apache Software Foundation (ASF) under

[GitHub] accumulo pull request #242: ACCUMULO-2181/3005 REST API and new Monitor UI

2017-04-06 Thread lstav
Github user lstav commented on a diff in the pull request: https://github.com/apache/accumulo/pull/242#discussion_r110160390 --- Diff: server/monitor/src/main/resources/resources/functions.js --- @@ -0,0 +1,686 @@ +/* +* Licensed to the Apache Software Foundation (ASF) under

[GitHub] accumulo pull request #242: ACCUMULO-2181/3005 REST API and new Monitor UI

2017-04-06 Thread lstav
Github user lstav commented on a diff in the pull request: https://github.com/apache/accumulo/pull/242#discussion_r110159175 --- Diff: server/monitor/src/main/resources/resources/bulkImport.js --- @@ -0,0 +1,213 @@ +/* +* Licensed to the Apache Software Foundation (ASF) unde

[GitHub] accumulo pull request #242: ACCUMULO-2181/3005 REST API and new Monitor UI

2017-04-06 Thread lstav
Github user lstav commented on a diff in the pull request: https://github.com/apache/accumulo/pull/242#discussion_r110156683 --- Diff: server/monitor/src/main/java/org/apache/accumulo/monitor/rest/tables/TablesResource.java --- @@ -0,0 +1,232 @@ +/* + * Licensed to the Apa

[GitHub] accumulo pull request #242: ACCUMULO-2181/3005 REST API and new Monitor UI

2017-04-06 Thread lstav
Github user lstav commented on a diff in the pull request: https://github.com/apache/accumulo/pull/242#discussion_r110156589 --- Diff: server/monitor/src/main/java/org/apache/accumulo/monitor/rest/tables/TablesResource.java --- @@ -0,0 +1,232 @@ +/* + * Licensed to the Apa

[GitHub] accumulo pull request #242: ACCUMULO-2181/3005 REST API and new Monitor UI

2017-04-06 Thread lstav
Github user lstav commented on a diff in the pull request: https://github.com/apache/accumulo/pull/242#discussion_r110156099 --- Diff: server/monitor/src/main/java/org/apache/accumulo/monitor/rest/replication/ReplicationResource.java --- @@ -0,0 +1,204 @@ +/* + * Licensed

[GitHub] accumulo pull request #242: ACCUMULO-2181/3005 REST API and new Monitor UI

2017-04-06 Thread lstav
Github user lstav commented on a diff in the pull request: https://github.com/apache/accumulo/pull/242#discussion_r110155338 --- Diff: server/monitor/src/main/java/org/apache/accumulo/monitor/rest/Totals.java --- @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] accumulo pull request #242: ACCUMULO-2181/3005 REST API and new Monitor UI

2017-04-06 Thread lstav
Github user lstav commented on a diff in the pull request: https://github.com/apache/accumulo/pull/242#discussion_r110154632 --- Diff: server/monitor/src/main/java/org/apache/accumulo/monitor/EmbeddedWebServer.java --- @@ -118,19 +98,17 @@ public void start() { } }

Re: [VOTE] Accumulo 1.7.3-rc2 - vote closed (passed)

2017-04-06 Thread Michael Wall
I am going to work on getting this finished up today. On Mon, Mar 27, 2017 at 7:55 AM Michael Wall wrote: > Thanks Christopher, thanks Ed. Ed, let me if you want help finishing up > the release notes. > > On Mon, Mar 27, 2017 at 6:23 AM Ed Coleman wrote: > > Thanks - The delay was mainly due t