Re: [VOTE] ActiveMQ Artemis becomes ActiveMQ 6

2017-12-05 Thread Michael André Pearce
Based on the Dev discussion linked I believe this vote was more making the direction and future clearer for users, its not deprecating overnight 5.x, but simply clearing up what is ActiveMQ 6 going to be. On your commends about JBoss. I don’t think vendor versions should come in here. Apache

[GitHub] activemq-artemis issue #1687: ARTEMIS-1535 - settle delivery in same lock as...

2017-12-05 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1687 @andytaylor @tabish121 onError isn't needed on this case... IOCriticalListener would kick in before (which is kicked after that method somewhere through the native interface on

Re: [VOTE] ActiveMQ Artemis becomes ActiveMQ 6

2017-12-05 Thread artnaseef
-1 I think we need to slow down. While the referenced discussion opened the possibility of unifying on a single broker, there's a lot more to discuss before that decision is made. Naming Artemis as ActiveMQ 6 implies to the community that we are deprecating AMQ 5 now. For example, the

Re: [VOTE] ActiveMQ Artemis becomes ActiveMQ 6

2017-12-05 Thread Howard Gao
+1 On Wed, Dec 6, 2017 at 12:23 AM, Timothy Bish wrote: > +1 > > > On 12/04/2017 03:32 PM, Clebert Suconic wrote: > >> Following on from the discussion, "[DISCUSS] Confusion surrounding the >> ActiveMQ project roadmap" >> >> linked here for convenience : >> -

[GitHub] activemq-artemis issue #1679: ARTEMIS-1523 Allow MQTT with dynamic cluster

2017-12-05 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/1679 It would be ideal to have a real test in the test-suite to validate this functionality instead of just an example. I think that once a test was created you could get rid of the example

[GitHub] activemq-artemis issue #1679: ARTEMIS-1523 Allow MQTT with dynamic cluster

2017-12-05 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/1679 It looks a lot better, but you need to squash your commits together into a single commit. Once that's done I'll kick off a full test-suite run with your changes and see how it goes.

[GitHub] activemq-artemis issue #1684: ARTEMIS-1498: Openwire internal headers should...

2017-12-05 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1684 On that note, going through the OpenWireConverter that currently converts OpenWire to Core on produce, there is many places where its not setting the correct matching

[GitHub] activemq-artemis issue #1679: ARTEMIS-1523 Allow MQTT with dynamic cluster

2017-12-05 Thread Skiler
Github user Skiler commented on the issue: https://github.com/apache/activemq-artemis/pull/1679 Hi @jbertram I changed the way it create the Bindings based in wildcard. I hope it's good now :) ---

[GitHub] activemq-artemis issue #1684: ARTEMIS-1498: Openwire internal headers should...

2017-12-05 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/activemq-artemis/pull/1684 So here I would either suggest that these are not copied to core message when converting to core, but if need because of consuming with openwire consumer then probably better

Re: [VOTE] ActiveMQ Artemis becomes ActiveMQ 6

2017-12-05 Thread Timothy Bish
+1 On 12/04/2017 03:32 PM, Clebert Suconic wrote: Following on from the discussion, "[DISCUSS] Confusion surrounding the ActiveMQ project roadmap" linked here for convenience : - http://activemq.2283324.n4.nabble.com/DISCUSS-Confusion-surrounding-the-ActiveMQ-project-roadmap-td4732935.html -

[GitHub] activemq-artemis pull request #1688: ARTEMIS-1537 broker was less strict whi...

2017-12-05 Thread stanlyDoge
GitHub user stanlyDoge opened a pull request: https://github.com/apache/activemq-artemis/pull/1688 ARTEMIS-1537 broker was less strict while reloading configuration You can merge this pull request into a Git repository by running: $ git pull

[GitHub] activemq-artemis issue #1644: ARTEMIS-1503 Added ng-grid plugin

2017-12-05 Thread stanlyDoge
Github user stanlyDoge commented on the issue: https://github.com/apache/activemq-artemis/pull/1644 Yes, there is described reproducer by reporter of this issue. > > you try to browse the queue to check the messages and you have more than 40 messages ( depends on your screen

[GitHub] activemq-artemis issue #1644: ARTEMIS-1503 Added ng-grid plugin

2017-12-05 Thread jbertram
Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/1644 Any update on this? It's been waiting for additional info for 20 days. ---

[GitHub] activemq-artemis pull request #1686: ARTEMIS-1534 added openwire logging (tr...

2017-12-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1686 ---

[GitHub] activemq-artemis pull request #1685: ARTEMIS-1533 Import subschema's so XMLL...

2017-12-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1685 ---

[GitHub] activemq-artemis pull request #1682: NO-JIRA Documentation: fix filenames of...

2017-12-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1682 ---

[GitHub] activemq-artemis issue #1687: ARTEMIS-1535 - settle delivery in same lock as...

2017-12-05 Thread clebertsuconic
Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1687 @andytaylor are you in a hurry to merge this? if so, I will take a look later today. But usually onError is not very useful. I will need to look at the solution

[GitHub] activemq-artemis pull request #1675: ARTEMIS-1526 NullpointerException in Ac...

2017-12-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1675 ---

[GitHub] activemq-artemis issue #1687: ARTEMIS-1535 - settle delivery in same lock as...

2017-12-05 Thread andytaylor
Github user andytaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/1687 @clebertsuconic what do you think, should we do something in onError at least fro discharge? ---

Re: [GitHub] activemq-artemis issue #1687: ARTEMIS-1535 - settle delivery in same lock as...

2017-12-05 Thread Clebert Suconic
It’s cslled upon IO errors but there is also the critical listener that would shutdown the broker before. So I’m not sure the error is very useful On this context. On Tue, Dec 5, 2017 at 9:53 AM tabish121 wrote: > Github user tabish121 commented on the issue: > >

[GitHub] activemq-artemis issue #1687: ARTEMIS-1535 - settle delivery in same lock as...

2017-12-05 Thread tabish121
Github user tabish121 commented on the issue: https://github.com/apache/activemq-artemis/pull/1687 Is it true that there's nothing that will be calling the IOCallback onError method? If that isn't the case then it seems like there's a possible case here where the Declare or

Re: [VOTE] ActiveMQ Artemis becomes ActiveMQ 6

2017-12-05 Thread Christopher Shannon
+1, This would probably be a good time to update the website to a more modern design as well On Tue, Dec 5, 2017 at 9:14 AM, Rob Davies wrote: > Sounds good - I recast my vote to +1 > > > > On 5 Dec 2017, at 13:18, Clebert Suconic > wrote: > > >

Re: [VOTE] ActiveMQ Artemis becomes ActiveMQ 6

2017-12-05 Thread Rob Davies
Sounds good - I recast my vote to +1 > On 5 Dec 2017, at 13:18, Clebert Suconic wrote: > > Point taken. We should improve the migration doc the best we can. > > If we make this a blocking/mandatory task before a 6 release, would you > consider changing your vote to

Re: [VOTE] ActiveMQ Artemis becomes ActiveMQ 6

2017-12-05 Thread Clebert Suconic
Point taken. We should improve the migration doc the best we can. If we make this a blocking/mandatory task before a 6 release, would you consider changing your vote to +1. (I would add this remark to the closing vote and would add a blocking/mandatory JIRA so it wouldn’t be released without

[GitHub] activemq-artemis issue #1687: ARTEMIS-1535 - settle delivery in same lock as...

2017-12-05 Thread andytaylor
Github user andytaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/1687 don't merge this yet ---

[GitHub] activemq-artemis pull request #1687: ARTEMIS-1535 - settle delivery in same ...

2017-12-05 Thread andytaylor
GitHub user andytaylor opened a pull request: https://github.com/apache/activemq-artemis/pull/1687 ARTEMIS-1535 - settle delivery in same lock as sending the disposition https://issues.apache.org/jira/browse/ARTEMIS-1535 You can merge this pull request into a Git repository by

Re: [VOTE] ActiveMQ Artemis becomes ActiveMQ 6

2017-12-05 Thread Rob Davies
[0] - without a clear migration path and tooling to assist existing users moving from ActiveMQ 5 to Artemis, we risk abandoning those users - who may then be forced to look at alternatives and abandon ActiveMQ all together. This could be counter productive to the original intent. > On 4

Re: [VOTE] ActiveMQ Artemis becomes ActiveMQ 6

2017-12-05 Thread Gary Tully
+1 On 5 Dec 2017 7:59 am, "Francesco Nigro" wrote: > +1 (non-binding) > > > Il giorno mar 5 dic 2017 alle ore 04:17 Francois Papon < > francois.pa...@openobject.fr> ha scritto: > > > +1 (non-binding) > > > > Francois > > > > > > Le 05/12/2017 à 00:32, Clebert Suconic a

[GitHub] activemq-artemis issue #1684: ARTEMIS-1498: Openwire internal headers should...

2017-12-05 Thread RaiSaurabh
Github user RaiSaurabh commented on the issue: https://github.com/apache/activemq-artemis/pull/1684 @michaelandrepearce @clebertsuconic Please correct me if my understanding is wrong. I checked the code of OpenwireMesageConverter when we send a message using client if comes to

Re: [VOTE] ActiveMQ Artemis becomes ActiveMQ 6

2017-12-05 Thread Francesco Nigro
+1 (non-binding) Il giorno mar 5 dic 2017 alle ore 04:17 Francois Papon < francois.pa...@openobject.fr> ha scritto: > +1 (non-binding) > > Francois > > > Le 05/12/2017 à 00:32, Clebert Suconic a écrit : > > Following on from the discussion, "[DISCUSS] Confusion surrounding the > > ActiveMQ