Re: Building on Java 11

Ok, shame. I'd probably ditch it for now given that and the other issues with newer JDKs. Or maybe it could be profile'd so it only worked on JDK 8 with the older minimal config, and just ensure it runs in CI? Save covering every module with dep bits for it. Regardless, point still stands about th

Re: Building on Java 11

But I wouldn’t hold jdk upgrade over it. Just setting out priorities. On Fri, May 29, 2020 at 12:56 PM Emmanuel Hugonnet wrote: > Well it discovers some issues like > > activemq-artemis/artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/check/QueueCheck.java:[104,55] > [FormatS

Re: Building on Java 11

Well it discovers some issues like activemq-artemis/artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/check/QueueCheck.java:[104,55] [FormatString] extra format arguments: used 0, provided 1 [ERROR] (see https://errorprone.info/bugpattern/FormatString) Le 29/05/2020 à 18:36,

Re: Building on Java 11

I agree 100% on ditching error prone if it's blocking us. Justin On Fri, May 29, 2020 at 11:34 AM Clebert Suconic wrote: > I'm not in love with error prone. if it's blocking us to move to a > newer JDK i say it goes away (at least for now).. if at a later point > it's again compatible we put i

Re: Building on Java 11

I'm not in love with error prone. if it's blocking us to move to a newer JDK i say it goes away (at least for now).. if at a later point it's again compatible we put it back on. On Fri, May 29, 2020 at 12:21 PM Emmanuel Hugonnet wrote: > > Hello, > > Alas yes as otherwise you need to configure th

Re: Building on Java 11

Hello, Alas yes as otherwise you need to configure the compilation with error-prone and jboss logging annotation processor., and future annotation processors. It was the less intrusive way from my point of view. Emmanuel Le 29/05/2020 à 18:10, Robbie Gemmell a écrit : > Is it really necessary

Re: Building on Java 11

https://github.com/google/error-prone/issues/1106 *cushon * commented 2 days ago As of 746c15f ,

Re: Building on Java 11

Is it really necessary to add error-prone definition to almost every module? Presumably theres some module it isnt defined in. No other workarounds for that? I also wonder about this bit: https://github.com/apache/activemq-artemis/compare/master...clebertsuconic:java_11#diff-600376dffeb79835ede4a0

Re: Building on Java 11

I used OpenJDK 11.0.6, didn't try OpenJDK 14. Maybe we should remove error prone for JDK > 11. Emmanuel Le 29/05/2020 à 17:58, Clebert Suconic a écrit : > I have JDK 13 on my mac.. I just tried with the rebase and I got this: > > [ERROR] at > org.codehaus.plexus.classworlds.launcher.Launcher.ma

Re: Building on Java 11

Excellent to see some work on this! Whilst I obviously have Java 8 around since most components target it currently and so its my main build env, I do also have envs that default to 11 and as you later said its really annoying having to tweak the env back to 8 just to build a given component there

Re: Building on Java 11

No worries... I am just making the ball rolling, perhaps someone else will also be interested on helping out here. On Fri, May 29, 2020 at 11:57 AM Emmanuel Hugonnet wrote: > > I'm a bit overloaded today. I will take a look Tuesday (since Monday is a > public holiday). > > Cheers, > > Emmanuel >

Re: Building on Java 11

I have JDK 13 on my mac.. I just tried with the rebase and I got this: [ERROR] at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356) [ERROR] Caused by: java.lang.NoSuchMethodException: com.sun.tools.javac.comp.Resolve.findIdent(com.sun.tools.javac.comp.Env,com.sun.tools.ja

Re: Building on Java 11

I'm a bit overloaded today. I will take a look Tuesday (since Monday is a public holiday). Cheers, Emmanuel Le 29/05/2020 à 17:55, Clebert Suconic a écrit : > @Emmanuel: I rebased your branch here: > https://github.com/clebertsuconic/activemq-artemis/tree/java_11 > > Perhaps you may want to tak

Re: Building on Java 11

@Emmanuel: I rebased your branch here: https://github.com/clebertsuconic/activemq-artemis/tree/java_11 Perhaps you may want to take a look. On Fri, May 29, 2020 at 11:54 AM Clebert Suconic wrote: > > so, if we switched to JDK 11 on the CI, those would still work with > the trick you used? > > On

Re: Building on Java 11

Yes, you should be able to build with both JDK 8 and 11. Emmanuel Le 29/05/2020 à 17:54, Clebert Suconic a écrit : > so, if we switched to JDK 11 on the CI, those would still work with > the trick you used? > > On Fri, May 29, 2020 at 11:39 AM Emmanuel Hugonnet > wrote: >> I changed the way the

Re: Building on Java 11

so, if we switched to JDK 11 on the CI, those would still work with the trick you used? On Fri, May 29, 2020 at 11:39 AM Emmanuel Hugonnet wrote: > > I changed the way the classloaders where working with JDK 11 using the > plateform classloader as the parent instead of null so that I could > acc

Re: Building on Java 11

I changed the way the classloaders where working with JDK 11 using the plateform classloader as the parent instead of null so that I could access the required modules. Emmanuel Le 29/05/2020 à 17:37, Clebert Suconic a écrit : > We should come back into this... > > > How did you fix the compatibi

Re: Building on Java 11

We should come back into this... How did you fix the compatibility tests with JDK 11? do you need JDK 8 to run the compatibility tests? On Fri, May 8, 2020 at 3:19 PM Emmanuel Hugonnet wrote: > > No relation to WildFly, just for the 'fun' of it and because switching my > JAVA_HOME and PATH eac

Re: svn commit: r39815 - in /release/activemq: 5.15.12/ 5.15.13/

Its best not to add the new release and remove the old release at the same time if possible, since it breaks download links on the website one way or the other over the period as the mirrors update and the site is refreshed. Any given mirror will now only have one of these releases as they update,