Re: Heads up: ActiveMQ 5.x Jakarta broker PR in final review

2023-09-01 Thread Jean-Baptiste Onofré
Hi, FYI, I'm resuming the work on AMQ 5.x in order to head to 5.19.0 release. Regards JB On Wed, Aug 30, 2023 at 4:32 PM Matt Pavlovich wrote: > > Heads up- > > The Jakarta PR is merged. ‘main’ is now JDK 17, Jakarta, Spring 6, Jetty 11 > > Thanks, > Matt Pavlovich > > > On Aug 29, 2023, at 10:

Re: Heads up: ActiveMQ 5.x Jakarta broker PR in final review

2023-08-30 Thread Matt Pavlovich
Heads up- The Jakarta PR is merged. ‘main’ is now JDK 17, Jakarta, Spring 6, Jetty 11 Thanks, Matt Pavlovich > On Aug 29, 2023, at 10:26 AM, Christopher Shannon > wrote: > > Sounds good, I think it's ready to go as anything that needs fixing > shouldn't be major and we have time to fix stuff

Re: Heads up: ActiveMQ 5.x Jakarta broker PR in final review

2023-08-29 Thread Christopher Shannon
Sounds good, I think it's ready to go as anything that needs fixing shouldn't be major and we have time to fix stuff in follow on PRs. It would be good to get 5.19.0 released before too long so it fixes compatibility with Spring 6 and Spring boot 3. When we do release it will be important to have

Re: Heads up: ActiveMQ 5.x Jakarta broker PR in final review

2023-08-29 Thread Matt Pavlovich
Hey Chris— Thanks for the review. I’ll plan to merge the PR this evening and get started on other tasks ahead of release. Thanks, Matt Pavlovich > On Aug 28, 2023, at 5:33 PM, Christopher Shannon > wrote: > > I'm wrapping up my testing now, I've done a lot of thorough testing with my > own c

Re: Heads up: ActiveMQ 5.x Jakarta broker PR in final review

2023-08-28 Thread Christopher Shannon
I'm wrapping up my testing now, I've done a lot of thorough testing with my own custom test suite and things are looking pretty good. Assuming all my tests look good I will approve the PR shortly and I figure we should give it a couple more days and just go ahead and merge the PR if there are no c

Heads up: ActiveMQ 5.x Jakarta broker PR in final review

2023-08-24 Thread Matt Pavlovich
Hey All- Heads up— the PR for Jakarta support for the ActiveMQ 5.x broker is in final review. There are a lot of notes in the PR ticket itself. I suggest scrolling down to the ‘reviewer checklist’ to see the 100 or so files that actually had some code change vs the 1,400+ or so files that have