Re: [VOTE] AIP-16: CLI: Use nested commands instead of flags

2019-06-11 Thread Andrii Soldatenko
+1 (non-binding) On Tue, Jun 11, 2019 at 11:41 PM Maxime Beauchemin < maximebeauche...@gmail.com> wrote: > +1 > > On Tue, Jun 11, 2019 at 12:29 PM Bas Harenslak < > basharens...@godatadriven.com> wrote: > > > +1 (binding) > > > > > > On 11 Jun 2019, at 18:59, Tao Feng > fengta...@gmail.com>>

Re: Tagging of the airflow images

2019-06-11 Thread Jarek Potiuk
It's super easy to do :) On Tue, Jun 11, 2019 at 10:33 PM Ash Berlin-Taylor wrote: > I'm fine with us just publishing release images using the newest python > release (i.e. 3.7) as the main reason we support older python versions is > to support distros thats ship those versions.(i.e. Deb

Re: [VOTE] AIP-16: CLI: Use nested commands instead of flags

2019-06-11 Thread Maxime Beauchemin
+1 On Tue, Jun 11, 2019 at 12:29 PM Bas Harenslak < basharens...@godatadriven.com> wrote: > +1 (binding) > > > On 11 Jun 2019, at 18:59, Tao Feng fengta...@gmail.com>> wrote: > > +1 (binding) > > On Tue, Jun 11, 2019 at 4:15 AM Ash Berlin-Taylor a...@apache.org>> wrote: > > Hi Airflowers, > >

Re: Tagging of the airflow images

2019-06-11 Thread Ash Berlin-Taylor
I'm fine with us just publishing release images using the newest python release (i.e. 3.7) as the main reason we support older python versions is to support distros thats ship those versions.(i.e. Deb stable), but I don't think we need to support that in docker. (But if it's easy to do since

Re: Tagging of the airflow images

2019-06-11 Thread Jarek Potiuk
Yeah Kamil - python 3.5 is the default one for now. I think we should have another discussion here - how many versions to support. There is this ticket opened today : https://issues.apache.org/jira/browse/AIRFLOW-4762 about supporting python 3.6 and 3.7 in tests. Anyone has a strong opinion on

Re: CLI: Use nested commands instead of flags

2019-06-11 Thread Bas Harenslak
My 2c: I googled a bit and checked a few other CLIs. The internet is full of people discussing this topic and there is no straight answer, so pick one and stick with it. Most CLIs seem to use both plural and singular, depending on whether you’re making a request to single resource or multiple

Re: Tagging of the airflow images

2019-06-11 Thread Jarek Potiuk
We are already using version.py which is also used by setup.py so we have one source of truth :). Principal Software Engineer Phone: +48660796129

Re: Tagging of the airflow images

2019-06-11 Thread Driesprong, Fokko
I would prefer to use one repository as well. Building from multiple repositories, in my opinion, this can become very complex, very easily. >From what I understand, we should avoid using the latest tag in Docker. The meaning of the *latest* tag is the latest untagged container. I'm more on the

Re: [VOTE] AIP-16: CLI: Use nested commands instead of flags

2019-06-11 Thread Bas Harenslak
+1 (binding) On 11 Jun 2019, at 18:59, Tao Feng mailto:fengta...@gmail.com>> wrote: +1 (binding) On Tue, Jun 11, 2019 at 4:15 AM Ash Berlin-Taylor mailto:a...@apache.org>> wrote: Hi Airflowers, This email calls for a vote to introduce restructure the CLI to use nested commands instead of

Re: [2.0 spring cleaning] Changes in import paths

2019-06-11 Thread Kamil Breguła
If I added a warning in the method that it calls immediately, IDE still could not detect everything correctly. The user is not able to see the error message in the IDE. The warning appears in the wrong place. https://i.imgur.com/CSqP1wU.png Adding a new import allows you to avoid some IDE

Re: Tagging of the airflow images

2019-06-11 Thread Kamil Breguła
1) I would prefer to use one repository. +1 2) The presented schema looks logical to me. I had doubts whether Python 3.5 was a good choice for "latest" version, but I checked that travis uses only this version. On Tue, Jun 11, 2019 at 3:04 PM Jarek Potiuk wrote: > > Hello everyone, > > We are

Re: CLI: Use nested commands instead of flags

2019-06-11 Thread Kamil Breguła
gcloud use a plurral form. https://cloud.google.com/sdk/gcloud/reference/compute/instances/list On Tue, Jun 11, 2019 at 8:08 PM Ash Berlin-Taylor wrote: > > To bring up the point that William Pursell brought up in the vote thread: > > > Not sure if this is the right place to address minor

Re: CLI: Use nested commands instead of flags

2019-06-11 Thread Ash Berlin-Taylor
To bring up the point that William Pursell brought up in the vote thread: > Not sure if this is the right place to address minor issues, and > perhaps I'm late to the discussion. It would be much more natural to > use singular expressions. eg, > > airflow dag list > airflow pool list > airflow

Re: [VOTE] AIP-16: CLI: Use nested commands instead of flags

2019-06-11 Thread Tao Feng
+1 (binding) On Tue, Jun 11, 2019 at 4:15 AM Ash Berlin-Taylor wrote: > Hi Airflowers, > > This email calls for a vote to introduce restructure the CLI to use nested > commands instead of flags. The vote will last for at least 1 week (June > 18th 12:00 BST), and at least three +1 (binding)

Re: [VOTE] AIP-16: CLI: Use nested commands instead of flags

2019-06-11 Thread William Pursell
Not sure if this is the right place to address minor issues, and perhaps I'm late to the discussion. It would be much more natural to use singular expressions. eg, airflow dag list airflow pool list airflow pool add etc. On Tue, Jun 11, 2019 at 2:57 PM Tolu Fakiyesi wrote: > > +1

Re: [VOTE] AIP-16: CLI: Use nested commands instead of flags

2019-06-11 Thread Sumit Maheshwari
+1 (binding) On Tue, Jun 11, 2019 at 8:19 PM James Meickle wrote: > +1 (non-binding) > > On Tue, Jun 11, 2019 at 7:15 AM Ash Berlin-Taylor wrote: > > > Hi Airflowers, > > > > This email calls for a vote to introduce restructure the CLI to use > nested > > commands instead of flags. The vote

Re: [VOTE] AIP-16: CLI: Use nested commands instead of flags

2019-06-11 Thread Tolu Fakiyesi
+1 (non-binding) On Tue, 11 Jun 2019 at 12:15, Ash Berlin-Taylor wrote: Hi Airflowers, This email calls for a vote to introduce restructure the CLI to use nested commands instead of flags. The vote will last for at least 1 week (June 18th 12:00 BST), and at least three +1 (binding)

Re: [VOTE] AIP-16: CLI: Use nested commands instead of flags

2019-06-11 Thread Arthur Wiedmer
+1 (binding) Best, Arthur On Tue, Jun 11, 2019, 04:15 Ash Berlin-Taylor wrote: > Hi Airflowers, > > This email calls for a vote to introduce restructure the CLI to use nested > commands instead of flags. The vote will last for at least 1 week (June > 18th 12:00 BST), and at least three +1

Re: [VOTE] AIP-16: CLI: Use nested commands instead of flags

2019-06-11 Thread James Meickle
+1 (non-binding) On Tue, Jun 11, 2019 at 7:15 AM Ash Berlin-Taylor wrote: > Hi Airflowers, > > This email calls for a vote to introduce restructure the CLI to use nested > commands instead of flags. The vote will last for at least 1 week (June > 18th 12:00 BST), and at least three +1 (binding)

Re: [VOTE] AIP-16: CLI: Use nested commands instead of flags

2019-06-11 Thread Kamil Breguła
+1 (binding) On Tue, Jun 11, 2019 at 4:45 PM Chen Tong wrote: > +1 (non-binding) > > On Tue, Jun 11, 2019 at 10:34 AM Christian Lellmann > wrote: > > > +1 (non-binding) > > > > Jiajie Zhong schrieb am Di., 11. Juni 2019, > > 13:43: > > > > > +1 (non-binding) > > > > > > > > > Best Wish > > >

Re: [VOTE] AIP-16: CLI: Use nested commands instead of flags

2019-06-11 Thread Szymon Przedwojski
+1 (non-binding) Szymon Przedwojski Polidea | Software Engineer M: +48 500 330 790 <+48500330790> E: szymon.przedwoj...@polidea.com [image: Polidea] Check out our projects! [image: Github]

Re: [VOTE] AIP-16: CLI: Use nested commands instead of flags

2019-06-11 Thread Christian Lellmann
+1 (non-binding) Jiajie Zhong schrieb am Di., 11. Juni 2019, 13:43: > +1 (non-binding) > > > Best Wish > — Jiajie > > > > On Jun 11, 2019, at 19:21, Kaxil Naik kaxiln...@gmail.com>> wrote: > > +1 (binding) > > On Tue, Jun 11, 2019, 12:15 Ash Berlin-Taylor a...@apache.org>> wrote: > > Hi

Tagging of the airflow images

2019-06-11 Thread Jarek Potiuk
Hello everyone, We are close to finish AIP-10 (Airlfow image for CI) and seems that we will start working soon on an official image AIP, but in the meantime we have 1.10.4 release coming and we would like to agree tagging scheme used for the current CI images. We discussed it a bit on Slack, but

Re: [VOTE] AIP-16: CLI: Use nested commands instead of flags

2019-06-11 Thread Jason Rich
+1 > On Jun 11, 2019, at 8:23 AM, Jarek Potiuk wrote: > > +1 (binding) > > On Tue, Jun 11, 2019 at 1:43 PM Jiajie Zhong > wrote: > >> +1 (non-binding) >> >> >> Best Wish >> — Jiajie >> >> >> >> On Jun 11, 2019, at 19:21, Kaxil Naik > kaxiln...@gmail.com>> wrote: >> >> +1 (binding) >>

Re: [VOTE] AIP-16: CLI: Use nested commands instead of flags

2019-06-11 Thread Jiajie Zhong
+1 (non-binding) Best Wish — Jiajie On Jun 11, 2019, at 19:21, Kaxil Naik mailto:kaxiln...@gmail.com>> wrote: +1 (binding) On Tue, Jun 11, 2019, 12:15 Ash Berlin-Taylor mailto:a...@apache.org>> wrote: Hi Airflowers, This email calls for a vote to introduce restructure the CLI to use

Re: [VOTE] AIP-16: CLI: Use nested commands instead of flags

2019-06-11 Thread Kaxil Naik
+1 (binding) On Tue, Jun 11, 2019, 12:15 Ash Berlin-Taylor wrote: > Hi Airflowers, > > This email calls for a vote to introduce restructure the CLI to use nested > commands instead of flags. The vote will last for at least 1 week (June > 18th 12:00 BST), and at least three +1 (binding) votes

[VOTE] AIP-16: CLI: Use nested commands instead of flags

2019-06-11 Thread Ash Berlin-Taylor
Hi Airflowers, This email calls for a vote to introduce restructure the CLI to use nested commands instead of flags. The vote will last for at least 1 week (June 18th 12:00 BST), and at least three +1 (binding) votes have been cast. The original discussion