Re: [DISCUSSION] Specify tasks to skip when triggering DAG

Hi Daniel, Thank you for sharing the `pre_execute` idea. It is a smart idea, and I do believe it would work. But to me, it is more as a walkaround instead of an universal solution. To explain, I would love to discuss the tradeoffs. [Pros] The solution I proposed requires change in either Airflow

Re: [VOTE] deprecate days_ago helper function

+1 (non-binding) On Fri, Feb 4, 2022 at 2:59 PM Jed Cunningham wrote: > +1 (binding) >

Re: [VOTE] deprecate days_ago helper function

+1 (binding)

Re: [VOTE] deprecate days_ago helper function

+1 (non-binding) On Fri, Feb 4, 2022 at 3:03 PM Drew Hubl wrote: > +1 (non-binding) > > On Feb 4, 2022, at 11:59 AM, Dennis Akpenyi > wrote: > > +1 non-binding > > On Fri 4. Feb 2022 at 20:43, Daniel Standish < > daniel.stand...@astronomer.io.invalid> wrote: > >> I suppose I should vote also...

Re: [VOTE] deprecate days_ago helper function

+1 (non-binding) > On Feb 4, 2022, at 11:59 AM, Dennis Akpenyi wrote: > > +1 non-binding > > On Fri 4. Feb 2022 at 20:43, Daniel Standish > wrote: > I suppose I should vote also... > > +1 binding > > On Fri, Feb 4, 2022 at 11:41 AM Tomasz Urbaszek > wrote: > +1

Re: [VOTE] deprecate days_ago helper function

+1 non-binding On Fri 4. Feb 2022 at 20:43, Daniel Standish wrote: > I suppose I should vote also... > > +1 binding > > On Fri, Feb 4, 2022 at 11:41 AM Tomasz Urbaszek > wrote: > >> +1 binding. Just please make sure we do point to resources for keeping >> equivalent behaviour. >> >> On Fri, 4 F

Re: [DISCUSS] how to name classes with abbreviations?

+1 for BranchSqlOperator, easier to read imho On Fri, 4 Feb 2022 at 20:39, Howard Yoo wrote: > Just my two cents : Have preference for not capitalizing all the > characters in abbrevications, so > BranchSqlOperator is totally fine with me. It's also easier to type (less > pressing on Caps key!),

Re: [VOTE] deprecate days_ago helper function

I suppose I should vote also... +1 binding On Fri, Feb 4, 2022 at 11:41 AM Tomasz Urbaszek wrote: > +1 binding. Just please make sure we do point to resources for keeping > equivalent behaviour. > > On Fri, 4 Feb 2022 at 16:14, Arthur Wiedmer wrote: > >> +1 (binding) >> >> On Thu, Feb 3, 2022,

Re: [VOTE] deprecate days_ago helper function

+1 binding. Just please make sure we do point to resources for keeping equivalent behaviour. On Fri, 4 Feb 2022 at 16:14, Arthur Wiedmer wrote: > +1 (binding) > > On Thu, Feb 3, 2022, 17:03 Daniel Standish > wrote: > >> Hi >> >> I would like to call a vote on the following proposal: >> >> Helpe

Re: [DISCUSS] how to name classes with abbreviations?

Just my two cents : Have preference for not capitalizing all the characters in abbrevications, so BranchSqlOperator is totally fine with me. It's also easier to type (less pressing on Caps key!), and also Might be easier to read and check. +1 on that. - Howard On Fri, Feb 4, 2022 at 1:20 PM Ferru

Re: [DISCUSS] how to name classes with abbreviations?

To expand on that thought, I find it easier to parse in cases like SQLAlchemy vs SqlAlchemy. It helps to visually indicate where that acronym stops and the next word starts. From: Ferruzzi, Dennis Sent: Friday, February 4, 2022 11:20 AM To: dev@airflow.apache.o

Re: [DISCUSS] how to name classes with abbreviations?

In December Elad organized a community project (https://github.com/apache/airflow/issues/20139) which included un-PEP-8-ing the Amazon provider package, the all-caps acronyms you see there are/should all be deprecated. That said, I do find it easier to read as `BranchSqlOperator`, so that forma

Re: [DISCUSSION] Specify tasks to skip when triggering DAG

Thanks Jarek, yeah, I wasn't thinking about the trigger rules, hazards of emailing before coffee. On Fri, Feb 4, 2022 at 10:32 AM Jarek Potiuk wrote: > Thanks Daniel, this something I have been thinking about for a while. One >> use case I have is for a dag only gets run on an ad hoc basis, for

Re: [DISCUSSION] Specify tasks to skip when triggering DAG

> > Thanks Daniel, this something I have been thinking about for a while. One > use case I have is for a dag only gets run on an ad hoc basis, for any > combination of a subset of tasks (I recognize this is a rather non-standard > use of airflow). One question though, if you specified skip_list=[“

Re: [DISCUSS] how to name classes with abbreviations?

Surprisingly, as opinionated as I often am, I am happy to follow whatever rules others agree with here :). Even if we agree that "either is ok" and we mix them and keep them inconsistent and even if someone we do this and sometimes that. I simply do not see huge value in standardizing this. Why?

Re: [VOTE] deprecate days_ago helper function

+1 (binding) On Thu, Feb 3, 2022, 17:03 Daniel Standish wrote: > Hi > > I would like to call a vote on the following proposal: > > Helper function `days_ago` is to be deprecated (warning of pending removal > with each call) with removal targeted for 3.0. The deprecation warning > should guide u

Re: [VOTE] deprecate days_ago helper function

+1 (binding) just to be precise. On Fri, Feb 4, 2022 at 1:46 PM Jarek Potiuk wrote: > +1. I think it's a good idea, that will gently guide our users to change > their (bad) habits in DAG authoring, especially when accompanied with > "equivalent behaviour" explanation. > > J. > > > On Fri, Feb 4,

Re: [VOTE] deprecate days_ago helper function

+1. I think it's a good idea, that will gently guide our users to change their (bad) habits in DAG authoring, especially when accompanied with "equivalent behaviour" explanation. J. On Fri, Feb 4, 2022 at 2:03 AM Daniel Standish wrote: > Hi > > I would like to call a vote on the following prop

Re: [DISCUSSION] Specify tasks to skip when triggering DAG

Thanks Daniel, this something I have been thinking about for a while. One use case I have is for a dag only gets run on an ad hoc basis, for any combination of a subset of tasks (I recognize this is a rather non-standard use of airflow). One question though, if you specified skip_list=[“task b”

Re: [DISCUSS] how to name classes with abbreviations?

Thanks for opening this discussion, hopefully we can improve consistency, regardless the outcome. +1 for capitalizing abbreviations. IMO since abbreviations are written capitalised in human language, using the same convention in code gives clarity. Bas > On 4 Feb 2022, at 07:26, Felix Uellenda