ultimately if the bot does something silly (just as a human can and
> often does) we can catch it in the PR review.
> >
> >
> > Cheers,
> > Niko
> >
> > ____
> > From: Wei Lee
> > Sent: Tuesday, January 2, 2024 5:58:18 PM
) we can catch it in the PR review.
>
>
> Cheers,
> Niko
>
>
> From: Wei Lee
> Sent: Tuesday, January 2, 2024 5:58:18 PM
> To: dev@airflow.apache.org
> Subject: RE: [EXTERNAL] [COURRIEL EXTERNE] [DISCUSSION] Enabling
> `pre-commit.ci` application for
PR review.
Cheers,
Niko
From: Wei Lee
Sent: Tuesday, January 2, 2024 5:58:18 PM
To: dev@airflow.apache.org
Subject: RE: [EXTERNAL] [COURRIEL EXTERNE] [DISCUSSION] Enabling
`pre-commit.ci` application for Airflow
CAUTION: This email originated fr
I image and docker.
>>>> Besides security things this would be something that needs testing if it
>>>> works.
>>>>
>>>> TLDR: +1 opinion
>>>>
>>>> Sent from Outlook for iOS<https://aka.ms/o0ukef>
>>>> ___
I image and docker.
>>>> Besides security things this would be something that needs testing if it
>>>> works.
>>>>
>>>> TLDR: +1 opinion
>>>>
>>>> Sent from Outlook for iOS<https://aka.ms/o0ukef>
>>>> ___
gt; stuff as we also depend during execution on the CI image and docker.
> > > Besides security things this would be something that needs testing if it
> > > works.
> > >
> > > TLDR: +1 opinion
> > >
> > > Sent from Outlook for iOS<https://aka.ms/o0uke
/aka.ms/o0ukef>
> >
> > From: Pankaj Koti
> > Sent: Saturday, December 30, 2023 7:50:10 AM
> > To: dev@airflow.apache.org
> > Subject: Re: [DISCUSSION] Enabling `pre-commit.ci` application for
> Airflow
> >
> > I ver
urday, December 30, 2023 7:50:10 AM
> To: dev@airflow.apache.org
> Subject: Re: [DISCUSSION] Enabling `pre-commit.ci` application for Airflow
>
> I very much like the concept. We have been using it actively for Astronomer
> code repositories for 1+ year already and it has helped us gre
things this would be something that needs testing if it works.
TLDR: +1 opinion
Sent from Outlook for iOS<https://aka.ms/o0ukef>
From: Pankaj Koti
Sent: Saturday, December 30, 2023 7:50:10 AM
To: dev@airflow.apache.org
Subject: Re: [DISCUSSION] Enablin
I very much like the concept. We have been using it actively for Astronomer
code repositories for 1+ year already and it has helped us greatly (Thanks
to Felix Uellendall for introducing this back then )
On Sat, 30 Dec 2023, 12:10 Jarek Potiuk, wrote:
> FYI - Just now INFRA rejected the
FYI - Just now INFRA rejected the request on the basis of "code write"
access permissions the app needs.
I'd still love to get feedback though on the concept - I am not giving up
that easily. We might still get it approved easily. We likely have some
ways we can get "auto-fixing" working for us.
Hello everyone,
TL;DRl; I'd like to propose that we enable the pre-commit-ci GitHub
application for Airflow repo. According to how I understand it works, it
should greatly reduce friction (especially for new contributors) for
passing the quality gates for our pre-commits. That is - if we get the
12 matches
Mail list logo