Re: [PROPOSAL] Removal of Python2 "virtualenv" support in Airlfow 2.3 ?

2022-01-05 Thread Jarek Potiuk
PR here: https://github.com/apache/airflow/pull/20680 On Wed, Dec 22, 2021 at 9:43 PM Kaxil Naik wrote: > > +1 > > On Wed, Dec 22, 2021 at 1:07 AM Leah Cole wrote: >> >> +1 for removal! >> >> On Tue, Dec 21, 2021 at 7:22 AM Tomasz Urbaszek wrote: >>> >>> +1 >>> >>> On Tue, 21 Dec 2021 at 16:19,

Re: [PROPOSAL] Removal of Python2 "virtualenv" support in Airlfow 2.3 ?

2021-12-22 Thread Kaxil Naik
+1 On Wed, Dec 22, 2021 at 1:07 AM Leah Cole wrote: > +1 for removal! > > On Tue, Dec 21, 2021 at 7:22 AM Tomasz Urbaszek > wrote: > >> +1 >> >> On Tue, 21 Dec 2021 at 16:19, Elad Kalif wrote: >> >>> +1 >>> >>> On Tue, Dec 21, 2021 at 4:02 PM Ash Berlin-Taylor >>> wrote: >>> +1

Re: [PROPOSAL] Removal of Python2 "virtualenv" support in Airlfow 2.3 ?

2021-12-21 Thread Tomasz Urbaszek
+1 On Tue, 21 Dec 2021 at 16:19, Elad Kalif wrote: > +1 > > On Tue, Dec 21, 2021 at 4:02 PM Ash Berlin-Taylor wrote: > >> +1 >> >> On 21 December 2021 13:41:53 GMT, Jarek Potiuk wrote: >>> >>> Following the discussion in >>> https://github.com/apache/airflow/pull/20238#issuecomment-998780796 >

Re: [PROPOSAL] Removal of Python2 "virtualenv" support in Airlfow 2.3 ?

2021-12-21 Thread Elad Kalif
+1 On Tue, Dec 21, 2021 at 4:02 PM Ash Berlin-Taylor wrote: > +1 > > On 21 December 2021 13:41:53 GMT, Jarek Potiuk wrote: >> >> Following the discussion in >> https://github.com/apache/airflow/pull/20238#issuecomment-998780796 >> >> Should we completely remove tests and python2 binary with Pyt

Re: [PROPOSAL] Removal of Python2 "virtualenv" support in Airlfow 2.3 ?

2021-12-21 Thread Ash Berlin-Taylor
+1 On 21 December 2021 13:41:53 GMT, Jarek Potiuk wrote: >Following the discussion in >https://github.com/apache/airflow/pull/20238#issuecomment-998780796 > >Should we completely remove tests and python2 binary with Python 2 >from the reference image? > >We still keep Python 2 installed in our Re

Re: [PROPOSAL] Removal of Python2 "virtualenv" support in Airlfow 2.3 ?

2021-12-21 Thread Bas Harenslak
+1 for removing it. Had a think whether removing the Python 2 binaries in Airflow 2.3 is right, or if we should first explicitly state the future removal. Since Python 2 has been EOL for a long time + we've advised Python 3 in the docs for a long time + users can still use Python 2 by installin

[PROPOSAL] Removal of Python2 "virtualenv" support in Airlfow 2.3 ?

2021-12-21 Thread Jarek Potiuk
Following the discussion in https://github.com/apache/airflow/pull/20238#issuecomment-998780796 Should we completely remove tests and python2 binary with Python 2 from the reference image? We still keep Python 2 installed in our Reference Images and we have tests in our CI that test that Python 2