Re: PR Descriptions

2020-09-10 Thread Kaxil Naik
xt, I am not > >> > sure what the change does" even before looking at the code IMHO. If we > >> > all do that - this will be much more effective than writing it in the > >> > template. > >> > > >> > J > >> > > >>

Re: PR Descriptions

2020-09-10 Thread Jarek Potiuk
gt; it should be the first point to say "please provider context, I am not > >> > sure what the change does" even before looking at the code IMHO. If we > >> > all do that - this will be much more effective than writing it in the > >>

Re: PR Descriptions

2020-09-10 Thread Ash Berlin-Taylor
gt; > all do that - this will be much more effective than writing it in the >> > template. >> > >> > J >> > >> > On Thu, Sep 10, 2020 at 3:14 PM Ry Walker wrote: >> > > >> > > Maybe modify the template to include some copy from your email

Re: PR Descriptions

2020-09-10 Thread Ash Berlin-Taylor
; template. >> >> J >> >> On Thu, Sep 10, 2020 at 3:14 PM Ry Walker wrote: >> > >> > Maybe modify the template to include some copy from your email in >> it :) >> > >> > On Sun, Sep 6, 2020 at 6:56 AM Kaxil Naik wrote: >&

Re: PR Descriptions

2020-09-10 Thread Jarek Potiuk
clude some copy from your email in it :) > > > > > > On Sun, Sep 6, 2020 at 6:56 AM Kaxil Naik wrote: > > > > > > > Hi all, > > > > > > > > I have brought this topic on multiple occasions earlier too on the > mailing > > >

Re: PR Descriptions

2020-09-10 Thread Tomasz Urbaszek
ep 6, 2020 at 6:56 AM Kaxil Naik wrote: > > > > > Hi all, > > > > > > I have brought this topic on multiple occasions earlier too on the mailing > > > list. I sincerely request all the contributors and Committers (including > > > myself) that we add PR de

Re: PR Descriptions

2020-09-10 Thread Jarek Potiuk
ybe modify the template to include some copy from your email in it :) > > On Sun, Sep 6, 2020 at 6:56 AM Kaxil Naik wrote: > > > Hi all, > > > > I have brought this topic on multiple occasions earlier too on the mailing > > list. I sincerely request all the contri

Re: PR Descriptions

2020-09-10 Thread Ry Walker
ing > myself) that we add PR descriptions. > > This helps the community understand what the PRs do and abides by the ASF > motto about "Community above Code", many users lands to the PR after > checking change log and having to look at the code to understand the PR is > not

Re: PR Descriptions

2020-09-06 Thread Jarek Potiuk
+10 On Sun, Sep 6, 2020 at 12:56 PM Kaxil Naik wrote: > > Hi all, > > I have brought this topic on multiple occasions earlier too on the mailing > list. I sincerely request all the contributors and Committers (including > myself) that we add PR descriptions. > >

PR Descriptions

2020-09-06 Thread Kaxil Naik
Hi all, I have brought this topic on multiple occasions earlier too on the mailing list. I sincerely request all the contributors and Committers (including myself) that we add PR descriptions. This helps the community understand what the PRs do and abides by the ASF motto about "Community