Re: Custom BashSensor

2017-12-27 Thread Diogo Franco
Could someone look into merging this? https://github.com/apache/incubator-airflow/pull/2489 I've been actively maintaining it conflict free for some months. Thanks! Cheers, Diogo On 4 August 2017 at 15:50, Diogo Franco wrote: > A PR implementing this is here https://github.com/ > apache/incuba

Re: Custom BashSensor

2017-08-04 Thread Diogo Franco
A PR implementing this is here https://github.com/apache/incubator-airflow/pull/2489 Cheers, Diogo On 30 July 2017 at 14:29, Diogo Franco wrote: > Hi Maxime, > > Awesome, I also believe PythonSensor makes sense in the core package of > course. These also allow someone trying out airflow to easi

Re: Custom BashSensor

2017-07-30 Thread Diogo Franco
Hi Maxime, Awesome, I also believe PythonSensor makes sense in the core package of course. These also allow someone trying out airflow to easily build dag's with sensors without setting up connections, for example. I'll open a different ticket for PythonSensor and do it separately, if that is ok.

Re: Custom BashSensor

2017-07-30 Thread Stefano Baghino
I see, thanks for the clarification! On Sun, Jul 30, 2017 at 3:24 PM, Diogo Franco wrote: > I believe that wouldn't be equivalent, as the use case here is to keep > poking until a script/bash command returns 0. > > To clarify, I needed this because I wanted to wait for a certain condition > to b

Re: Custom BashSensor

2017-07-30 Thread Diogo Franco
I believe that wouldn't be equivalent, as the use case here is to keep poking until a script/bash command returns 0. To clarify, I needed this because I wanted to wait for a certain condition to become True, but checking that condition meant SSH'ing into a machine and looking for the presence of a

Re: Custom BashSensor

2017-07-28 Thread Maxime Beauchemin
BashSensor would be a good contribution. I'm guessing that the reason why it doesn't exist or (PythonSensor doesn't exist for that matter) is that it's pretty easy to derive BaseSensorOperator and make your own. It still would be neat to have it in the core package and in the docs. Max On Fri, J

Re: Custom BashSensor

2017-07-28 Thread Stefano Baghino
Couldn't this be achieved by simply making the script that needs the sensor a dependency of the one that emits the return code? On Fri, Jul 28, 2017 at 4:12 PM, Diogo Franco wrote: > Hi, > > I was looking for a sensor that allowed me to customize the sensing logic. > I couldn't find any way of d

Custom BashSensor

2017-07-28 Thread Diogo Franco
Hi, I was looking for a sensor that allowed me to customize the sensing logic. I couldn't find any way of doing this and wrote a BashSensor, which returns True or False based on a command/script's return code. The implementation is similar to the BashOperator, and it seems to me that it would fit