Re: Review Request 43663: PXF Service checks fails with timeout

2016-02-22 Thread jun aoki
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43663/#review120191 --- Ship it! Ship It! - jun aoki On Feb. 21, 2016, 2:19 a.m., bh

Re: Review Request 43663: PXF Service checks fails with timeout

2016-02-22 Thread jun aoki
> On Feb. 22, 2016, 8 p.m., jun aoki wrote: > > Ship It! With InlineTemplate, it is much clearer! - jun --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43663/#review120191 ---

Re: Review Request 43663: PXF Service checks fails with timeout

2016-02-21 Thread Matt
> On Feb. 21, 2016, 2:47 p.m., Matt wrote: > > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py, > > line 261 > > > > > > Do you think we should call __cleanup_hbase_data b

Re: Review Request 43663: PXF Service checks fails with timeout

2016-02-21 Thread bhuvnesh chaudhary
> On Feb. 21, 2016, 10:47 p.m., Matt wrote: > > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py, > > line 261 > > > > > > Do you think we should call __cleanup_hbase_data

Re: Review Request 43663: PXF Service checks fails with timeout

2016-02-21 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43663/#review120079 --- ambari-server/src/main/resources/common-services/PXF/3.0.0/packag

Re: Review Request 43663: PXF Service checks fails with timeout

2016-02-20 Thread bhuvnesh chaudhary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43663/ --- (Updated Feb. 21, 2016, 2:19 a.m.) Review request for Ambari, Alejandro Fernand

Re: Review Request 43663: PXF Service checks fails with timeout

2016-02-18 Thread bhuvnesh chaudhary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43663/ --- (Updated Feb. 19, 2016, 4:39 a.m.) Review request for Ambari, Alejandro Fernand

Re: Review Request 43663: PXF Service checks fails with timeout

2016-02-18 Thread bhuvnesh chaudhary
> On Feb. 19, 2016, 1:37 a.m., jun aoki wrote: > > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/files/hbase-cleanup-data.sh, > > line 22 > > > > > > Could this be InlineTemplate? will do > On

Re: Review Request 43663: PXF Service checks fails with timeout

2016-02-18 Thread jun aoki
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43663/#review119764 --- ambari-server/src/main/resources/common-services/PXF/3.0.0/packag

Re: Review Request 43663: PXF Service checks fails with timeout

2016-02-18 Thread bhuvnesh chaudhary
> On Feb. 17, 2016, 7:52 p.m., Matt wrote: > > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py, > > line 329 > > > > > > May be str(hive_load_commands) ? Its a string, so

Re: Review Request 43663: PXF Service checks fails with timeout

2016-02-18 Thread bhuvnesh chaudhary
> On Feb. 17, 2016, 7:52 p.m., Matt wrote: > > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/files/hbase-populate-data.sh, > > line 21 > > > > > > Why are the table names hardcoded here and not u

Re: Review Request 43663: PXF Service checks fails with timeout

2016-02-17 Thread bhuvnesh chaudhary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43663/ --- (Updated Feb. 17, 2016, 10:46 p.m.) Review request for Ambari, Alejandro Fernan

Re: Review Request 43663: PXF Service checks fails with timeout

2016-02-17 Thread bhuvnesh chaudhary
> On Feb. 17, 2016, 7:52 p.m., Matt wrote: > > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py, > > line 271 > > > > > > Is it required to write these files everytime serv

Re: Review Request 43663: PXF Service checks fails with timeout

2016-02-17 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43663/#review119518 --- Fix it, then Ship it! ambari-server/src/main/resources/common-

Review Request 43663: PXF Service checks fails with timeout

2016-02-17 Thread bhuvnesh chaudhary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43663/ --- Review request for Ambari, Alejandro Fernandez, jun aoki, Jayush Luniya, Oleksan