Re: ant git commit: Inline buildfile names, make search easier

2018-04-30 Thread Gintautas Grigelionis
2018-04-30 13:13 GMT+00:00 Stefan Bodewig : > On 2018-04-30, Gintautas Grigelionis wrote: > > the overarching goal, however, is to reduce verbosity, because > > verbosity makes it easier to hide mistakes. > > This is your goal and we should have decided together whether we agree > on this goal. Th

Re: ant git commit: Inline buildfile names, make search easier

2018-04-30 Thread Stefan Bodewig
On 2018-04-30, Gintautas Grigelionis wrote: > I do realize that some changes might be a subject for discussion; Gintas, please try to see what the others are saying. Most of the changes are changes that nobody of those who've spoken up consider improvements at all - apart from yourself. The outco

Re: ant git commit: Inline buildfile names, make search easier

2018-04-30 Thread Gintautas Grigelionis
2018-04-30 11:20 GMT+00:00 Jan Matèrne (jhm) : > For that single point I think parametrization is 'good'. > If I count right, it impacted three test classes. > Why change all the others? > > Starting a discussion before such big changes would also be helpful. > Just to pick a nit, there are 9 par

AW: ant git commit: Inline buildfile names, make search easier

2018-04-30 Thread jhm
> > In my eyes most of the committers don't like these "code style" > changes. > > So please stop these changes and invest your energy more productive. > > > > I don't think it would be helpful if another committer starts > > reverting the changes because of a different preference ... > > > With

Re: ant git commit: Inline buildfile names, make search easier

2018-04-30 Thread Gintautas Grigelionis
2018-04-30 10:45 GMT+00:00 Jan Matèrne (jhm) : > In my eyes most of the committers don't like these "code style" changes. > So please stop these changes and invest your energy more productive. > > I don't think it would be helpful if another committer starts reverting the > changes because of a di

Re: ant git commit: Inline buildfile names, make search easier

2018-04-30 Thread Gintautas Grigelionis
2018-04-30 10:43 GMT+00:00 Jaikiran Pai : > > On 30/04/18 12:52 PM, Gintautas Grigelionis wrote: > >> My apologies for offending anyone; just one last silly question: why >> uniformity is not a requirement? >> > I think it has already been explained in the other thread why it's not a > necessity f

Re: ant git commit: Inline buildfile names, make search easier

2018-04-30 Thread Gintautas Grigelionis
2018-04-30 10:35 GMT+00:00 Jaikiran Pai : > > On 30/04/18 3:52 PM, Gintautas Grigelionis wrote: > >> 2018-04-30 9:55 GMT+00:00 Stefan Bodewig : >> >> On 2018-04-30, Gintautas Grigelionis wrote: >>> >>> My apologies for offending anyone; just one last silly question: why uniformity is not a re

AW: ant git commit: Inline buildfile names, make search easier

2018-04-30 Thread jhm
> > Changes like these are random personal preferences. > > Right. > > > The fact that these are being done even after the mail discussions we > > recently had, indicates that the request to not do such changes have > > been ignored. This is going down the route of a being some kind of a > > pers

Re: ant git commit: Inline buildfile names, make search easier

2018-04-30 Thread Jaikiran Pai
On 30/04/18 12:52 PM, Gintautas Grigelionis wrote: My apologies for offending anyone; just one last silly question: why uniformity is not a requirement? I think it has already been explained in the other thread why it's not a necessity for a project as large and as old as this one, especially w

Re: ant git commit: Inline buildfile names, make search easier

2018-04-30 Thread Nicolas Lalevée
> Le 30 avr. 2018 à 11:58, Stefan Bodewig a écrit : > > On 2018-04-30, Jaikiran Pai wrote: > >> Changes like these are random personal preferences. > > Right. > >> The fact that these are being done even after the mail discussions we >> recently had, indicates that the request to not do such

Re: ant git commit: Inline buildfile names, make search easier

2018-04-30 Thread Jaikiran Pai
On 30/04/18 3:52 PM, Gintautas Grigelionis wrote: 2018-04-30 9:55 GMT+00:00 Stefan Bodewig : On 2018-04-30, Gintautas Grigelionis wrote: My apologies for offending anyone; just one last silly question: why uniformity is not a requirement? Who's uniformity do you pick? There are so many choi

Re: ant git commit: Inline buildfile names, make search easier

2018-04-30 Thread Gintautas Grigelionis
2018-04-30 9:55 GMT+00:00 Stefan Bodewig : > On 2018-04-30, Gintautas Grigelionis wrote: > > > My apologies for offending anyone; just one last silly question: why > > uniformity is not a requirement? > > Who's uniformity do you pick? There are so many choices that only depend > on taste. > > asse

Re: ant git commit: Inline buildfile names, make search easier

2018-04-30 Thread Stefan Bodewig
On 2018-04-30, Jaikiran Pai wrote: > Changes like these are random personal preferences. Right. > The fact that these are being done even after the mail discussions we > recently had, indicates that the request to not do such changes have > been ignored. This is going down the route of a being s

Re: ant git commit: Inline buildfile names, make search easier

2018-04-30 Thread Stefan Bodewig
On 2018-04-30, Gintautas Grigelionis wrote: > My apologies for offending anyone; just one last silly question: why > uniformity is not a requirement? Who's uniformity do you pick? There are so many choices that only depend on taste. assertEquals(x, y) vs assertThat(y, equalTo(x)) amd many many s

[GitHub] ant issue #54: Let’s use Ivy (properly!) and drop Maven Ant tasks + Common...

2018-04-30 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/54 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Windows/57/ ---

[GitHub] ant issue #54: Let’s use Ivy (properly!) and drop Maven Ant tasks + Common...

2018-04-30 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/54 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Linux/51/ --- --

Re: ant git commit: Inline buildfile names, make search easier

2018-04-30 Thread Gintautas Grigelionis
My apologies for offending anyone; just one last silly question: why uniformity is not a requirement? I believe that even one language that espoused TMTOWDI has moved to TIMTOWTDIBSCINABTE? Gintas 2018-04-30 5:56 GMT+00:00 Jaikiran Pai : > > On 30/04/18 11:12 AM, Gintautas Grigelionis wrote: > >