Re: Hoped for advantages of migrating to git

On Mon, May 5, 2014 at 8:22 AM, Nicolas Lalevée wrote: > once a committer is satisfied with the result, the work is being imported > into the git repo with a script A much more straightforward workflow is just to do all work in the GitHub repo, accepting pull requests simply by pressing the Merg

AntClassLoader performance problem

Just an FYI that resource loading in AntClassLoader can be extremely inefficient; this change https://github.com/jenkinsci/jenkins/commit/9a2882dd704bece9b7ca51a52347dad15d79f843#diff-8350d999dfd5b0afa845690062db133fR250 in a modular system resulted in a 2–3 order of magnitude (!) improvement in

Re: svn commit: r1560253 - in /ant/core/trunk: WHATSNEW src/main/org/apache/tools/ant/taskdefs/Javadoc.java

FYI there is a FindBugs rule for this.

Re: unpredictable failure of FileChannel#transferFrom

On Sat, Jan 4, 2014 at 10:23 AM, Stefan Bodewig wrote: > all Ant sees is a plain IOException so we cannot handle the case by falling > back to stream based copying. Why not? Even if the IOException is “genuine” (missing permissions, etc.), a fallback to stream copying would presumably fail with

Re: svn commit: r1554684 - in /ant/core/trunk: ./ src/main/org/apache/tools/ant/ src/main/org/apache/tools/ant/helper/ src/main/org/apache/tools/ant/taskdefs/ src/main/org/apache/tools/ant/types/

On Wed, Jan 1, 2014 at 4:55 PM, wrote: > +URLConnection conn = resource.openConnection(); > +conn.setDefaultUseCaches(false); > +ArgumentProcessor processor = > getProcessorByService(conn.getInputStream()); Why setDefaultUseCaches, whi

Re: svn commit: r1554758 - in /ant/core/trunk: WHATSNEW src/main/org/apache/tools/ant/AntClassLoader.java src/tests/antunit/taskdefs/optional/junit/junit-test.xml src/tests/junit/org/apache/tools/ant/

On Thu, Jan 2, 2014 at 2:22 AM, wrote: > +try { > +jarFile = new JarFile(file); > +} catch (ZipException notAJar) { > +// raised if a file that is not a ZIP Would also be thrown if the file _i

Re: Future of JDK 5 support in Ant

On 07/19/2013 11:00 AM, Stefan Bodewig wrote: · javax.script instead of having to depend on BSH we already do that. Well, using reflection yes; the same is true of some other post-5 APIs. Updating the minimum version would merely allow the code to be simplified. ---

Future of JDK 5 support in Ant

It has now been almost a year and a half since I called a vote to drop JDK 1.4 support for 1.9.0. Is anyone thinking about when to drop JDK 5 support for running Ant itself, e.g. in 1.10.0 or whatever? (Keeping the ability to fork older tools for etc. of course.) Jenkins has already done so in de

Re: [VOTE] Release Ant 1.9.2

+1; a contact at NetBeans did some sanity checking at my suggestion (especially Javadoc generation on JDK 7u21 and 7u25) and said it was OK. Thanks Stefan for taking the initiative on this! - To unsubscribe, e-mail: dev-unsubsc

Version updates in BZ

E.g. https://issues.apache.org/bugzilla/show_bug.cgi?id=54583 Antoine Levy-Lambert changed: What|Removed |Added Version|1.9.0 |1.9.1 Is this really

Re: [VOTE] Ant 1.9.1 Release

+1; my NetBeans colleagues say an exploratory integration went well. - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

Re: JUnit4 requirement

On 04/03/2013 12:14 AM, Stefan Bodewig wrote: I don't really have an opinion myself whether we still want to support JUnit 3.x or not. To be clear, we absolutely need to support 3.x *tests*. The question is whether we want to mandate that junit-4.*.jar be in the test classpath even for project

Re: svn commit: r1462931 - in /ant/core/trunk: WHATSNEW manual/Tasks/ear.html manual/Tasks/jar.html manual/Tasks/war.html manual/Tasks/zip.html

On 03/31/2013 02:20 PM, Stefan Bodewig wrote: compressing to a temporary buffer perhaps? We do so for STORED entries and risk OutOfMemoryExceptions (we could throw away the buffer and just count). The performance impact would be non-trivial for big files, which is what Zip64 really is about.

Re: svn commit: r1462911 - in /ant/core/trunk/src: main/org/apache/tools/ant/taskdefs/Jar.java main/org/apache/tools/ant/taskdefs/Zip.java tests/junit/org/apache/tools/ant/taskdefs/ZipExtraFieldTest.j

On 03/31/2013 02:23 PM, Stefan Bodewig wrote: I must admit I haven't checked whether IntrospectionHelper supports enums, does it do so already? If so, great. Yes, see getEnumSetter. If I want a different string representation like "as-needed" then I still end up writing a mapping class Or

Re: svn commit: r1462931 - in /ant/core/trunk: WHATSNEW manual/Tasks/ear.html manual/Tasks/jar.html manual/Tasks/war.html manual/Tasks/zip.html

On 03/31/2013 07:24 AM, bode...@apache.org wrote: +When Ant writes compressed entries into the archive it creates it + doesn't know the compressed size of an entry before it has been + written. Unfortunately the decision whether a Zip64 extra field + will be written has to be made before writ

Re: svn commit: r1462911 - in /ant/core/trunk/src: main/org/apache/tools/ant/taskdefs/Jar.java main/org/apache/tools/ant/taskdefs/Zip.java tests/junit/org/apache/tools/ant/taskdefs/ZipExtraFieldTest.j

On 03/31/2013 06:22 AM, bode...@apache.org wrote: +public static final class Zip64ModeAttribute extends EnumeratedAttribute { BTW for new code you can simply use an enum. - To unsubscribe, e-mail: dev-unsubscr...@ant.apach

Re: svn commit: r1460264 - in /ant/core/trunk: WHATSNEW build.xml src/etc/poms/ant-junit/pom.xml src/etc/poms/ant-junit4/ src/etc/poms/pom.xml

On 03/27/2013 06:48 PM, Michael Clarke wrote: https://github.com/mc1arke/ant/commits/JUnitNonTestsSkipped FYI: the more helpful URL is https://github.com/mc1arke/ant/compare/JUnitNonTestsSkipped which shows that you have mixed some changes into this branch which do not really belong there.

Re: svn commit: r1461421 - in /ant/core/trunk/manual/Tasks: ear.html jar.html war.html zip.html

On 03/27/2013 02:02 AM, bode...@apache.org wrote: URL: http://svn.apache.org/viewvc/ant/core/trunk/manual/Tasks/zip.html?rev=1461421&r1=1461420&r2=1461421&view=diff - Possible values are "never", "always" and "not-encodable" + Possible values are "never", "always" and "not-encodeable"

Re: [VOTE] Michael Clarke as a committer

+1. - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

Re: [VOTE] Ant 1.9.0 release [2nd attempt]

“Changes that could break older environments” fails to list the Java 5 requirement! Typo in WHATSNEW: “NullPointerExcpetion” Otherwise, +1. - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-m

Contributions (was: Re: Suggestion - JUnit4 tests for Ant)

First, BuildFileRule sounds like a great idea; do not see a patch so cannot comment further. Second, should Michael just be nominated as a committer? The @Ignore change was complex and valuable, and refactoring unit tests demonstrates serious intent. Third, why are we still using Subversion wh

Re: [Bug 54641] XSLTC problem with StringUtils

On 03/05/2013 11:19 PM, Antoine Levy Lambert wrote: can this problem with the junit-frames.xsl wait for ant 1.9.1 ? I feel like making another release in one month to 6 weeks from now. If you are volunteering to do another release that soon, then sure! I marked it high priority since it seems

Re: Build failed in Jenkins: Ant-Build-Matrix » JDK 1.6 (latest),Windows #555

On 03/06/2013 07:44 AM, Jesse Glick wrote: Perhaps the test itself somehow kills the test runner? More likely an OOME of some kind; asked for help on bui...@apache.org. - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org

Re: Build failed in Jenkins: Ant-Build-Matrix » JDK 1.6 (latest),Windows #555

On 03/05/2013 11:13 PM, Apache Jenkins Server wrote: [exec] [au:antunit] Build File: [exec] [au:antunit] Tests run: 30, Failures: 0, Error

Re: [VOTE] Ant 1.9.0 release

On 03/05/2013 08:45 PM, Jesse Glick wrote: Reproducible locally when running on Java 7. Not yet sure what it means but it looks bad. https://issues.apache.org/bugzilla/show_bug.cgi?id=54641 - To unsubscribe, e-mail: dev

Re: [VOTE] Ant 1.9.0 release

On 03/04/2013 11:25 PM, Antoine Levy Lambert wrote: in fact the patch is failing one test : testTestMethods in junit-test.xml Now fixed? Reports: skipping tests since it fails when using JUnit 4 But there is one genuine failure I know about, which predates @Ignore support: https://builds.ap

Re: svn commit: r1453118 - in /ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/junit: BriefJUnitResultFormatter.java PlainJUnitResultFormatter.java TestListenerWrapper.java XMLJUnitResu

On 03/05/2013 08:29 PM, jgl...@apache.org wrote: -if (annotation != null && annotation.value() != null && !annotation.value().isEmpty()) { +if (annotation != null && annotation.value().length() > 0) { (And yes removing the null check was intentional—annotation values ar

Re: svn commit: r1452722 - in /ant/core/trunk: WHATSNEW lib/optional/hamcrest-core-1.3.jar src/etc/poms/ant-junit4/pom.xml src/etc/testcases/taskdefs/optional/junit.xml

On 03/05/2013 05:29 AM, anto...@apache.org wrote: adding hamcrest to the lib/optional because it is required at runtime for some tests, also bumping junit dependency in pom file URL: http://svn.apache.org/viewvc/ant/core/trunk/src/etc/testcases/taskdefs/optional/junit.xml?rev=1452722&r1=145272

Re: [VOTE] Ant 1.9.0 release

-0. My main reservation is that an important patch, JUnit @Ignore support [1], is outstanding. (I promised Michael Clarke it would get reviewed.) It could be pushed back to 1.9.1 of course, but that could be a long way off. [1] https://issues.apache.org/bugzilla/show_bug.cgi?id=43969 -

Re: Ant 1.9.0

On 02/19/2013 10:31 AM, Justin Georgeson wrote: have an issue with the javac task and package-info.class Please use Bugzilla to report things like this. - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional

Re: Ant 1.9.0

On 01/30/2013 10:09 PM, Antoine Levy Lambert wrote: Are there other bugs - ideally with patches - that the community needs? Those with PatchAvailable [1] should be checked. (Pity that we cannot just get pull requests; coming from the land of GitHub this feels really primitive.) There were a fa

Re: svn commit: r1429602 - in /ant/core/trunk: WHATSNEW src/main/org/apache/tools/ant/taskdefs/optional/ssh/SSHBase.java

On 01/06/2013 04:46 PM, anto...@apache.org wrote: URL: http://svn.apache.org/viewvc/ant/core/trunk/WHATSNEW?rev=1429602&r1=1429601&r2=1429602&view=diff @@ -1,4 +1,4 @@ -Changes from Ant 1.8.4 TO Ant 1.9.0 +Changes from Ant 1.8.4 TO Ant 1.9.0 Why the indentation? --

Re: New External Task: Reencode

On 10/23/2012 08:25 AM, Nick Watts wrote: I would like to have this task added to the "External Tools and Tasks" page. http://ant.apache.org/external.html#Reencode - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For

Re: File.toURL() and org.apache.tools.ant.launch.Locator.fileToURL(File)

On 08/22/2012 02:30 PM, Nicolas Lalevée wrote: I could not think we can put 4 slashes file:server/share/path is the broken result of new File("server\\share\\path").toURI(). While new File(URI) works to round-trip it (IIRC), if you call URI.normalize() or otherwise do any kind of inter

Re: File.toURL() and org.apache.tools.ant.launch.Locator.fileToURL(File)

On 08/22/2012 08:50 AM, Nicolas Lalevée wrote: Don't understand the encoding issue there, since we are manipulating Strings. But String's which represent pathnames on an OS which might natively represent pathnames as octet sequences in some encoding. Again I am not sure what the defining examp

Re: File.toURL() and org.apache.tools.ant.launch.Locator.fileToURL(File)

On 08/21/2012 03:13 PM, Nicolas Lalevée wrote: Or is there some code which rely on the broken behavior? Not that I know of. See the various commented-out code blocks and "XXX" comments in this class; it has a long and messy history. I do not know whether the current code successfully works aro

Re: File.toURL() and org.apache.tools.ant.launch.Locator.fileToURL(File)

On 08/21/2012 03:41 PM, Martin Gainty wrote: Make sure you catch IllegalArgumentException - If this URL is not absolute Should never happen in this case. MalformedURLException - If a protocol handler for the URL could not be found, or if some other error occurred while constructing

Re: deprecations

On 08/20/2012 01:52 PM, Matt Benson wrote: There are lots of methods in Ant's source that have been deprecated since e.g. v1.6. Does anyone object to removing deprecated methods for Ant 1.9? I think OK so long as you are talking about members in the Java API - I guess we are still keeping co

Re: Request for list of core classes in Apache Ant

On 04/15/2012 06:53 PM, Phillip Meyer wrote: If any list like this already exists, please let me know. Not that I know of, though the section of the manual that deals with extending or embedding Ant at the Java level [1] refers to a variety of types which would generally be thought of as "core

Re: AntUnit test failures in Jenkins

Looks like Ant-Build-Matrix is finally fixed! I have reenabled mail sent to notificati...@ant.apache.org so we can track regressions. - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev

Re: Merging to the 1.8.x branch

On 03/16/2012 04:48 PM, Bruce Atherton wrote: If there are bug fixes that need to go into a future 1.8.4 release we can deal with them when the time comes. Agreed, i.e. option 2. Rather than sifting through all commits made into trunk - which besides Java 5 could include all sorts of code clea

Re: Java5 move and Jenkins

On 03/09/2012 04:16 AM, Nicolas Lalevée wrote: As a quick fix I guess we can add in the command line launched by Jenkins a -Djava.io.tmpdir=$WORKSPACE/tmpdir I guess that would work for the AntUnit tests, so try that. For JUnit tests it would probably have no effect since these run in a forke

Re: Java5 move and Jenkins

On 03/08/2012 12:04 AM, Stefan Bodewig wrote: do we have to do anything special to provide the Jenkins build with a ${java.to.tmpdir} that it actually is allowed to write to? Using ${java.io.tmpdir} from tests is a bit dangerous anyway; the files may rarely or never get cleaned up, you need to

Re: Java5 move and Jenkins

On 03/06/2012 06:21 PM, Jesse Glick wrote: #462 shows tons of AntUnit failures BTW I disabled email notifications as it looks like we are a long way from fixing all of these tests. - To unsubscribe, e-mail: dev-unsubscr

Re: Java5 move and Jenkins

On 03/06/2012 12:53 PM, Nicolas Lalevée wrote: [AntUnit] results were not aggregated by Jenkins. I have fixed it. Confirmed; #462 shows tons of AntUnit failures. Whoever wrote these tests and is still around, consider reviewing them. (I do not think it is safe to do much of anything in trunk u

Re: Java5 move and Jenkins

On 03/05/2012 01:33 PM, Jesse Glick wrote: I am looking into some of the test failures. I think I have fixed most of the failures, though there are still some things that seem to fail at random, especially on Windows. Two points of confusion: 1. All the JDK 1.5 and 1.6 history - including

Re: Java5 move and Jenkins

On 03/03/2012 12:51 PM, Nicolas Lalevée wrote: So we would have Ant_Nightly which builds the distrib of Ant and gather findbugs warnings, java warnings and TODO/FIXMEs, and we would have the tests run by Ant-Build-Matrix. Looks like an improvement - thanks for setting this up. I am looking in

Re: [ANNOUNCE] Apache Ant 1.8.3 Released

BTW the 201203010400 development build of NetBeans 7.2 bundles it. - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

Re: [VOTE] Release Ant 1.8.3 Take 2

+1; have not found any problems so far. - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

Re: AntUnit test failures

On 02/24/2012 12:12 AM, Stefan Bodewig wrote: It is supposed to be used via ./build.sh antunit-tests. Ah. But when I do that, I get failures that I do not get when I use ./dist/bin/ant -lib lib/optional antunit-tests, e.g.: Build File: .../src/tests/antunit/bugfixes/br50866/br50866-test.xml T

Re: Property expansion in macrodef attributes

On 02/21/2012 10:40 AM, Stefan Bodewig wrote: can do the implementation if you agree. If you can beat me to it, please do. Done in trunk, please review. (Especially whether your changes to property-test.xml and propertyhelper-test.xml still stand - I did not understand what was going on with

Re: AntUnit test failures

...though it hangs in taskdefs/exec/apply-test.xml: apply-test.antunit: Build File: .../src/tests/antunit/taskdefs/exec/apply-test.xml ... "main" prio=10 tid=0x091c7c00 nid=0x24e0 in Object.wait() [0xf6947000] java.lang.Thread.State: WAITING (on object monitor) at java.lang.Object.wait

Re: AntUnit test failures

On 02/23/2012 04:09 PM, Jesse Glick wrote: $ ant -lib lib/optional/ant-antunit-1.2.jar antunit-tests Never mind, just figured out that you need to use $ ./dist/bin/ant ... to actually test trunk code! Maybe build.xml should detect this somehow and warn you (though of course it would be

AntUnit test failures

I get a bunch of test failures in trunk using $ ant -lib lib/optional/ant-antunit-1.2.jar antunit-tests under JDK 7u3, Ubuntu. Are these tests normally expected to pass? - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org

Re: Property expansion in macrodef attributes

Any updates on #52621 and what we want the behavior to be in 1.8.3? My suggestion still stands to restore the 1.8.2 behavior by default but add an optional parameter to implement the fix of #42046 where needed; can do the implementation if you agree.

Re: Property expansion in macrodef attributes

On 02/14/2012 07:39 AM, Stefan Bodewig wrote: Most likely you don't want double expansion in most cases. Right, but how often would you even notice the difference? Usually property values do not themselves contain interpolable variables, as seen by the fact that this problem has just been repo

Re: NIO 2.0 == Ant 2.0? was Re: Java NIO support

On 02/13/2012 01:25 PM, Bruce Atherton wrote: could Java 7 and NIO 2.0 be a good reason to create Ant 2.0? While the new java.nio.file.* APIs are indeed valuable for a tool like Ant, I hardly think a fork or major rewrite is required to take advantage of them. As Stefan pointed out, it would b

Re: Property expansion in macrodef attributes

On 02/12/2012 05:13 AM, Stefan Bodewig wrote: I'm not sure whether the macrodef writer will always know whether she wants double-expansion or not. I would say that if you come across a problem like that mentioned in #42046 then you know you do not want double expansion and should explicitly tu

Re: [VOTE] Release Ant 1.8.3

-1 because of regression #52621 [1] which completely breaks a lot of build scripts used by and generated by NetBeans, and probably anything else requiring recursive property expansion. [1] https://issues.apache.org/bugzilla/show_bug.cgi?id=52621

Re: [VOTE] Release Ant 1.8.3

On 02/07/2012 10:27 AM, Stefan Bodewig wrote: I have re-uploaded the Maven artifacts, the only change is that ant-1.8.3-javadocs.jar* has been renamed to ant-1.8.3-javadoc.jar* New URL is: https://repository.apache.org/content/repositories/orgapacheant-206/org/apache/ant/ Good. Confirmed that

Re: [VOTE] Release Ant 1.8.3

On 02/06/2012 03:28 PM, Stefan Bodewig wrote: Maven artifacts: https://repository.apache.org/content/repositories/orgapacheant-203/org/apache/ant/ Typo in Javadoc artifact: ant-1.8.3-javadocs.jar should be ant-1.8.3-javadoc.jar. (Not just cosmetic; Maven-based tools including IDEs may fail to

Re: [VOTE] Drop JDK 1.4 after 1.8.3

On 01/27/2012 05:29 PM, Maarten Coene wrote: +1 to drop JDK1.4 support for Ant 1.9, and after 1.8.3 is branched we permit trunk sources to assume JDK5+ Agreed and sorry for not offering this as an option to begin with. So let us assume with a +1 that if there is any demand for a 1.8.4 supporti

[VOTE] Drop JDK 1.4 after 1.8.3

As suggested in 1.8.3 thread, I propose we drop JDK 1.4 support in trunk after Ant 1.8.3 is released. It is long past EOL and cumbersome to even get installed for testing. (Note that JDK 5 is also past EOL, but I am not proposing dropping J

Re: 1.8.3?

On 01/26/2012 12:19 PM, Stefan Bodewig wrote: One thing I want to do is giving a recent OpenJDK8 snapshot a try so Ant 1.8.3's javac would support building for 1.8/8 when that gets released. I would not bother with that at this point. JDK 8 is expected to include a module system, which is like

Re: 1.8.3?

On 01/20/2012 12:25 AM, Stefan Bodewig wrote: I don't have Java 1.4 around anymore and wouldn't really know where to obtain one. http://www.oracle.com/technetwork/java/javasebusiness/downloads/java-archive-downloads-javase14-419411.html#j2sdk-1.4.2_19-oth-JPR I still have a copy of this runni

Re: 1.8.3?

On 01/16/2012 12:27 AM, Stefan Bodewig wrote: what do you think about putting out a new release? +1; looks like around forty issues fixed so far in 1.8.3 - not a lot, but enough time has passed. A few issues are still open but marked as TM=1.8.3.

Re: trouble fetching Ant dependencies -- getting HTTP 403 forbidden

On 10/21/2011 11:34 AM, Nicolas Lalevée wrote: I have search in every maven repository I know, it seems the jai-core.jar has disappeared... fetch.xml:116: Unable to resolve artifact: Unable to get dependency information: Unable to read the metadata file for artifact 'javax.media:jai-core:jar':

Re: xor condition

On 07/16/2011 08:59 PM, Matt Benson wrote: xor(true, false) == true xor(true, false, true) == false xor(true, false, true, false) == false Is this correct? Follows the usual semantics; cf.: http://en.wikipedia.org/wiki/Exclusive_or#Associativity_and_commutativity It would seem that semantic

Re: Ant Plugins - ant version compatibility

On 06/20/2011 09:40 AM, Michael Nellis wrote: I am investigating how to determine whether an Ant plugin, built with Ant 1.8.1, will work with Ant 1.8.2. Do you mean an Ant task? Generally it should work this (not the reverse of course), though specific incompatibilities ought to be mentioned i

Re: Command Line Debugging

On 06/09/2011 05:42 AM, Nicolas Lalevée wrote: At some point we may imagine a debugger in an IDE like Eclipse too. By the way there has long been an Ant debugger in NetBeans. Just select Debug Target from the context menu of a build script in e.g. the Files tab. Breakpoints and property inspec

Re: Sources of the ant jars into the maven repository

On 04/12/2011 02:06 PM, Nicolas Lalevée wrote: Is there any objection regarding the publication of such jars ? Please do so. In fact I am surprised that earlier releases were accepted into the Central repository without sources and Javadoc attached. Note that you ought to be able to just run:

Re: list iteration (was: svn commit: r1066963 ...)

On 02/17/2011 11:30 PM, Kevin Jackson wrote: I tried to introduce some micro-optimizations (pretty much like these) into the Tomcat codebase 8 years ago, but was met with 'meh why bother?' responses as the thinking was that the vm would pretty much make optimizations pointless. I suppose it depe

Re: svn commit: r1066963 - in /ant/core/trunk/src/main/org/apache/tools: ant/ ant/taskdefs/ ant/taskdefs/cvslib/ ant/taskdefs/email/ ant/taskdefs/optional/ ant/taskdefs/optional/depend/ ant/taskdefs/o

On 02/04/2011 09:03 AM, Antoine Levy-Lambert wrote: I did not know that using a final variable for the upper bound of a loop instead of something.size() makes a difference in terms of performance. Generally the preferred idiom is to use an iterator, which the Java 5 for loop would do if we wer

Re: [VOTE] release of ant 1.8.2

On 01/04/2011 12:32 PM, Antoine Levy-Lambert wrote: Can you point me to the changes you did to make ant test the version of the source tree? http://svn.apache.org/viewvc?diff_format=h&view=revision&revision=944377 - To unsub

Re: [VOTE] release of ant 1.8.2

On 12/20/2010 12:32 AM, Antoine Levy-Lambert wrote: However I was not able to reproduce the problem that you mentioned. Is it possible that you did not put junit-4 on the classpath when running the junit 4 style test suite ? No, the property was defined to point to a copy of JUnit 4.8.1. Anywa

Re: [VOTE] release of ant 1.8.2

Jesse Glick oracle.com> writes: > Cannot add a test for it easily without relying on JDK 5 to build. Manual test case (retyped by hand so please excuse any typos): public class T1 extends junit.framework.TestCase" { public void testOK() {} public void testBad() {throw new Runti

Re: [VOTE] release of ant 1.8.2

Jesse Glick oracle.com> writes: > there seems to be some problem with #34748 not working correctly > on JUnit 4.x-style @Test's Found it. In JUnitTask.init, need to add: addClasspathEntry("/org/apache/tools/ant/taskdefs/optional/junit /JUnit4TestMethodAdapter.class"); (

Re: [VOTE] release of ant 1.8.2

On 12/13/2010 03:59 PM, Antoine Levy-Lambert wrote: http://people.apache.org/~antoine/dist/ Built big chunks of NetBeans sources without problems. Generally seems to be working embedded on various scripts. But there seems to be some problem with #34748 not working correctly on JUnit 4.x-style

Re: Credentials With Turkish Locale

On 12/02/2010 12:47 PM, Faruk Can Kaya wrote: It is possible due to a String.toLowerCase function. I have seen something like "bas?ic". I guess you mean "basıc", from "BASIC".toLowerCase(). This bug plagues Java software generally. (*) All uses of toLowerCase and toUpperCase in Ant have long s

Re: svn commit: r1034687 - /ant/core/trunk/src/main/org/apache/tools/ant/Main.java

On 11/13/2010 02:07 AM, bode...@apache.org wrote: URL: http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/Main.java?rev=1034687&r1=1034686&r2=1034687&view=diff +msg.append("Apache Ant(TM) version "); I guess ™ would not display properly in shells on lame

Re: issues with ant

On 11/11/2010 03:35 PM, Stefan Bodewig wrote: javac should do what Ant does for it in the Java5 case. If the user only specifies -target but not -source, assume the user wanted the same version as well (and vice versa). Probably would be beneficial. I can file an issue for it in the Java bug

Re: issues with ant

On 11/10/2010 12:17 AM, Stefan Bodewig wrote: The projects use a javac task like ... which is translated to a command line javac -target 1.5 ... This works fine with JDK6's javac but causes the error you've cited when run with OpenJDK 7. This is not the first time this happens,

Re: class BuildTimeoutException extends BuildException

On 10/28/2010 06:17 AM, Steve Loughran wrote: Ant uses getMessage() primarily to extract some text from BuildException to use in a log or other exception. Probably this should be fixed to use getLocalizedMessage(), if only for consistency with Throwable.printStackTrace. -

Re: class BuildTimeoutException extends BuildException

On 10/27/2010 06:01 AM, Steve Loughran wrote: 4. we leave the error strings alone for fear of [...fear itself?] #4 irritates me, I'd like some details about which subprocess got killed, but if we are searching for the string in Ant's own codebase, then we can be confident that others will be doi

Re: ReviewBoard for Ant?

On 10/26/2010 11:12 AM, Stefan Bodewig wrote: I've never used it, but nothing stops us from giving it a try. OK, I filed: https://issues.apache.org/jira/browse/INFRA-3104 So far I haven't been able to register with the site, though. Interesting. I was able to register OK.

ReviewBoard for Ant?

Would this be useful? https://blogs.apache.org/infra/entry/reviewboard_instance_running_at_the It seems we often have in-progress patches that need to be tweaked a bit before use. (I could have used this on #34748; I was accustomed to just creating a Mercurial branch or patch queue for experime

Re: svn commit: r1026123 [1/3] - in /ant/core/trunk: docs/antlibs/proper.html docs/antlibs/sandbox.html docs/bylaws.html docs/external.html docs/nightlies.html docs/projects.html docs/resources.html x

On 10/21/2010 04:05 PM, j...@apache.org wrote: URL: http://svn.apache.org/viewvc?rev=1026123&view=rev ant/core/trunk/docs/antlibs/proper.html ant/core/trunk/docs/antlibs/sandbox.html ant/core/trunk/docs/bylaws.html ant/core/trunk/docs/external.html ant/core/trunk/docs/nig

Re: svn commit: r1001756 - in /ant/core/trunk: WHATSNEW src/main/org/apache/tools/ant/helper/ProjectHelper2.java src/main/org/apache/tools/ant/launch/Locator.java src/tests/antunit/taskdefs/taskdef-te

On 09/27/2010 10:49 AM, Stefan Bodewig wrote: (2) The new tests create JARs that will be loaded by a classloader - which means Ant cannot delete them because they remain locked until the JVM has exited. Can't this at least use something inside ${build.dir}, rather than ${java.io.tmpd

Re: Hudson target to build Ant via Maven

On 06/25/2010 08:20 AM, Jesse Glick wrote: I'm not an admin so I can't see the job configuration. I am now. I think I finally managed to get all the Ant-related (not Ivy-related) jobs at least "succeeding", though there remain various test failures. Building on JDK 1.4

Re: warning: 'includeantruntime' was not set

On 08/19/2010 11:19 AM, Chet Hosey wrote: Perhaps the tag could be given a "behavior" attribute Note that there is the condition which lets you enforce a minimum version of Ant, but this is procedural rather than declarative so Ant cannot tell what version of Ant your script expects to be us

Re: Testlistener Events in JUnit Slows Down Forked Tests in 1.8.x

On 08/19/2010 08:25 AM, Stefan Bodewig wrote: I've added an attribute to enable the events (defaults to false) and a magic property that overrides the attribute setting. OK, though I still think the attribute is useless since the only known use case is for container control.

Re: warning: 'includeantruntime' was not set

On 08/18/2010 02:27 PM, Matt Benson wrote: I would still guess that more builds than not DON'T need to compile against Ant itself. Of course; at least an order of magnitude more. But those that do will be *broken* if your suggested change is made, whereas those that don't get a *warning* curre

Re: warning: 'includeantruntime' was not set

On 08/18/2010 12:31 PM, Matt Benson wrote: require those running such ancient buildfiles Unfortunately they need not be so ancient. I have come across more than one build.xml from an actively developed project which just assumed that sources could be compiled against org.apache.tools.ant.** wi

Re: warning: 'includeantruntime' was not set

On 08/18/2010 10:14 AM, kwut...@web.de wrote: Why doesn't Ant just default to false and just omit warning me about this for every Ant build? That would be an incompatible change. Some old build scripts may be intentionally compiling sources against ant.jar (typically because they define Ant ta

Re: New task contribution

On 08/13/2010 06:35 AM, Andrey Pavlenko wrote: Exporting properties and references from a sub-project to its parent project This is something I struggled with in NetBeans-generated Java projects. I wanted to permit build scripts to call dependencies recursively without reentering any dependenc

Re: Testlistener Events in JUnit Slows Down Forked Tests in 1.8.x

On 08/10/2010 03:00 PM, Stefan Bodewig wrote: buffering on the testrunner side would help but at the same time make the lines unusable for the test listener events that must happen in step with the test to be useful. It would suffice for test listener events to be delivered fairly soon after th

Re: Testlistener Events in JUnit Slows Down Forked Tests in 1.8.x

On 08/09/2010 03:42 AM, Stefan Bodewig wrote: I plan to add an disableTestListenerEvents First I would like to hear an explanation of why printing a few lines to System.out causes such a big performance hit and why this cannot be fixed. What is waiting for what to finish? Does the problem only

Re: AW: Distributing Docs: Manual or whole Site?

On 07/20/2010 01:47 AM, jan.mate...@rzf.fin-nrw.de wrote: First it will scans the Ant manual table of content files by starting from a given file - like like a spider. With the scanned information it generates a toc.xml which is needed for Eclipse Help. It writes a plugin.xml with static content,

Re: bug in DOMElementWriter

On 06/27/2010 01:35 PM, Dominique Devienne wrote: with \n, which is just like any other character*, the serializer doesn't do anything special, and the output the also contain a "plain" \n. Jon is correct: or similar should be emitted for \n. Newlines are _not_ just like any other character;

Re: Hudson target to build Ant via Maven

On 06/25/2010 06:52 AM, jan.mate...@rzf.fin-nrw.de wrote: Building modules in parallel. Good luck there... these are only "modules" by fiat; they share some source and target dirs. The include/exclude definitions very likely do not form a disjoint union of all source files, so I have no idea i

  1   2   3   4   >