On 2018-04-15, Gintautas Grigelionis wrote:
> Moreover, the refactoring of tests is not about extracting repetitive
> code into "smart" methods; it's about parameterizing -- which is
> another nice thing about JUnit 4 -- and we'll be getting to that.
If we could get there with diff smaller than s
2018-04-15 9:59 GMT+00:00 Stefan Bodewig :
> On 2018-04-15, Gintautas Grigelionis wrote:
>
> > Could you please explain what alternative approach does the "root"
> > property support
>
> It has been added with
> https://github.com/apache/ant/commit/71333195c9d57d80d1a44cd8362a64
> 1c62d5e214
> and
On 2018-04-15, Gintautas Grigelionis wrote:
> Could you please explain what alternative approach does the "root"
> property support
It has been added with
https://github.com/apache/ant/commit/71333195c9d57d80d1a44cd8362a641c62d5e214
and the commit message states the main use case "running tests f
2018-04-14 16:23 GMT+00:00 Stefan Bodewig :
> On 2018-04-13, Gintautas Grigelionis wrote:
>
> > 2018-04-13 5:33 GMT+00:00 Stefan Bodewig :
>
> >> Ant test cases are not designed to be run from an IDE, this has never
> >> been a goal. I'm surprised this system property is the only thing you
> >> ne
On 2018-04-13, Gintautas Grigelionis wrote:
> 2018-04-13 5:33 GMT+00:00 Stefan Bodewig :
>> Ant test cases are not designed to be run from an IDE, this has never
>> been a goal. I'm surprised this system property is the only thing you
>> need to remember :-)
> Well, I decided to give it a spin
2018-04-13 5:33 GMT+00:00 Stefan Bodewig :
> On 2018-04-12, Gintautas Grigelionis wrote:
>
> > 2018-04-12 15:18 GMT+00:00 Stefan Bodewig :
>
> >> On 2018-04-12, Gintautas Grigelionis wrote:
>
> >>> 2018-04-12 14:39 GMT+00:00 Stefan Bodewig :
>
> On 2018-04-11, Gintautas Grigelionis wrote:
>
>
On 2018-04-12, Gintautas Grigelionis wrote:
> 2018-04-12 15:18 GMT+00:00 Stefan Bodewig :
>> On 2018-04-12, Gintautas Grigelionis wrote:
>>> 2018-04-12 14:39 GMT+00:00 Stefan Bodewig :
On 2018-04-11, Gintautas Grigelionis wrote:
> XMLCatalogTest is an example of unit tests complicated
2018-04-12 15:18 GMT+00:00 Stefan Bodewig :
> On 2018-04-12, Gintautas Grigelionis wrote:
>
> > 2018-04-12 14:39 GMT+00:00 Stefan Bodewig :
>
> >> On 2018-04-11, Gintautas Grigelionis wrote:
>
> >>> XMLCatalogTest is an example of unit tests complicated by root
> property.
>
> >> Actually, the tes
On 2018-04-12, Gintautas Grigelionis wrote:
> 2018-04-12 14:39 GMT+00:00 Stefan Bodewig :
>> On 2018-04-11, Gintautas Grigelionis wrote:
>>> XMLCatalogTest is an example of unit tests complicated by root property.
>> Actually, the test even passes if you remove the line using the property
>> as
2018-04-12 14:39 GMT+00:00 Stefan Bodewig :
> On 2018-04-11, Gintautas Grigelionis wrote:
>
> > XMLCatalogTest is an example of unit tests complicated by root property.
>
> Actually, the test even passes if you remove the line using the property
> as long as your current working directory is Ant's
On 2018-04-11, Gintautas Grigelionis wrote:
> 2018-04-11 6:25 GMT+00:00 Jaikiran Pai :´
>> On 10/04/18 12:27 AM, Gintautas Grigelionis wrote:
>>> I wrote earlier that I was about to review the unit tests.
>>> I was particularly unhappy about the root-property hack for an ancient
>>> deficiency i
t; __
>
>
>
>
> --------------
> *From:* Gintautas Grigelionis
> *Sent:* Wednesday, April 11, 2018 4:44 PM
> *To:* Ant Developers List
> *Subject:* Re: Mass changes to various projects under Ant umbrella -
> s
2018-04-11 6:25 GMT+00:00 Jaikiran Pai :´
> On 10/04/18 12:27 AM, Gintautas Grigelionis wrote:
>
>> I wrote earlier that I was about to review the unit tests.
>> I was particularly unhappy about the root-property hack for an ancient
>> deficiency in Surefire.
>>
> I checked some of the mail discus
On Wed, Apr 11, 2018, 8:25 AM Stefan Bodewig wrote:
> On 2018-04-11, Matt Benson wrote:
>
> > On Sun, Apr 8, 2018, 11:03 AM Stefan Bodewig wrote:
>
> >> We did have one big "cleanup" commit which has been the one that brought
> >> us the regressions in 1.10.2 and I deeply regret not taking the t
On 2018-04-11, Matt Benson wrote:
> On Sun, Apr 8, 2018, 11:03 AM Stefan Bodewig wrote:
>> We did have one big "cleanup" commit which has been the one that brought
>> us the regressions in 1.10.2 and I deeply regret not taking the time
>> reviewing the change back then.
> I'm pretty sure I was
On Sun, Apr 8, 2018, 11:03 AM Stefan Bodewig wrote:
> On 2018-04-07, Jaikiran Pai wrote:
>
> > I don't mean to appear authoritative but I feel that these mass,
> > never-ending changes to various projects under the Ant umbrella,
> > related to formatting, coding style, whitespaces, syntax changes
On 2018-04-09, Gintautas Grigelionis wrote:
> I was particularly unhappy about the root-property hack for an ancient
> deficiency in Surefire.
Could you please expand on this a bit?
> I consider my previous commits a sort of a groundwork for
> refactorisation of JUnit tests. Would you bear with
On 10/04/18 12:27 AM, Gintautas Grigelionis wrote:
2018-04-08 16:13 GMT+00:00 Stefan Bodewig :
I don't believe woking well tested code rots. Code rot is something that
happends when code doesn't get adapted to changing environments or
requirements. This is not the case here.
I wrote earlier
> Le 9 avr. 2018 à 20:46, Gintautas Grigelionis a
> écrit :
>
> 2018-04-09 16:48 GMT+00:00 Nicolas Lalevée :
>
>> I have not been reading ant-dev lately, so I cannot comment much about the
>> last patches. For a while now I have not been involved much, but probably
>> the last reviews of patc
2018-04-08 16:13 GMT+00:00 Stefan Bodewig :
> On 2018-04-07, Gintautas Grigelionis wrote:
>
> > Java is a language with the syntax that changes and tries to accomodate
> new
> > patterns that make programming more efficient.
>
> Some of the patterns you've been changign don't fall into this catego
2018-04-09 16:48 GMT+00:00 Nicolas Lalevée :
> I have not been reading ant-dev lately, so I cannot comment much about the
> last patches. For a while now I have not been involved much, but probably
> the last reviews of patches bored me enough so I lost track of the dev
> community entirely.
>
> N
Le 7 avr. 2018 à 14:13, Gintautas Grigelionis a écrit
:
>
> I sense a personal attack using broad, generalised accusations :-)
> Could we please stop the inflammatory comments and be more to the point?
Please don’t. Nothing is personal here. Jaikiran used « we ». Even if you are
the author of
On 2018-04-07, Gintautas Grigelionis wrote:
> Java is a language with the syntax that changes and tries to accomodate new
> patterns that make programming more efficient.
Some of the patterns you've been changign don't fall into this category
for me. Switching if/else blocks, colapsing ifs or rem
On 2018-04-07, Jaikiran Pai wrote:
> I don't mean to appear authoritative but I feel that these mass,
> never-ending changes to various projects under the Ant umbrella,
> related to formatting, coding style, whitespaces, syntax changes and
> such aren't really worth it.
We've done some systematic
I sense a personal attack using broad, generalised accusations :-)
Could we please stop the inflammatory comments and be more to the point?
Yes, I did make a series of commits, but it's not endless. In fact, it is
to end pretty soon.
It is long merely because each commit is about a specific patter
I don't mean to appear authoritative but I feel that these mass,
never-ending changes to various projects under the Ant umbrella, related
to formatting, coding style, whitespaces, syntax changes and such aren't
really worth it. Especially when a lot of those changes are merely, IMO,
personal pr
26 matches
Mail list logo
