Re: svn commit: r1896724 - /apr/apr/trunk/file_io/win32/filestat.c

Reviewing, and writing tests. Thanks for your analysis! On Wed, Jan 5, 2022 at 11:45 AM wrote: > > Author: ivan > Date: Wed Jan 5 17:45:33 2022 > New Revision: 1896724 > > URL: http://svn.apache.org/viewvc?rev=1896724=rev > Log: > Win32: Minor optimization of apr_stat() and apr_file_info_get().

Re: Minimum msvc version to compile apr/trunk on Windows

On Thu, Dec 2, 2021 at 1:33 PM Mladen Turk wrote: > > On 02/12/2021 13:21, Ivan Zhakov wrote: > > On Wed, 1 Dec 2021 at 21:26, Mladen Turk > > wrote: > > > > So no uuidof used in recent Windows SDK. > > > > Btw Visual Studio 2008 support ended April 10, 2018 [1]. > >

Re: Minimum msvc version to compile apr/trunk on Windows

On Fri, Dec 10, 2021 at 8:47 AM Ivan Zhakov wrote: > > On Thu, 2 Dec 2021 at 22:33, Mladen Turk wrote: >> >> Issues with API beyond Windows SDK 7.1.A >> (Latest one supporting Windows 7.1sp1) >> >> It just means apr-2 won't be able to run on anything below Windows 10. >> There a lots of code you

Re: svn commit: r1896510 - in /apr/apr/branches/1.7.x: ./ file_io/win32/ include/arch/unix/ include/arch/win32/ network_io/os2/ poll/os2/ poll/unix/

On Thu, Jan 13, 2022 at 2:37 PM Ruediger Pluem wrote: > > On 1/13/22 7:04 PM, Ivan Zhakov wrote: > > > > On Fri, 7 Jan 2022 at 17:33, Yann Ylavic wrote: > >> > >> On Fri, Jan 7, 2022 at 2:50 PM Ivan Zhakov wrote: > >>> > >>> I also have a high-level objection against backporting this change to

Possible apr 1.7.1 showstopper from httpd test framework

In addition to a broken release of brotli (where enc/dec don't specify -lbrotlicommon, even on trunk, for openssl and other consumers to ferret out that binding), and lots of fun changes to build flags in curl 7.81 minor release (who does that?) there appears to be one test failure with date

Re: svn commit: r1897021 - /apr/apr/branches/1.8.x/

A quick review of nm against libapr-1.so between 1.7.0 and 1.7.x indicates that 1.7.1 isn't releasable as-is. Any hints? +T apr_pool_find +T apr_pool_join +T apr_pool_lock +T apr_pool_num_bytes +T apr__pool_unmanage Preserving whatever has changed on 1.8.x branch for ABI breaking changes. On

Backport svn log style request

We have traditionally described a commit even when performing a backport. I'd traditionally cut and pasted the actual log entries and then compressed them some to ignore the trivial stuff that doesn't particularly apply to the combined patch. Then decorated with the usual; Authored by:

Re: apr/trunk netware and os2

On Tue, Nov 30, 2021 at 4:47 PM Mladen Turk wrote: > > BTW did anyone was able to compile trunk on netware or os2 > There are bunch of those NWGNUmakefiles and netware subdirs My +1 to drop both from trunk. > According to Wikipedia NetWare was discontinued in 2009 > and OS/2 in 2001, so if

Re: svn commit: r1896510 - in /apr/apr/branches/1.7.x: ./ file_io/win32/ include/arch/unix/ include/arch/win32/ network_io/os2/ poll/os2/ poll/unix/

On 1/13/22 7:04 PM, Ivan Zhakov wrote: > [[ sorry for delayed response ]] > > On Fri, 7 Jan 2022 at 17:33, Yann Ylavic wrote: >> >> Hi Ivan, >> >> On Fri, Jan 7, 2022 at 2:50 PM Ivan Zhakov wrote: >>> >>> This change does not compile on Windows in APR 1.7.x: >>> [[[ >>>

Re: svn commit: r1896510 - in /apr/apr/branches/1.7.x: ./ file_io/win32/ include/arch/unix/ include/arch/win32/ network_io/os2/ poll/os2/ poll/unix/

[[ sorry for delayed response ]] On Fri, 7 Jan 2022 at 17:33, Yann Ylavic wrote: > > Hi Ivan, > > On Fri, Jan 7, 2022 at 2:50 PM Ivan Zhakov wrote: > > > > This change does not compile on Windows in APR 1.7.x: > > [[[ > > file_io\win32\readwrite.c(325): error C2065: 'file': undeclared