RE: [PATCH] Building apr-util with recent libexpat2 using CMake

2017-10-05 Thread Bert Huijben
libexpat.lib for some other builds (probably recently added for somebody using the makefile build). We define ‘XML_STATIC’ in both shared and static library cases. Bert From: William A Rowe Jr [mailto:wr...@rowe-clan.net] Sent: woensdag 4 oktober 2017 19:21 To: Bert Huijben

RE: [PATCH] Building apr-util with recent libexpat2 using CMake

2017-10-04 Thread Bert Huijben
> -Original Message- > From: William A Rowe Jr [mailto:wr...@rowe-clan.net] > Sent: woensdag 4 oktober 2017 18:14 > To: Bert Huijben > Cc: APR Developer List > Subject: Re: [PATCH] Building apr-util with recent libexpat2 using CMake > > On Wed, Oct 4, 2017 a

[PATCH] Building apr-util with recent libexpat2 using CMake

2017-10-04 Thread Bert Huijben
Hi, Building apr-util with a recent libexpat2 (2.2.4) requires referencing an additional .c file on Windows. The attached patch fixes the CMake build. Perhaps somebody more experienced with CMake can create a patch that would be compatible with older and newer versions. Note that includin

RE: svn commit: r1806603 - /apr/apr/trunk/file_io/win32/readwrite.c

2017-08-30 Thread Bert Huijben
> -Original Message- > From: i...@apache.org [mailto:i...@apache.org] > Sent: dinsdag 29 augustus 2017 16:59 > To: comm...@apr.apache.org > Subject: svn commit: r1806603 - /apr/apr/trunk/file_io/win32/readwrite.c > > Author: ivan > Date: Tue Aug 29 14:59:11 2017 > New Revision: 1806603 >

RE: [Patch] Fix apr_file_trunc on buffered files after read

2016-10-13 Thread Bert Huijben
> -Original Message- > From: Stefan Fuhrmann [mailto:stefanfuhrm...@alice-dsl.de] > Sent: donderdag 13 oktober 2016 15:25 > To: APR Developer List > Subject: [Patch] Fix apr_file_trunc on buffered files after read > > Hey there, > > I stumbled across a problem with apr_file_trunc not upd

Apr-Util compatibility with OpenSSL 1.1.0

2016-03-29 Thread Bert Huijben
Hi, I just tried using OpenSSL 1.1.0-pre4 with APR-UTIL and found that the code is incompatible. The file apr_crypto_openssl.c fails to compile as some structs have been made opaque. I can probably provide a patch later, but perhaps others want to know about the problem before that.

RE: [PATCH] APR hash documentation

2015-12-11 Thread Bert Huijben
> -Original Message- > From: Stefan Fuhrmann [mailto:stef...@apache.org] > Sent: donderdag 10 december 2015 23:59 > To: dev@apr.apache.org > Subject: [PATCH] APR hash documentation > > Hi there, > > since 1.4.6, the hash implementation allows for > mismatching and custom hash functions

RE: apr_hash_overlay returns hash with duplicate keys

2015-12-10 Thread Bert Huijben
Are both hash tables created with the same hash function? (I think stefan2 introduced some variants). Otherwise I would expect some key values to be changed somewhere after adding to the first hashtable… But I don’t think this is really a likely scenario. Bert Sent from Outlook Mail for Windows

RE: Optimization, modern C and APR 2.0 onwards

2015-11-20 Thread Bert Huijben
+1 As long as we don’t require complete/100% C99 at this time. Microsoft only intends to implement the C99 subset that is also part of the recent C++ specs (or just easy to do) in Visual Studio, and in most cases it already does in the most recent version. But talking specifically abo

A 'few' overflows

2015-11-04 Thread Bert Huijben
Hi, The function [[ APR_DECLARE(apr_status_t) apr_mmap_offset(void **addr, apr_mmap_t *mmap, apr_off_t offset) { if (offset < 0 || (apr_size_t)offset > mmap->size) return APR_EINVAL; (*addr) = (char *) mmap->mm + offset; re

RE: minor APR 1.5.2 build error on Windows

2015-06-22 Thread Bert Huijben
> -Original Message- > From: Stefan Hett [mailto:ste...@egosoft.com] > Sent: maandag 22 juni 2015 11:49 > To: dev@apr.apache.org > Subject: minor APR 1.5.2 build error on Windows > > Hi, > > I just tested building APR 1.5.2 from source on windows, following the > instructions from the r

RE: A question

2015-06-22 Thread Bert Huijben
Hi Zachary, I'm not sure if you should really look at APR-Iconv for new code. The code hasn't been updated in a long time and is basically dead. (Not too long ago there was a suggestion to remove the library as it is basically unused now that Subversion uses a Win32 specific imp

RE: [Patch] apr_file_path_merge returns incorrect truepath on certain 'short paths' on Windows

2015-06-15 Thread Bert Huijben
Trying yet another e-mail address... Nice that this just bounces instead of being moderated :( Bert > -Original Message- > From: Bert Huijben [mailto:rhuij...@collab.net] > Sent: maandag 15 juni 2015 14:04 > To: dev@apr.apache.org > Cc: Stephen White; d...@subver

RE: svn commit: r1671362 - /apr/apr/trunk/README.cmake

2015-04-06 Thread Bert Huijben
> -Original Message- > From: traw...@apache.org [mailto:traw...@apache.org] > Sent: zondag 5 april 2015 03:06 > To: comm...@apr.apache.org > Subject: svn commit: r1671362 - /apr/apr/trunk/README.cmake > > Author: trawick > Date: Sun Apr 5 01:06:02 2015 > New Revision: 1671362 > > URL:

RE: svn commit: r1668866 - /apr/apr-util/branches/1.5.x/README.cmake

2015-04-03 Thread Bert Huijben
> -Original Message- > From: Jeff Trawick [mailto:traw...@gmail.com] > Sent: vrijdag 3 april 2015 15:49 > To: dev@apr.apache.org > Subject: Re: svn commit: r1668866 - /apr/apr- > util/branches/1.5.x/README.cmake > > On 04/02/2015 04:04 PM, Bert Huijben wrote

RE: svn commit: r1668866 - /apr/apr-util/branches/1.5.x/README.cmake

2015-04-02 Thread Bert Huijben
> -Original Message- > From: traw...@apache.org [mailto:traw...@apache.org] > Sent: dinsdag 24 maart 2015 13:47 > To: comm...@apr.apache.org > Subject: svn commit: r1668866 - /apr/apr-util/branches/1.5.x/README.cmake > > Author: trawick > Date: Tue Mar 24 12:47:10 2015 > New Revision: 16

RE: [Patch] R/W lock slowness on Windows (Was: Windows R/W lock comment / Reader Writer lock performance on Windows)

2014-08-27 Thread Bert Huijben
> -Original Message- > From: Ivan Zhakov [mailto:i...@visualsvn.com] > Sent: woensdag 27 augustus 2014 15:29 > To: Bert Huijben > Subject: Re: [Patch] R/W lock slowness on Windows (Was: Windows R/W lock > comment / Reader Writer lock performance on Windows) > > H

[Patch] R/W lock slowness on Windows (Was: Windows R/W lock comment / Reader Writer lock performance on Windows)

2014-08-02 Thread Bert Huijben
Hi, With this mail I would like to ping the original problem with the second patch I send to the list. This patch doesn't have the likely original problems of potentially changing the lock behavior to a spin lock, but provides all the performance improvements anyway. It just replaces the

RE: Windows R/W lock comment

2014-07-07 Thread Bert Huijben
to use rwlock->readers in apr_thread_rwlock_unlock(), like in my original patch as the apr unlock doesn’t produce an usable errorcode. But as we can assume having at least one reader or writer lock when entering this function, this is safe to do. Bert From: Bert Huij

RE: Windows R/W lock comment

2014-07-07 Thread Bert Huijben
By googling for more details I just found an additional problem… TryAcquireSRWLockExclusive and TryAcquireSRWLockShared are only implemented on Windows 7 and later (not Vista and later), so the code needs more fallback behavior for Vista. Bert From: Bert Huijben

RE: Windows R/W lock comment

2014-07-07 Thread Bert Huijben
I think it is a hybrid loop, but the documentation is not really clear about it. It is not as hybrid as a critical section (which internally falls back to the kernel based mutex behavior for long waits), but it is more CPU efficient than a loop around a few simple atomic operations. Looking

RE: [Patch] Reader Writer lock performance on Windows

2014-07-03 Thread Bert Huijben
> -Original Message- > From: Bert Huijben [mailto:b...@qqmail.nl] > Sent: maandag 30 juni 2014 19:34 > To: dev@apr.apache.org > Cc: stef...@apache.org; i...@apache.org > Subject: [Patch] Reader Writer lock performance on Windows > > Hi, The patch as

[Patch] Reader Writer lock performance on Windows

2014-06-30 Thread Bert Huijben
Hi, I was profiling a subversion operation which actively used a recently added memory cache that uses apr rwlocks. Somehow just these locks used more than 2.5% of the total processing time (which is mostly IO bound). (For future reference: 'svn log file:trunk/ChangeLog' against a pack

RE: svn commit: r1561041 - in /apr/apr/branches/1.5.x: ./ include/apr_errno.h

2014-01-26 Thread Bert Huijben
> -Original Message- > From: j...@apache.org [mailto:j...@apache.org] > Sent: vrijdag 24 januari 2014 16:47 > To: comm...@apr.apache.org > Subject: svn commit: r1561041 - in /apr/apr/branches/1.5.x: ./ > include/apr_errno.h > > Author: jim > Date: Fri Jan 24 15:46:47 2014 > New Revision:

[Patch] Fix for concurrent/race condition in apr_dir_make_recursive()

2014-01-16 Thread Bert Huijben
Hi, While debugging a Subversion buildbot error I found a race condition in apr_dir_make_recursive(). If two new threads perform something like $ mkdir -p some/deep/sub/dir $ mkdir -p some/deep/sub/other At the same time And 'some' and/or 'deep' don't exist both threads will fail to crea

RE: Race condition in APR_DECLARE_LATE_DLL_FUNC() implementation

2013-12-11 Thread Bert Huijben
: daniel.lescoh...@cbsinteractive.com [mailto:daniel.lescoh...@cbsinteractive.com] On Behalf Of Daniel Lescohier Sent: zaterdag 7 december 2013 16:05 To: Bert Huijben Cc: William A. Rowe Jr.; Stefan Fuhrmann; APR Developer List; Stefan Fuhrman; Philip Martin; Subversion Development Subject: Re: Ra

RE: Race condition in APR_DECLARE_LATE_DLL_FUNC() implementation

2013-12-07 Thread Bert Huijben
> -Original Message- > From: Bert Huijben [mailto:b...@qqmail.nl] > Sent: vrijdag 6 december 2013 19:14 > To: 'William A. Rowe Jr.'; 'Stefan Fuhrmann' > Cc: 'APR Developer List'; 'Stefan Fuhrman'; 'Philip Martin&#

RE: Race condition in APR_DECLARE_LATE_DLL_FUNC() implementation

2013-12-06 Thread Bert Huijben
> -Original Message- > From: William A. Rowe Jr. [mailto:wr...@rowe-clan.net] > Sent: vrijdag 6 december 2013 18:24 > To: Stefan Fuhrmann > Cc: Bert Huijben; APR Developer List; Stefan Fuhrman; Philip Martin; > Subversion Development > Subject:

CMake build doesn't define 'WINNT', but apr headers check for it anyway

2013-12-05 Thread Bert Huijben
Hi, On Windows apr_arch_misc.h checks for the 'WINNT' define, which was unconditionally defined on Windows before the CMake build. But now it is no longer defined. This enables some additional dynamic load operations that could fail in some cases (See "Race condition in APR_DECL

Race condition in APR_DECLARE_LATE_DLL_FUNC() implementation

2013-12-05 Thread Bert Huijben
Hi, Someone in the Subversion team made our C tests run in parallel. With that our buildbot found a race condition in the Windows specific APR_DECLARE_LATE_DLL_FUNC() implementation. The current code is [[ #define APR_DECLARE_LATE_DLL_FUNC(lib, rettype, calltype, fn, ord, args, names) \

Error compiling apr_crypto_openssl using cmake

2013-11-19 Thread Bert Huijben
Hi, Continuing my work to switch my build chain to cmake for apr, apr-util and httpd I now found the same problem in the optional components of apr-util that was just fixed in httpd in r1543149: some defines are not quoted correctly to the resource compiler when invoked from Visual Studio

RE: Using UNIX domain sockets with apr

2013-09-20 Thread Bert Huijben
> -Original Message- > From: William A. Rowe Jr. [mailto:wr...@rowe-clan.net] > Sent: dinsdag 17 september 2013 20:13 > To: Timo Rothenpieler > Cc: dev@apr.apache.org > Subject: Re: Using UNIX domain sockets with apr > > On Mon, 09 Sep 2013 21:06:34 +0200 > Timo Rothenpieler wrote: > >

RE: svn commit: r1518760 - in /apr/apr/branches/1.4.x: CMakeLists.txt README.cmake include/apr.hwc

2013-09-05 Thread Bert Huijben
> -Original Message- > From: traw...@apache.org [mailto:traw...@apache.org] > Sent: donderdag 29 augustus 2013 20:49 > To: comm...@apr.apache.org > Subject: svn commit: r1518760 - in /apr/apr/branches/1.4.x: CMakeLists.txt > README.cmake include/apr.hwc > > Author: trawick > Date: Thu Au

RE: build-outputs.mk and generated headers

2013-06-03 Thread Bert Huijben
> -Original Message- > From: Guenter Knauf [mailto:fua...@apache.org] > Sent: maandag 3 juni 2013 09:12 > To: Graham Leggett; dev@apr.apache.org List > Subject: Re: build-outputs.mk and generated headers > > Hi Graham, > On 31.05.2013 23:34, Graham Leggett wrote: > > I have been putting

RE: [VOTE] Release apr-util 1.5.0

2012-08-22 Thread Bert Huijben
> -Original Message- > From: William A. Rowe Jr. [mailto:wr...@rowe-clan.net] > Sent: zondag 12 augustus 2012 19:40 > To: dev@apr.apache.org > Subject: Re: [VOTE] Release apr-util 1.5.0 > > On 8/10/2012 1:05 PM, Stefan Fritsch wrote: > > Thanks for the detailed tests. > > > > On Friday 10

RE: svn commit: r1308910 - in /apr/apr/trunk: configure.in include/apr_poll.h include/arch/unix/apr_arch_poll_private.h poll/unix/pollset.c poll/unix/z_asio.c

2012-04-04 Thread Bert Huijben
> -Original Message- > From: grega...@apache.org [mailto:grega...@apache.org] > Sent: dinsdag 3 april 2012 6:48 > To: comm...@apr.apache.org > Subject: svn commit: r1308910 - in /apr/apr/trunk: configure.in > include/apr_poll.h include/arch/unix/apr_arch_poll_private.h > poll/unix/pollset

RE: svn commit: r1231605 - /apr/apr/trunk/tables/apr_hash.c

2012-01-15 Thread Bert Huijben
> -Original Message- > From: bo...@apache.org [mailto:bo...@apache.org] > Sent: zondag 15 januari 2012 1:37 > To: comm...@apr.apache.org > Subject: svn commit: r1231605 - /apr/apr/trunk/tables/apr_hash.c > > Author: bojan > Date: Sun Jan 15 00:37:14 2012 > New Revision: 1231605 > > URL:

RE: Researched and adapted pre-vista/2008 windows symlinks

2011-07-28 Thread Bert Huijben
> -Original Message- > From: Mladen Turk [mailto:mt...@apache.org] > Sent: donderdag 28 juli 2011 22:07 > To: Bert Huijben > Subject: Re: Researched and adapted pre-vista/2008 windows symlinks > > On 07/28/2011 09:22 PM, Bert Huijben wrote: > > > >>

RE: Researched and adapted pre-vista/2008 windows symlinks

2011-07-28 Thread Bert Huijben
> -Original Message- > From: William A. Rowe Jr. [mailto:wr...@rowe-clan.net] > Sent: donderdag 28 juli 2011 18:01 > To: APR Developer List > Subject: Researched and adapted pre-vista/2008 windows symlinks > > http://fearthecowboy.com/2011/04/04/coapp-package-composition/ > http://fearth

RE: apr, pools and NetWare

2011-07-28 Thread Bert Huijben
> -Original Message- > From: William A. Rowe Jr. [mailto:wr...@rowe-clan.net] > Sent: donderdag 28 juli 2011 17:07 > To: dev@apr.apache.org > Subject: Re: apr, pools and NetWare > > On 7/27/2011 6:24 PM, NormW wrote: > > > >> APR_DECLARE(apr_pool_t *) apr_pool_parent_get(apr_pool_t *pool

LoadLibrary failures? (Was: RE: MinGW status)

2011-05-11 Thread Bert Huijben
> -Original Message- > From: Jeff Trawick [mailto:traw...@gmail.com] > Sent: woensdag 13 april 2011 14:54 > To: dev@apr.apache.org > Subject: Re: MinGW status > > Oh, how could I forget :) > > Running myapp.exe against libapr-2-0.dll can result in a myapp.exe.### > droplet that looks li

RE: svn commit: r1100345 - in /apr/apr-util/branches/1.3.x: dbd/apr_dbd_freetds.mak dbd/apr_dbd_mysql.mak dbd/apr_dbd_oracle.mak dbd/apr_dbd_pgsql.mak dbd/apr_dbd_sqlite2.mak dbd/apr_dbd_sqlite3.mak d

2011-05-06 Thread Bert Huijben
> -Original Message- > From: wr...@apache.org [mailto:wr...@apache.org] > Sent: vrijdag 6 mei 2011 21:32 > To: comm...@apr.apache.org > Subject: svn commit: r1100345 - in /apr/apr-util/branches/1.3.x: > dbd/apr_dbd_freetds.mak dbd/apr_dbd_mysql.mak > dbd/apr_dbd_oracle.mak dbd/apr_dbd_pgs

RE: svn commit: r1099173 - /apr/apr/branches/1.4.x/file_io/win32/filepath.c

2011-05-04 Thread Bert Huijben
he.org wrote: > > Remove assumption that drive letters are always uppercase. > > Patch by: Bert Huijben > > Backports: r960665 > > We needed this on 1.4, I'll add to 1.5 later tonight, and I'll refactor > once again for the //Machine/Share/ syntax later (si

RE: [vote] reset to apr-util 1.5.0-dev?

2011-04-15 Thread Bert Huijben
> -Original Message- > From: William A. Rowe Jr. [mailto:wr...@rowe-clan.net] > Sent: vrijdag 15 april 2011 3:52 > To: APR Developer List > Subject: [vote] reset to apr-util 1.5.0-dev? > > In order to disambiguate what was released by external entities from what > the ASF APR Project has

RE: apr 1.4.3, apr-util 1.3.11

2011-03-14 Thread Bert Huijben
> -Original Message- > From: William A. Rowe Jr. [mailto:wr...@rowe-clan.net] > Sent: maandag 14 maart 2011 18:22 > To: Bert Huijben; APR Developer List > Subject: Re: apr 1.4.3, apr-util 1.3.11 > > On 3/14/2011 12:11 PM, Bert Huijben wrote: > >> >

RE: apr 1.4.3, apr-util 1.3.11

2011-03-14 Thread Bert Huijben
> -Original Message- > From: William A. Rowe Jr. [mailto:wr...@rowe-clan.net] > Sent: maandag 14 maart 2011 17:14 > To: dev@apr.apache.org > Subject: Re: apr 1.4.3, apr-util 1.3.11 > > On 3/14/2011 8:02 AM, Bert Huijben wrote: > > > > I would really li

RE: apr 1.4.3, apr-util 1.3.11

2011-03-14 Thread Bert Huijben
> -Original Message- > From: William A. Rowe Jr. [mailto:wr...@rowe-clan.net] > Sent: zaterdag 12 maart 2011 22:13 > To: APR Developer List > Subject: Re: apr 1.4.3, apr-util 1.3.11 > > On 3/12/2011 7:31 AM, Jeff Trawick wrote: > > lots of fixes awaiting apr 1.4.3, a few fixes awaiting a

RE: [PATCH] apr_file_flush_locked and short writes

2011-02-21 Thread Bert Huijben
> -Original Message- > From: Blair Zajac [mailto:bl...@orcaware.com] > Sent: zaterdag 5 februari 2011 0:33 > To: dev@apr.apache.org > Subject: [PATCH] apr_file_flush_locked and short writes > > Looking at apr_file_flush_locked(), it looks like it doesn't handle short writes > for buffere

RE: apr_file_*() threading issues under Windows!

2010-10-08 Thread Bert Huijben
> -Original Message- > From: Stefan Ruppert [mailto:s...@myarm.com] > Sent: vrijdag 8 oktober 2010 17:55 > To: dev@apr.apache.org > Subject: Re: apr_file_*() threading issues under Windows! > > I do not use a file handle from different threads. But if this is not a > valid usage scenario w

RE: intent to T&R apr-util 1.3.10 sometime Thursday

2010-09-29 Thread Bert Huijben
> -Original Message- > From: Jeff Trawick [mailto:traw...@gmail.com] > Sent: dinsdag 28 september 2010 13:05 > To: dev@apr.apache.org > Subject: intent to T&R apr-util 1.3.10 sometime Thursday > > any concerns about the timing? > any additional fixes people would like to see in that releas

RE: Thread handle leak in APR

2010-08-20 Thread Bert Huijben
> -Original Message- > From: Erik Huelsmann [mailto:ehu...@gmail.com] > Sent: vrijdag 20 augustus 2010 13:20 > To: William A. Rowe Jr. > Cc: dev@apr.apache.org > Subject: Re: Thread handle leak in APR > > On Fri, Aug 20, 2010 at 8:30 PM, William A. Rowe Jr. > wrote: > > On 8/20/2010 1:08

RE: [Patch] apr_filepath_merge() on "c:path" fails consistently on Windows if the current directory is "c:/windows" instead of "C:/Windows"

2010-07-05 Thread Bert Huijben
> -Original Message- > From: William A. Rowe Jr. [mailto:wr...@rowe-clan.net] > Sent: maandag 5 juli 2010 22:35 > To: dev@apr.apache.org > Subject: Re: [Patch] apr_filepath_merge() on "c:path" fails > consistently on Windows if the current directory is "c:/windows" > instead of "C:/Window

[Patch] apr_filepath_merge() on "c:path" fails consistently on Windows if the current directory is "c:/windows" instead of "C:/Windows"

2010-07-05 Thread Bert Huijben
Hi, As mailed in November 2009 [1], simple apr_filepath_merge() calls on paths like "C:/Windows" fail for users that use a shell that turns their active directory in a "c:/users/bert" style instead of the more common "C:/users/bert" (note the lower case 'C'). The current APR code just ass

RE: Why does apr_file_read() with !APR_XTHREAD use mutexes on Windows

2010-06-06 Thread Bert Huijben
> -Original Message- > From: Ivan Zhakov [mailto:i...@visualsvn.com] > Sent: zaterdag 5 juni 2010 11:58 > To: wr...@rowe-clan.net; traw...@gmail.com > Cc: dev@apr.apache.org; Bert Huijben > Subject: Re: Why does apr_file_read() with !APR_XTHREAD use mutexes on > Win

RE: [Patch] RE: Windows drive letter check fails on lower case current working drive

2010-05-19 Thread Bert Huijben
> -Original Message- > From: Bert Huijben [mailto:b...@qqmail.nl] > Sent: woensdag 20 januari 2010 11:31 > To: 'Branko Čibej'; 'William A. Rowe Jr.' > Cc: dev@apr.apache.org; 'Philip Martin'; 'Bert Huijben'; > d...@subversion.

RE: First SVN performance data

2010-05-13 Thread Bert Huijben
> -Original Message- > From: Stefan Fuhrmann [mailto:stefanfuhrm...@alice-dsl.de] > Sent: woensdag 12 mei 2010 12:25 > To: dev@apr.apache.org > Subject: First SVN performance data > > Hi there, > > as I promised, I'm going to conduct some in-depth analysis and > comprehensive SVN perfor

RE: Why does apr_file_read() with !APR_XTHREAD use mutexes on Windows

2010-04-27 Thread Bert Huijben
> -Original Message- > From: Jeff Trawick [mailto:traw...@gmail.com] > Sent: maandag 26 april 2010 23:14 > To: APR Developer List > Cc: Bert Huijben > Subject: Re: Why does apr_file_read() with !APR_XTHREAD use mutexes on > Windows > > On Mon, Apr 26, 2010 at

RE: Why does apr_file_read() with !APR_XTHREAD use mutexes on Windows

2010-04-20 Thread Bert Huijben
> -Original Message- > From: Bert Huijben [mailto:b...@qqmail.nl] > Sent: vrijdag 16 april 2010 17:28 > To: dev@apr.apache.org > Subject: Why does apr_file_read() with !APR_XTHREAD on Windows > > Hi, > > While profiling subversions file usage perfor

Why does apr_file_read() with !APR_XTHREAD on Windows

2010-04-16 Thread Bert Huijben
Hi, While profiling subversions file usage performance on Windows, one major slowdown shows: When a file is opened with APR_BUFFERED on Windows all read and file operations are slowed down by a mutex (or actually a critical section), even though the function is not documented to be thread

RE: [PATCH] delta_files() speedup 3/3: file write buffering

2010-03-29 Thread Bert Huijben
[CC to d...@apr.apache.org] > -Original Message- > From: Stefan Fuhrmann [mailto:stefanfuhrm...@alice-dsl.de] > Sent: zondag 28 maart 2010 14:51 > To: d...@subversion.apache.org > Subject: [PATCH] delta_files() speedup 3/3: file write buffering > > Hi devs, > > this is part of the delta_

RE: svn commit: r921306 - /apr/apr/branches/1.5.x/file_io/win32/open.c

2010-03-12 Thread Bert Huijben
> -Original Message- > From: jean-frederic clere [mailto:jfcl...@gmail.com] > Sent: vrijdag 12 maart 2010 12:12 > To: Bert Huijben > Cc: dev@apr.apache.org > Subject: Re: svn commit: r921306 - > /apr/apr/branches/1.5.x/file_io/win32/open.c > > On 03/12/2010 1

RE: svn commit: r921306 - /apr/apr/branches/1.5.x/file_io/win32/open.c

2010-03-12 Thread Bert Huijben
> -Original Message- > From: jfcl...@apache.org [mailto:jfcl...@apache.org] > Sent: woensdag 10 maart 2010 12:18 > To: comm...@apr.apache.org > Subject: svn commit: r921306 - > /apr/apr/branches/1.5.x/file_io/win32/open.c > > Author: jfclere > Date: Wed Mar 10 11:18:28 2010 > New Revisio

RE: [Patch] RE: Windows drive letter check fails on lower case current working drive

2010-01-20 Thread Bert Huijben
> -Original Message- > From: Branko Čibej [mailto:br...@xbc.nu] > Sent: woensdag 20 januari 2010 10:17 > To: William A. Rowe Jr. > Cc: Bert Huijben; dev@apr.apache.org; 'Philip Martin'; 'Bert Huijben'; > d...@subversion.apache.org > Subject: Re: [Pa

[Patch] RE: Windows drive letter check fails on lower case current working drive

2010-01-19 Thread Bert Huijben
ed it to trunk for easy application. Bert > -Original Message- > From: Bert Huijben [mailto:b...@qqmail.nl] > Sent: woensdag 6 januari 2010 13:45 > To: 'William A. Rowe, Jr.'; dev@apr.apache.org > Cc: 'Philip Martin'; 'Bert Huijben';

Hashtable data freed before pool cleanup

2010-01-07 Thread Bert Huijben
Hi, Looking at apr's 1.3.x branch: In r817810 a change to the hash table implementation was introduced, which moves the data of a hash table from the main pool to a subpool (as seen from the pool passed to apr_hash_make). This makes the contents of the hashtable unavailable

RE: Windows drive letter check fails on lower case cwd

2010-01-06 Thread Bert Huijben
> -Original Message- > From: Bert Huijben [mailto:b...@qqmail.nl] > Sent: maandag 9 november 2009 10:05 > To: 'William A. Rowe, Jr.' > Cc: 'Philip Martin'; 'Bert Huijben'; dev@apr.apache.org; > d...@subversion.tigris.org > Subject: RE:

RE: Windows drive letter check fails on lower case cwd

2009-11-09 Thread Bert Huijben
> -Original Message- > From: William A. Rowe, Jr. [mailto:wr...@rowe-clan.net] > Sent: maandag 9 november 2009 4:25 > To: Bert Huijben > Cc: 'Philip Martin'; 'Bert Huijben'; dev@apr.apache.org; > d...@subversion.tigris.org > Subject: Re: Windows d

RE: Windows drive letter check fails on lower case cwd

2009-11-07 Thread Bert Huijben
> -Original Message- > From: Philip Martin [mailto:phi...@codematters.co.uk] > Sent: zaterdag 7 november 2009 9:41 > To: Bert Huijben > Cc: dev@apr.apache.org; d...@subversion.tigris.org > Subject: Re: Windows drive letter check fails on lower case cwd > &

Windows drive letter check fails on lower case cwd

2009-11-04 Thread Bert Huijben
leasing Subversion 1.7 (and its planned betas). Subversion tells its users it is compatible with apr 0.9 and 1.X, so I would also like to propose it for backport to older release's... Thanks, Bert Huijben