The answer to your question is whether a consumer who built against
apr<1.7.0 is going to blow up, whether they borrowed "private" API's
or not. If they were exported, it's effectively public.
Or, whether a consumer built against 1.7.1 would blow up against 1.7.0
- if that's true, we need to rever
On Wed, 9 Feb 2022 at 13:47, Ivan Zhakov wrote:
> On Tue, 8 Feb 2022 at 21:58, Evgeny Kotkov
> wrote:
>
>> Ivan Zhakov writes:
>>
>> > This part is now in the following branch:
>> >
>> https://svn.ostyserver.net/svn/asf/apr/apr/branches/win32-pollset-wakeup-no-file-socket-emulation
>> >
>> > Wh
On Tue, 8 Feb 2022 at 21:58, Evgeny Kotkov
wrote:
> Ivan Zhakov writes:
>
> > This part is now in the following branch:
> >
> https://svn.ostyserver.net/svn/asf/apr/apr/branches/win32-pollset-wakeup-no-file-socket-emulation
> >
> > What do you think?
> >
> > It would be great if someone could ta
Ivan Zhakov writes:
> This part is now in the following branch:
> https://svn.ostyserver.net/svn/asf/apr/apr/branches/win32-pollset-wakeup-no-file-socket-emulation
>
> What do you think?
>
> It would be great if someone could take a look on the implementation from
> the *nix perspective.
> After
On Thu, 20 Jan 2022 at 17:39, Ivan Zhakov wrote:
> On Fri, 14 Jan 2022 at 18:19, Ivan Zhakov wrote:
>
>> On Thu, 13 Jan 2022 at 23:37, Ruediger Pluem wrote:
>>
>>>
>>>
>>> On 1/13/22 7:04 PM, Ivan Zhakov wrote:
>>> > [[ sorry for delayed response ]]
>>> >
>>> > On Fri, 7 Jan 2022 at 17:33, Yann
On Fri, 14 Jan 2022 at 18:19, Ivan Zhakov wrote:
> On Thu, 13 Jan 2022 at 23:37, Ruediger Pluem wrote:
>
>>
>>
>> On 1/13/22 7:04 PM, Ivan Zhakov wrote:
>> > [[ sorry for delayed response ]]
>> >
>> > On Fri, 7 Jan 2022 at 17:33, Yann Ylavic wrote:
>> >>
>> >> Hi Ivan,
>> >>
>> >> On Fri, Jan 7
On Thu, Jan 13, 2022 at 7:04 PM Ivan Zhakov wrote:
>
> On Fri, 7 Jan 2022 at 17:33, Yann Ylavic wrote:
> >
> > I think that most if not all of the changes to 1.7.x since 1.7.0 are
> > fixes for bugs that were there before 1.7 already, not regressions
> > introduced by 1.7.0.
>
> Agreed on the bug
On Fri, Jan 14, 2022 at 4:20 PM Ivan Zhakov wrote:
>
> 1. Revert this change from 1.7.x
Done in r1897222.
Regards;
Yann.
On Fri, Jan 14, 2022 at 4:40 PM Yann Ylavic wrote:
>
> On Fri, Jan 14, 2022 at 4:20 PM Ivan Zhakov wrote:
> >
> > 1. Revert this change from 1.7.x
> > 2. Release 1.7.1
> > 3. Rework this code on trunk without changing the apr_file_t's behavior
> > 4. Backport it to 1.7.x/1.8.x
> >
> > And if this
On Fri, Jan 14, 2022 at 4:20 PM Ivan Zhakov wrote:
>
> 1. Revert this change from 1.7.x
> 2. Release 1.7.1
> 3. Rework this code on trunk without changing the apr_file_t's behavior
> 4. Backport it to 1.7.x/1.8.x
>
> And if this plan makes sense, I am ready to proceed with steps (1), (3) and
> (4
On Thu, 13 Jan 2022 at 23:37, Ruediger Pluem wrote:
>
>
> On 1/13/22 7:04 PM, Ivan Zhakov wrote:
> > [[ sorry for delayed response ]]
> >
> > On Fri, 7 Jan 2022 at 17:33, Yann Ylavic wrote:
> >>
> >> Hi Ivan,
> >>
> >> On Fri, Jan 7, 2022 at 2:50 PM Ivan Zhakov wrote:
> >>>
> >>> This change do
Hi Ivan;
On Thu, Jan 13, 2022 at 7:04 PM Ivan Zhakov wrote:
>
> On Fri, 7 Jan 2022 at 17:33, Yann Ylavic wrote:
> >
> > I was missing backport of r1895178, does r1896808 compile now?
> > (Sorry, no Windows at hand..).
> Yes, it builds now. Thanks!
Great, thanks for testing.
> >
> > I think tha
On Thu, Jan 13, 2022 at 2:37 PM Ruediger Pluem wrote:
>
> On 1/13/22 7:04 PM, Ivan Zhakov wrote:
> >
> > On Fri, 7 Jan 2022 at 17:33, Yann Ylavic wrote:
> >>
> >> On Fri, Jan 7, 2022 at 2:50 PM Ivan Zhakov wrote:
> >>>
> >>> I also have a high-level objection against backporting this change to
>
On 1/13/22 7:04 PM, Ivan Zhakov wrote:
> [[ sorry for delayed response ]]
>
> On Fri, 7 Jan 2022 at 17:33, Yann Ylavic wrote:
>>
>> Hi Ivan,
>>
>> On Fri, Jan 7, 2022 at 2:50 PM Ivan Zhakov wrote:
>>>
>>> This change does not compile on Windows in APR 1.7.x:
>>> [[[
>>> file_io\win32\readwrit
[[ sorry for delayed response ]]
On Fri, 7 Jan 2022 at 17:33, Yann Ylavic wrote:
>
> Hi Ivan,
>
> On Fri, Jan 7, 2022 at 2:50 PM Ivan Zhakov wrote:
> >
> > This change does not compile on Windows in APR 1.7.x:
> > [[[
> > file_io\win32\readwrite.c(325): error C2065: 'file': undeclared identifier
On 1/7/22 3:32 PM, Yann Ylavic wrote:
> Hi Ivan,
>
> On Fri, Jan 7, 2022 at 2:50 PM Ivan Zhakov wrote:
>>
>> This change does not compile on Windows in APR 1.7.x:
>> [[[
>> file_io\win32\readwrite.c(325): error C2065: 'file': undeclared identifier
>> file_io\win32\readwrite.c(325): error C2223
Hi Ivan,
On Fri, Jan 7, 2022 at 2:50 PM Ivan Zhakov wrote:
>
> This change does not compile on Windows in APR 1.7.x:
> [[[
> file_io\win32\readwrite.c(325): error C2065: 'file': undeclared identifier
> file_io\win32\readwrite.c(325): error C2223: left of '->filehand' must
> point to struct/union
> I also have a high-level objection against backporting this change to
> APR 1.7.x: IMHO APR 1.7.x is a stable branch and I think that only
> regression fixes should be backported to the stable branch. r1896510
> is a significant change and as far as I understand it's not a
> regression fix. So I
On Wed, 29 Dec 2021 at 19:53, wrote:
>
> Author: ylavic
> Date: Wed Dec 29 16:53:51 2021
> New Revision: 1896510
>
> URL: http://svn.apache.org/viewvc?rev=1896510&view=rev
> Log:
> Merge r1895106, r1895111, r1895175, r1895181, r1895465 from trunk:
>
>
> Fix drain wakeup pipe issue when multiple th
19 matches
Mail list logo
