Re: svn commit: r1917050 - in /apr/apr/trunk: CHANGES crypto/apr_crypto.c dbd/apr_dbd.c dbm/apr_dbm.c include/private/apu_internal.h util-misc/apu_dso.c

On 4/22/24 4:07 PM, Graham Leggett via dev wrote: > On 22 Apr 2024, at 14:05, Ruediger Pluem wrote: > >>>> Now the caller needs to allocate memory even if it is not interested in >>>> the error or if there is no error at all. >>>> Wouldn't it b

Re: svn commit: r1917266 - in /apr/apr/trunk: buffer/apr_buffer.c include/apr_buffer.h test/testbuffer.c

On 4/22/24 2:46 PM, minf...@apache.org wrote: > Author: minfrin > Date: Mon Apr 22 12:46:37 2024 > New Revision: 1917266 > > URL: http://svn.apache.org/viewvc?rev=1917266=rev > Log: > apr_buffer: Redefine size to separate the unsigned size and the > flag to indicate whether a zero terminated

Re: svn commit: r1917050 - in /apr/apr/trunk: CHANGES crypto/apr_crypto.c dbd/apr_dbd.c dbm/apr_dbm.c include/private/apu_internal.h util-misc/apu_dso.c

On 4/17/24 9:30 AM, Graham Leggett via dev wrote: > On 17 Apr 2024, at 08:07, Ruediger Pluem wrote: > >>> Modified: apr/apr/trunk/util-misc/apu_dso.c >>> URL: >>> http://svn.apache.org/viewvc/apr/apr/trunk/util-misc/apu_dso.c

Re: svn commit: r1917082 - /apr/apr/trunk/buffer/apr_buffer.c

On 4/18/24 12:37 AM, minf...@apache.org wrote: > Author: minfrin > Date: Wed Apr 17 22:37:07 2024 > New Revision: 1917082 > > URL: http://svn.apache.org/viewvc?rev=1917082=rev > Log: > apr_buffer: Add explicit casts on all potentially narrowing conversions > to apr_size_t. Define the maximum

Re: svn commit: r1917047 - in /apr/apr/trunk: CHANGES buffer/ buffer/apr_buffer.c build.conf include/apr_buffer.h test/Makefile.in test/Makefile.win test/NWGNUaprtest test/abts_tests.h test/testbuffer

On 4/17/24 12:02 AM, Graham Leggett via dev wrote: > Hi all, > >> +/** >> + * Structure for efficiently tracking a buffer that could contain >> + * a zero terminated string, or a fixed length non zero string. >> + */ >> +typedef struct >> +{ >> +/** pointer to the data, which could be a

Re: svn commit: r1917050 - in /apr/apr/trunk: CHANGES crypto/apr_crypto.c dbd/apr_dbd.c dbm/apr_dbm.c include/private/apu_internal.h util-misc/apu_dso.c

On 4/16/24 11:33 PM, minf...@apache.org wrote: > Author: minfrin > Date: Tue Apr 16 21:33:58 2024 > New Revision: 1917050 > > URL: http://svn.apache.org/viewvc?rev=1917050=rev > Log: > Pass details of module loading errors back to the caller through the > apu_err_t structure. > > Modified: >

Re: svn commit: r1917047 - in /apr/apr/trunk: CHANGES buffer/ buffer/apr_buffer.c build.conf include/apr_buffer.h test/Makefile.in test/Makefile.win test/NWGNUaprtest test/abts_tests.h test/testbuffer

On 4/16/24 10:54 PM, minf...@apache.org wrote: > Author: minfrin > Date: Tue Apr 16 20:54:51 2024 > New Revision: 1917047 > > URL: http://svn.apache.org/viewvc?rev=1917047=rev > Log: > Add the apr_buffer API. > > An APR buffer is a structure that can contain a zero terminated string, or > a

Re: svn commit: r1916337 - /apr/apr/trunk/include/apr_general.h

On 3/15/24 2:35 PM, yla...@apache.org wrote: > Author: ylavic > Date: Fri Mar 15 13:35:04 2024 > New Revision: 1916337 > > URL: http://svn.apache.org/viewvc?rev=1916337=rev > Log: > apr_general: Use __builtin_offsetof for APR_OFFSETOF if available. PR 68763. > > Sanitizers might warn about

Re: svn commit: r1915658 - /apr/apr/trunk/test/testbuckets.c

On 2/8/24 4:49 PM, jor...@apache.org wrote: > Author: jorton > Date: Thu Feb 8 15:49:14 2024 > New Revision: 1915658 > > URL: http://svn.apache.org/viewvc?rev=1915658=rev > Log: > * buckets/apr_brigade.c (apr_brigade_split_line): After finding an LF, > only split the bucket if the LF is not

Re: svn commit: r1914814 - in /apr/apr/trunk: CHANGES encoding/apr_escape.c include/apr_escape.h test/testescape.c tools/gen_test_char.c

On 12/20/23 11:46 PM, minf...@apache.org wrote: > Author: minfrin > Date: Wed Dec 20 22:46:22 2023 > New Revision: 1914814 > > URL: http://svn.apache.org/viewvc?rev=1914814=rev > Log: > apr_escape: Add apr_escape_json() and apr_pescape_json(). > > Modified: > apr/apr/trunk/CHANGES >

Re: [PATCH] Avoid memcpy-from-NULL in apr_brigade_flatten

On 12/18/23 12:09 PM, Joe Orton wrote: > On Thu, Dec 14, 2023 at 04:44:47PM -0500, Ben Kallus wrote: >> memcpy to or from NULL is undefined behavior, even for copies of >> length 0. See this godbolt link for an example of how this can cause >> problems: https://gcc.godbolt.org/z/zfvnMMsds >> >>

Possible cache inconsistency in apr_memcache.c

I think the below code from memcache/apr_memcache.c::apr_memcache_find_server_hash_default can cause a cache inconsistency. If the server determined by the provided hash value is dead we just choose the next one. If we do this when writing and the previous dead server comes back with its cache

Hard coded time value in apr_memcache.c

I am a little bit bothered by the following hardcoded time in memcache/apr_memcache.c::apr_memcache_find_server_hash_default if (curtime - ms->btime > apr_time_from_sec(5)) { ms->btime = curtime; if (mc_version_ping(ms) == APR_SUCCESS) {

Re: Release APR 1.7.4?

On 4/12/23 5:12 PM, Evgeny Kotkov via dev wrote: > Hi everyone, > > Unfortunately, one of the fixes in APR 1.7.3 that was authored by me has > caused a significant regression, where writing to files opened with both > APR_FOPEN_APPEND and APR_FOPEN_BUFFERED now may not properly append > the

Re: [ANNOUNCEMENT] Apache Portable Runtime 1.7.3 Released

On 3/31/23 11:13 AM, rpluem wrote: >Apache Portable Runtime APR 1.7.3 Released > Should I remove the old APR 1.6.5 files from the releases directory as well? Regards Rüdiger

[VOTE] Release apr-1.7.3 [RESULTS]

On 3/27/23 10:17 AM, Ruediger Pluem wrote: > 1.7.3-rc1 is here: > > https://apr.apache.org/dev/dist/ > > For the release of apr-1.7.3 > [ ] +1 looks great! > [ ] -1 something is broken > > I will let the vote run through end-of-week. > With mo

Re: [VOTE] Release apr-1.7.3

On 3/27/23 10:17 AM, Ruediger Pluem wrote: > 1.7.3-rc1 is here: > > https://apr.apache.org/dev/dist/ > > For the release of apr-1.7.3 > [X ] +1 looks great! > [ ] -1 something is broken > > I will let the vote run through end-of-week. > Tested on RedHa

[VOTE] Release apr-1.7.3

1.7.3-rc1 is here: https://apr.apache.org/dev/dist/ For the release of apr-1.7.3 [ ] +1 looks great! [ ] -1 something is broken I will let the vote run through end-of-week. Regards Rüdiger

Release APR 1.7.3 ?

Is someone opposed if I put an APR 1.7.x release for vote on the beginning of next week? It would be my first APR release, but I think I should be able to do it with the instructions in release.sh (thanks Eric). Otherwise I will ask here for help. We had a regression in apr-1-config that is now

Re: svn commit: r1906889 - in /apr/apr/trunk: ./ build/ include/ include/arch/win32/ test/ threadproc/beos/ threadproc/netware/ threadproc/os2/ threadproc/unix/ threadproc/win32/

On 3/17/23 11:20 AM, Rainer Jung wrote: > Thanks Yann, configure now detects the missing function. > > But: testpoll fails: > > testpoll    :  Line 897: apr_pollset_poll() didn't sleep > > Unfortunately I don't know when it started. Any idea, what I should > investigate? > > All

Re: svn commit: r1908433 - in /apr/apr/trunk: crypto/apr_crypto_openssl.c test/testcrypto.c

On 3/16/23 1:43 PM, yla...@apache.org wrote: > Author: ylavic > Date: Thu Mar 16 12:43:17 2023 > New Revision: 1908433 > > URL: http://svn.apache.org/viewvc?rev=1908433=rev > Log: > apr_crypto_openssl: Compatibility with OpenSSL 3+ > > Modified: > apr/apr/trunk/crypto/apr_crypto_openssl.c

Re: svn commit: r1908433 - in /apr/apr/trunk: crypto/apr_crypto_openssl.c test/testcrypto.c

On 3/16/23 1:43 PM, yla...@apache.org wrote: > Author: ylavic > Date: Thu Mar 16 12:43:17 2023 > New Revision: 1908433 > > URL: http://svn.apache.org/viewvc?rev=1908433=rev > Log: > apr_crypto_openssl: Compatibility with OpenSSL 3+ > > Modified: > apr/apr/trunk/crypto/apr_crypto_openssl.c

Re: svn commit: r1907634 - /apr/apr/trunk/include/apr_buckets.h

On 2/14/23 7:28 PM, Christophe JAILLET wrote: > Le 14/02/2023 à 11:51, Ivan Zhakov via dev a écrit : >> On Tue, 14 Feb 2023 at 10:58, > > wrote: >> >>     Author: jailletc36 >>     Date: Tue Feb 14 07:56:50 2023 >>     New Revision: 1907634 >> >>     URL:

Re: apr-1.7.2/Apache shared memory now world readable?

On 2/10/23 2:42 AM, Eric Covener wrote: >> I think this should be revisited and changed to 600. > > It seems like all the methods use 0644. After the change, it's just > accessible in the filesystem rather than in the sysv shm ether. > > It seems like an API gap, APR can't know what the

Re: apr-1.7.2/Apache shared memory now world readable?

On 2/8/23 11:06 PM, Michael Brunnbauer wrote: > > hi all, > > I upgraded to apr-1.7.2 and apr-util-1.6.3 today and ran into an issue where > Apache 2.4.55 would not start any more because it could not open the > ScoreBoardFile and/or SSLSessionCache. This is apparently caused by this >

Re: [VOTE] apr 1.7.2 and apr-util 1.6.3

On 2/1/23 8:32 AM, Ruediger Pluem wrote: > > > On 1/31/23 10:22 PM, Eric Covener wrote: >> I hosed 1.7.1/1.6.2 and the archives have -rcX in them at the top >> level. I would like to call for an expedited vote to replace them >> with version bumps. I will proce

Re: [VOTE] apr 1.7.2 and apr-util 1.6.3

On 1/31/23 10:22 PM, Eric Covener wrote: > I hosed 1.7.1/1.6.2 and the archives have -rcX in them at the top > level. I would like to call for an expedited vote to replace them > with version bumps. I will proceed once we get 3 binding +1. > > I have re-tagged because I think the consensus

Re: [VOTE] release apr-1.6.2-rc3 as APR 1.6.2

On 1/27/23 4:53 PM, Eric Covener wrote: > On Fri, Jan 27, 2023 at 10:12 AM Ruediger Pluem wrote: >> >> >> >> On 1/27/23 2:42 PM, Eric Covener wrote: >>> 1.6.2-rc3 is here: >>> >>> https://apr.apache.org/dev/dist/ >>> &

Re: [VOTE] release apr-1.6.2-rc3 as APR 1.6.2

On 1/27/23 2:42 PM, Eric Covener wrote: > 1.6.2-rc3 is here: > > https://apr.apache.org/dev/dist/ > > For the release of apr-util-1.6.2 > [ ] +1 looks great > [ ] -1 something is broken > > I'd like to call a vote in parallel to the discussion around the > suitability for 1.6.x. > >

Re: [VOTE] release apr-util-1.6.2-rc2 as apr-util 1.6.2

On 1/26/23 3:15 AM, Noel Butler wrote: > On 24/01/2023 22:08, Graham Leggett via dev wrote: > >> On 24 Jan 2023, at 02:02, Noel Butler > > wrote: >>> >>> This is a result of apr-util 1.6 STILL NOT patched for mariadb or mysql 10 >>> plus  >>> >>>

Re: [VOTE] release apr-util-1.6.2-rc2 as apr-util 1.6.2

On 1/24/23 1:08 PM, Graham Leggett via dev wrote: > On 24 Jan 2023, at 02:02, Noel Butler > wrote: >> >> This is a result of apr-util 1.6 STILL NOT patched for mariadb or mysql 10 >> plus  >> >> https://bz.apache.org/bugzilla/show_bug.cgi?id=61517#c5 >> > If you

Re: VOTE: Release apr-1.7.1-rc2 as 1.7.1

On 1/20/23 1:44 AM, Eric Covener wrote: > 1.7.1-rc1 is here: > > https://apr.apache.org/dev/dist/ > > For the release of apr-1.7.1 > [ ] +1 looks great! > [ ] -1 something is broken > > I will let the vote run through mid-week. > +1. Tested on RedHat 8.7 x86_64 Regards Rüdiger

Re: malloc, calloc and APR pools

On 11/13/22 4:23 PM, Jim Jagielski wrote: > This article (https://vorpus.org/blog/why-does-calloc-exist/) > looks like it's very applicable to APR, where we do the exact > malloc-memset trick. > > Prelim testing on my macOS and Linux machines do show appreciable > improvements. At the very

Re: svn commit: r1902206 - /apr/apr/trunk/encoding/apr_base64.c

On 6/23/22 8:49 PM, Ruediger Pluem wrote: > > > On 6/23/22 5:12 PM, yla...@apache.org wrote: >> Author: ylavic >> Date: Thu Jun 23 15:12:47 2022 >> New Revision: 1902206 > > >> @@ -275,16 +284,17 @@ APR_DECLARE(int) apr_base64_encode_binar >>

Re: svn commit: r1902206 - /apr/apr/trunk/encoding/apr_base64.c

On 6/24/22 11:56 AM, Yann Ylavic wrote: > On Thu, Jun 23, 2022 at 8:50 PM Ruediger Pluem wrote: >> >> On 6/23/22 5:12 PM, yla...@apache.org wrote: >>> >>> +/* Above APR_BASE64_ENCODE_MAX length the encoding can't fit in an int >= >>> 0 */

Re: svn commit: r1902207 - /apr/apr/trunk/json/apr_json_decode.c

On 6/23/22 6:14 PM, yla...@apache.org wrote: > Author: ylavic > Date: Thu Jun 23 16:14:41 2022 > New Revision: 1902207 > > URL: http://svn.apache.org/viewvc?rev=1902207=rev > Log: > apr_json_decode: Return APR_ENOSPC if a decoded array is above INT_MAX. > > *

Re: svn commit: r1902206 - /apr/apr/trunk/encoding/apr_base64.c

On 6/23/22 5:12 PM, yla...@apache.org wrote: > Author: ylavic > Date: Thu Jun 23 15:12:47 2022 > New Revision: 1902206 > > URL: http://svn.apache.org/viewvc?rev=1902206=rev > Log: > apr_base64: Make sure encoding/decoding lengths fit in an int >= 0. > > The (old) API of apr_base64 functions

Re: svn commit: r1902196 - /apr/apr/trunk/json/apr_json_decode.c

On 6/23/22 1:43 PM, yla...@apache.org wrote: > Author: ylavic > Date: Thu Jun 23 11:43:05 2022 > New Revision: 1902196 > > URL: http://svn.apache.org/viewvc?rev=1902196=rev > Log: > apr_json_decode: apr_array_header_t uses ints. > > * json/apr_json_decode.c(apr_json_decode_array): >

Re: svn commit: r1902176 - /apr/apr/trunk/build/xml.m4

On 6/23/22 1:46 AM, cove...@apache.org wrote: > Author: covener > Date: Wed Jun 22 23:46:43 2022 > New Revision: 1902176 > > URL: http://svn.apache.org/viewvc?rev=1902176=rev > Log: > set -lxml2 in non xml2-config case > > Closes #36 > > Modified: > apr/apr/trunk/build/xml.m4 > >

Re: GitHub Actions CI

On 6/22/22 4:29 PM, Yann Ylavic wrote: > On Wed, Jun 22, 2022 at 2:26 PM Ivan Zhakov via dev > wrote: >> >> As far I understand Apache Infra recommends to migrate Continuous >> Integration builds from Travis to GitHub Actions. >> >> I've added initial configuration for GitHub Actions for APR

Re: Possible apr 1.7.1 showstopper from httpd test framework

On 1/14/22 6:47 AM, William A Rowe Jr wrote: > In addition to a broken release of brotli (where enc/dec don't specify > -lbrotlicommon, > even on trunk, for openssl and other consumers to ferret out that binding), > and > lots of fun changes to build flags in curl 7.81 minor release (who does

Re: svn commit: r1896510 - in /apr/apr/branches/1.7.x: ./ file_io/win32/ include/arch/unix/ include/arch/win32/ network_io/os2/ poll/os2/ poll/unix/

On 1/13/22 7:04 PM, Ivan Zhakov wrote: > [[ sorry for delayed response ]] > > On Fri, 7 Jan 2022 at 17:33, Yann Ylavic wrote: >> >> Hi Ivan, >> >> On Fri, Jan 7, 2022 at 2:50 PM Ivan Zhakov wrote: >>> >>> This change does not compile on Windows in APR 1.7.x: >>> [[[ >>>

Re: svn commit: r1896510 - in /apr/apr/branches/1.7.x: ./ file_io/win32/ include/arch/unix/ include/arch/win32/ network_io/os2/ poll/os2/ poll/unix/

On 1/7/22 3:32 PM, Yann Ylavic wrote: > Hi Ivan, > > On Fri, Jan 7, 2022 at 2:50 PM Ivan Zhakov wrote: >> >> This change does not compile on Windows in APR 1.7.x: >> [[[ >> file_io\win32\readwrite.c(325): error C2065: 'file': undeclared identifier >> file_io\win32\readwrite.c(325): error

Re: svn commit: r1893204 - in /apr/apr/trunk/file_io: os2/filedup.c unix/filedup.c win32/filedup.c

On 1/7/22 3:02 PM, Yann Ylavic wrote: > On Fri, Sep 10, 2021 at 5:49 PM Yann Ylavic wrote: >> >> On Fri, Sep 10, 2021 at 4:44 PM Ruediger Pluem wrote: >>> >>> On 9/10/21 4:04 PM, Yann Ylavic wrote: >&

Re: Dropping Netware code from Windows apr/trunk

On 12/9/21 9:18 PM, Greg Stein wrote: > On Thu, Dec 9, 2021 at 1:55 PM Ruediger Pluem <mailto:rpl...@apache.org>> wrote: > > On 12/9/21 6:10 PM, Greg Stein wrote: > > On Wed, Dec 8, 2021 at 7:08 AM Ruediger Pluem <mailto:rpl...@apache.org> <mailto:rp

Re: Dropping Netware code from Windows apr/trunk

On 12/9/21 6:10 PM, Greg Stein wrote: > On Wed, Dec 8, 2021 at 7:08 AM Ruediger Pluem <mailto:rpl...@apache.org>> wrote: >>... > > I think our API / ABI rules do not allow this for 1.8, only for 2.0. > But the question is if we are wiling t

Re: Dropping Netware code from Windows apr/trunk

On 12/8/21 1:37 PM, Nick Kew wrote: > > >> On 7 Dec 2021, at 13:50, Mladen Turk wrote: >> >> There are still bunch of Netware code >> polluting win32 code in apr/trunk. >> >> Since the Netware itself is discontinued for >> quit some time, I wonder the effective purpose >> of that code inside

Re: Get rid of APU api in favor of APR for apr/turk

I assumed this as a trunk/2.0 only proposal. Is my assumption wrong? Regards Rüdiger On 12/7/21 9:46 PM, Greg Stein wrote: > If you're talking 1.7, then as long as an apu_legacy.h header is included by > $appropriate with #define symbols mapping APU_FOO to > APR_FOO. This header could be

Re: Dropping Netware code from Windows apr/trunk

On 12/7/21 2:50 PM, Mladen Turk wrote: > There are still bunch of Netware code > polluting win32 code in apr/trunk. > > Since the Netware itself is discontinued for > quit some time, I wonder the effective purpose > of that code inside apr. > > I propose to remove all that > #ifdef NETWARE

Re: svn commit: r1894917 - /apr/apr/trunk/poll/unix/wakeup.c

On 11/17/21 2:39 AM, Mladen Turk wrote: > > > On 16/11/2021 12:00, Yann Ylavic wrote: >> On Wed, Nov 10, 2021 at 4:19 PM Yann Ylavic wrote: >>> >>> Otherwise I'll revert because I have no way to test it, but I think >>> that apr_poll_drain_wakeup_pipe() might block on Windows for the same

Re: svn commit: r1894621 - in /apr/apr/trunk: atomic/unix/builtins.c atomic/unix/builtins64.c atomic/unix/mutex.c configure.in

On 10/29/21 11:10 PM, Yann Ylavic wrote: > On Fri, Oct 29, 2021 at 8:00 PM Ruediger Pluem wrote: >> >> >> >> On 10/29/21 5:09 PM, yla...@apache.org wrote: >>> Author: ylavic >>> Date: Fri Oct 29 15:09:13 2021 >>> New Revision: 1894621 >

Re: svn commit: r1894621 - in /apr/apr/trunk: atomic/unix/builtins.c atomic/unix/builtins64.c atomic/unix/mutex.c configure.in

On 10/29/21 5:09 PM, yla...@apache.org wrote: > Author: ylavic > Date: Fri Oct 29 15:09:13 2021 > New Revision: 1894621 > > URL: http://svn.apache.org/viewvc?rev=1894621=rev > Log: > apr_atomic: Use __atomic builtins when available. > > Unlike Intel's atomic builtins (__sync_*), the more

Re: svn commit: r1894551 - in /apr/apr/trunk: buckets/apr_brigade.c configure.in include/apr.h.in include/apr.hnw include/apr.hw include/apr.hwc

On 10/25/21 2:27 PM, Graham Leggett wrote: > On 25 Oct 2021, at 12:30, Ruediger Pluem wrote: > >> begin is unused. > > Will fix. > >>> + >>> +    while ((hay = memchr(hay, *(char *)needle, len))) { >> >> Does memchr have a defined b

Re: svn commit: r1894551 - in /apr/apr/trunk: buckets/apr_brigade.c configure.in include/apr.h.in include/apr.hnw include/apr.hw include/apr.hwc

On 10/25/21 12:31 PM, minf...@apache.org wrote: > Author: minfrin > Date: Mon Oct 25 10:31:32 2021 > New Revision: 1894551 > > URL: http://svn.apache.org/viewvc?rev=1894551=rev > Log: > apr_brigade_split_boundary: Provide a memmem implementation on platforms that > do not have one. > >

Re: svn commit: r1894423 - /apr/apr/trunk/buckets/apr_brigade.c

On 10/21/21 12:23 AM, minf...@apache.org wrote: > Author: minfrin > Date: Wed Oct 20 22:23:10 2021 > New Revision: 1894423 > > URL: http://svn.apache.org/viewvc?rev=1894423=rev > Log: > apr_brigade_split_boundary: Rather than shaving one byte from > a bucket, ignore the byte instead on the

Re: svn commit: r1894380 - in /apr/apr/trunk: buckets/apr_brigade.c include/apr_buckets.h test/testbuckets.c

On 10/20/21 11:01 PM, Graham Leggett wrote: > On 20 Oct 2021, at 10:43, Yann Ylavic wrote: > >> apr_strnstr() maybe, strnstr() is non-standard AFAICT and possibly not >> available on all platforms (Windows)? > > This needs to be memmem really, as the boundary isn’t always a string. But I

Re: svn commit: r1893204 - in /apr/apr/trunk/file_io: os2/filedup.c unix/filedup.c win32/filedup.c

On 9/10/21 4:04 PM, Yann Ylavic wrote: > Index: buckets/apr_buckets_file.c > === > --- buckets/apr_buckets_file.c(revision 1893196) > +++ buckets/apr_buckets_file.c(working copy) > @@ -223,11 +223,33 @@

Re: svn commit: r1893204 - in /apr/apr/trunk/file_io: os2/filedup.c unix/filedup.c win32/filedup.c

On 9/10/21 2:55 PM, Yann Ylavic wrote: > On Fri, Sep 10, 2021 at 1:32 PM Yann Ylavic wrote: >> >> On Fri, Sep 10, 2021 at 11:12 AM Ruediger Pluem wrote: >>> >>> On 9/10/21 11:04 AM, Ruediger Pluem wrote: >>>> >>>> On 9/10/21 8:55 AM,

Re: svn commit: r1893204 - in /apr/apr/trunk/file_io: os2/filedup.c unix/filedup.c win32/filedup.c

On 9/10/21 11:04 AM, Ruediger Pluem wrote: > > > On 9/10/21 8:55 AM, Joe Orton wrote: >> On Fri, Sep 10, 2021 at 12:51:53AM -, yla...@apache.org wrote: >>> Author: ylavic >>> Date: Fri Sep 10 00:51:53 2021 >>> New Revision: 1893204 >>> &g

Re: svn commit: r1893204 - in /apr/apr/trunk/file_io: os2/filedup.c unix/filedup.c win32/filedup.c

On 9/10/21 8:55 AM, Joe Orton wrote: > On Fri, Sep 10, 2021 at 12:51:53AM -, yla...@apache.org wrote: >> Author: ylavic >> Date: Fri Sep 10 00:51:53 2021 >> New Revision: 1893204 >> >> URL: http://svn.apache.org/viewvc?rev=1893204=rev >> Log: >> apr_file_setaside: don't blindly kill the old

Re: APR 1.7.1 release?

On 9/10/21 10:28 AM, Steffen Land wrote: > Please be sure that the following two are included in 1.7.1 : > > PR 63491 regression in 1.7, see  > https://www.apachelounge.com/viewtopic.php?p=39558 r1882155 brought this already to 1.7. > PR 61165 CPU deadlock under load, see   >

Re: svn commit: r1893204 - in /apr/apr/trunk/file_io: os2/filedup.c unix/filedup.c win32/filedup.c

On 9/10/21 2:51 AM, yla...@apache.org wrote: > Author: ylavic > Date: Fri Sep 10 00:51:53 2021 > New Revision: 1893204 > > URL: http://svn.apache.org/viewvc?rev=1893204=rev > Log: > apr_file_setaside: don't blindly kill the old cleanup and file descriptor. > > There is no cleanup with

Re: svn commit: r1887060 - in /apr/apr/trunk: CHANGES include/apr_mmap.h mmap/unix/mmap.c test/data/mmap_large_datafile.txt test/testmmap.c

On 3/2/21 1:54 AM, Yann Ylavic wrote: > On Tue, Mar 2, 2021 at 1:37 AM wrote: >> >> Author: ylavic >> Date: Tue Mar 2 00:37:18 2021 >> New Revision: 1887060 >> >> URL: http://svn.apache.org/viewvc?rev=1887060=rev >> Log: >> Align apr_mmap()ing offset to a page boundary. PR 65158. > [] >> ---

Re: svn commit: r1883868 - /apr/apr/trunk/encoding/apr_encode.c

On 11/27/20 5:54 PM, yla...@apache.org wrote: > Author: ylavic > Date: Fri Nov 27 16:54:50 2020 > New Revision: 1883868 > > URL: http://svn.apache.org/viewvc?rev=1883868=rev > Log: > apr_encode_base32: fix estimated output *len (when called with src == NULL). If src == NULL we leave

Re: svn commit: r1883801 - /apr/apr/trunk/memory/unix/apr_pools.c

On 11/25/20 11:45 AM, Yann Ylavic wrote: > On Wed, Nov 25, 2020 at 10:20 AM Ruediger Pluem wrote: >> >> On 11/24/20 10:12 PM, yla...@apache.org wrote: >>> Author: ylavic >>> Date: Tue Nov 24 21:12:37 2020 >>> New Revision: 1883801 >>> &g

Re: svn commit: r1883801 - /apr/apr/trunk/memory/unix/apr_pools.c

On 11/24/20 10:12 PM, yla...@apache.org wrote: > Author: ylavic > Date: Tue Nov 24 21:12:37 2020 > New Revision: 1883801 > > URL: http://svn.apache.org/viewvc?rev=1883801=rev > Log: > apr_pools: follow up to r1883750 and r1883800. > > After r1883800, the mutex of a pool in APR_POOL_DEBUG

Re: svn commit: r1883728 - /apr/apr/trunk/network_io/unix/sockaddr.c

On 11/22/20 11:21 PM, yla...@apache.org wrote: > Author: ylavic > Date: Sun Nov 22 22:21:30 2020 > New Revision: 1883728 > > URL: http://svn.apache.org/viewvc?rev=1883728=rev > Log: > apr_sockaddr_ip_get[buf]: handle APR_UNIX family. > > For unix sockets, return the path (sun_path). > >

Re: [PATCH] Fix out of bounds write in apr_pbase64_encode() function

On 10/21/20 9:26 PM, Christopher Schultz wrote: > Denis, > > On 10/21/20 14:53, Denis Kovalchuk wrote: >> Hello. >> >> If I am not mistaken, there is an undefined behavior in apr_pbase64_encode() >> function: >> >> encoded = (char *) apr_palloc(p, apr_base64_encode_len(l)); >> l =

Re: svn commit: r1880286 - /apr/apr/trunk/build/xml.m4

On 7/25/20 11:05 AM, minf...@apache.org wrote: > Author: minfrin > Date: Sat Jul 25 09:05:54 2020 > New Revision: 1880286 > > URL: http://svn.apache.org/viewvc?rev=1880286=rev > Log: > Use the xml2-config tool to configure libxml2. Revert changes to expat build > that prevented the expat

Re: apr_jose_decode.c gcc warnings

On 3/28/20 11:35 AM, Graham Leggett wrote: > On 27 Mar 2020, at 21:20, Ruediger Pluem wrote > : >> Why are functions that are supposed to be static in the apr_ namespace? >> IMHO this is confusing when reading code. > > Are you asking the actual question why, or a

Re: apr_jose_decode.c gcc warnings

On 3/27/20 12:07 PM, Graham Leggett wrote: > On 27 Mar 2020, at 10:48, Joe Orton wrote: > >> I assume all these functions should be declared static but haven't >> looked at the code. branches/1.7.x as at r1875766 - > > If they’re not in the header file they should be static, yes. Why are

Re: apr_jose_decode.c gcc warnings

On 3/27/20 9:48 AM, Joe Orton wrote: > I assume all these functions should be declared static but haven't > looked at the code. branches/1.7.x as at r1875766 - > > jose/apr_jose_decode.c:21:14: warning: no previous prototype for > ‘apr_jose_flatten’ [-Wmissing-prototypes] >21 |

Re: Better choice for Linux semaphore than spinlock?

On 10/07/2019 08:40 PM, Branko Čibej wrote: > On Mon, 7 Oct 2019, 19:47 Doug Robinson, > wrote: > > Folks: > > I spoke with this user late last week. They stated that they can only > get approximately 400 parallel SVN operations > before the

Re: svn commit: r1862071 - in /apr/apr/trunk: file_io/os2/dir.c file_io/unix/dir.c file_io/win32/dir.c include/apr_file_info.h test/testdir.c

On 08/25/2019 04:04 PM, Branko Čibej wrote: > On 24.08.2019 16:39, Ivan Zhakov wrote: >> On Thu, 25 Jul 2019 at 15:58, Ivan Zhakov wrote: >>> On Mon, 8 Jul 2019 at 20:05, Ivan Zhakov wrote: On Wed, 3 Jul 2019 at 18:37, Joe Orton wrote: > On Wed, Jul 03, 2019 at 02:43:02PM +0300,

Re: crash during httpd cleanup when using APR debug library (APR_POOL_DEBUG)

On 07/17/2019 11:43 AM, Rainer Jung wrote: > Am 17.07.2019 um 10:03 schrieb Ruediger Pluem: >> >> >> On 07/16/2019 11:28 PM, Rainer Jung wrote: >>> cross-posted to APR+HTTPD >>> >>> Crahs happens in #2 0x7faf4c154945 in raise () from /lib

Re: crash during httpd cleanup when using APR debug library (APR_POOL_DEBUG)

On 07/16/2019 11:28 PM, Rainer Jung wrote: > cross-posted to APR+HTTPD > > Crahs happens in #2 0x7faf4c154945 in raise () from /lib64/libc.so.6 > #3 0x7faf4c155f21 in abort () from /lib64/libc.so.6 > #4 0x7faf4c14d810 in __assert_fail () from /lib64/libc.so.6 > #5

Re: svn commit: r1862071 - in /apr/apr/trunk: file_io/os2/dir.c file_io/unix/dir.c file_io/win32/dir.c include/apr_file_info.h test/testdir.c

On 07/03/2019 05:37 PM, Joe Orton wrote: > On Wed, Jul 03, 2019 at 02:43:02PM +0300, Ivan Zhakov wrote: >> They also make the existing old API unusable for many cases thus >> making a switch to the new API mandatory, even though it doesn't have >> to be so (see below). >> >> APR 1.x did not

Re: svn commit: r1860150 - in /apr/apr/trunk: ./ CHANGES CMakeLists.txt include/apr.hwc xml/apr_xml_xmllite.c

On 2019/05/28 09:12:01, Ruediger Pluem wrote: > > > On 2019/05/27 17:17:53, Ivan Zhakov wrote: > > On Mon, 27 May 2019 at 20:13, wrote: > > > > > > Author: ivan > > > Date: Mon May 27 17:13:43 2019 > > > New Revision: 1860150 > >

Re: svn commit: r1860150 - in /apr/apr/trunk: ./ CHANGES CMakeLists.txt include/apr.hwc xml/apr_xml_xmllite.c

On 2019/05/27 17:17:53, Ivan Zhakov wrote: > On Mon, 27 May 2019 at 20:13, wrote: > > > > Author: ivan > > Date: Mon May 27 17:13:43 2019 > > New Revision: 1860150 > > > > URL: http://svn.apache.org/viewvc?rev=1860150=rev > > Log: > > Windows platform: Provide a native XML parser

Re: [vote] Win32 Decision Point

On 04/24/2019 09:31 PM, William A Rowe Jr wrote: > Some 17 years later we are at a crossroads, because the win32 code > is somewhat illegible and harder to maintain due to the ANSI-vs-UTF8, > Win9x-vs-NT code paths. > > NT won. The only remaining question is how many apr consumers are >

Re: Verifying printf() formatting of types

On 03/20/2019 11:00 AM, Stefan Sperling wrote: > On Tue, Mar 19, 2019 at 07:30:09PM -0500, William A Rowe Jr wrote: >> According to my observations, apr_time_t should match the APR_TIME_T_FMT >> token in every case. Please inspect that line of httpd code to see how some >> non-apr_time_t value

Re: svn commit: r1841078 - in /apr/apr/trunk: CHANGES apr.dsp atomic/unix/builtins64.c atomic/unix/mutex64.c atomic/win32/apr_atomic64.c include/apr_atomic.h include/arch/unix/apr_arch_atomic.h test/t

On 09/18/2018 04:02 PM, Jim Jagielski wrote: > > >> On Sep 18, 2018, at 9:53 AM, Jim Jagielski > <mailto:j...@jagunet.com>> wrote: >> >> >> >>> On Sep 18, 2018, at 9:33 AM, Ruediger Pluem >> <mailto:rpl...@apache.org>> wrote:

Re: svn commit: r1841078 - in /apr/apr/trunk: CHANGES apr.dsp atomic/unix/builtins64.c atomic/unix/mutex64.c atomic/win32/apr_atomic64.c include/apr_atomic.h include/arch/unix/apr_arch_atomic.h test/t

On 09/17/2018 05:50 PM, j...@apache.org wrote: > Author: jim > Date: Mon Sep 17 15:50:19 2018 > New Revision: 1841078 > > URL: http://svn.apache.org/viewvc?rev=1841078=rev > Log: > Add in Atomics for 64bit ints > > Added: > apr/apr/trunk/atomic/unix/builtins64.c (with props) >

Re: Hashes for apr downloads

On 09/18/2018 02:52 PM, William A Rowe Jr wrote: > Note that in moderation of annou...@apache.org , > I received the following response; > >> MD5 and SHA1 hashes have been deprecated for some time on download pages (*) >> >> Please update the download page(s) to

Re: svn commit: r1828369 - in /apr/apr/trunk: include/apr_reslist.h util-misc/apr_reslist.c

On 04/16/2018 12:04 PM, Yann Ylavic wrote: > On Mon, Apr 16, 2018 at 8:45 AM, Ruediger Pluem <rpl...@apache.org> wrote: >> >> On 04/14/2018 02:32 AM, Yann Ylavic wrote: >>> >>> IOW, this simple patch would work equally for me (and could go in any

Re: svn commit: r1828369 - in /apr/apr/trunk: include/apr_reslist.h util-misc/apr_reslist.c

On 04/14/2018 02:32 AM, Yann Ylavic wrote: > On Sat, Apr 14, 2018 at 2:18 AM, Yann Ylavic wrote: >> >> when the ttl is to be >> checked against the resource we should always peek it as LIFO (i.e. >> s/fifo/1/ in the first peek_resource() of reslist_acquire() in my >>

Re: svn commit: r1828369 - in /apr/apr/trunk: include/apr_reslist.h util-misc/apr_reslist.c

On 04/11/2018 01:26 PM, Yann Ylavic wrote: > On Fri, Apr 6, 2018 at 10:18 AM, Yann Ylavic <ylavic@gmail.com> wrote: >> On Fri, Apr 6, 2018 at 8:57 AM, Ruediger Pluem <rpl...@apache.org> wrote: >>> >>> I don't think that a remark is strong enough here.

Re: svn commit: r1828492 - in /apr/apr/trunk: include/apr_reslist.h util-misc/apr_reslist.c

On 04/06/2018 09:53 AM, yla...@apache.org wrote: > Author: ylavic > Date: Fri Apr 6 07:53:02 2018 > New Revision: 1828492 > > URL: http://svn.apache.org/viewvc?rev=1828492=rev > Log: > reslist: follow up to r1828289: enfore empty list requirement when setting > fifo. > > The doxygen remark

Re: svn commit: r1828369 - in /apr/apr/trunk: include/apr_reslist.h util-misc/apr_reslist.c

On 04/04/2018 07:43 PM, yla...@apache.org wrote: > Author: ylavic > Date: Wed Apr 4 17:43:46 2018 > New Revision: 1828369 > > URL: http://svn.apache.org/viewvc?rev=1828369=rev > Log: > reslist: follow up to r1828289: adjust maintenance top too. > > Also, clarify in doxygen when

Re: svn commit: r1822315 - /apr/apr/trunk/buckets/apr_buckets_alloc.c

On 01/26/2018 10:42 PM, Yann Ylavic wrote: > On Fri, Jan 26, 2018 at 4:24 PM, wrote: >> >> Modified: apr/apr/trunk/buckets/apr_buckets_alloc.c >> URL: >> http://svn.apache.org/viewvc/apr/apr/trunk/buckets/apr_buckets_alloc.c?rev=1822315=1822314=1822315=diff >>

Re: svn commit: r1816527 - in /apr/apr/trunk: CHANGES configure.in include/apr_network_io.h include/arch/win32/apr_private.h network_io/unix/sockaddr.c test/testsock.c

On 11/28/2017 09:53 AM, jor...@apache.org wrote: > Author: jorton > Date: Tue Nov 28 08:53:13 2017 > New Revision: 1816527 > > URL: http://svn.apache.org/viewvc?rev=1816527=rev > Log: > Support IPv6 link-local address scope/zone mapping. > > * network_io/unix/sockaddr.c (apr_sockaddr_zone_set,

Re: [POLL] (Was Re: Et resurrexit tertia die.)

On 05/19/2017 07:14 AM, William A Rowe Jr wrote: > On Mon, Apr 10, 2017 at 4:40 AM, Nick Kew wrote: >> I think we've done most of 1.6.0, modulo a couple of questionmarks. >> >> Potentially open issues are (in no particular order): >> 1. Mark timedlocks experimental > > The

Re: 1.6.0 release candidates

On 04/20/2017 09:03 AM, Nick Kew wrote: > On Wed, 2017-04-19 at 13:43 -0500, William A Rowe Jr wrote: >> With patches now accounted for I can pre-test and report back today on >> AIX, HPUX and propose a fix to silence the win32 32 -> 16 bit warnings >> (after division is done.) > > Excellent.

Re: svn commit: r1790490 - in /apr/apr/branches/1.6.x: ./ include/ include/arch/unix/ locks/beos/ locks/netware/ locks/os2/ locks/unix/ locks/win32/ test/

On 04/07/2017 04:31 PM, Yann Ylavic wrote: > On Fri, Apr 7, 2017 at 3:39 PM, Ruediger Pluem <rpl...@apache.org> wrote: >> >> >> On 04/07/2017 03:33 PM, Ruediger Pluem wrote: >>> >>> >>> On 04/07/2017 10:37 AM, Yann Ylavic wrote: >

Re: svn commit: r1790490 - in /apr/apr/branches/1.6.x: ./ include/ include/arch/unix/ locks/beos/ locks/netware/ locks/os2/ locks/unix/ locks/win32/ test/

On 04/07/2017 03:33 PM, Ruediger Pluem wrote: > > > On 04/07/2017 10:37 AM, Yann Ylavic wrote: >> On Fri, Apr 7, 2017 at 10:21 AM, Ruediger Pluem <rpl...@apache.org> wrote: >>> >>> >>> On 04/07/2017 02:11 AM, yla...@apache.org wrote: >>

Re: svn commit: r1790490 - in /apr/apr/branches/1.6.x: ./ include/ include/arch/unix/ locks/beos/ locks/netware/ locks/os2/ locks/unix/ locks/win32/ test/

On 04/07/2017 10:37 AM, Yann Ylavic wrote: > On Fri, Apr 7, 2017 at 10:21 AM, Ruediger Pluem <rpl...@apache.org> wrote: >> >> >> On 04/07/2017 02:11 AM, yla...@apache.org wrote: >>> Author: ylavic >>> Date: Fri Apr 7 00:11:27 2017 >>> Ne

Re: svn commit: r1790490 - in /apr/apr/branches/1.6.x: ./ include/ include/arch/unix/ locks/beos/ locks/netware/ locks/os2/ locks/unix/ locks/win32/ test/

On 04/07/2017 02:11 AM, yla...@apache.org wrote: > Author: ylavic > Date: Fri Apr 7 00:11:27 2017 > New Revision: 1790490 > > URL: http://svn.apache.org/viewvc?rev=1790490=rev > Log: > Merge r1790488 from trunk: > > locks: follow up to r1667900. > > Axe the 'absolute' argument of

Re: SHA256 and friends.

On 01/20/2017 05:01 PM, Eric Covener wrote: > On Fri, Jan 20, 2017 at 10:52 AM, Yann Ylavic wrote: >> On Fri, Jan 20, 2017 at 4:19 PM, Dirk-Willem van Gulik >> wrote: >>> >>> Ok so if we had a special #ifdef for 'TRUE_MD5 and would manually >>>

Re: svn commit: r1733775 - in /apr/apr/trunk: ./ include/ include/arch/unix/ locks/beos/ locks/netware/ locks/os2/ locks/unix/ locks/win32/

On 03/07/2016 12:53 PM, Yann Ylavic wrote: > [resend: list's reply policy strikes again :/ ] > > On Mon, Mar 7, 2016 at 12:47 PM, Yann Ylavic <ylavic@gmail.com> wrote: >> On Mon, Mar 7, 2016 at 10:52 AM, Ruediger Pluem <rpl...@apache.org> wrote: >>

Re: svn commit: r1733775 - in /apr/apr/trunk: ./ include/ include/arch/unix/ locks/beos/ locks/netware/ locks/os2/ locks/unix/ locks/win32/

On 03/06/2016 01:19 AM, yla...@apache.org wrote: > Author: ylavic > Date: Sun Mar 6 00:19:51 2016 > New Revision: 1733775 > > URL: http://svn.apache.org/viewvc?rev=1733775=rev > Log: > apr_proc/global_mutex: Fix API regarding the native OS mutexes > accessors from/to available APR mechanisms,

  1   2   3   4   >