Re: Review Request 75207: ATLAS-4901: upgraded to JanusGraph 1.0.0 version

2024-09-24 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75207/#review226944 --- Ship it! Ship It! - Sarath Subramanian On Sept. 15, 2024

Re: [DRAFT] [REPORT] Apache Atlas - September 2024

2024-09-11 Thread Sarath Subramanian
Thanks Madhan for the draft report. +1 > On Sep 11, 2024, at 2:51 PM, Madhan Neethiraj wrote: > > Atlas community, > > > > Please review the following draft report for this quarter. > > > > Thanks, > > Madhan > > > > > > > > > > ## Description: > > The mission of Apache Atlas

Re: [DRAFT] [REPORT] Apache Atlas - June 2024

2024-06-13 Thread Sarath Subramanian
Thanks for the draft report Madhan. Looks good +1 Thanks, Sarath > On Jun 13, 2024, at 5:23 PM, Madhan Neethiraj wrote: > > Atlas community, > > Please review the following draft report for this quarter. > > Thanks, > Madhan > > > ## Description: > The mission of Apache Atlas is the creat

Re: [DRAFT] [REPORT] Apache Atlas - March 2024

2024-03-15 Thread Sarath Subramanian
Thanks for the draft board report Madhan. Looks good. +1 > On Mar 14, 2024, at 2:27 AM, Nikhil Bonte wrote: > > Looks Good to me > Thanks Madhan for putting this together > > > Regards > Nikhil P. Bonte > >> On Wed, 13 Mar 2024 at 1:17 PM, Madhan Neethiraj wrote: >> >> Atlas community, >>

Re: [DRAFT] [REPORT] Apache Atlas - December 2023

2023-12-14 Thread Sarath Subramanian
+1. Thanks for the draft Madhan Thanks, Sarath On Wed, Dec 13, 2023 at 9:25 AM Madhan Neethiraj wrote: > Atlas community, > > > > Please review the following draft report for this quarter. > > > > Thanks, > > Madhan > > > > ## Description: > > The mission of Apache Atlas is the creation and ma

Re: Review Request 74587: ATLAS-4795: docker setup updated to support Apple M1

2023-09-11 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74587/#review225735 --- Ship it! Ship It! - Sarath Subramanian On Sept. 8, 2023, 5

Re: Review Request 74586: ATLAS-4794: fixed initialization failure in HBase, Hive hooks

2023-09-11 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74586/#review225733 --- Ship it! Ship It! - Sarath Subramanian On Sept. 8, 2023, 2

[jira] [Commented] (ATLAS-4749) What is the meaning of version in the JSON content of creating entities, and how to update version when updating entity content

2023-05-05 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-4749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17720007#comment-17720007 ] Sarath Subramanian commented on ATLAS-4749: --- [~zhangkai] version is modele

[jira] [Resolved] (ATLAS-4748) 创建实体的JSON内容中版本是什么含义,更新实体内容时如何更新版本

2023-05-05 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-4748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian resolved ATLAS-4748. --- Resolution: Incomplete > 创建实体的JSON内容中版本是什么含义,更新实体内容时如何更

Re: Review Request 74375: ATLAS-4740: enable building Atlas using JDK versions higher than 8

2023-04-04 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74375/#review225352 --- Ship it! Ship It! - Sarath Subramanian On March 30, 2023, 3

Re: [DRAFT] [REPORT] Apache Atlas - March 2023

2023-03-13 Thread Sarath Subramanian
Thank you for drafting the board report Madhan. +1 Thanks, Sarath On Sun, Mar 12, 2023 at 7:16 PM Madhan Neethiraj wrote: > Atlas community, > > > > Please review the following draft report for this quarter. > > > > Thanks, > > Madhan > > > > > > ## Description: > > The mission of Apache Atlas

Re: [VOTE] Release Apache Atlas 2.3.0 rc1

2022-12-01 Thread Sarath Subramanian
ced search > > P.S. Recently I upgraded my mac to ventura and I'm not sure if these > issues are due to the upgrade. If someone else has a similar mac > version and it works for them then we are good to proceed. > Please check once if the signature is correct or else I wil

Re: [VOTE] Release Apache Atlas 2.3.0 rc1

2022-11-29 Thread Sarath Subramanian
Thank you Madhan for the release candidate. +1 for Apache Atlas 2.3.0 release candidate #1 validated the following: - Able to download source, signature, md5 and sha512 files and verified checksum hash - validated signature of source from release manager (Madhan Neethiraj < mad...@apache.org>) -

Re: Review Request 74202: ATLAS-4713: docker setup updates to be in sync with component versions in project pom.xml

2022-11-16 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74202/#review224881 --- Ship it! Ship It! - Sarath Subramanian On Nov. 15, 2022, 5

Re: Review Request 74204: ATLAS-3820: fix import-kafka.sh failures

2022-11-16 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74204/#review224880 --- Ship it! Ship It! - Sarath Subramanian On Nov. 15, 2022, 10

Re: Review Request 74203: ATLAS-4241: fix import-hbase errors

2022-11-16 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74203/#review224879 --- Ship it! Ship It! - Sarath Subramanian On Nov. 15, 2022, 9

Re: Review Request 74201: ATLAS-4445: fix import-hive.sh failure due to NoClassDefFoundError: javax/ws/rs/core/Link$Builder

2022-11-16 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74201/#review224878 --- Ship it! Ship It! - Sarath Subramanian On Nov. 15, 2022, 12

Re: Apache Atlas 2.3.0 release

2022-10-26 Thread Sarath Subramanian
Lots of great features and improvements! +1 for Atlas release 2.3.0 Thanks, Sarath On Wed, Oct 26, 2022 at 7:22 PM Madhan Neethiraj wrote: > Atlas community, > > > > It is more than a year since Apache Atlas 2.2.0 was released on Aug-2021. > During this time, the community has been busy in en

Re: Review Request 74157: ATLAS-4684: UI dependent components version update

2022-10-09 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74157/#review224769 --- Ship it! Ship It! - Sarath Subramanian On Oct. 9, 2022, 2

Re: [DRAFT] [REPORT] Apache Atlas - September 2022

2022-09-13 Thread Sarath Subramanian
Thanks for putting this together Madhan. +1 Thanks, Sarath On Tue, Sep 13, 2022 at 8:15 PM Madhan Neethiraj wrote: > Atlas community, > > > > Please review the following draft report for this quarter. > > > > Thanks, > > Madhan > > > > ## Description: > > The mission of Apache Atlas is the cre

Re: [DRAFT] [REPORT] Apache Atlas - July 2022

2022-07-12 Thread Sarath Subramanian
Thank you Madhan for putting this together. Looks good. +1 Thanks, Sarath On Sun, Jul 10, 2022 at 10:46 PM Madhan Neethiraj wrote: > Atlas community, > > Please review the following draft report for this quarter. > > Thanks, > Madhan > > ## Description: > The mission of Apache Atlas is the cre

Re: [DRAFT] [REPORT] Apache Atlas - March 2022

2022-03-08 Thread Sarath Subramanian
Thanks Madhan for putting the draft report. +1 Thanks, Sarath On Tue, Mar 8, 2022 at 2:38 PM Madhan Neethiraj wrote: > Atlas community, > > > > Please review the following draft report for this quarter. > > > > Thanks, > > Madhan > > > > > > > > ## Description: > > The mission of Apache Atlas

Re: Review Request 73826: ATLAS-4548: Set Empty attribute value for queryStr and queryId in case of null value when atlas.hook.hive.hive_process.populate.deprecated.attributes=true

2022-02-02 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73826/#review224016 --- Ship it! Ship It! - Sarath Subramanian On Feb. 2, 2022, 11

[jira] [Commented] (ATLAS-4540) Upgrade JanusGraph to version 0.6.1

2022-01-25 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-4540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17482043#comment-17482043 ] Sarath Subramanian commented on ATLAS-4540: --- Thanks for the patch [~ma

[jira] [Updated] (ATLAS-4536) The newline character in attribues will fail simple auth check

2022-01-24 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-4536: -- Fix Version/s: 3.0.0 2.3.0 > The newline character in attrib

[jira] [Resolved] (ATLAS-4536) The newline character in attribues will fail simple auth check

2022-01-24 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian resolved ATLAS-4536. --- Resolution: Fixed > The newline character in attribues will fail simple auth ch

[jira] [Updated] (ATLAS-4522) Updating typedef with new supertype should be allowed only if attributes are unique compared to other existing supertypes

2022-01-19 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-4522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-4522: -- Fix Version/s: 3.0.0 2.3.0 > Updating typedef with new supert

Re: Review Request 73798: ATLAS-4529 : DSL Search : OrderBy does not work for ScriptEngineBasedExecutor (gremlin groovy)

2022-01-12 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73798/#review223958 --- Ship it! Ship It! - Sarath Subramanian On Jan. 12, 2022, 12

Re: Review Request 73796: ATLAS-4528: updated log4j2 version to 2.17.1; removed references to org.apache.logging.NDC

2022-01-10 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73796/#review223947 --- Ship it! Ship It! - Sarath Subramanian On Jan. 10, 2022, 7

Re: Review Request 73762: ATLAS-4508: Though a particular tag is blocked propagation , tag is still propagated

2021-12-19 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73762/#review223877 --- Ship it! Ship It! - Sarath Subramanian On Dec. 15, 2021, 3

Re: Review Request 73766: ATLAS-4507 : Atlas - Upgrade testng to 7.0.0

2021-12-17 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73766/#review223870 --- Ship it! Ship It! - Sarath Subramanian On Dec. 17, 2021, 7

Re: Review Request 73762: ATLAS-4508: Though a particular tag is blocked propagation , tag is still propagated

2021-12-15 Thread Sarath Subramanian
> On Dec. 15, 2021, 9:43 p.m., Sarath Subramanian wrote: > > Ship It! can you add precommit link? - Sarath --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73762/#rev

Re: Review Request 73762: ATLAS-4508: Though a particular tag is blocked propagation , tag is still propagated

2021-12-15 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73762/#review223864 --- Ship it! Ship It! - Sarath Subramanian On Dec. 15, 2021, 3

Re: Review Request 73747: ATLAS-4502: Add cassandra and elasticsearch search profile for Atlas

2021-12-08 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73747/#review223825 --- Ship it! Ship It! - Sarath Subramanian On Dec. 8, 2021, 4

Re: Review Request 73747: ATLAS-4502: Add cassandra and elasticsearch search profile for Atlas

2021-12-08 Thread Sarath Subramanian
(patched) <https://reviews.apache.org/r/73747/#comment312878> consider using variable here ${guava.version} - Sarath Subramanian On Dec. 7, 2021, 12:21 p.m., Sidharth Mishra wrote: > > --- > This is an automatically gener

Re: [DRAFT] [REPORT] Apache Atlas - Dec-2021

2021-12-08 Thread Sarath Subramanian
Thanks Madhan for the draft report. +1 Thanks, Sarath On Wed, Dec 8, 2021 at 1:20 AM Madhan Neethiraj wrote: > Atlas community, > > Please review the following draft report for this quarter. > > Thanks, > Madhan > > ## Description: > The mission of Apache Atlas is the creation and maintenance

Re: Review Request 73740: ATLAS-4491 :- Atlas - Upgrade Spring framework to 5.3.10+/5.2.17+

2021-12-06 Thread Sarath Subramanian
> On Dec. 6, 2021, 10:52 a.m., Sarath Subramanian wrote: > > Ship It! do we have a clean pre-commit? - Sarath --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73740/#rev

Re: Review Request 73740: ATLAS-4491 :- Atlas - Upgrade Spring framework to 5.3.10+/5.2.17+

2021-12-06 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73740/#review223808 --- Ship it! Ship It! - Sarath Subramanian On Dec. 6, 2021, 1

Re: Review Request 73637: ATLAS-4370: Persist Metrics for user to retrieve Metrics info at a past timestamp

2021-12-02 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73637/#review223793 --- Ship it! Ship It! - Sarath Subramanian On Nov. 15, 2021, 8

Re: Review Request 73704: ATLAS-4475: Import Hive V2 is throwing wrong log message when running with set of tables

2021-11-18 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73704/#review223752 --- Ship it! Ship It! - Sarath Subramanian On Nov. 16, 2021, 5

[jira] [Commented] (ATLAS-4485) Can HA support multi write/read?

2021-11-18 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-4485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446029#comment-17446029 ] Sarath Subramanian commented on ATLAS-4485: --- [~wzg547228197] , yes Atla

Re: Review Request 73711: ATLAS-4481: Atlas API on update classifications is failing with NPE when we pass body without propagate flag

2021-11-16 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73711/#review223742 --- Ship it! Ship It! - Sarath Subramanian On Nov. 16, 2021, 1

Re: Review Request 73700: ATLAS-4473 GlossaryTerms Bulk Create Performance Improvement

2021-11-12 Thread Sarath Subramanian
/atlas/glossary/GlossaryService.java Lines 1011 (patched) <https://reviews.apache.org/r/73700/#comment312832> extract as static constant - "r:AtlasGlossaryTermAnchor" - Sarath Subramanian On Nov. 9, 2021, 11:23 p.m., Manda

Re: Review Request 73637: ATLAS-4370: Persist Metrics for user to retrieve Metrics info at a past timestamp

2021-11-12 Thread Sarath Subramanian
;); webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java Lines 453 (patched) <https://reviews.apache.org/r/73637/#comment312831> consider moving private methods after public - Sarath Subramanian On Nov. 9, 2021, 11:54 a.m., Disha Talreja wrote: > >

Re: Review Request 73691: ATLAS-4431: Random NPE when retrieving tasks (“part2 - additional null check”)

2021-11-08 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73691/#review223715 --- Ship it! Ship It! - Sarath Subramanian On Nov. 8, 2021, 3

Re: Review Request 73586: ATLAS-4424: Enhance the Import hive utility to create export zip files and run bulk import

2021-11-03 Thread Sarath Subramanian
//reviews.apache.org/r/73586/ > --- > > (Updated Oct. 29, 2021, 12:40 p.m.) > > > Review request for atlas, Ashutosh Mestry, Disha Talreja, Radhika Kundam, and > Sarath Subramanian. > > > Bugs: ATLAS-4424 > https://issues.apache.org/jira/browse/ATLAS-4424 > >

Re: Review Request 73669: ATLAS-4462: Atlas tests are failing and PreCommit tests are also failing

2021-10-28 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73669/#review223692 --- Ship it! Ship It! - Sarath Subramanian On Oct. 28, 2021, 5

Re: Review Request 73670: ATLAS-4351 Maven-jetty throwing warnings when running Integration tests for conflicting jars in classpath

2021-10-28 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73670/#review223689 --- Ship it! Ship It! - Sarath Subramanian On Oct. 28, 2021, 2

Re: Review Request 73671: ATLAS-4463: Infinite loop at Index Health Monitor (IndexRecoveryService)

2021-10-28 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73671/#review223688 --- Ship it! Ship It! - Sarath Subramanian On Oct. 28, 2021, 2

Re: Review Request 73669: ATLAS-4462: Atlas tests are failing and PreCommit tests are also failing

2021-10-28 Thread Sarath Subramanian
https://reviews.apache.org/r/73669/#comment312793> 'reader' is never used? consider removing pom.xml Line 1963 (original), 1963 (patched) <https://reviews.apache.org/r/73669/#comment312796> consider using variable here: ${surefire.version} - Sarath Subramanian On

Re: Review Request 73654: ATLAS-4454 : Upgrade JanusGraph version to 0.6.0

2021-10-19 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73654/#review223633 --- Ship it! Ship It! - Sarath Subramanian On Oct. 19, 2021, 4

Re: Review Request 73586: ATLAS-4424: Enhance the Import hive utility to create export zip files and run bulk import

2021-10-18 Thread Sarath Subramanian
mportStatus.java Line 38 (original), 33 (patched) <https://reviews.apache.org/r/73586/#comment312746> instead of getting rid of "name" and using "fileHash". Can we capture both - name and fileHash? will this change in POJO, affect cross-version compat (backward-comp

[jira] [Resolved] (ATLAS-4381) Release Atlas 2.2.0

2021-10-18 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-4381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian resolved ATLAS-4381. --- Resolution: Fixed > Release Atlas 2.

[jira] [Resolved] (ATLAS-3972) Apache atlas 2.1.0

2021-10-18 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian resolved ATLAS-3972. --- Resolution: Fixed > Apache atlas 2.1.0 > -- > >

Re: Review Request 73595: ATLAS-4428 : Enhance Atlas hook messages to capture hook version & message source

2021-10-12 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73595/#review223610 --- Ship it! Ship It! - Sarath Subramanian On Oct. 12, 2021, 11

Re: Review Request 73641: ATLAS-4447: Update Composite indexes status

2021-10-11 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73641/#review223602 --- Ship it! Ship It! - Sarath Subramanian On Oct. 11, 2021, 10

Re: Review Request 73641: Repair Composite indexes

2021-10-10 Thread Sarath Subramanian
patched) <https://reviews.apache.org/r/73641/#comment312704> consider renaming class to "UpdateCompositeIndexStatusPatch", since this JAVA patch deals with UPDATING the schema status of certain composite indexes. - Sarat

[jira] [Updated] (ATLAS-4408) Dynamic handling of failure in updating index

2021-10-10 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-4408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-4408: -- Affects Version/s: 3.0.0 2.2.0 > Dynamic handling of failure

[jira] [Updated] (ATLAS-4408) Dynamic handling of failure in updating index

2021-10-10 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-4408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-4408: -- Labels: indexing (was: ) > Dynamic handling of failure in updating in

[jira] [Updated] (ATLAS-4408) Dynamic handling of failure in updating index

2021-10-10 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-4408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-4408: -- Fix Version/s: 2.3.0 3.0.0 > Dynamic handling of failure

Re: Review Request 73589: Indexing Monitor and Recovery

2021-10-10 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73589/#review223594 --- Ship it! Ship It! - Sarath Subramanian On Sept. 21, 2021, 8

Re: Review Request 73603: ATLAS-4436 Basic Search : Search By Query '*' gets internal entities also

2021-10-07 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73603/#review223591 --- Ship it! Ship It! - Sarath Subramanian On Sept. 27, 2021

Re: Review Request 73585: ATLAS-4425: Migration import should be able to import multiple zip files present in a particular path

2021-10-07 Thread Sarath Subramanian
ZipFileMigrationImporter.java Lines 162 (patched) <https://reviews.apache.org/r/73585/#comment312699> check if you have write/move permission on the destination archive dir as well (newFile) - Sarath Subramanian On Oct. 5, 2021, 4:30 p.m., Sidharth Mishra wrote: > > --

[jira] [Commented] (ATLAS-4246) Make Kafka Interface aware of Kafka Schema Registry

2021-10-07 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425734#comment-17425734 ] Sarath Subramanian commented on ATLAS-4246: --- [~aileeen], added some re

Re: Review Request 73286: Initial commit

2021-10-07 Thread Sarath Subramanian
eate static constant for "schema" addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/bridge/SchemaRegistryConnector.java Lines 104 (patched) <https://reviews.apache.org/r/73286/#comment312680> avoid printing stacktrace here and print in log:

Re: Review Request 73595: ATLAS-4428 : Enhance Atlas hook messages to capture hook version & message source

2021-10-06 Thread Sarath Subramanian
eSource.java Lines 62 (patched) <https://reviews.apache.org/r/73595/#comment312660> move private methods after public methods - Sarath Subramanian On Oct. 6, 2021, 8:13 a.m., chaitali wrote: > > --- > This is an automat

[jira] [Commented] (ATLAS-4440) Upgrade Atlas's Kafka dependency to 2.8

2021-10-04 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-4440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424224#comment-17424224 ] Sarath Subramanian commented on ATLAS-4440: --- [~viktorsomogyi], is this K

[jira] [Commented] (ATLAS-4440) Upgrade Atlas's Kafka dependency to 2.8

2021-10-04 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-4440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424223#comment-17424223 ] Sarath Subramanian commented on ATLAS-4440: --- Thanks for the Precommit

Re: Review Request 73595: ATLAS-4428 : Enhance Atlas hook messages to capture hook version & message source

2021-09-30 Thread Sarath Subramanian
lizes 'hookVersion' variable, usage of getters here is confusing: public MessageSource(String messageSource) { this.messageSource = messageSource; this.hookVersion = properties.getProperty("build.version", "UNKNOWN"); } Also, can&#x

[jira] [Updated] (ATLAS-4351) Maven-jetty throwing warnings when running Integration tests for conflicting jars in classpath

2021-09-30 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-4351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-4351: -- Component/s: atlas-core > Maven-jetty throwing warnings when running Integrat

[jira] [Updated] (ATLAS-4351) Maven-jetty throwing warnings when running Integration tests for conflicting jars in classpath

2021-09-30 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-4351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-4351: -- Affects Version/s: 2.2.0 > Maven-jetty throwing warnings when running Integrat

Re: Review Request 73448: ATLAS-4351 : Maven-jetty throwing warnings when running Integration tests for conflicting jars in classpath

2021-09-30 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73448/#review223552 --- Ship it! Ship It! - Sarath Subramanian On Sept. 29, 2021

Re: Review Request 73448: ATLAS-4351 : Maven-jetty throwing warnings when running Integration tests for conflicting jars in classpath

2021-09-29 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73448/#review223549 --- Ship it! Ship It! - Sarath Subramanian On Sept. 13, 2021

[jira] [Updated] (ATLAS-4421) [Atlas: Hive Import] When import-hive is run with incorrect input the information is not conveyed to the user

2021-09-29 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-4421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-4421: -- Component/s: atlas-core > [Atlas: Hive Import] When import-hive is run with incorr

[jira] [Updated] (ATLAS-4421) [Atlas: Hive Import] When import-hive is run with incorrect input the information is not conveyed to the user

2021-09-29 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-4421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-4421: -- Labels: hive (was: ) > [Atlas: Hive Import] When import-hive is run with incorr

[jira] [Updated] (ATLAS-4421) [Atlas: Hive Import] When import-hive is run with incorrect input the information is not conveyed to the user

2021-09-29 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-4421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-4421: -- Fix Version/s: 2.3.0 3.0.0 > [Atlas: Hive Import] When import-h

[jira] [Updated] (ATLAS-4421) [Atlas: Hive Import] When import-hive is run with incorrect input the information is not conveyed to the user

2021-09-29 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-4421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-4421: -- Affects Version/s: 2.2.0 > [Atlas: Hive Import] When import-hive is run with incorr

Re: Review Request 73616: ATLAS-4421: [Atlas: Hive Import] When import-hive is run with incorrect input the information is not conveyed to the user

2021-09-27 Thread Sarath Subramanian
/hive-bridge/src/bin/import-hive.sh Line 159 (original), 159 (patched) <https://reviews.apache.org/r/73616/#comment312609> "Meta Data" => "metadata" - Sarath Subramanian On Sept. 27, 2021, 10

Re: Review Request 73606: AtlasPatchManager: Avoid Race Condition in HA Mode

2021-09-27 Thread Sarath Subramanian
red during initialization (before indexes got created) -> moved to applyAll() method. Good fix! - Sarath Subramanian On Sept. 24, 2021, 11:14 a.m., Ashutosh Mestry wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 73599: Conditionally Disable 'Session Inactivity Timeout'

2021-09-22 Thread Sarath Subramanian
x27; - closer to where it is used for better readabality. - Sarath Subramanian On Sept. 21, 2021, 11:38 a.m., Ashutosh Mestry wrote: > > --- > This is an automatically gener

Re: Review Request 73589: Indexing Monitor and Recovery

2021-09-21 Thread Sarath Subramanian
always updates the global config even if user haven't set it. global config is a site-wide setting for Atlas/Janusgraph and should not be changed unless explicitly specified. - Sarath Subramanian On Sept. 21, 2021, 8:40 a.m., Ashutosh M

[jira] [Commented] (ATLAS-4358) Mapping for some internal Atlas attributes ( like __patch.type , __timestamp, etc) does not exist in Elasticsearch

2021-09-21 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-4358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17417946#comment-17417946 ] Sarath Subramanian commented on ATLAS-4358: --- Thanks for the det

[jira] [Updated] (ATLAS-4431) Random NPE when retrieving tasks

2021-09-20 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-4431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-4431: -- Fix Version/s: 2.3.0 3.0.0 > Random NPE when retrieving ta

[jira] [Updated] (ATLAS-4431) Random NPE when retrieving tasks

2021-09-20 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-4431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-4431: -- Affects Version/s: 2.2.0 > Random NPE when retrieving ta

Re: Review Request 73593: ATLAS-4431: Random NPE when retrieving tasks

2021-09-20 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73593/#review223505 --- Ship it! Ship It! - Sarath Subramanian On Sept. 20, 2021, 1

Re: Review Request 73584: ATLAS-4422 : Quick Search: Provide sorting

2021-09-15 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73584/#review223492 --- Ship it! Ship It! - Sarath Subramanian On Sept. 15, 2021, 9

Re: Review Request 73584: ATLAS-4422 : Quick Search: Provide sorting

2021-09-14 Thread Sarath Subramanian
. - Sarath Subramanian On Sept. 13, 2021, 11:38 p.m., Pinal Shah wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

[jira] [Updated] (ATLAS-4369) import-hive.sh does not write logs to /var/log/atlas/import-hive.log file, instead write into ${atlas.log.file} under the directory "${atlas.log.dir}"

2021-09-13 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-4369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-4369: -- Fix Version/s: 2.3.0 3.0.0 > import-hive.sh does not write logs

[jira] [Updated] (ATLAS-4369) import-hive.sh does not write logs to /var/log/atlas/import-hive.log file, instead write into ${atlas.log.file} under the directory "${atlas.log.dir}"

2021-09-13 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-4369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-4369: -- Affects Version/s: 3.0.0 2.2.0 > import-hive.sh does not wr

Re: Review Request 73580: ATLAS-4369: import-hive.sh does not write logs to /var/log/atlas/import-hive.log file, instead write into ${atlas.log.file} under the directory "${atlas.log.dir}"

2021-09-13 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73580/#review223484 --- Ship it! Ship It! - Sarath Subramanian On Sept. 13, 2021

Re: Review Request 73528: ATLAS-4377 : Atlas - Upgrade Spring Security to 5.4.4+/5.3.8+/5.2.9+

2021-09-09 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73528/#review223466 --- Ship it! Ship It! - Sarath Subramanian On Sept. 6, 2021, 1

Re: Review Request 73544: ATLAS-4400: Lower version of aws_s3_v2_directory (1.2) of Atlas is is compatible with new Hooks

2021-08-27 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73544/#review223414 --- Ship it! Ship It! - Sarath Subramanian On Aug. 26, 2021, 4

Re: Review Request 73549: ATLAS-4403: Improve find entity by unique attributes logic - when multiple unique attributes exist for entity type

2021-08-26 Thread Sarath Subramanian
://reviews.apache.org/r/73549/diff/4/ Changes: https://reviews.apache.org/r/73549/diff/3-4/ Testing --- Pre-commit: https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/822/consoleFull (SUCCESS) Thanks, Sarath Subramanian

Re: Review Request 73547: ATLAS-4401: Upgrade commons-io to 2.8.0

2021-08-25 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73547/#review223406 --- Ship it! Ship It! - Sarath Subramanian On Aug. 25, 2021, 8

Re: Review Request 73548: ATLAS-4402: Upgrade junit to 4.13.1

2021-08-25 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73548/#review223405 --- Ship it! Ship It! - Sarath Subramanian On Aug. 25, 2021, 12

Re: Review Request 73544: ATLAS-4400: Lower version of aws_s3_v2_directory (1.2) of Atlas is is compatible with new Hooks

2021-08-25 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73544/#review223404 --- Ship it! Ship It! - Sarath Subramanian On Aug. 25, 2021, 8

Re: Review Request 73544: ATLAS-4400: Lower version of aws_s3_v2_directory (1.2) of Atlas is is compatible with new Hooks

2021-08-25 Thread Sarath Subramanian
s3a://my_bucket_1/datalake/warehouse/tablespace/external/hive/employee.csv/@cm objectPrefix : /datalake/warehouse/tablespace/external/hive/employee.csv/ name : employee.csv - Sarath Subramanian On Aug. 24, 2021, 11:21 p.m., Sidharth Mishra wrote: > >

Review Request 73549: ATLAS-4403: Improve find entity by unique attributes logic - when multiple unique attributes exist for entity type

2021-08-25 Thread Sarath Subramanian
/consoleFull (SUCCESS) Thanks, Sarath Subramanian

[jira] [Created] (ATLAS-4403) Improve find entity by unique attributes logic - when multiple unique attributes exist for entity type

2021-08-25 Thread Sarath Subramanian (Jira)
Sarath Subramanian created ATLAS-4403: - Summary: Improve find entity by unique attributes logic - when multiple unique attributes exist for entity type Key: ATLAS-4403 URL: https://issues.apache.org/jira

[jira] [Commented] (ATLAS-4399) Restore deleted entity

2021-08-23 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-4399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17403260#comment-17403260 ] Sarath Subramanian commented on ATLAS-4399: --- To answer your questions: #

  1   2   3   4   5   6   7   8   9   10   >